Commit Graph

7821 Commits

Author SHA1 Message Date
TreeHugger Robot
38b671d602 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev am: 36705e6039
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16273821

Change-Id: I07a1681b8d5ba1a5699537e4f6e5f981ae09718b
2021-11-16 20:39:18 +00:00
TreeHugger Robot
36705e6039 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev 2021-11-16 20:25:06 +00:00
Alex Chau
0f38629826 Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev am: 1c4871298e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16166972

Change-Id: Icf8e6992c6b76fddca4ae25c81a66f6424d9554e
2021-11-16 18:57:56 +00:00
Alex Chau
04309940c0 If hometask is last task to be dismissed, show empty recents instead of home screen
- http://ag/16221737 ensure homescren stub is always added if tasks hasn't been loaded in RecentsView. This introduced an edge case that after dismissing home task view, no task remains in overview and it get dismissed
- The fix is to show empty recents instead of home screen if last task dismissed is a home task (showing empty recents isn't always correct, as there might be unloaded tasks, but it's better than dismissing overview)
- Also tuned the timing of when mLoadPlanEverApplied is set

Fix: 206462357
Test: FallbackRecentsTest.goToOverviewFromHome
Change-Id: I0f395639f57a1a57fddf750623a8a74b8ede8555
2021-11-16 18:48:28 +00:00
Alex Chau
1c4871298e Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev 2021-11-16 18:40:31 +00:00
Fedor Kudasov
b807d92aa7 Merge "Annotate RecentsView with @Nullable" into sc-v2-dev am: 72c8e71e06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16261398

Change-Id: Ic382d5886aa2df5c1bb8f981cbe626f031fd9c51
2021-11-16 10:44:07 +00:00
Fedor Kudasov
72c8e71e06 Merge "Annotate RecentsView with @Nullable" into sc-v2-dev 2021-11-16 10:26:23 +00:00
Tracy Zhou
022c66327b Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev am: 0200636585
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16205781

Change-Id: Ie9ca6ecdd77ac76b5b93461b6c5d7d6e670b71a6
2021-11-16 09:57:38 +00:00
Tracy Zhou
0200636585 Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev 2021-11-16 09:41:58 +00:00
Fedor Kudasov
acf07f338e Simplify getTaskViewAt call am: 9d6fb64f45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16249427

Change-Id: If52c26a38fab17d294b08a34a3e41fd5f88cef27
2021-11-15 20:50:06 +00:00
Fedor Kudasov
3a0f8a90bd Annotate RecentsView with @Nullable
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I44a4f7ce4258e54d43ca2c5a3937c81a4a686f80
(cherry picked from commit ac9cee5a7c)
2021-11-15 20:39:07 +00:00
Fedor Kudasov
9d6fb64f45 Simplify getTaskViewAt call
RecentsView getTaskViewAt method is nullable and is safe
to call for an out of bound index.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I7709d63ad4490fd756a50caaf42ba70c4fad4d06
(cherry picked from commit 41edede1ee)
2021-11-15 20:37:12 +00:00
Fedor Kudasov
913c8aee24 Merge "Add @Nullable annotations for simple cases" into sc-v2-dev am: ba47b591c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16246987

Change-Id: I4fe20700452492680e0ea1e30577ed04ecda0e4f
2021-11-13 09:17:31 +00:00
Fedor Kudasov
ba47b591c4 Merge "Add @Nullable annotations for simple cases" into sc-v2-dev 2021-11-13 09:00:32 +00:00
Winson Chung
16d6010418 Merge "Freeze task list if requested when launching split tasks" into sc-v2-dev am: ea77e49524
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16245857

Change-Id: Icad379bd6b9302e1dd2903e3e7f8d468f8d87718
2021-11-12 21:08:27 +00:00
Winson Chung
ea77e49524 Merge "Freeze task list if requested when launching split tasks" into sc-v2-dev 2021-11-12 20:51:15 +00:00
Alex Chau
45bb7b48ec Fix launch animation from grid am: f75725830a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16240053

Change-Id: I6815036c3d3916a4378340c089a35339a52206d4
2021-11-12 18:13:10 +00:00
Alex Chau
f75725830a Fix launch animation from grid
- Fixed calculateGridTaskSize to algin to taskRect instead of gridRect
- Extracted end of grid's scroll diff calculation to getOffsetFromScrollPosition to accurately calculate end of grid task's offset between its scroll and visual position (End of grid task's scroll is all the same at the position where ClearAllButton is just invisible)
- Extracted isGridTask in TaskView so TaskViewSimualtor can use the correct task size depedning if it's grid task or not

Bug: 200813202
Test: manual
Change-Id: I11a980345aee2680abf1c2563baadd9718a40192
2021-11-12 16:13:47 +00:00
Fedor Kudasov
2ca545c387 Add @Nullable annotations for simple cases
Add @Nullable annotations for the fields that are expected
to be null at arbitrary lifecycle time and are their usage
is protected by null checks.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I9c31e1dc0d01cdd68dfff0a005ba1f40c257f8ea
(cherry picked from commit 920dc2f28f)
2021-11-12 10:01:33 +00:00
Fedor Kudasov
820f8b6da4 Merge "Annotate AttributeSet with @Nullable" into sc-v2-dev am: 6c7c91fe86
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16233502

Change-Id: I44b3c235304572fc034a38584324a7f275fd24d9
2021-11-12 08:32:14 +00:00
Fedor Kudasov
6c7c91fe86 Merge "Annotate AttributeSet with @Nullable" into sc-v2-dev 2021-11-12 08:17:55 +00:00
Hyunyoung Song
9dfc2ba0a3 Merge "Address AppEventProducer to correctly send search-result location on AppTargetEvent" into sc-v2-dev am: 664f685336
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16235837

Change-Id: I015c3a22684a74c93241287dbcd27651fdf36ac3
2021-11-12 08:03:20 +00:00
Hyunyoung Song
664f685336 Merge "Address AppEventProducer to correctly send search-result location on AppTargetEvent" into sc-v2-dev 2021-11-12 07:46:23 +00:00
Winson Chung
d0e6c8b2e7 Freeze task list if requested when launching split tasks
Bug: 206000278
Test: Quickswitch from app pair and back
Change-Id: I76af1396145e121e7f66f9e6b97f21a85c075e8e
2021-11-12 06:27:26 +00:00
Hyunyoung Song
1e5b621a50 Address AppEventProducer to correctly send search-result location on AppTargetEvent
Bug: 191362091
Test: logcat printout

11-10 20:27:02.290 32215 32237 D QuickstepModelDelegate: notifyAppTargetEvent action=1launchLocation=search-results

Change-Id: I16ef7679116e397a8a108cc291f5741febf2e453
2021-11-11 21:27:01 -08:00
TreeHugger Robot
215a79a150 Merge "Update corner radius of both snapshot in app pair" into sc-v2-dev am: 916873e7ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16240047

Change-Id: I20fb777687eb54d7710c59f875951946501b0350
2021-11-11 21:18:00 +00:00
Alex Chau
80836f637f Update corner radius of both snapshot in app pair
Fix: 206002609
Test: manual
Change-Id: I6af28c6948769eac53326d61e84ac39196bd840f
2021-11-11 19:40:42 +00:00
Fedor Kudasov
b498b648ae Annotate AttributeSet with @Nullable
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: Ib8584e1bbcc7061aef2eb4813a8f6aa41d3c7362
(cherry picked from commit 96f8792c04)
2021-11-11 08:16:08 +00:00
Vinit Nayak
f9ed2a09d1 Merge "Finish recents animation for app-icon tap" into sc-v2-dev am: 185da72e98
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16223705

Change-Id: Icfaddc538c171f09a65efd0d82bb869228518c44
2021-11-11 06:22:34 +00:00
Vinit Nayak
185da72e98 Merge "Finish recents animation for app-icon tap" into sc-v2-dev 2021-11-11 06:03:47 +00:00
Ryan Lin
29cb975748 Merge "Fix the cutout of magnification border" into sc-v2-dev am: b6e3caeb7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16214743

Change-Id: I8f9abdbee71c100dde4c6403158732922a809c56
2021-11-11 02:01:39 +00:00
Ryan Lin
b6e3caeb7a Merge "Fix the cutout of magnification border" into sc-v2-dev 2021-11-11 01:56:21 +00:00
TreeHugger Robot
3945fd8f4c Merge "launcher: use a different task menu for foldables" into sc-v2-dev am: 0aadbc6b37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16214330

Change-Id: I46f180584f6abb122adbb290e6a128151509c07c
2021-11-10 20:17:36 +00:00
TreeHugger Robot
0aadbc6b37 Merge "launcher: use a different task menu for foldables" into sc-v2-dev 2021-11-10 19:45:36 +00:00
Vinit Nayak
2db58f68ee Finish recents animation for app-icon tap
* There is a layering issue w/ live tile
* Also, order tasks for app-pair when binding

Bug: 205354856
Change-Id: I4fb5b9ed070e96299fd4b58d172ebba93789d009
2021-11-10 10:21:02 -08:00
Thales Lima
c335ad28a2 launcher: use a different task menu for foldables
Foldables use a different menu from phones, positioned either to the
right or left of the app icon, and display an arrow. Since TaskMenuView
is very specific for handhelds, it was cleaner to create another class
to handle foldables case extending from ArrowPopup.

This creates a working menu, the correct style will come in later CLs.

Bug: 193432925
Test: open Overview and tap the app icon

Fixes: 205298731
Test: atest NexusLauncherTests

Change-Id: I7a5c1fb4800a309f40fadb2df0f6c3a4c3f42679
2021-11-10 17:30:13 +00:00
Winson Chung
5e48eac33e Merge "Support multiple tasks in recentsaninmation onTaskAppeared" into sc-v2-dev am: 7ce4af988b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16184047

Change-Id: I5c10d44cd48b423a38893138ff410b68a1816b62
2021-11-10 17:28:05 +00:00
Winson Chung
7ce4af988b Merge "Support multiple tasks in recentsaninmation onTaskAppeared" into sc-v2-dev 2021-11-10 17:05:46 +00:00
Vinit Nayak
d9d4ef59ac Merge "Shows AppPairs in previous tasks" into sc-v2-dev am: 524d6b83e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16134803

Change-Id: I244d0877336d28d6d76a5c45c78811bfc662755b
2021-11-10 16:46:23 +00:00
Vinit Nayak
524d6b83e9 Merge "Shows AppPairs in previous tasks" into sc-v2-dev 2021-11-10 16:33:50 +00:00
ryanlwlin
1ee6bd7bb6 Fix the cutout of magnification border
If the window is unmagnifiable, it might cause the cutout of
magnification region.
To fix it, we set the flag when the touchable region is not the
entier window frame.

To fix NexusLauncherTests, we add a flag to avoid updateViewLayout
too frequently that would impact memory test and have the performance
issue.

Bug: 196510717
Test: manual test on gestural and 3-button navigation
      presumbit test pass
      run atest NexusLauncherTests with foldables
Change-Id: Ifef81640fe6c08ee1b0dcd3915227fba3002ea43
Merged-In: Ifef81640fe6c08ee1b0dcd3915227fba3002ea43
(cherry picked from commit c8d588cff6)
2021-11-10 09:51:54 +00:00
TreeHugger Robot
d354341d30 Merge "Don't skip adding stub home task if applyLoadPlan hasn't run" into sc-v2-dev am: e4f6f951da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16221737

Change-Id: I1e40e55d97207031c416d1ea99abc6a63d93e466
2021-11-10 09:51:06 +00:00
Tracy Zhou
e89a83b65d Track LauncherState, RecentsAnimation, resumed state for task bar in one place
TODO:
- Consider delaying animating task bar to stashed towards all apps state until user releasing their finger (tho in this change heuristic is applied for stashing and unstashing respectively)
- Further consolidate some animation logic

Bug: 204220602
Test: manual

Change-Id: I58b4d035fcf65a9f5c68e69c129eae95b89b1c4a
2021-11-09 23:46:03 -08:00
Vinit Nayak
4d57e7091f Shows AppPairs in previous tasks
Fixes: 203006080
Change-Id: I63912a61e7617ec41f229c19cc267dc5a1857bae
2021-11-09 13:47:18 -08:00
Alex Chau
7c4bc7dd74 Don't skip adding stub home task if applyLoadPlan hasn't run
- In FallbackRecentsTest.goToOverviewFromHome, home task gesture starts before applyLoadPlan, causing shouldAddStubTaskView to return false because getTaskViewCount is 0. This falsely avoid home task to be added to RecentsView, causing the animation to be drastically different from what user sees outside the test
- Added a check on whether applyLoadPlan is ever called to solve the problem

Fix: 205580523
Test: FallbackRecentsTest.goToOverviewFromHome
Change-Id: I2e435e56008e916e8f7e1037d3fa3c8177437d13
2021-11-09 19:01:23 +00:00
TreeHugger Robot
690bd9c527 Merge "Fix a case that task jump when dismissing" into sc-v2-dev am: 055d9a5f07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16194618

Change-Id: Ia76826d79488d3fcf11d100206456a69d09a81e1
2021-11-09 16:16:58 +00:00
TreeHugger Robot
055d9a5f07 Merge "Fix a case that task jump when dismissing" into sc-v2-dev 2021-11-09 16:03:45 +00:00
TreeHugger Robot
ff75c4fe78 Merge "Fixing allSet page not closed if recentsAnimation takes time to start" into sc-v2-dev am: ef18f8c5a2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16200930

Change-Id: Ie168c6b5d955b9839f6d48b3204d9f62ed67cd90
2021-11-09 01:57:46 +00:00
Evan Rosky
e4102c6ffe Support multiple tasks in recentsaninmation onTaskAppeared
Needed for app-pairs support

Bug: 204094785
Test: TODO
Change-Id: I3c5f8097b04b4033ba887e3c6d9e5ffd900df80e
2021-11-08 17:40:13 -08:00
TreeHugger Robot
ef18f8c5a2 Merge "Fixing allSet page not closed if recentsAnimation takes time to start" into sc-v2-dev 2021-11-09 01:35:48 +00:00