We only need to run the Search edu if it is enabled on devices. The code
itself is also made more generic in terms of method and variable names.
Fix: 330401405
Test: Enable and disable the search function and check whether the edu tooltip shows
up for each specific use case.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD
Change-Id: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
Merged-In: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
This reverts commit 38bc885de9.
- Always request layout of action_buttons after changing visibility of its children
- Update Split button visibility based on DeviceProfile change in updateDimension() only
- Update Split button visibility based on 3P launcher in initialization only
- Also simplified action_buttons to wrap_content and layout in middle of parent
- Also removed the space between buttons and use marginStart
- Fixed TAPL to not expect save app pair button on phone. Before this CL actions_buttons are still on view hierarchy despite they're not visible on screen.
Fix: 321291049
Fix: 329255757
Test: Clear all tasks, fold, launch app, swipe up to Overivew; repeat in RTL
Test: OverviewImageTest
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7d0edb46ac0a09aa0c801598b46cd338d04886a9)
Merged-In: I9ecf872279f6f07d2d9bc33fb09031568023cb77
Change-Id: I9ecf872279f6f07d2d9bc33fb09031568023cb77
- http://ag/q/topic:%22b/329255757%22 caused a regression that in landscape, action_buttons shifted up when ShareTarget become visible, because OverviewActionsView become taller when this happens, and the topMargin is no longer valid to put actions_button at the position we want
- Bring back layout_gravity="bottom" solves the issue, as bottomMarign is always correct
Fix: 331517987
Test: manual as ShareTarget requires AiAi interaction and cannot easily be mocked
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6431d6e87910bc7c7767c40d42f51961dc462134)
Merged-In: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
Change-Id: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
The small size of the screenshots and make text look odd. Implementing new UI specs to improve this.
- Updated icon position and size
- Added some blur to the thumbnail
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328259439
Fixes: 328692456
Test: opened KQS in dark and light mode
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dba7cbae1adfde615060598a55b5ee0edfedef9f)
Merged-In: I2b20100ddeb562291edf5f0bacbce916002eee45
Change-Id: I2b20100ddeb562291edf5f0bacbce916002eee45
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
This CL sets gravity="start" and ellipsize="end" so that longer strings in the Overview app dropdown menu are still left-aligned and ellipsized when they are longer than the container.
Fixes: 330426535
Flag: N/A
Test: Manual
Change-Id: I1e62412c9b8be41a8dbb6b0597a69a283a56e3f0
(cherry picked from commit 6867b18db2)
- Removed the weight=3 space on left/right and replace with gracvity=central_horizontal
- Removed unused oav_three_button_space
- Removed irrelevant layout_gravity (gravity within parent), as the LinearLayout is already taking full parent width, and its vertical alignemnt si controlled by `updateVerticalMargin` in code
Bug: 329255757
Test: OverviewImageTest
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2cf1a0c08d41ee7a29ea920c93850d3914ed7cd8)
Merged-In: Ice087dde7d3c36b4536d36ce82c382c31c124855
Change-Id: Ice087dde7d3c36b4536d36ce82c382c31c124855
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN
Reason for revert: Test failure in question wasn't related to this topic b/328016248
Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN
Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
Merged-In: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
This CL sets an accessibility title so that TalkBack and other tools will properly read out the instructions on SplitInstructionsView.
Fixes: 323461342
Flag: ACONFIG com.android.wm.shell.enable_split_contextual TRUNKFOOD
Test: TalkBack announces the instructions immediately when the view appears, and is not interrupted.
Change-Id: I1666f0c374d40b31d732d3cca529f03a7f2f7f28
Touch targets have to meet a minimum of 48 dp to meet accessibility
requirements. The Done button in taskbar education was previously too short.
Fixes: 320600718
Test: Manual
Flag: N/A
Change-Id: I5fae302b82585e9793d7ede42dbcc6e6395254da
This CL refactors some methods in OverviewTask to rely on OverviewSplitTask. It also changes the BaseOverview getTasks function to retrieve the parent task and support cases where only the bottomright_snapshot is available in the recent tasks.
Bug: 320633351
Test: TaplTestsSplitscreen
Flag: N/A
Change-Id: I226f895810ce3b46cc107f76cd85e2918abf7088
Bug: 230395757
Test: In 3-button folded mode, make sure that the touches that happen between nav buttons go to the nearest button. No regression in other modes.
Change-Id: Icb776a9a4ed4fc31d33dc3267c7053f2b0da0bfc
Touch targets have to meet a minimum of 48 dp to meet accessibility
requirements. The Done button in the gesture navigation tutorial menu
was previously too small.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Fixes: 319752098
Test: Opened the gesture tutorial menu in smaller and larger screens.
Change-Id: I7d9b856ad4829e4ffe26a7df00f42e5e4fcf1b2e
This change adds in a standalone edu window for the pinnable taskbar
feature. The reason for the change is to educate users about pinnable
taskbar to those who have already seen taskbar edu before.
Fixes: 302589411, 300161174
Test: Went through taskbar education taskbar with the flag on and off.
Check that the standalone pinning taskbar only shows up if previous
taskbar education was already completed.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I03a5fb05ae5f15892421a57355f6d503de56d9fd
Description: in ag/24721149 we stopped inflating IconView
from Task.xml and instead used a viewstub. When creating
files to fill the viewstub, we forgot to place the correct
attributes on Icon_view.xml. We did place them correctly
elsewhere. Anyways this is why we were seeing focusable
icons.
Flag: None
Test: Built locally, will follow up with automation
Bug: 307461880
Change-Id: I45f895c8545a80f80c79709180f2878476d10221
* Styling (accent color) is still a TODO,
just made it bold for now.
Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Bug: 295983387
Test: Tested w/ flag on and off, cancel doesn't show
with flag off
Change-Id: Id5214a86abbe0cf095e32f6f75522ea51d6b1f3c
This change updates the current transient taskbar education to include
the pinning feature and additional updates to Lottie animations. It also
removes the tutorial that teaches users to switch navigation modes. The
pinning education is gated behind an additional pinning education static flag.
Fixes: 302588455,300161174
Test: Went through taskbar education for persistent and transient
taskbar with the flag on and off.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I836467091bfe694eee89ac46c4be597c490e1b3f
Fix clipping of DesktopTaskView border on focus/ hover
Hover border: https://screenshot.googleplex.com/B9CUW49q6inMW75
Focus border: https://screenshot.googleplex.com/36uLJ4jC295t7PZ
`android:clipToOutline` prevents drawing outside view bounds and results in the focus/ hover border getting clipped, instead we can use `android:clipToPadding` with a small non-zero padding to clip children and allow drawing a border outside the bounds
Change-Id: I7e763f7ee8c7fd1090c7778c2c000d2b792bef06
Since the number of Overview actions is growing, this patch factors out the button hiding logic so it's not all handled in OverviewActionsView.
Also, since splitscreen can now be carried out on Taskbar targets, the split button is no longer ever disabled (only hidden), so removed unused code for that.
Bug: 274835596
Test: Manual
Flag: NA
Change-Id: Icacdee6d0e6071ccb400dfc25a84572e7e9ce772
we recently added support for settings app style switches to Launcher. Use that style for TaskbarDividerPopupMenu Switch
Test: Manual
Bug: 308682758
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: If61a426e4051ebce67601055942667ed93928d15
- Dynamically adjust the paddings of both start and end contextual containers in different layouts
Test: manual
Bug: 230395757
Change-Id: I2c6a1350e0dab36f6d5100b8d4e2012d8a97cd9b
- Added a res id to KeyboardQuickSwitchView for TAPL testing
- Updated KeyboardQuickSwitch focus and scroll initialization
- Logging KeyEvents for TAPL testing
- Updated scrolling logic to wait for initial layout
- Fixed activity leak in KeyboardQuickSwitchViewController
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 267520665
Test: TaplTestsKeyboardQuickSwitch
Change-Id: I1d45d948c0e185504d994f7ef1d34f173c2243a9
- removes a lot of dead code for the old popup design and especially around adding notifications to popups
- renames several resource files to remove the material_u specification, as it is now the only design
Test: manually run through launcher popups
Bug: 270395516
Flag: ENABLE_MATERIAL_U_POPUP
Change-Id: I462063482206578b4b896a6d405dc2383f2da510
- Breakout CL part 3
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist removal of an option from taskbar divider popup meu which is no longer required and other changes regarding the removal like ripple.
Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
- Breakout CL part 1
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist refactoring of Taskbar Divider Line to be using IconButtonView.
Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I6719dd568986dce7cf9cdf0f287c3f079fd35ba6
