Updated the logic to set the taskbar window height to accommodate the
bubble bar with its maximum flyout height before the bubble bar
animation begins. The height is reverted to the default value once the
animation is completed.
Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Set 3-button navigation mode and have the QSB placed
above the hotseat. Send a notification that will display a bubble, and
observe the bubble bar animation and final placement aligned with the
QSB.
Next, set gesture navigation mode and repeat the flow above. Observe
that the bubble bar is aligned with the hotseat icons.
Felix video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/gYMVt0sH4si0KOpaBxIPem
Tangor video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fz95MbjcjW3awStnuOl8BJ
Change-Id: I239f935743c3936fed44822c3c62652073ffefe2
Change logic to updated bubble bar alignment with the QSB vertical
center for 3 buttons navigation mode.
Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: PersistentBubbleStashControllerTest
Test: TransientBubbleStashControllerTest
Test: Manual. Set the buttons navigation mode and observe that the
bubble bar is centered with the QSB when the QSB is not aligned with the
hotseat. Then, switch to gestures navigation mode and observe that the
bubble bar is centered with the hotseat when the QSB is not aligned with
the hotseat.
Change-Id: I57a32ac5bde7a7055b54a89727429424e5c0ca4f
Refactor the TaskbarManager's existing usages of TaskbarRootLayouts to use a map, so that there can be a 1:1 relationship between TaskbarRootLayouts and TaskbarActivityContexts.
Flag: EXEMPT not adding new behavior
Bug: 380351840
Test: Manual
Change-Id: Ib4379a9b6d50b8bdd64b70d7b15ce798ebb42731
Previously home animations for 3rd party launchers were being cancelled by the recently added onFinishComplete call in AbsSwipeUpHandler.onTasksAppeared. This was because FallbackSwipeHandler.handleTasksAppeared was returning false even though mActiveAnimationFactory.handleHomeTaskAppeared was true. However, only fixing this so it returned true instead would allow AbsSwipeUpHandler.onTasksAppeared to continue to the following conditions which would fail, so this change also converts FallbackSwipeHandler.handleTasksAppeared to override onTasksAppeared instead. This allows home tasks to be handled first and skip splash screen handling since it is not needed.
Flag: NONE bug fix for recently introduced issue
Fixes: 362900007
Test: set 3rd party launcher as default and use home navigation gesture
Change-Id: I88015bd3bdbad94bd4897411714ff3f52a782499
- Speculative fix, there are some scenarios where we update the swipe
touch/assistant regions without updating the OHM regions
Bug: 362039326
Flag: EXEMPT bugfix
Test: Manual
Change-Id: If5c558623073e5185827ae17a162dacf322c74a4
When using a 3P Launcher, i.e. when the ROLE_HOME is not held by QuickstepLauncher, there should be no back callback registered with SystemUI.
Bug: 374882166
Flag: EXEMPT bugfix
Test: Manual, i.e. verified back-callback registration updates in SystemUI and also verified that back-to-home navigations in Nova Launcher are responsive.
Change-Id: I03187f80a4c3c893a6529f0a22613f6fdfe7b7b3
Bug: 373544911
Test: Manual, i.e. verified that sliding away from the back button (within the taskbar window) cancels the predictive back animation
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I9a1448c7005211c87a8979261b13fe37ab64a5b2
This means that overlay is initialised in all cases, not just some. Also uses pre-existing method for `isTaskViewFullyVisible()`
Fix: 376264918
Test: Manual checking of flows in bug.
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ia898a2a869b79fb120a162fa5a3fe7df0fbf9800
We were checking the wrong index (off by one), leading to a crash if the divider is already in the Taskbar at the correct index. However, we do need to add it after the expected index if the divider isn't there, otherwise it will push the icon that is at that position to the right of the divider (it should be to the left).
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Bug: 368522274
Test: go/testedequals
Change-Id: I0263f704728286b53da5b45828784b20aaae31ce
- To workaround the fact that TTT does not get full task visibility info,
we can existing tasks as not-visible whenever the occluding home task
is moved to front
- Fix an issue where task icons were not loading for running tasks
due to us skipping updating for running tasks in the recents
transition (we will continue to skip updating the thumbnail though)
- Also skip updating the same taskview multiple times if the task
container has multiple tasks that need to be updated
Bug: 372067617
Bug: 280812109
Flag: EXEMPT bugfix
Test: atest TaskThumbnailViewModelTest,TasksRepositoryTest,RecentsViewModelTest
Test: atest TaplTestsQuickstep#testExcludeFromRecents
Change-Id: Ifa33cfe53d44e5fe7778aecd5434abf9c29b3170
* changes:
Prepare for LayoutTransition with RTL support.
Split up hotseat and recents into two methods.
Filter out unsupported items immediately when updating Taskbar.
Was not able to repo the initial bug, but this change leaves the
original path unchanged.
Fixes: 374579710
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I91e0235571b0736dcbe70c7730d7c90ec949a13e
Only remove divider when it needs to be removed or moved between All Apps and recents locations. Keep All Apps and QSB in Taskbar at all times. LayoutTransition does not work if views are being removed and then immediately readded (what current code branch does).
Overflow is not supported yet with the LayoutTransition flag.
Test: go/tested-equals
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 368522274, 343521765
Change-Id: I9ae1d7c52e853106cdf86329be6f221213e7cb86
To support RTL with recents, will need to support calling updateRecents before updateHotseatItems. Splitting into two methods makes this doable.
Test: go/testedequals
Flag: EXEMPT refactor
Bug: 343521765, 368522274
Change-Id: I8756ea23fff1606ef4ab9f72d18dd4b21f135b25
Fixes an issue where hotseatItems may not reflect the number of hotseat views in Taskbar. Entries in the array can be null (e.g. no predictions but there is space in the hotseat for them). If these are filtered out immediately, hotseatItems.length will correspond to the number of hotseat views.
Test: go/testedequals
Flag: EXEMPT bugfix
Fix: 379704910
Change-Id: I375d8152fccb6df5a9b783842ecf5dcedf6894c1
- excludeFromRecents are sometimes added as index 0 after moveRunningTaskToFront, breking the model that fullscreen tasks should be shown after desktop tasks
- Added getRunningTaskExpectedIndex to compute expected runningTask postion in all scenario, and apply this position both when adding the view in showCurrentTask and moveRunningTaskToExpectedPosition
Fix: 380232192
Test: Swipe up from following scenario in phone/tablet, repeat several times
1) 1st fullscreen task
2) 2nd fullscreen task
3) excludeFromRecents task
4) Desktop task
Flag: EXEMPT BUG_FIX
Change-Id: Iec551fb1403a6bb5307b684a50f7ae7d31bd4644
Refactor the TaskbarManager to support multiple TaskbarActivityContexts.
Flag: EXEMPT not adding new behavior
Bug: 362720616
Test: Manual
Change-Id: I1baa081f6994cb94465f20aa7e0c6b47f5cb7eb8
We can access the static instance as needed without retaining it
in this class.
Bug: 321226611
Test: Manual (test Circle to Search setting works as expected)
Flag: EXEMPT bugfix
Change-Id: I79a22d313bf802b6ea5e388e06269dd9ee5131a4
PiP2's enter flow is different in that we resolve
TRANSIT_PIP's startWCT in Shell, and PipTransition
will always make sure to set the right alphas
at the start and finish.
Bug: 380030547
Flag: com.android.wm.shell.enable_pip2
Test: atest NexusLauncherOutOfProcTests:TaplTestsSplitscreen
Change-Id: I7d28ed5dcccecfab71ff324098d5c31653ce1c9f
This change addresses an issue where the background of the multi
instance menu would sometimes not render in time, leading to a visual
bug.
Fix: 380087041
Bug: 315989246
Test: Manual
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: I32b746a990e89e954b00a0cdcb0e1bf2fae2537f
Add a semaphore to block the test until the bubble bar is expanded.
100x run: http://ab/I94900010337166460
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 380023942
Test: ab link above
Change-Id: I473208255ef658ee532f54c2665889ee5c24e39e
Bubble bar was stashing with a delay compared to taskbar.
This is because taskbar stashing looks at isInLauncher value in addition
to launcher state.
Add this check to the bubble bar in overview condition. And only
consider bubble bar showing in overview if we isInLauncher returns true
and launcher state is overview.
Bug: 371229068
Test: manual, start from home with bubble bar shown, swipe up to
overview, tap on an app, observe that bubble bar stashes at the same
time as taskbar
Test: swipe up to home, open all apps, check that bubble bar remains
visible
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Icedfd29300f739e37d636122bad0fb6e14fa2ced
