Commit Graph

2790 Commits

Author SHA1 Message Date
Tony Wickham
2e3b7c6e97 Redraw live tile in updatePageOffsets()
Also finish recents controller in RecentsView#reset() if it hasn't
been already.

Test: in 2 button mode, swipe up from overview when a live tile is
running, ensure it moves offscreen with its TaskView; after swiping
from overview to home, tap nav bar to ensure controller was finished
Fixes: 185588376

Change-Id: Ibfdea9fcfb69dbc20c51474198c7cc2f9281c705
2021-04-20 17:55:17 -07:00
Tracy Zhou
e1ce26e70c Fix weird task launch animation
Sometimes a weird task launch animation can be observed where the task is animated to fullscreen before animated again from center to the left side of the screen. This is caused by stateManager.moveToRestState() call that internally animates FULLSCREEN_PROGRESS to 0 based on its launcher state (normal). The implementation right now finishes the recents animation after this call, instead of before. We should finish the recents animation first before doing the recents view clean up work.

Fixes: 184878444
Test: manual
Change-Id: Ib24fcf5ecb12e1a1357441427daface2778e1008
2021-04-20 17:55:17 -07:00
Winson Chung
0dfce759a9 Reset activity reference after invalidation
Bug: 185909226
Test: Presubmit
Change-Id: Id0a6a1c5301c66a515cefcab58b77495081c6190
2021-04-20 13:31:09 -07:00
TreeHugger Robot
426bcc7715 Merge "Update TwoButtonNavbarTouchController logs" into sc-dev 2021-04-20 20:00:51 +00:00
Alex Chau
e8f147e2ce Merge "Check null for actinosView in resetPaddingFromTaskSize" into sc-dev 2021-04-20 17:50:38 +00:00
Alex Chau
aef3a3c40a Merge "Consider orientationHandler when calculating ClearAllButton scrollOffset" into sc-dev 2021-04-20 14:21:19 +00:00
Alex Chau
e485941c10 Check null for actinosView in resetPaddingFromTaskSize
Bug: 185805100
Fixes: 185805100
Test: manual
Change-Id: I03cc5820d77c16873acf3d9600c544d90b515a29
2021-04-20 14:31:20 +01:00
Vadim Tryshev
874a389c05 Merge "Revert "Default shell_starting_surface to true to match platform behavior."" into sc-dev 2021-04-20 01:16:36 +00:00
Tony Wickham
8559ae324c Update TwoButtonNavbarTouchController logs
- Fix wrong bug number
- Log when we intercept and reinit to a state rather than in
  getTargetState() which is used to determine possible swipe
  directions too (which makes the logs confusing)

Test: run TaplTestsQuickstep#testOverviewActions
Bug: 177316094
Change-Id: Ibe5db6317c16c429c9c46bf237d3f8adc1458037
2021-04-19 17:40:47 -07:00
Vadim Tryshev
250f568cb2 Revert "Default shell_starting_surface to true to match platform behavior."
This reverts commit 6acba27109.

Reason for revert: https://b.corp.google.com/issues/185818929#comment4

Change-Id: I30875c1f81808b92f529bd11c916fea05b93fd4d
2021-04-19 21:31:51 +00:00
Jonathan Miranda
fbea50d807 Merge "Default shell_starting_surface to true to match platform behavior." into sc-dev 2021-04-19 15:08:32 +00:00
Jon Miranda
6acba27109 Default shell_starting_surface to true to match platform behavior.
Bug: 177264697
Test: manual, cold/warm app launches
Change-Id: I0b2f080ddc234f7b9f1432bb8cd80f85c176bc7a
2021-04-19 04:05:18 +00:00
Andy Wickham
6c9f4ef566 Merge "Sandbox changes for use in UXR prototype." into sc-dev 2021-04-17 05:37:41 +00:00
TreeHugger Robot
231ccd65bf Merge "Redraw live tile when dismissing all tasks" into sc-dev 2021-04-17 02:01:05 +00:00
Tracy Zhou
9a14d08987 Redraw live tile when dismissing all tasks
Fixes: 185309909
Test: manual
Change-Id: Ibfa4e5eaddfff79cffc76b272be35f726cb2bc9a
2021-04-16 17:12:07 -07:00
Andy Wickham
855072cda5 Sandbox changes for use in UXR prototype.
- "All Set" screen doesn't show after Home/Overview/Back tutorials.
 - X button in top left is hidden (we'll want to move this to the
   feedback view).
 - Feedback pops in and out from the top of the screen.
 - Hand animation is replaced by video feedback at start and after
   incorrect gesture.
 - Back tutorial goes left then right, in order to match video.
 - Updated strings and marked translatable (UX-reviewed already).
 - Added Chinese translations.
 - Many other things.

Test: Manual
Change-Id: I126a3ea0dad645014fab9cdee2ed19e06a8a56e9
2021-04-16 16:54:41 -07:00
Tracy Zhou
ddc33d6344 Check if the TaskView is a live tile task in task launch animation
Fixes: 185540107
Test: manual
Change-Id: I7f1503d8ac6dee4c153a60d5f72fae9a37f1c387
2021-04-16 16:35:42 -07:00
Sunny Goyal
9a8c77afe9 Merge "Fixing recents command not working properly in gesture mode" into sc-dev 2021-04-16 22:03:31 +00:00
Sunny Goyal
dfc22b8ff1 Fixing recents command not working properly in gesture mode
Bug: 185445289
Test: Manual
Change-Id: I233ee493ea0d42bbfca14b17e921d907cc65da53
2021-04-16 12:13:31 -07:00
Alex Chau
8181479443 Consider orientationHandler when calculating ClearAllButton scrollOffset
Bug: 185498648
Fixes: 185498648
Test: Manual
Change-Id: I7aaab4e62c3e7edf3ecdb3fe40020b8064e0109b
2021-04-16 18:11:27 +01:00
Sunny Goyal
4b162b1336 Merge "Adding surface-release check for live-tiles" into sc-dev 2021-04-16 17:10:43 +00:00
Alex Chau
84a1e40912 Merge "Handle page offset for grid overview" into sc-dev 2021-04-16 14:09:33 +00:00
Cyrus Boadway
42431d5217 Merge "Use Quickstep ActivityOptions when launching activities from App Widgets" into sc-dev 2021-04-16 11:53:35 +00:00
Alex Chau
9594c6987f Handle page offset for grid overview
- Use TaskView's actual position with grid/fullscreen translation considered for taskPosition calculation
- Shift taskPosition by midpoint scroll, and no longer assumes midpoint is on middle of the screen
- Handle situation that TaskView is on left/right of midpoint, making the calculation generic to be able to handle grid situation

Bug: 175939487
Test: Launch modal view with wide/, RTL/non-RTL, orientation/simulated landscape combinations
Change-Id: Idd0cc9c5e24f453d830e1420319a38d3d784270d
2021-04-16 12:25:49 +01:00
Cyrus Boadway
0d309db47e Use Quickstep ActivityOptions when launching activities from App Widgets
Set a Quickstep specific InteractionHandler on QuickstepLauncher's
AppWidgetHost, which provides QuickstepTransitionManager-generated
ActivityOptions when starting activities from app widget interactions.

Bug: 169042867
Test: manual
Topic: quickstep-widget-app-launch
Change-Id: I231122b09aede940c047f19a5b5d1e7c562f6d3f
2021-04-16 09:42:46 +00:00
Sunny Goyal
eb104ad9fe Adding surface-release check for live-tiles
Bug: 181615944
Test: Will wait for newer more bugreports
Change-Id: If82efbfa738ceb9890a9994607b13fd2bde096c4
2021-04-15 12:58:40 -07:00
Alex Chau
d2ec22c3f6 Merge "Handle swipe up after quick switch in overview grid" into sc-dev 2021-04-15 18:50:14 +00:00
TreeHugger Robot
c874ccc163 Merge "Fix regression where StaggeredWorkspaceAnim didn't respect animateScrim" into sc-dev 2021-04-15 17:39:01 +00:00
Alex Chau
f4cf80ea73 Handle swipe up after quick switch in overview grid
- If swipe up after task launches, move the task to be the first and focused it
- If swipe up before task launches, make sure the task can be sanpped to by moving ClearAllButton further away
- Before snapping to page on swipe up, make sure scroll calculation is up to date and consider the target gesture state
- Removed home task special casing in fallback recents, as the snapped page logic handles invariant scroll generically
- Invoke reset when launching home in fallback recents

Bug: 175939487
Fixes: 184262404
Fixes: 185468049
Test: Manual
Change-Id: I5a6c581f15cd62748cfe6c77342d959f4dd1bfaf
2021-04-15 18:13:50 +01:00
Vinit Nayak
0a19747cae Merge "Revert "Make RotationTouchHelper singleton to report single rotation state"" into sc-dev 2021-04-15 05:38:18 +00:00
Vinit Nayak
08f3d4d675 Revert "Make RotationTouchHelper singleton to report single rotation state"
This reverts commit d8ad6b25f4.

Reason for revert: b/185382799, b/185383656

Change-Id: Ie500fd5c4f2937df56fbd8afe5556f1a71b90d87
2021-04-15 01:50:02 +00:00
Tony Wickham
01320be908 Fix regression where StaggeredWorkspaceAnim didn't respect animateScrim
Before, this happened to work because we skipped setting the scrim when
doing an atomic animation, but the atomic animation code has been
removed. Add an explicit SKIP_SCRIM config flag instead.

Test: swipe up from overview to home, ensure scrim animates nicely

Bug: 185411781
Change-Id: I7bc14a11d9d416cc7336ea29d21107dcdbdbf782
2021-04-14 14:54:44 -07:00
TreeHugger Robot
9a7281c51e Merge "Add logs to help debug TwoButtonNavBarTouchController" into sc-dev 2021-04-14 19:40:54 +00:00
Andy Wickham
3aea671e4f Merge "Updates quickswitch animation from Launcher." into sc-dev 2021-04-14 01:56:36 +00:00
TreeHugger Robot
047f2ed9b8 Merge "Remove SystemUiProxy#monitorGestureInput() as it's no longer used" into sc-dev 2021-04-14 00:14:36 +00:00
TreeHugger Robot
cc339a5587 Merge "Fixing race condition when an apk is removed." into sc-dev 2021-04-14 00:04:48 +00:00
Tony Wickham
7b2e3df2d7 Add logs to help debug TwoButtonNavBarTouchController
Test: TaplTestsQuickstep#testSwitchToOverview()

Bug: 13714484
Change-Id: I21740ac0fd6ddf2923fd081a00c84a463f13673b
2021-04-13 16:45:41 -07:00
Vinit Nayak
91b83064e1 Merge "Make RotationTouchHelper singleton to report single rotation state" into sc-dev 2021-04-13 22:43:07 +00:00
Andy Wickham
18694a2545 Updates quickswitch animation from Launcher.
- Workspace/All Apps/Hotseat no longer translate down
 - Fading of these elements and scaling of Workspace are tied to the
   wallpaper depth animation
 - At any point in the drag, you can still swipe up to enter Overview

This makes it feel like the apps are tied to the wallpaper and avoids
moving them orthogonally to the finger.

It also makes the "No recent items" animation more elegant.

Demo: https://drive.google.com/file/d/1phuRCqb69vuMp3ijS6PR5lTEcBHScjie/view?usp=sharing&resourcekey=0-2HXtMLUhQ-YU53hYlYV-fQ
Demo with no recent apps: https://drive.google.com/file/d/1wjexqznxs9ZhiUtCDW4-ZK6c7hKDRaXn/view?usp=sharing&resourcekey=0-GugbpJK8_cnFbUBB2Ar30w

Fixes: 174228745
Test: Manual
Change-Id: I1574ff89a0f382b7e63bf03cf4300ec7c695cfec
2021-04-13 15:35:46 -07:00
Tony Wickham
9ac8b781b9 Remove SystemUiProxy#monitorGestureInput() as it's no longer used
Test: compiles and runs locally
Bug: 185266621
Change-Id: I4d40de269007178550cf1a9e9e906018badc6f74
2021-04-13 14:29:19 -07:00
Tony Wickham
a5788cc24f Merge "Move taskbar to be closer to QSB" into sc-dev 2021-04-13 21:12:49 +00:00
Sunny Goyal
79ee3f6310 Fixing race condition when an apk is removed.
Since the check was happening on a different thread, the view might have change by the time
the callback comes back on UI thread.

Bug: 185100744
Test: Manual
Change-Id: I1347819bee71ed9d7ba6aa676f4318ea03316ea2
2021-04-13 13:43:25 -07:00
Rob Carr
a3ba0f9f6d Merge "Launcher3: Port SurfaceTransactionApplier to BLAST" into sc-dev 2021-04-13 19:47:25 +00:00
Tony Wickham
5df03e1585 Merge changes from topic "taskbar-hotseat" into sc-dev
* changes:
  Update taskbar to add extra hotseat items instead of recent apps
  Add support for having more hotseat icons in the DB than we show
2021-04-13 18:41:47 +00:00
Tony Wickham
81f8175ab1 Move taskbar to be closer to QSB
- Offset taskbar to be halfway between QSB and bottom of the screen.
- Add taskbar translationY state property to animate when going
  between launcher and an app.
- Draw the taskbar background in TaskbarContainerView instead of
  TaskbarView so it stays pinned to the bottom as TaskbarView
  translates up. If we want to have a background behind the
  taskbar on home, this should move back to TaskbarView so that
  the drawing can be shared by mTaskbarViewOnHome.

Test: visually on home screen, translates when entering and
exiting an app

Bug: 182981881
Bug: 171917176
Change-Id: I44f8b2c770074f7f015dcccbc2befd3453811193
2021-04-13 10:10:54 -07:00
Vinit Nayak
d8ad6b25f4 Make RotationTouchHelper singleton to report single rotation state
Multiple instances of RotationTouchHelper were being
created and reporting conflicting and incorrect information
to sysui for current quickswitch state.

Bug: 183897242
Test: Ensure quickswitch gestures work as expected.
Change-Id: Ia8716f2b597033e9e81291e0b4490119c30ad972
2021-04-13 09:35:23 -07:00
Tony Wickham
be282e9bc8 Update taskbar to add extra hotseat items instead of recent apps
Removes recents-related code including the divider between it and
hotseat.

Test: manually on device

Fixes: 184366189
Bug: 184789479
Bug: 171917176
Change-Id: I7776c98659ded70f53a49befddcd23c8353c6440
2021-04-12 16:20:18 -07:00
Tony Wickham
b87f3cdc1c Add support for having more hotseat icons in the DB than we show
Split InvariantDeviceProfile#numHotseatIcons into two variables:
numDatabaseHotseatIcons and numShownHotseatIcons. These are generally
the same, but different DisplayOptions within the same GridOption
can choose to show different numbers of hotseat icons while sharing
the same database.

numDatabaseHotseatIcons is used for all reading/writing/migrating
purposes, while numShownHotseatIcons determines how many Hotseat
icons to show in the UI.

Test: Existing tests pass, added two new migration tests
Bug: 184789479
Bug: 171917176

Change-Id: I54583504f61a47a4444b6a637ebb7e3ab31528b7
2021-04-12 16:08:15 -07:00
TreeHugger Robot
9bb040ec6d Merge "Handle transitining out of overview more gracefully for 3P launchers" into sc-dev 2021-04-12 22:41:36 +00:00
Vinit Nayak
58dfd4d209 Handle transitining out of overview more gracefully for 3P launchers
Bug: 183897242
Test: Tested with Pixel Custom Launcher, as suggested on the bug
Change-Id: I46ceddb9f5eed6b16b7e66406dd68d94e7a30aee
2021-04-12 10:21:14 -07:00