Commit Graph

3996 Commits

Author SHA1 Message Date
Tony Wickham
2ca7e2695c Add null check when settling on LAST_TASK
Test: N/A
Fixes: 203237855
Change-Id: I511fde0ba3f22720ed1fe29769c97a3207a98a4b
2021-10-29 14:15:53 -07:00
Tony Wickham
00841576d4 Merge "Fix NPE when TaskView isn't attached to RecentsView" into sc-v2-dev 2021-10-28 22:40:01 +00:00
TreeHugger Robot
da86c0e64d Merge "Update taskbar drag and drop treatment" into sc-v2-dev 2021-10-28 20:54:09 +00:00
Tony Wickham
956ce16f51 Fix NPE when TaskView isn't attached to RecentsView
Test: theoretical
Fixes: 201481275
Change-Id: Ie10b5ebac373e41a4d4113ee3cda737d88adad8a
2021-10-28 13:21:15 -07:00
TreeHugger Robot
d84aaad11f Merge "Make gesture nav tutorial skip button always visible." into sc-v2-dev 2021-10-28 19:51:05 +00:00
Tony Wickham
89ef745d1c Update taskbar drag and drop treatment
- Disable the FastBitmapDrawable icon instead of setting it to invisible
- Suspend auto hide during drag and drop (moved to new TaskbarAutoHideSuspendController)

Test: Drag and drop from taskbar and ensure the original icon stays in place but desaturated
Test: Open immersive app, drag and drop from taskbar and ensure taskbar doesn't hide before drop
Fixes: 200816442
Change-Id: I4b895efd043be75e7e7034bd75e751ffdd2cfdd7
2021-10-28 11:43:49 -07:00
bquezada
e12b321d5f Change AppTargetId for launcher events to align with other AppTargetId's.
Bug: 202535375
Test: Manual
Change-Id: I0c28f7f64935fdaf08edb7781e4e7378a068e8e6
2021-10-28 17:52:02 +00:00
Alina Zaidi
29c3f23be5 Merge "Send widget added and removed events to AiAi." into sc-v2-dev 2021-10-28 16:45:22 +00:00
TreeHugger Robot
ce597d786f Merge "Prevent launching app in split if task split is unsupported" into sc-v2-dev 2021-10-28 11:19:39 +00:00
Bill Lin
497d08aa01 Merge "Allow One-handed gesture when densityDpi > 600" into sc-v2-dev 2021-10-28 02:20:24 +00:00
Tony Wickham
c1cdadf6ea Merge "Fix testStressSwipeToOverview" into sc-v2-dev 2021-10-27 21:39:45 +00:00
Tony Wickham
ce6bf7dd7f Fix testStressSwipeToOverview
- Finish recents controller to app rather than to launcher, to ensure taskbar state uses in-app configuration
- Also fix an issue when a gesture completes before onLauncherStart, which happens in 3 button mode. The error I saw in the test was:
java.lang.AssertionError: http://go/tapl test failure: Failed to receive an event for the state change: expected [Overview], actual: [Background, Normal];
Context: want to switch from background to overview, clicking Recents button; now visible state is Background
(This also accurately describes what I saw on the device, where the LauncherState went to Normal but the task was still running in the live tile)

Test: testStressSwipeToOverview
Fixes: 203577620
Change-Id: I19616f7921c9821f1b45a90a3e4bec4fb3b8a9d3
2021-10-27 12:35:31 -07:00
Schneider Victor-tulias
9188b6b993 Update the hotseat edu layout for foldable devices.
Test: ran the hotseat edu on folded and unfolded foldable device in portrait and landscape mode and in three-button and gesture nav mode. ran hotseat edu on regular phone
Fixes: 203734732
Change-Id: Iea2140c8241cdea60cb5db37fbfb7f7701d63bd6
2021-10-27 17:48:46 +00:00
TreeHugger Robot
3edb8de094 Merge "Add mock animated taskbar to gesture nav tutorial for foldable devices." into sc-v2-dev 2021-10-27 17:45:38 +00:00
Tracy Zhou
c6bdd9243a Merge "Delete TaskbarStateHander" into sc-v2-dev 2021-10-27 02:11:12 +00:00
Pablo Gamito
aae8a2a2a5 Merge "Set custom task transition spec when taskbar is visible" into sc-v2-dev 2021-10-26 21:32:16 +00:00
Tracy Zhou
72f1afcf02 Delete TaskbarStateHander
Bug: 204220602
Test: N/A
Change-Id: I6c26b4d3b8acb35750be56986555350e84f31ecb
2021-10-26 13:26:27 -07:00
TreeHugger Robot
3cbee2d1d7 Merge "Using a different transition for All-set activity" into sc-v2-dev 2021-10-26 20:00:21 +00:00
Sunny Goyal
eed4bbfb49 Using a different transition for All-set activity
Bug: 201797003
Test: Manual
Change-Id: I33b342ca224ab283e2ac475d4defe2eac6a87bb8
2021-10-26 11:25:32 -07:00
Vinit Nayak
3e9bd87ca9 Prevent launching app in split if task split is unsupported
Bug: 204026157
Change-Id: Ie13ac74e0c1d357db242d49083be97f0f45e6ca5
2021-10-26 11:10:23 -07:00
TreeHugger Robot
3bd6b8bf81 Merge "Make sure distinct widgets items are used when mapping widget component names to widget items." into sc-v2-dev 2021-10-26 18:01:48 +00:00
Pablo Gamito
77d3cab287 Set custom task transition spec when taskbar is visible
This is to ensure that the task to task animations look good when the
taskbar is visible (the transition background is the same as the taskbar
color, the taskbar overlay rounded corners are hidden, and the task
animates above the taskbar so it's rounded corners are visible during
the animation and not hidden behind the taskbar).

Test: Open tasks from other tasks to trigger task to task animations and
see if they look good
Bug: 200675009
Bug: 196387647

Change-Id: I8e46718829c0e6541a5c1b1a3a156285aeecd30a
2021-10-26 14:56:27 +02:00
Alina Zaidi
987221a1cc Send widget added and removed events to AiAi.
-Pass the widgets on workspace as an extra List<AppTargetEvents> while
 creating prediction session.
-Notify the session about widget added/removed events after creation.

Bug: 186648032
Test: Manually checked events are received
Change-Id: I4de6c011a1e24c129a3e995ddba16bfc55074939
2021-10-26 12:29:48 +01:00
Tony Wickham
add188f339 Merge "Hide taskbar background when notification shade is expanded" into sc-v2-dev 2021-10-26 02:56:47 +00:00
TreeHugger Robot
c6649763a7 Merge "Fix launching window bounds for immersive apps" into sc-v2-dev 2021-10-25 23:20:47 +00:00
Tony Wickham
232e9a4631 Hide taskbar background when notification shade is expanded
- In 3 button mode, don't hide the background but do ensure nav buttons are translated down when swiping to notificaitons from the home screen

Test: swipe down notifications, background hides in 0 button mode but not in 3 button mode
Fixes: 199163951
Change-Id: Ic70adc7d67b2ab7c92a2d5d846b9b259d1bd7bfc
2021-10-25 13:44:09 -07:00
Alina Zaidi
fa37c6742e Make sure distinct widgets items are used when mapping widget component
names to widget items.

This is to prevent a crash on duplicate key when creating map.

Bug: 204065759
Test: Enabled flag and got no crash
Change-Id: Ice9f93af76c02eeba53c934687358ed806c60b60
2021-10-25 16:10:45 +01:00
Alex Chau
39da1f78da Fix TaskView jumping caused by split select
- Never apply split select translation to grid overview, instead use dismiss translation to make space to split placeholder to minimize motion and avoid janky double movement
- Ensures snapping to last task for end of grid split cases
- Adjust mCurrentPageScrollDiff due to coordinate shift
- Use longGridRowWidthDiff to shift all task to make space for split placeholder
- Also fixed a bug that split translation isn't reset if entering overview immediately after exit

Bug: 200537815
Test: manual
Change-Id: Ie1b57c34ce4bb079f898ba5b7c3464a714021847
2021-10-25 15:38:34 +01:00
Bill Lin
2745327c5e Allow One-handed gesture when densityDpi > 600
This logic was aim to prevent tablet device enable One-handed gesture
so added displayInfo.densityDpi < DisplayMetrics.DENSITY_600 before.

However, it seems this densityDpi=600 does not able to represent to
tablet device, instead we already have system property
"ro.support_one_handed_mode" which provides feasibility to config false
on tablet project, as the reason we can safe to remove this condition.

Bug: 203936659
Test: adb shell wm density 600 , and observe OHM gesture is available
Test: atest WMShellUnitTests
Change-Id: Ic7ae10e8a47d26b9bb39ab80e22d591d74f89ae5
2021-10-25 06:47:13 +00:00
Tony Wickham
3f6e3f0650 Stash taskbar in fallback recents
Test: Swipe to Overview with 3P launcher as default, watch taskbar stash
Fixes: 188790554
Change-Id: Id9fdcd715fc50872e3a96f102053a9a99859b482
2021-10-21 10:53:48 -07:00
Tony Wickham
8791e7de11 Add FallbackTaskbarUIController
- Refactor TaskbarManager to accept StatefulActivity instead of BaseQuickstepLauncher
- Update the new StatefulActivity in onOverviewTargetChange()
- Cleanup LauncherTaskbarUIController a bit to avoid initializing TaskbarActivityContext, TaskbarDragLayer, and TaskbarViewController in the constructor, and instead get these from mControllers after init()

Test: No change in behavior
Bug: 188790554
Change-Id: Ic4d69d73deb6dada416876eb265db57803c3adfd
2021-10-21 10:53:46 -07:00
TreeHugger Robot
d238074c39 Merge "Update TaskView corner radius as RecentsView scale changes" into sc-v2-dev 2021-10-21 15:12:16 +00:00
Alex Chau
3c6795e355 Update TaskView corner radius as RecentsView scale changes
Fix: 192253697
Test: manual
Change-Id: I45825c955b759163792d704408e348c198830fc8
2021-10-21 14:23:11 +01:00
Nick Chameyev
8523412470 Merge "Do not animate statusbar unfold when in portrait orientation" into sc-v2-dev 2021-10-21 10:02:00 +00:00
TreeHugger Robot
6409130f29 Merge "Cache TISBinder for multiple onBind() calls" into sc-v2-dev 2021-10-20 23:34:49 +00:00
Schneider Victor-tulias
e61fd5f316 Add mock animated taskbar to gesture nav tutorial for foldable devices.
Bug: 198434693
Test: launched and completed tutorial on regular phone and foldable device.
Change-Id: Id378e9bdd21fdfbc880ef528cb040b6390699d43
2021-10-20 16:16:10 -07:00
Vinit Nayak
45fbe5b563 Cache TISBinder for multiple onBind() calls
Bug: 202986128
Change-Id: I29a0963ff2880c9970859bc1437c7624bc7f0aea
2021-10-20 13:51:40 -07:00
Schneider Victor-tulias
e9bd364390 Merge "Generalize the icon popup menu types." into sc-v2-dev 2021-10-20 18:32:56 +00:00
Pat Manning
3c647ff30a Merge "Add new quickstep test for many tasks open at once." into sc-v2-dev 2021-10-20 15:20:26 +00:00
Pat Manning
ccec1de6ae Add new quickstep test for many tasks open at once.
This test is needed for testing overview-grid-related functionality.
- Opening non-focused tasks
- Dismissing a non-focused task from the grid
- Grid rows rebalancing after dismissal, which only happens when enough
apps are open to be off-screen.
- Grid tasks do not scroll after dismissal.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: Ic907db4643cdc2eb9e4610dab917347e234e470c
2021-10-20 14:40:32 +01:00
Schneider Victor-tulias
16e04e29d2 Generalize the icon popup menu types.
Generalized popup menu types and logic to allow wider uses outside of launcher.

Bug: 198438631
Test: long pressed launcher icons and pressed menu options
Change-Id: Iadcbb1796496c0061dcee362784e426ff55dc94a
2021-10-19 16:06:16 -07:00
TreeHugger Robot
bc9dd92220 Merge "Delaying taskbar loading until user setup completed" into sc-v2-dev 2021-10-19 21:49:02 +00:00
Sunny Goyal
2a528a43c1 Delaying taskbar loading until user setup completed
> Also keeping it stashed while all-set activity is visible
> Creating a shared state (simiar to saved instance state) for taskbar
> Keeping taskbar stashed while all-set activity is visible

Bug: 194786060
Bug: 201782272
Test: Manual
Change-Id: Iab5e082243a206772266aece62d3028f5acb6400
2021-10-19 12:38:02 -07:00
Vinit Nayak
75465b2d7f Add log to RemoteTargetGluer to determine which array is empty.
Bug: 199658495
Change-Id: I069044d8ee0173fa3870f48d50374c634e0d58d7
2021-10-19 18:10:06 +00:00
Schneider Victor-tulias
b4307ff8aa Merge "Update gesture navigation tutorial with new specs for foldable devices." into sc-v2-dev 2021-10-19 17:59:31 +00:00
Tracy Zhou
fc0b21596f Merge "Track LauncherState for task bar stashing better" into sc-v2-dev 2021-10-19 07:06:14 +00:00
Vinit Nayak
6f6e97c653 Merge "Ensure RecentsView RemoteTargetHandle's are non-null" into sc-v2-dev 2021-10-18 23:19:21 +00:00
Mady Mellor
20c05fbd4c Merge "Add a scrim to taskbar for bubbles expanded state" into sc-v2-dev 2021-10-18 19:35:05 +00:00
Tracy Zhou
ae88197e5f Track LauncherState for task bar stashing better
- Animate in onStateTransitionStart
- Commit in onStateTransitionComplete

Fixes: 193938970
Fixes: 200765631
Fixes: 201644899
Test: Go home from overview; Go to all apps from home; Go to overview from home
Change-Id: I393022c86f09806fea29fb5bc7191304b473f231
2021-10-18 10:51:51 -07:00
Tony Wickham
e202a64e56 Merge "Fix taskbar layout issues in setup wizard" into sc-v2-dev 2021-10-18 16:01:38 +00:00