Commit Graph

360 Commits

Author SHA1 Message Date
Treehugger Robot
27c2f4ddc1 Merge "Decouple Backup / Restore Error Codes" into main 2024-12-02 18:57:17 +00:00
Stefan Andonian
6df13d3b8e Decouple Backup / Restore Error Codes
Bug: 381315244
Test: Simply looked at emitted error codes and changed names if they were used in multiple locations.
Flag: EXEMPT bug fix
Change-Id: Iab4a8d6ff410682f448b2ac32e44b766d79a7616
2024-11-27 16:48:28 -08:00
Juan Sebastian Martinez
12c5b06add Merge "Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest." into main 2024-11-22 18:21:05 +00:00
Juan Sebastian Martinez
86f3d35839 Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest.
The mock makes sure we don't rely on a device hardware for tests.

Test: DeleteDropTargetTest
Flag: com.android.launcher3.msdl_feedback
Bug: 379958544
Change-Id: I202b81f3dd16af1c0985980d0b962be0000bf31f
2024-11-21 13:32:43 -08:00
Charlie Anderson
24e3132bbd Revert^2 "Update test activities with a non-default icon."
3e7d28e1c7

Change-Id: Ifea50664980a5bb52700e494abb10643d68fbd01
2024-11-20 23:23:01 +00:00
Juan Sebastian Martinez
3f0d356619 Merge "Adding MSDL feedback to dragging apps and widgest over drop targets." into main 2024-11-19 15:58:35 +00:00
Treehugger Robot
7f103a6d5c Merge "Remove any fixed landscape foldable dumps" into main 2024-11-19 02:54:46 +00:00
Federico Baron
dd28335d78 Remove any fixed landscape foldable dumps
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I71f026d34dd536cc4041e1dd36908824eb479153
2024-11-19 00:49:26 +00:00
Shamali Patwa
f05d59cdad Merge "Update the enforce_system_radius_for_app_widgets flag's type" into main 2024-11-19 00:03:34 +00:00
Shamali Patwa
d2cc1f0577 Update the enforce_system_radius_for_app_widgets flag's type
Renamed to use_system_radius_for_app_widgets since metadata cannot be updated after submitting definition.

Bug: 373351337
Test: N/A flag metadata update
Change-Id: I25283b05341517f5984b0f2fc0d27efe8027a3de
Flag: com.android.launcher3.use_system_radius_for_app_widgets
2024-11-18 21:58:48 +00:00
Uwais Ashraf
970d19327d Close repeatedly unclosed resources at the end of tests
Fix: 379432671
Test: edited tests, presubmits passing
Flag: EXEMPT test only change
Change-Id: I45c46d7a56a30af4a11dff54b5bcc8a1e9bcda5f
2024-11-18 21:39:59 +00:00
Fengjiang Li
f6f4c18ff9 Merge "Revert "Revert AllAppsRecyclerViewPoolTest.kt"" into main 2024-11-16 00:09:23 +00:00
Sunny Goyal
5861ee437a Fixing LauncherAppCompoent not available for isolated context
In those cases, creating a new LauncherAppCompoent and storing it in
the application context

Bug: 372180905
Test: atest LauncherComponentProviderTest
Flag: EXEMPT bugfix
Change-Id: Ibf517a23801138b1fa18e8e4a7adbdedb994365b
2024-11-14 12:34:26 -08:00
Fengjiang Li
8fa1dcdc03 Revert "Revert AllAppsRecyclerViewPoolTest.kt"
This reverts commit 6554ab99e3.

Reason for revert: Since ag/28600866 was the real fix of b/354560500, we should restore the AllAppsRecyclerViewPoolTest.kt

Fix: 359247985
Test: Presubmit
Flag: NONE - released

Change-Id: I54c3a4d15ec5a9e96cd03c465d10898ef6ac2078
2024-11-14 16:21:07 +08:00
Juan Sebastian Martinez
d36f0d2b7a Adding MSDL feedback to dragging apps and widgest over drop targets.
The ButtonDropTarget class delivers MSDL feedback onDragEnter.

Test: DeleteDropTargetTest
Test: manual. Verified haptics when dragging apps and widgtes over
  "Remove" and secondary drop areas.
Flag: com.android.launcher3.msdl_feedback
Bug: 371249457
Bug: 371315650
Change-Id: Ic3f79ab5e3da7bb26797f2a1bfb79b5e37b3ac97
2024-11-13 10:20:13 -08:00
Charlie Anderson
90892a56b7 Merge "Revert "Update test activities with a non-default icon."" into main 2024-11-12 17:39:44 +00:00
fbaron
9b2f38fa26 Add device profile dump flag guarding for OneGrid
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: n/a
Change-Id: I8bee69a051e81e7a1f7ed0d4e20196e2379a8ed0
2024-11-12 04:30:41 +00:00
Charlie Anderson
3e7d28e1c7 Revert "Update test activities with a non-default icon."
Revert submission 29570743-fix-default-app-icons

Reason for revert: possible culprit of b/371183869

Reverted changes: /q/submissionid:29570743-fix-default-app-icons

Change-Id: I6be362d03791893f94d3393bf9c9ffc4d9e83ec9
2024-11-11 22:04:33 +00:00
Sunny Goyal
5ad2d9f53c Moving some tests off TAPL
Bug: 377772352
Test: Presubmit
Flag: EXEMPT test refactor
Change-Id: I679ae043d617b74a61a682d802c38cc904d2d0c5
2024-11-08 11:09:59 -08:00
Sebastian Franco
9e4c99befd Adding Launcher Mode settings to Launcher settings
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Iab688ebdb8449f9258b61f59a0afe97875f82a81
2024-11-07 21:17:10 -08:00
Uwais Ashraf
3e630a5d4b Merge "Make the test wait for Main Thread execution." into main 2024-11-07 11:33:19 +00:00
Sunny Goyal
7ab3c7f744 Updating IconCacheUpdateHandlerTest
also fixing cached shortcut info getting invalidated on every reboot

Bug: 373085333
Test: atest IconCacheUpdateHandlerTest
Flag: EXEMPT bugfix
Change-Id: I8cdfe9e2d4a5b0b35ea71da4b3c18ebc9327016c
2024-11-07 00:07:54 +00:00
Anushree Ganjam
3b87d5c97a Make the test wait for Main Thread execution.
Bug: 377444474
Test: Manual
Flag: TEST_ONLY

Change-Id: Ia560dd1cd658947af6b1c4e0b57f3e92faa1afce
2024-11-05 15:17:53 -08:00
Shamali Patwa
20cde49b4c Merge "Add a resource override for providing default widgets filter." into main 2024-11-05 01:01:00 +00:00
Shamali P
ea078cb647 Add a resource override for providing default widgets filter.
The implementation in this CL is no-op i.e. all widgets will be shown

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
2024-11-04 22:17:23 +00:00
Anushree Ganjam
2f73d60b30 Merge "Make VibratorWrapper injected by dagger (14/n)" into main 2024-11-04 21:36:19 +00:00
Anushree Ganjam
87ea411e97 Make VibratorWrapper injected by dagger (14/n)
Bug: 361850561
Test: Manual
Flag: NONE Dagger Integration
Change-Id: I57047122b35731d83674a5607e1ac980b86aebca
2024-11-04 11:33:34 -08:00
fbaron
ebc10c9ecc OneGrid Grid Option Updates
Bug: 330900048
Flag: com.android.launcher3.one_grid_specs
Test: n/a
Change-Id: I919195dbc7ac78c3be42f0f9d7620193a24d7e99
2024-10-30 11:38:09 -07:00
Toshiki Kikuchi
c6b29e374c Merge "Handle display windowing mode change in onConfigChanged" into main 2024-10-30 01:25:23 +00:00
Federico Baron
43cc25b64b Merge "Fix grid migration tests with grid migration refactor flag on" into main 2024-10-29 07:01:16 +00:00
fbaron
22029f6517 Fix grid migration tests with grid migration refactor flag on
Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationDBControllerTest, ValidGridMigrationUnitTest
Change-Id: I2dceb5f9756da7ee7e7ef2d5ec29b3550a51e965
2024-10-28 10:46:17 -07:00
Toshiki Kikuchi
b00c260669 Handle display windowing mode change in onConfigChanged
This CL allows onConfigChanged to handle the changes of
showLockedTaskbarOnHome().
The return value of showLockedTaskbarOnHome() depends on the display
windowing mode. And onConfigChanged() is triggered when the display
windowing mode changes (e.g. by adb shell wm set-display-windowing
mode).

Bug: 375321881
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: DisplayControllerTest
Test: manual
Change-Id: I1932f460735b9517cc68170c01cd45ca9bacfeb0
2024-10-28 08:47:26 +09:00
Anushree Ganjam
ba8c0a8fbd Merge "Make ApiWrapper to be injected by dagger (12/n)" into main 2024-10-25 19:27:50 +00:00
Anushree Ganjam
ef2c5c0e49 Make ApiWrapper to be injected by dagger (12/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I53ec78999085b3e0ad6df69e177806e0cb1b52d1
2024-10-24 12:14:40 -07:00
fbaron
a796d74e36 Refactor grid migration
In this CL:
-Make GridsizeMigrationLogic functions pure (no side effects)
-Make it so GridSizeMigrationLogic contains the migration logic and does NOT interact with the database
-Let GridSizeMigrationUtil receive the results from the logic layer and use those results to interact with the database appropriately

In future CLs:
-Refactor GridSizeMigrationLogic to Kotlin

Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationTest
Change-Id: Ifcc5ca356558a7463352580f2e89eef8c86ed16b
2024-10-23 22:26:38 +00:00
Shamali Patwa
2fc32dc2d8 Enforce system radius instead of separate value for widgets in launcher
The change is behind a flag. This is to get to the stage of having
consistent corner radius across rectangular widgets.

Bug: 373351337
Test: Unit test and manual
Flag: com.android.launcher3.enforce_system_radius_for_app_widgets
Change-Id: I23d8d3bb2561b4fc3f780fc4ddce62e8b9293192
2024-10-22 18:03:07 +00:00
Sunny Goyal
0b7f4cf1e2 Fixing deadlock in dagger singletons
Bug: 373557167
Flag: EXEMPT dagger
Test: atest DaggerSingletonDeadlockTest

Change-Id: I2304237bfd818c99b82bbfceea8a81ddb136b5a1
2024-10-21 18:09:37 +00:00
Sunny Goyal
4eaf3df1fe Merge "Moving PluginManager to dagger" into main 2024-10-17 21:47:28 +00:00
Sunny Goyal
9cd3154952 Moving PluginManager to dagger
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread

Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00
Treehugger Robot
642e84e397 Merge "Cleanup for TAPL Debugging" into main 2024-10-17 02:18:08 +00:00
Sukesh Ram
fc6cc4e409 Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 324419890
Test: Manual
Change-Id: I54145d07f0699f68c44aaa34e1692c8fe2f7b780
2024-10-16 16:55:45 -07:00
Brian Isganitis
fa6ca0fe6f Have external resource call init() explicitly.
Change-Id: Ibdd444478d0d171353a58c060022f5a181f9d1c4
Flag: TEST_ONLY
Test: go/testedequals
Bug: 230027385
2024-10-15 23:43:31 +00:00
Treehugger Robot
8915d3c3b8 Merge "[Dagger] Make CustomWidgetManager provided by DaggerSingletonObject" into main 2024-10-15 19:19:36 +00:00
Sihua Ma
58fc65dedf [Dagger] Make CustomWidgetManager provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE Dagger change
Change-Id: I9c2a9cc12aa2a409e8f9053a059426843f72deed
2024-10-14 22:35:59 +00:00
Brian Isganitis
a3ec98e06d Migrate to FakeLauncherPrefs for Taskbar unit tests.
Deprecates the preference rules.

Flag: TEST_ONLY
Test: go/testedequals
Bug: 230027385
Change-Id: Ic3a9e589b556232d196942d687e2e2bddc000877
2024-10-14 18:13:23 -04:00
Treehugger Robot
99f6d447ea Merge "Cleaning up temporary interfaces which were created for refactoring" into main 2024-10-11 23:02:52 +00:00
Sunny Goyal
43b01b9900 Cleaning up temporary interfaces which were created for refactoring
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ic2c69bcdde1429c787903c24f0e19ea26b91d314
2024-10-11 11:03:47 -07:00
Brian Isganitis
0e27df431a Merge changes from topic "launcher-prefs-abs" into main
* changes:
  Add FakeLauncherPrefs with basic tests.
  Split LauncherPrefs into abs class / impl.
2024-10-10 19:31:04 +00:00
Sunny Goyal
266f51b488 Converting LauncherModel to kotlin
> This will make it easier to migrate to dagger as it will
  increase the number of constructor parameters significantly

Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger migration
Change-Id: Id06246ec74c678d7614f4c6a798c5644b40a0545
2024-10-10 00:34:12 +00:00
Brian Isganitis
7f6ecaaa06 Add FakeLauncherPrefs with basic tests.
Flag: TEST_ONLY
Bug: 369504330
Test: go/testedequals
Change-Id: I1cc408451b1f6e316c0ec6b087989323bcd9da4d
2024-10-09 18:55:51 -04:00