Commit Graph

730 Commits

Author SHA1 Message Date
Anushree Ganjam
2a14b978c6 Remove the test aconfig lib.
zhidou@ from ACE team is working on AConfigFakelib which will be useful
to set fake flag values in both unit tests and UI automator tests.
Meanwhile, we will mock the flag values for unit tests and UI automator
tests will have all flags values defaulted to false.

testAConfigLib with "test:true" doesn't generate fake flags values and
forces us to set the flag values using "SetFlagsRule". "SetFlagsRule"
doesn't work with Out Of Proc tests and hence doesn't serve the purpose
for us. AConfigFakelib and FakeFlagTargetPreparer should use for Out Of
Proc tests.

testAConfigLib with "test:true" is suitable for java host tests where
there is no device involved. Launcher tests are instrumentation tests and tests run on actual
devices. So we can use the production version of the AConfig lib and device
config flag values will be fetched for UI Automator tests.

Also migrating "enable_twoline_allapps" to trunk stable. Unit tests is
using mockito to mock the flag value as false. The owner of
"enable_twoline_allapps" can mock the value to true in unit tests as
next step.

Bug: 294913042
Test: Local studio build and soong build
Flag: enable_twoline_allapps

Change-Id: Iea42bf18197832a9ecbddc1c3aaa8c9e36169131
2023-08-30 15:20:51 -07:00
Anushree Ganjam
29e1e61e07 Merge "Add Launcher aconfig." into main 2023-08-24 22:03:18 +00:00
Anushree Ganjam
d1a28fe08d Add Launcher aconfig.
Use `enable_expanding_pause_work_button` as an example.

See go/trunk-stable-launcher for implementation details

Bug: 294913042

Test: adb shell device_config put launcher com.google.android.platform.launcher.aconfig.flags.enable_expanding_pause_work_button true

Flag: enable_expanding_pause_work_button
Change-Id: I732722c8b219c023adf5bf31f132ce9da72fc4d5
2023-08-24 11:11:02 -07:00
Fengjiang Li
d18fcad565 Re-enable ALL_APPS_GONE_VISIBILITY and ENABLE_ALL_APPS_RV_PREINFLATION
Re-submit ag/24499161 with ag/24517009 to ensure tests are still passing

Flags: ENABLE_ALL_APPS_RV_PREINFLATION ALL_APPS_GONE_VISIBILITY
Test: Tested in bug bash
Bug: 288161355 291651514
Change-Id: I562d39f5edef46240700669b26d6e8fb27cbb77a
2023-08-22 18:20:52 -07:00
Fengjiang Li
053c11a344 Merge "Revert "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch"" into udc-qpr-dev 2023-08-22 18:49:10 +00:00
Fengjiang Li
df7cb761aa Revert "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch"
This reverts commit e302fb8cd9.

Reason for revert: WellbeingTests#testPauseAppFromAllApps is failing b/297040371

Change-Id: I92f885abff4bb1e3058eebcd23bf23875e5f84cf
2023-08-22 18:42:38 +00:00
Fengjiang Li
2474a8c1fb Merge "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch" into udc-qpr-dev 2023-08-22 15:09:20 +00:00
Treehugger Robot
a5f24d709e Merge "Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag" into udc-qpr-dev 2023-08-22 09:09:51 +00:00
Sunny Goyal
5442cbc300 Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag
Bug: b/270397209
Test: Presubmit
Flag: RECEIVE_UNFOLD_EVENTS_FROM_SYSUI
Change-Id: I4f87777fd27b5489557742b58e25dc5488b7d32b
2023-08-22 04:31:09 +00:00
Fengjiang Li
e302fb8cd9 Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch
Flags: ENABLE_ALL_APPS_RV_PREINFLATION ALL_APPS_GONE_VISIBILITY
Test: Tested in bug bash
Bug: 288161355 291651514
Change-Id: Iea486fcbe7099e823cac17d05d1b5a18d5258b2c
2023-08-21 10:55:54 -07:00
Treehugger Robot
37385af4b5 Merge "Turn off TWOLINE_TEXT_ALLAPPS" into udc-qpr-dev 2023-08-19 00:52:39 +00:00
Brandon Dayauon
cbcbcd82b3 Turn off TWOLINE_TEXT_ALLAPPS
Turning off twoline text for all_apps since we will revisit with UX to minimize grid size changes.
The ENABLE_TWOLINE_DEVICESEARCH is fine to be kept on.

bug: 270390937
test: manual-presubmit
Flag: flipping on -> off
Change-Id: I262f809d43b0781c1942bf7176869d6b74e77f1e
2023-08-18 16:22:50 -07:00
Treehugger Robot
7af0db7e94 Merge "Enable ENABLE_DYNAMIC_TASKBAR_THRESHOLDS." into udc-qpr-dev 2023-08-17 18:49:51 +00:00
Jon Miranda
0605413a30 Enable ENABLE_DYNAMIC_TASKBAR_THRESHOLDS.
Bug: 274467454
Test: manual, has been soaking in teamfood

Change-Id: I2729ed3c4f93ef5a4e8e1769802931e1c6b80708
2023-08-17 07:48:03 -07:00
Vinit Nayak
d07d83dd75 Merge "Revert "Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD"" into udc-qpr-dev 2023-08-17 05:04:53 +00:00
Vinit Nayak
e09f34628e Merge "Revert "Teamfood ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS"" into udc-qpr-dev 2023-08-17 05:04:53 +00:00
Vinit Nayak
e606ad44c0 Revert "Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD"
This reverts commit d49239be89.

Reason for revert: delaying to QPR2

Change-Id: I0b5cb044395c311470ad1fcd9b901ef2e787eb05
2023-08-16 17:28:10 +00:00
Tracy Zhou
c73f6f1a9e Revert "Teamfood ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS"
This reverts commit 0615a80f8b.

Reason for revert: Delaying the feature to QPR2

Bug: 270394122
Change-Id: Iefb3550959926ba3430062f8515b265ee8b29bc0
2023-08-16 17:20:27 +00:00
Andy Wickham
c928369894 Merge "Enable Toast launch animations flags by default" into udc-qpr-dev 2023-08-11 23:21:31 +00:00
Luca Zuccarini
c3c75c28b0 Enable Toast launch animations flags by default
Bug: 270394041
Bug: 270394392
Bug: 262778448
Bug: 293863913
Flag: ENABLE_SEARCH_RESULT_BACKGROUND_DRAWABLES
Flag: ENABLE_SEARCH_RESULT_LAUNCH_TRANSITION
Test: manual
Change-Id: I9019d76045e3f6d931c99c0fc14435b52d8671bf
2023-08-11 18:36:40 +00:00
Hyunyoung Song
1788bdad7f Merge "Turn ENABLE_LONG_PRESS_NAV_HANDLE flag to server side flag" into udc-qpr-dev 2023-08-10 18:49:26 +00:00
hyunyoungs
f40c799797 Turn ENABLE_LONG_PRESS_NAV_HANDLE flag to server side flag
Bug: 294920095
Test: adb shell device_config put launcher ENABLE_LONG_PRESS_NAV_HANDLE true
Change-Id: Ibc3ad2ade770934660161092e1ab5ef8d1a90eb5
2023-08-10 08:57:12 -07:00
Sebastián Franco
1f4d56c01e Revert "Remove flags ENABLE_TWO_PANEL_HOME FOLDABLE_WORKSPACE_REORDE and FOLDABLE_SINGLE_PAGE"
This reverts commit 76a1ceb5f2.

Reason for revert: Add flag back to turn it off for further testing

Bug: 270395274
Merged-In: I10b9e99734b14cbbe8d1190300493099a1f28a24
Change-Id: I10b9e99734b14cbbe8d1190300493099a1f28a24
2023-08-09 20:43:47 +00:00
mattsziklay
95c85034ea Allow split select transition from desktop mode.
Introduces a new controller to manage an app entering split select mode
from desktop mode.

Video: http://recall/-/gjymLwjdDT07aWqaK6101a/gU56zTDcWov6ukbKuH8tFx
Flag: ENABLE_SPLIT_FROM_DESKTOP_TO_WORKSPACE
Bug: 286550932
Bug: 279586624
Test: Manual

Change-Id: Ib94402553c88286894d94c95c38cac125be23a0d
2023-08-09 17:23:03 +00:00
Jon @
e3d6188343 Merge "Enable ENABLE_DYNAMIC_TASKBAR_THRESHOLDS for teamfood." into udc-qpr-dev 2023-08-07 19:30:52 +00:00
Tracy Zhou
c73ce34730 Merge "Teamfood ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS" into udc-qpr-dev 2023-08-07 18:29:58 +00:00
Jon Miranda
fef90aa57f Enable ENABLE_DYNAMIC_TASKBAR_THRESHOLDS for teamfood.
Bug: 274467454
Test: manual
Change-Id: I5fe1e2ce2e4edaac1c6c4d2a1eda0ef99257e88a
2023-08-07 11:01:50 -07:00
Treehugger Robot
93e088dc1c Merge changes Ifa66cfb7,Ied7867fb into udc-qpr-dev
* changes:
  Add dynamic thresholds for taskbar based on screen size.
  Add ENABLE_DYNAMIC_TASKBAR_THRESHOLDS feature flag.
2023-08-07 16:27:36 +00:00
Jon Miranda
f762e17fa3 Add ENABLE_DYNAMIC_TASKBAR_THRESHOLDS feature flag.
Bug: 294252473
Bug: 274467454
Test: N/A
Change-Id: Ied7867fbae602303c699afc3da7f88eef7aeb728
2023-08-04 11:43:27 -07:00
Fengjiang Li
2f2306c14b Turn off ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY
Test: Tested in ag/24107285
Bug: 264341825
Change-Id: Iafdad8f2aabe4296befc00800dc9a1fdfd58dc6f
2023-08-04 10:29:03 -07:00
Fengjiang Li
98c91a65cf Revert "Revert "Make AllAppsRecyclerViewContainer GONE when hidden""
This reverts commit a163646c7a.

Reason for revert: Re-submit with ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY turned off in child CL (submit together)

Test: Tested in ag/24107285
Change-Id: Ia85c1e8447c45ff44814ad4bfe0f178a72d0e7d3
2023-08-04 10:28:36 -07:00
Inseob Kim
40a44e08b9 Merge "Revert "Make AllAppsRecyclerViewContainer GONE when hidden"" into udc-qpr-dev 2023-08-04 04:13:28 +00:00
Inseob Kim
a163646c7a Revert "Make AllAppsRecyclerViewContainer GONE when hidden"
This reverts commit df59c2e535.

Reason for revert: b/293944420

Change-Id: I0ae830e1a5ba8affb6815c9e96ffee1b20c6e8d0
2023-08-04 02:18:44 +00:00
Fengjiang Li
068df4c1ca Merge "Make AllAppsRecyclerViewContainer GONE when hidden" into udc-qpr-dev 2023-07-31 20:27:21 +00:00
Luca Zuccarini
36e7df0d47 Merge "Update default value for container launch animations to TEAMFOOD." into udc-qpr-dev 2023-07-31 19:21:03 +00:00
Fengjiang Li
df59c2e535 Make AllAppsRecyclerViewContainer GONE when hidden
Test: N/A
Flags: ALL_APPS_GONE_VISIBILITY
Bug: 264341825
Change-Id: I28933c08e80b95bcd5031da9869b37f34f6408b2
2023-07-31 10:41:58 -07:00
Brandon Dayauon
d6c00c7114 Merge "enable flags: ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH" into udc-qpr-dev 2023-07-26 22:51:55 +00:00
Brandon Dayauon
19a380095e enable flags: ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH
PM said we can enable ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH flags.

bug:287307252
Flag: turning to true
test: presubmit (updated tests in previous CL ag/23835677)

Change-Id: I89ede9807205a72108f25ca3b962f8d67384f7ae
2023-07-24 07:38:38 -07:00
Tracy Zhou
0615a80f8b Teamfood ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS
Bug: 270394122
Test: Make sure the feature works
Change-Id: I9dc239d941484f70879550f877674b889f1bf45e
2023-07-21 11:09:19 -07:00
Luca Zuccarini
86e18b59a9 Update default value for container launch animations to TEAMFOOD.
Also move flag checking outside ItemInfo.

Bug: 262778448
Flag: ENABLE_SEARCH_RESULT_BACKGROUND_DRAWABLES
Flag: ENABLE_SEARCH_RESULT_LAUNCH_TRANSITION
Test: manual
Change-Id: I49de8a93539829e41c1de1fb23630c1b2ca8b646
2023-07-21 13:14:24 +00:00
Vinit Nayak
d49239be89 Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD
Bug: 276361926
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Change-Id: I55c8e8293eeadeca623ae879ca62d8d7c405f486
2023-07-20 16:32:51 -07:00
Vinit Nayak
1db3292029 Clean up SplitData refactor flag
Bug: 279494325
Test: Invoking split works from home, overview.
Opening split to fullscreen also works

Change-Id: Ie1f26f833d5c10bb114b9e8eb1bd9f3b6b913b3d
2023-07-14 10:54:59 -07:00
Vinit Nayak
f909a72f3f Merge "Cleanup ENABLE_SPLIT_FROM_WORKSPACE flag" into udc-qpr-dev 2023-07-12 20:57:22 +00:00
Vinit Nayak
46b2beea26 Cleanup ENABLE_SPLIT_FROM_WORKSPACE flag
Fixes: 270393906
Flag: none
Test: Compiles
Change-Id: I1431f544b26cef5cd417c9a5a97f183b49fe7adc
2023-07-11 17:05:17 -07:00
Sebastian Franco
7ba948967c Adding flag for use of ParametrizeReorderAlgorithm
Also, some cleaning of the comments.

Bug: 289420844
Test: compiling
Change-Id: I5dfb4b252755550059c3ee050bc491f5449bec97
2023-07-10 20:32:18 +00:00
Fengjiang Li
1e3d799fe3 Merge changes from topic "preinflate-allapps-rv" into udc-qpr-dev
* changes:
  Pre-inflate BubbleTextViews into Launcher/TaskBar All Apps RV
  Fix calculation of all apps recyclerview pool size of app icons
2023-07-05 22:44:55 +00:00
Fengjiang Li
1519c168da Pre-inflate BubbleTextViews into Launcher/TaskBar All Apps RV
This CL ensures no inflation of BubbleTextView happens while binding applications, and reduces jank on slow device.

1. Let active/inactive all apps RVs share the same AllAppsRecyclerViewPool
2. Use worker thread to pre-inflate BubbleTextViews and add them to shared view pool on main thread

Bug: 287523421
Test: See before/after screenshot/video/trace attached in bug
Change-Id: I00213407be2c7c2d329997552785d0aa56c4d057
2023-07-05 13:07:26 -07:00
Jeremy Sim
d2255f2b79 Remove flag ENABLE_LAUNCH_FROM_STAGED_APP
This patch makes it so that the "launch from staged app" feature, which has been enabled since TQPR3, has its flag removed.

Fixes: 270395567
Test: None
Change-Id: I46878475c0dac5a3d64938ec9dfa5ca4123c7bb4
2023-06-28 22:45:32 +00:00
Holly Jiuyu Sun
d9e0a2836a Merge "[Play] Enable play flag by default on client side for udc-d1-dev." into udc-d1-dev am: a78a22e0c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23680192

Change-Id: Ic5d58714e15ba6926c1c07b25f98c7812fa2c02a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-17 06:05:31 +00:00
Sebastián Franco
29a13676f4 Merge "Remove flags ENABLE_TWO_PANEL_HOME FOLDABLE_WORKSPACE_REORDE and FOLDABLE_SINGLE_PAGE" into udc-qpr-dev 2023-06-13 23:08:40 +00:00