Commit Graph

14746 Commits

Author SHA1 Message Date
Luca Zuccarini
2449a01b22 Add a view type check to ensure the right animation is used.
Bug: 265134143
Test: recorded perfetto trace, see bug
Change-Id: If6abc36f0f43c6bb632fc824c19717c1231b32dc
2023-05-19 09:51:15 +00:00
TreeHugger Robot
b9f04842b5 Merge "Add a no recent tasks message to the keyboard quick switch view" into udc-dev 2023-05-16 06:49:52 +00:00
Schneider Victor-tulias
4ee471fecf Merge "Update keyboard quick switch view ordering and add icons" into udc-dev 2023-05-16 05:12:47 +00:00
Treehugger Robot
56f539538f Merge "Don't treat Recents as transient for all apps from overview." into udc-dev 2023-05-16 01:28:49 +00:00
Schneider Victor-tulias
b29355c192 Add a no recent tasks message to the keyboard quick switch view
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 280652620
Test: launched the keyboard quick switch with 0, <=6 and >6 tasks launched
Change-Id: I560707645b83b79ba2203460e62e4c540f5da421
2023-05-15 16:49:45 -07:00
Schneider Victor-tulias
f0233c53d3 Merge "Code cleanup: recycle typed arrays when they are no longer needed" into udc-dev 2023-05-15 23:48:11 +00:00
TreeHugger Robot
f0c96721ba Merge "Add handling for toggling keyboard stashing from the keyboard" into udc-dev 2023-05-15 22:57:14 +00:00
TreeHugger Robot
15bc0d388a Merge "Adding support for listening to end callbacks when launching an intent from Launcher" into udc-dev 2023-05-15 22:20:32 +00:00
Stefan Andonian
e3b06996c3 Merge "Added ViewCapture to all tests which implement AbstractLauncherUiTest." into udc-dev 2023-05-15 22:06:37 +00:00
Tony Wickham
4f69ca52ef Merge "Remove unused/obsolete feature flags" into udc-dev 2023-05-15 21:46:15 +00:00
Tracy Zhou
3711aa64ac Merge "[Reland] Fix touch focus not updated correctly after launching overview with live tile." into udc-dev 2023-05-15 19:45:46 +00:00
Schneider Victor-tulias
b6407699ae Update keyboard quick switch view ordering and add icons
- Updated the keyboard quick switch view ordering to left-to-right (vice versa in RTL)
- Added app icons to keyboard quick switch taskviews

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 275629107
Test: launched keyboard quick switch view and changed focus back and forth
Change-Id: Ie2f0a1c08c7065c53075f6fa015000a2d6184491
2023-05-15 12:06:19 -07:00
Schneider Victor-tulias
eb8dce01ce Add handling for toggling keyboard stashing from the keyboard
Flag: ENABLE_KEYBOARD_TASKBAR_TOGGLE
Bug: 281726846
Fixes: 246660615
Test: toggled the transient taskbar with the meta+t input
Change-Id: I315f83850b11d24d8b55061d7111300effb43936
2023-05-15 18:41:25 +00:00
Schneider Victor-tulias
581fd3eede Code cleanup: recycle typed arrays when they are no longer needed
The border animator does not need the typed array anymore after initialization. recycling the object.

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 282202504
Test: changed focus in quick switch view and overview
Change-Id: Iea9077e49e754894008899dfc9b90e3876b53051
2023-05-15 11:38:17 -07:00
Treehugger Robot
11939898f3 Merge "Update app ring color and alpha" into udc-dev 2023-05-15 17:33:23 +00:00
Sunny Goyal
4fdc9181dd Adding support for listening to end callbacks when launching an intent from Launcher
Also moving various state handling to these end callbacks enstead of relying on resume

Bug: 265134143
Test: Verified that the end callback is received
Change-Id: I326a99c80154d244c0e49f678717c476602b6240
2023-05-15 10:31:06 -07:00
Treehugger Robot
ba4fcb0171 Merge "Fix bug where unstash animation plays twice." into udc-dev 2023-05-13 01:47:20 +00:00
Jeremy Sim
ab9e66c260 Merge "Allows splitscreen with work & personal version of the same app" into udc-dev 2023-05-13 00:23:23 +00:00
Jon Miranda
e30a551f93 Fix bug where unstash animation plays twice.
Fixes: 282056846
Change-Id: I372444684fafd246369f6bc1e77c5e6fbb651c6f
Flag: ENABLE_TRANSIENT_TASKBAR
Test: open app, then very quickly swipe to unstash taskbar
2023-05-12 16:27:57 -07:00
Schneider Victor-tulias
8f23be7b6f Merge "Fix the overview tutorial step success animation" into udc-dev 2023-05-12 22:40:14 +00:00
Jeremy Sim
d27b06f500 Merge "Force Taskbar to remain stashed when in 3p launcher or recents" into udc-dev 2023-05-12 22:08:51 +00:00
Saumya Prakash
24aec5e6b0 Merge "Fix UI issues of fake task view in gesture nav tutorial." into udc-dev 2023-05-12 21:41:38 +00:00
Stefan Andonian
fa8091661a Added ViewCapture to all tests which implement AbstractLauncherUiTest.
This enables developers to watch failed tests in classes like
TaplTestsQuickstep in the go/web-hv tool.

Bug: 242867462
Test: Failed a test and verified that the TimeLapse bugreport entry
showed up properly in the go/web-hv tool.

Change-Id: Ic89af2a0e7102db52c52ddc668607a81c4809ed6
2023-05-12 21:15:14 +00:00
Tony Wickham
53c811fd7d Remove unused/obsolete feature flags
Flag: N/A
Test: N/A
Fixes: 270391641
Fixes: 270395077
Change-Id: I91834b43bf043a26c2fe8e5f7b2e720592830918
2023-05-12 21:09:30 +00:00
Treehugger Robot
87abc0644b Merge "Cleanup SettingsChangeLogger onClose()" into udc-dev 2023-05-12 17:39:19 +00:00
Schneider Victor-tulias
a8ccd542bc Fix the overview tutorial step success animation
- Tapping the screen after a successful overview gesture, but before the delayed success feedbck created a janky experience
- Immediately setting the gesture as successful

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281742006
Test: tapped the screen quickly after successfully completing the overview gesture
Change-Id: I166060191753d6b95bc223e2be08df2bb4b4ecfd
2023-05-12 10:24:39 -07:00
Brandon Dayauon
125e121834 Merge "Separate animations and add dragOffSet points in dragOptions" into udc-dev 2023-05-12 15:22:48 +00:00
Jeremy Sim
f4835a8884 Force Taskbar to remain stashed when in 3p launcher or recents
This patch makes it so that the transient Taskbar cannot unstash when in 3P launcher.

Previously, the user was able to unstash Taskbar when in 3P launcher, causing a janky-looking UI (3P launchers may implement their own version of Taskbar on the home screen. This also caused problems with certain Taskbar commands like split screen, which provide an entry portal to Pixel-specific implementations.

Fixed by forcing the Taskbar to stay stashed when a 3P Launcher is displayed. The Taskbar is still usable inside of other non-launcher apps. This was done by using TopTaskTracker to check for ACTIVITY_TYPE_HOME or ACTIVITY_TYPE_RECENTS, and disabling Taskbar when these activities are running.

Fixes: 277963491
Test: Manual
Change-Id: Ifc0f3c07e3b76eb610f93205978fbc596bab6253
2023-05-12 00:32:24 -07:00
Jeremy Sim
92e1eeb5f0 Allows splitscreen with work & personal version of the same app
This patch makes changes in various splitscreen controllers to pass userId to the new shell API, to allow same-app splitting with different users.

Fixes: 274973415
Test: Manual
Change-Id: I810b5353aad738c7c275856586b9c521f1554022
2023-05-11 22:10:51 -07:00
Jerry Chang
303d6101fb Merge "Fix not tracking splitting tasks correctly" into udc-dev 2023-05-12 00:49:21 +00:00
Vinit Nayak
f68f1fa3cc Cleanup SettingsChangeLogger onClose()
* Correct name for San*d*box

Bug: 280463854
Flag: none
Test: v2/gnl-eng/unbundled/launcher/nexus_unit_test_multi_device_platform
Change-Id: I2446871c8ea0b146ccfa2ea7caa1727aec42dd42
2023-05-11 16:32:27 -07:00
Winson Chung
e04071e19c Merge "Only refresh the launcher resume state when the task launch fails" into udc-dev 2023-05-11 23:31:21 +00:00
Winson Chung
de1b42b957 Only refresh the launcher resume state when the task launch fails
- The previous call from TaskbarLauncherStateController caused a
  regression due to the inability for the code to distinguish
  Normal -> Background -> Normal when tapping on the bar area
  or from failing to launch a task, so both cases were triggering
  the resumed state to cycle and start an animation.  For now we can
  only handle the task-launch fail case.

Bug: 268448123
Fixes: 281966662
Test: Quickswitch to an activity that finishes when resumed
Change-Id: Ie4692dd85252540ff47633978c0e6e4adbb1bdd0
2023-05-11 23:31:14 +00:00
Tony Wickham
8d402efac2 Merge "Consistently multiply touch slop for InputConsumers" into udc-dev 2023-05-11 23:21:33 +00:00
fbaron
55c10be912 Update app ring color and alpha
Bug: 268521231
Test: Verify that app ring colors match the figma attached in the bug
Flag: no flag
Change-Id: I2270f6e5e3ad2c653aad36feb2232a672bdf2a79
2023-05-11 15:45:52 -07:00
Treehugger Robot
52d4764576 Merge "Revert "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash"" into udc-dev 2023-05-11 20:58:02 +00:00
Mady Mellor
662787540c Revert "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash"
This reverts commit 7344766886.

Reason for revert: b/282035015

Change-Id: I38db287f730048d3e1e5041f1853bdae214e1a66
2023-05-11 18:50:35 +00:00
Brandon Dayauon
e63401e711 Separate animations and add dragOffSet points in dragOptions
For 1, when animateShift() is called shiftAnimation() is the only thing needed.
2, by having point saved in preDragCondition, we can use that to update the drag layers and not have to
modify registrationX/Y later

Removed dragVisualizedOffset since it does not do anything.

There is an issue that also needs to be fixed if user decides to long click
on a search result and let go, the icon flashes at the touch point when you let go.. so we check when mContent can be shown in DragView
depending on if there is dragOffset.
If there is dragOffset, set mContent to invisible.
If there is no dragOffset, set mContent to visible because it doesn't matter as the original content is at the same spot.

bug: 245659929
test: manual: video: https://drive.google.com/file/d/1JQ0pud31HU0WlrqecX0v1cdPKQ37jQCf/view?usp=sharing
Change-Id: I4d2276b9c43e1e92c45d8538b8dde70baa84a5e8
2023-05-11 10:50:17 -07:00
Saumya Prakash
5c5472ff96 Fix UI issues of fake task view in gesture nav tutorial.
This change fixes the bug where the view for the fake task in the overview gesture was not being reset correctly. This was leading to UI issues such as lack of rounded corners and incorrect animations in the gesture navigation tutorial.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 281121451
Fix: 281121699
Fix: 281785378
Test: Manually went through the tutorial on handheld, foldable, and
tablet devices

Change-Id: I424a471013d2b8667724f790618d142ba7ae9a7b
2023-05-11 17:41:18 +00:00
Thales Lima
fda9f3d430 Merge "Make taskbar touchable region smaller in Overview" into udc-dev 2023-05-11 14:48:18 +00:00
Thales Lima
3bc763f5a3 Make taskbar touchable region smaller in Overview
While in overview, makes the touchable region smaller so touches can go to the window below and trigger tapping on overview to go home.

Bug: 269985301
Test: Manual (TAPL in a following CL)
Flag: none
Change-Id: Ie8c7719090c387f951d78cf0fc47e6d9ed192f27
2023-05-11 14:45:41 +00:00
Jerry Chang
87ed2f1176 Fix not tracking splitting tasks correctly
When drag-to-repace one of the splitting tasks, it might reports to
TopTaskTracker the original task changed to undefined after repoting the
new task appeared in a split pair. Result to clear the split tasks
record unexpectedly in TopTaskTracker. This makes sure to clear the
correct stage and prevent override the correct split record.

Fix: 277982233
Test: manual check the behavior and verify the reocrd in TopTaskTracker
Change-Id: Ifce2efdde6d99508f1afa844b3ad424071e13a8f
2023-05-11 08:53:23 +00:00
Jerry Chang
2792271688 Defer intercepting touch events to actually start shifting tasks
Fix: 278740578
Test: http://recall/-/fLARJNt42LVxc3tt86SneW/d9A443iE2UQVktVc2YqwT2
Change-Id: I81efc87f19775dba96bab581a1c443d6070f6ebc
2023-05-11 05:44:16 +00:00
Tracy Zhou
690d897c88 [Reland] Fix touch focus not updated correctly after launching overview with live tile.
- Set touch mode to false at the first dpad left or right key event, since the framework doesn't do so in the live tile case
- Clear focus at any motion event

Similar to ag/19938037

Fixes: 277625965
Test: Meta+Tab to launch overview from app, or swipe from app, then use DPAD_LEFT and DPAD_RIGHT to go through overview. Make sure the selected task is highlighted. Also make sure swipe up to overview and go home doesn't highlight any icons on the home screen
Change-Id: I7afa46af7eb1cd826d2dc893583685936721868a
2023-05-11 05:30:39 +00:00
Tony Wickham
233ab99093 Consistently multiply touch slop for InputConsumers
Fixes: 268651129
Test: TaplTestsQuickstep; manually swipe up from various InputConsumers
Change-Id: I0a3baf654092a1a0bdafbfc734ec394668ba60f6
2023-05-11 03:33:57 +00:00
Jagrut Desai
4d559a6c92 Merge "Fixing TaplTests" into udc-dev 2023-05-10 23:19:39 +00:00
Mady Mellor
3291bfecf2 Merge "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash" into udc-dev 2023-05-10 23:11:42 +00:00
Treehugger Robot
360b5a301a Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-10 21:55:16 +00:00
Treehugger Robot
f3fdca59d2 Merge "Revert "Fix null-pointers in SurfaceTransactionApplier constructor."" into udc-dev 2023-05-10 21:40:40 +00:00
Sunny Goyal
64809780ce Revert "Fix null-pointers in SurfaceTransactionApplier constructor."
This reverts commit d86c5657e0.

Reason for revert: b/281294745

Change-Id: Ib2680b60346a9bc5932057707d0ef105441f324d
2023-05-10 19:34:01 +00:00