Commit Graph

57 Commits

Author SHA1 Message Date
Sebastián Franco
e1d31e5406 Revert "Revert "Moving DeviceProfile properties into DevicePrope..."
Revert submission 33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Reason for revert: Error is fixed

Reverted changes: /q/submissionid:33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Change-Id: Ib86824134955903c11e51e52dbfd6368aba1cd50
2025-05-23 14:08:11 -07:00
Priyanka Advani (xWF)
7705e92d93 Revert "Moving DeviceProfile properties into DeviceProperties da..."
Revert submission 33672643-DataDeviceProfile1

Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.

Fix: 419867875

Reverted changes: /q/submissionid:33672643-DataDeviceProfile1

Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
2025-05-23 13:53:04 -07:00
Sebastian Franco
e1111e28c2 Moving DeviceProfile properties into DeviceProperties data class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I638f88cd76b926917965dbf9e70b5bdfff5971e0
2025-05-23 10:42:26 -07:00
Shamali P
4cb6ff3838 Pass device profile as constructor arg to DatabaseWidgetPreviewLoader
This is so, we can use it with compose, and let caller pass the needed
dependencies. May also convert to dagger in
 followup

Bug: 408283627
Flag: EXEMPT BUGFIX
Test: N/A
Change-Id: I9b04011ec2592df3bd02bd74ec4889eb05928e7f
2025-05-16 11:47:18 -07:00
Coco Duan
cc55afe1fd Show all default widgets in glanceable hub widget picker
Update the predicate condition to correctly use the host's specified
filter for default widgets.

Fixes: b/415899961
Test: verify in hub widget picker on tablet
Test: atest WidgetPickerDataProviderTest
Flag: EXEMPT bugfix
Change-Id: I5a68d49dfda08059de880bca6964ac1620ffff36
2025-05-09 07:18:36 +00:00
Shamali P
472709d9ca Delete the filter code as it will be provided differently in refactor
With the dagger update the initialization happens in constructor which
we would avoid once we work on refactor and move it into a repository
class. The list will also be fetched from a different data source, so,
makes sense to delete it at the moment.

Bug: 406324964
Flag: EXEMPT BUGFIX
Test: Not applicable as code is removed
Change-Id: Iab8bb1e94677abf9b5b882f4d3485b002faf3e0f
2025-03-27 14:15:05 -07:00
Sunny Goyal
3b307455a0 Revert^2 "Simplifying model testing rules"
35b6d322ab

Change-Id: I3ed574a517dbe350b6dfe5b1d3ed198203d22f44
2025-03-26 23:08:55 -07:00
Priyanka Advani (xWF)
35b6d322ab Revert "Simplifying model testing rules"
Revert submission 32704934-model-test-cleanup

Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:32704934-model-test-cleanup

Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
2025-03-26 16:12:16 -07:00
Sunny Goyal
cb84230913 Simplifying model testing rules
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions

Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit

Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
2025-03-26 11:34:15 -07:00
Sunny Goyal
66916cda10 Moving LauncherAppWidgetHolder to dagger
This would allow customizing the widget holder in LauncherPreview

Bug: 361850561
Test: Updated tests and presubmit
Flag: EXEMPT dagger
Change-Id: I32491169188992453693048986c57cb780fdf1d8
2025-03-14 14:19:29 -07:00
Sunny Goyal
5025b9ab04 Moving widgetFilter to dagger
Moving widget filtering to UI layer as it changes with surface

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
2025-03-03 10:27:14 -08:00
Owner Cleanup Bot
c383866630 Merge "[owners] Remove zakcohen@google.com from tests/multivalentTests/src/com/android/launcher3/widget/picker/OWNERS" into main am: bbda0821a6 am: c8abc144b7
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3490671

Change-Id: I9a0698da781bae7365ed46bc52fee13f46aaba2f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-25 15:37:31 -08:00
Owner Cleanup Bot
41ed20667e [owners] Remove zakcohen@google.com from tests/multivalentTests/src/com/android/launcher3/widget/picker/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote the lowest CR value
(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to
approve this change. You may also abandon this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/zakcohen@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I72cb2c5e66ee297e9ff09257969d3d8934aad373
2025-02-11 16:02:59 -08:00
Sunny Goyal
5bca45a739 Moving InvariantDeviceProfile to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Ia99ee031e96c5e6069a56fe90a262a533dd8665a
2025-02-11 15:22:18 -08:00
Shamali Patwa
d60bb5a2f2 Merge "[HSUM] Update createTestWidgetItem to use current user for test widget" into main 2024-12-10 19:42:42 +00:00
Shamali P
2536bcae0c [HSUM] Update createTestWidgetItem to use current user for test widget
Bug: 383087777
Fix: 383087777
Test: Unit test and ABTD for HSUM
Flag: EXEMPT BUGFIX
Change-Id: I3d7ac21628b8ddc16ed09853523a45cde858adb6
2024-12-10 03:59:28 +00:00
Sunny Goyal
ee15f52a7c Loading generated preview on-demand instead of keeping everything in memory
Bug: 369906121
Test: atest GeneratedPreviewTest
Flag: EXEMPT bugfix
Change-Id: Idd7610e8a5c577d2c7b0a1d7d2a1f1efde40b11f
2024-12-06 22:25:40 +00:00
Shamali Patwa
f05d59cdad Merge "Update the enforce_system_radius_for_app_widgets flag's type" into main 2024-11-19 00:03:34 +00:00
Shamali Patwa
d2cc1f0577 Update the enforce_system_radius_for_app_widgets flag's type
Renamed to use_system_radius_for_app_widgets since metadata cannot be updated after submitting definition.

Bug: 373351337
Test: N/A flag metadata update
Change-Id: I25283b05341517f5984b0f2fc0d27efe8027a3de
Flag: com.android.launcher3.use_system_radius_for_app_widgets
2024-11-18 21:58:48 +00:00
Uwais Ashraf
970d19327d Close repeatedly unclosed resources at the end of tests
Fix: 379432671
Test: edited tests, presubmits passing
Flag: EXEMPT test only change
Change-Id: I45c46d7a56a30af4a11dff54b5bcc8a1e9bcda5f
2024-11-18 21:39:59 +00:00
Shamali Patwa
2fc32dc2d8 Enforce system radius instead of separate value for widgets in launcher
The change is behind a flag. This is to get to the stage of having
consistent corner radius across rectangular widgets.

Bug: 373351337
Test: Unit test and manual
Flag: com.android.launcher3.enforce_system_radius_for_app_widgets
Change-Id: I23d8d3bb2561b4fc3f780fc4ddce62e8b9293192
2024-10-22 18:03:07 +00:00
Sunny Goyal
9cd3154952 Moving PluginManager to dagger
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread

Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00
Treehugger Robot
8915d3c3b8 Merge "[Dagger] Make CustomWidgetManager provided by DaggerSingletonObject" into main 2024-10-15 19:19:36 +00:00
Sihua Ma
58fc65dedf [Dagger] Make CustomWidgetManager provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE Dagger change
Change-Id: I9c2a9cc12aa2a409e8f9053a059426843f72deed
2024-10-14 22:35:59 +00:00
Sunny Goyal
43b01b9900 Cleaning up temporary interfaces which were created for refactoring
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ic2c69bcdde1429c787903c24f0e19ea26b91d314
2024-10-11 11:03:47 -07:00
Sunny Goyal
b619d2c297 Removing dependency on PackageInfo in IconCache
Bug: 363324203
Flag: EXEMPT bugfix
Test: atest IconCacheTest
      atest IconCacheUpdateHandler

Change-Id: I85005ef1069960a17a0f3e7265749a8ef3004172
2024-10-08 04:09:54 +00:00
Sunny Goyal
f7c32a29fd Requesting ApplicationInfo in cached object
Bug: 363324203
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I92f3d3ed8c267b895dc439ba1f01eb67d7f63965
2024-09-27 14:04:16 -07:00
Sunny Goyal
28d6bbd6b4 Moving various application into related methods to a separate class
> This avoids duplicate RPCs when trying to get multiple properties
  from AppInfo
> This would be used in a followup cl when AppInfo is added to caching
  logic in IconCache

Bug: 366237794
Test: atest ApplicationInfoWrapperTest
Flag: EXEMPT refactor
Change-Id: I55b964d4f8cfa1ff1770e310ac278719495e285d
2024-09-23 22:09:24 -07:00
Shamali P
c7e1b5c975 Update the scale on corner radii on scaled image drawable.
The RoundedDrawableWrapper applies rounded corners on each draw, so,
on scaling, the corners look odd for small widgets.

This change, applies the same scale to corner radius as well.
There are some widgets whose preview images have embedded transparency,
but we don't do much for such previews.

Bug: 359860747
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I5e58e29765503454f286d99050b13b497531d306
2024-08-15 02:54:17 +00:00
Sihua Ma
7eaf24840d Merge "Add unit test for LauncherAppWidgetHost" into main 2024-08-01 20:26:40 +00:00
Shamali P
9e7d288f67 Create a separate class for widget related methods from popup provider
Child cl removes those methods from popup provider and updates its
references

Bug: 353347512
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: Id559e8c8d32a40adab961e7c710ec835d5a92184
2024-07-22 23:58:04 +00:00
Sihua Ma
f2abd671d1 Merge "Add unit test for RoundedCornerEnforcement" into main 2024-07-19 17:13:08 +00:00
Shamali Patwa
6babde40e3 Merge "Move out picker related methods from widgets model" into main 2024-07-19 15:46:00 +00:00
Sihua Ma
045165a4ba Add unit test for LauncherAppWidgetHost
Number of methods covered: 3

Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I8fa9ed7b496baa18dac1a721c72a32814d89dd6f
2024-07-19 00:38:32 +00:00
Sihua Ma
cda4805e62 Add unit test for RoundedCornerEnforcement
Number of methods covered: 4

Test: atest NexusLauncherRoboTests:RoundedCornerEnforcementTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I488ce4a6617b96d4937a7030cd25831bcefadca1
2024-07-18 23:57:09 +00:00
Shamali P
54bd36ef81 Move out picker related methods from widgets model
* The WidgetsBaseEntry and related types are specific to picker UI.
So, moved them to a entry builder class.

Bug: 353347512
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: I42b3083b42ee03dc8d548e7464689ea270a36f22
2024-07-18 18:35:19 +00:00
Sihua Ma
e2dde4e468 Merge "Add unit test for CustomAppWidgetProviderInfo" into main 2024-07-18 15:47:32 +00:00
Sihua Ma
b648a0f386 Merge "Add unit test for CustomWidgetManager" into main 2024-07-18 15:47:15 +00:00
Sihua Ma
1f3f951b70 Add unit test for CustomAppWidgetProviderInfo
Number of methods covered: 2

Test: atest NexusLauncherRoboTests:CustomAppWidgetProviderInfoTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I4235569878a9f1c1b2ec040b26190f97d9734679
2024-07-17 23:38:33 +00:00
Shamali P
6211e86009 Consider the widget option menu choice in search results
Makes the search related code separate from popup provider.

Bug: 347288851
Flag: EXEMPT flag in sysui
Test: Unit tests
Change-Id: I4534d5f70876ec0cf4e2d78030864f78a8bfabb9
2024-07-17 22:56:58 +00:00
Sihua Ma
71a48d9ac5 Add unit test for CustomWidgetManager
Number of methods covered: 5

Test: atest NexusLauncherRoboTests:CustomWidgetManagerTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I69c9567391d3a874c7b2abcd473887194ec2dcfc
2024-07-17 22:21:40 +00:00
Treehugger Robot
52f7fc5ef6 Merge "Unit tests for ListenableHostView" into main 2024-07-17 01:17:57 +00:00
Stefan Andonian
3e28e9c829 Merge "[Test Week] Unit test for WidgetAddFlowHandlerTest." into main 2024-07-16 23:25:57 +00:00
Stefan Andonian
2e1bb929ba Unit tests for ListenableHostView
3 public methods.

Bug: 353303621
Test: unit test CL.
Flag: EXEMPT unit test
Change-Id: If5e3b4f8e6f2fa2c2e44907a1a8080215f231ca2
2024-07-16 21:03:56 +00:00
Stefan Andonian
35b584d0ef [Test Week] Unit test for WidgetAddFlowHandlerTest.
8 public methods covered.

Bug: 353303621
Test: Unit Test
Flag: EXEMPT unit test
Change-Id: I5dd20de33b64de561ee8845beaa513b4e08c3a31
2024-07-16 20:58:39 +00:00
Stefan Andonian
19c5f7ae71 [Test Week] Unit test for WidgetManagerHelperTest.
6 public methods covered.

Bug: 353303621
Test: Unit Test
Flag: EXEMPT unit test
Change-Id: I549d97f5b57f0e6e9af44bd1695d94ebfa0538f2
2024-07-16 20:58:11 +00:00
Sihua Ma
7098ba260f Add test for LauncherWidgetHolder
Number of new tested methods: 8

Test: atest NexusLauncherRoboTests:LauncherWidgetHolderTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I8751c8de8d719e567775368d988794b2d7abc37e
2024-07-15 22:51:04 +00:00
Willie Koomson
caf7065ef4 Cleanup obsolete generated preview tests
Remove tests that no longer run because the flag is always enabled.

Bug: 343764554
Bug: 336821272
Test: N/A
Flag: android.appwidget.flags.generated_previews
Change-Id: I106579771c2301cdac2ff1a17008c9faa1a1b0e3
2024-06-26 19:12:43 +00:00
Sihua Ma
de5ef62967 Migrate GeneratedPreviewTest to multivalent
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Fix: 325088369
Flag: TEST_ONLY
Change-Id: I2c88a357c8ac5fb0171a70e850be25e8fb11de33
2024-06-10 16:49:47 +00:00
Shamali Patwa
8e7613e4c7 Fix test failure in post submit
Bug: 343937933
Change-Id: Ie989e4ce4f098a225873d13de9c6913933e5628e
Test: Unit test fix
Flag: None test fix
2024-05-31 21:59:41 +00:00