Commit Graph

9149 Commits

Author SHA1 Message Date
Schneider Victor-tulias
b4e91b14bd Merge "Update gesture nav edu motion and colors" into udc-dev 2023-05-26 16:12:06 +00:00
Schneider Victor-tulias
010a55d377 Merge "Fix keyboard quick switch d-pad left/right traversal direction" into udc-dev 2023-05-26 16:11:51 +00:00
Winson Chung
a5fb95df57 Merge "Try to handle side-task launches even if not fully transitioned to overview" into udc-dev 2023-05-26 04:25:21 +00:00
Luca Zuccarini
07c3491ec2 Merge "Add a view type check to ensure the right animation is used." into udc-dev 2023-05-25 15:42:51 +00:00
Winson Chung
98fbe25da9 Try to handle side-task launches even if not fully transitioned to overview
- The launcher state does not transition from Background -> Overview
  until the overview animation finishes, and if a side task is launched
  before that happens, then we receive onTaskAppeared() but
  isInLiveTileMode() is false, which results in a state where no
  animation of the side task surface is run, and the recents animation
  is not finished.  In these cases, if we've already calculated the
  end target is RECENTS, then we can still animate the side task
- Adding some more gesture logs to indicate side task launched (or didn't)

Bug: 279114961
Test: Go to overview and launch next task

Change-Id: I23eac8721da801f14cc95fc6781a0ef9f0355cc0
2023-05-25 06:14:53 +00:00
Schneider Victor-tulias
9a7de100f4 Update gesture nav edu motion and colors
- Updated gesture nav edu overview step post-success motion and colors
- Updated gesture nav edu menu done button color and legacy action button color
- Switching light/dark mode when a step is complete started the demonstration animation. fixed this jank

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281764891
Fixes: 283964958
Bug: 279823249
Test: ran full tutorial with ENABLE_NEW_GESTURE_NAV_TUTORIAL enabled and disabled
Change-Id: I9adc05947267ec038b6f374b2a29a5499468883b
2023-05-24 18:36:39 +00:00
Jagrut Desai
990aef6c00 Merge "Android U: GM3 Color Tokens for Taskbar and quickstep" into udc-dev 2023-05-24 17:28:33 +00:00
Schneider Victor-tulias
8f26e47736 Fix keyboard quick switch d-pad left/right traversal direction
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 284156698
Test: tried keyboard quick switching with d-pad left/right in rtl/ltr
Change-Id: Idb7466b316cb7cbd9f592c5949d2c95c3278d85f
2023-05-24 10:04:05 -07:00
Luca Zuccarini
f898ee474c Merge "Remove redundant instances of depth controller." into udc-dev 2023-05-24 11:35:21 +00:00
Jagrut Desai
5b3161ef3e Android U: GM3 Color Tokens for Taskbar and quickstep
Test: Manual, Design Review
Bug: 268505871
Flag: not needed
Change-Id: I68e5092ccc69cf8a0d40aa4cc49fe9e8d82a68f4
2023-05-23 11:44:15 -07:00
Luca Zuccarini
a96dcb0cc7 Remove redundant instances of depth controller.
During each app launch, a new `MyDepthController` is instantiated, which
registers two of its methods as listeners for cross window blur and
opaqueness. This controller's usefulness spans that specific animation
only, but the listeners are never unregistered. This creates conflicts
when an opaqueness signal happens, which cause the background to flicker
(see videos).

Bug: 283335820
Test: manual, see videos in the bug
Flag: not needed, bug fix
Change-Id: I3dcb0b8ff0aa77bf3183a926889d0131b17bcaa4
2023-05-23 15:33:17 +00:00
Tony Huang
2d586455dc Merge "Hide divider immediately if going to launcher" into udc-dev 2023-05-23 03:04:18 +00:00
Treehugger Robot
25e94ccb1b Merge "Adding debug tracing for b/262282528" into udc-dev 2023-05-22 22:48:47 +00:00
Schneider Victor-tulias
b323851e01 Merge "Update BorderAnimator to work with layout updates" into udc-dev 2023-05-22 20:17:35 +00:00
Schneider Victor-tulias
bd0188abd1 Merge "Fix redesigned gesture nav jank" into udc-dev 2023-05-22 19:01:35 +00:00
Schneider Victor-tulias
7dee27f470 Update BorderAnimator to work with layout updates
1. if a 'ViewScaleTargetProvider' is being used, this can cause a crash
2. otherwise, the old border bounds are reapplied, which is likely no longer correct

Updated BorderAnimator to use 'BorderAnimationParams' rather than 'ViewScaleTargetProvider'. This removes some unnecessary null checks while making the util class simpler to use. It also allows us to listen for specific view events for the border animation.

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 283272516
Test: opened the keyboard quick switch view and highlighted a view in recents view, then rotated the screen several times
Change-Id: I7959d6cd892ebcdd2c68163dd56c358815494af6
2023-05-22 11:33:57 -07:00
Jagrut Desai
6acf350107 Merge "Fix Taskbar Education Tooltip Bottom Margin" into udc-dev 2023-05-22 17:04:25 +00:00
Tony Huang
2083c5450d Hide divider immediately if going to launcher
Divider should hide immediately when going to launcher, this fix
the divider hidden delay in 3-btn-nav mode.

Fix: 283058496
Test: manual
Test: pass existing tests
Change-Id: Ia4eaba8020c564cc95b8652fe0f7066b653b9df4
2023-05-22 16:38:14 +08:00
Jon Miranda
9e0eee3729 Merge "Fix SUW unstash animation." into udc-dev 2023-05-20 20:16:17 +00:00
Jon Miranda
0aef6981ac Fix SUW unstash animation.
- Defer any UI updates to taskbar after the SUW unstash animation is created.
- Predicted app icons take longer to load, so it's possible that they are
  added after the animation is created.
- This avoids the case where icons are seemingly in the taskbar but
  do not get animated like the rest of the icons.

- We also need to call onAnimationStart for the reveal animation immediately,
  otherwise the clipToOutline params never get set.

Bug: 277712185
Test: flash device, very quickly go through SUW
Change-Id: I4c3089da0d20bf91672e2305655c4c37b1f367aa
2023-05-19 17:24:50 -07:00
vadimt
144a9508be Adding debug tracing for b/262282528
We see two long-clicks on the taskbar instead of expected one.

Bug: 262282528
Test: presubmit
Change-Id: I231d54ac08cf53ac7b0b6177da6b671314998021
2023-05-19 17:04:04 -07:00
Jagrut Desai
709242e89e Fix Taskbar Education Tooltip Bottom Margin
Test: Manual
Bug: 282990924
Flag: Not needed
Change-Id: I977e7fc84382b1c43612516c8d6f27610ad25a3f
2023-05-19 15:45:41 -07:00
Vinit Nayak
258019fe8e Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev 2023-05-19 17:51:23 +00:00
Luca Zuccarini
2449a01b22 Add a view type check to ensure the right animation is used.
Bug: 265134143
Test: recorded perfetto trace, see bug
Change-Id: If6abc36f0f43c6bb632fc824c19717c1231b32dc
2023-05-19 09:51:15 +00:00
Hongwei Wang
0c66b151e3 Merge "Notify WMShell on aborting auto-enter-pip" into udc-dev 2023-05-18 23:00:03 +00:00
Saumya Prakash
66e7ec721b Merge changes If2c82082,I03532b80 into udc-dev
* changes:
  Update Lottie animations for gesture navigation tutorial to enable custom colors
  Update gesture tutorial colors
2023-05-18 22:01:49 +00:00
Schneider Victor-tulias
9caa0f9559 Fix redesigned gesture nav jank
- Removed the fake animated taskbar view from the redesigned tutorial flow
- Fixed the hotseat and home icon colors from the overview step

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Fixes: 281121701
Fixes: 283310758
Test: swiped up from home/overview step
Change-Id: Ie659495994f0c935c5b6c6bf1ae534ec51521726
2023-05-18 14:36:28 -07:00
Hongwei Wang
45b8d39ab8 Notify WMShell on aborting auto-enter-pip
Note that this change does not fix the bug listed here. This is to
callback WMShell when the transition is aborted and WMShell can choose
how to handle this.

Bug: 283177443
Test: adb shell dumpsys activity service SystemUIService WMShell
Test: go/winscope and check the SF/WM dump
Change-Id: I8abfc2db47d1f0bfc3d400066936bed354743420
2023-05-18 13:15:57 -07:00
Treehugger Robot
80e9a3b64e Merge "Fix widget clipping in widget back animation" into udc-dev 2023-05-18 19:59:21 +00:00
Saumya Prakash
0a6fb2c9e1 Update Lottie animations for gesture navigation tutorial to enable custom colors
This change introduces tokens for all the lottie animations in the
gesture navigation tutorial so that the colors can be changed to match
with the current design spec at http://shortn/_aig7n8W7rF

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Bug: 281764891
Test: Tried changing colors and verified that lottie animations changed
appropriately.

Change-Id: If2c820826603fb1cf424f5f0c97d83b195d26606
2023-05-18 10:47:44 -07:00
Schneider Victor-tulias
474f3c4e90 Update gesture tutorial colors
- Updated all redesigned gesture nav menu and tutorial colors to dynamic color spec

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 281764891
Bug: 279823249
Test: launched tutorial menu and tutorial steps
Change-Id: I03532b80c6e14867c1374bbdf9f984c1cece9809
2023-05-18 10:47:33 -07:00
Vinit Nayak
6ab2786d16 Separate code paths to launch split from existing pair vs new pair
* Launching existing pair doesn't rely on any existing
data/state in SplitSelectStateController or SplitSelectDataHolder
* Consolidate launchTask*() methods in GroupedTaskView

Test: TaskThumbnailViews measured correctly, animation
correct on small+large screen, initiating split
still working
Fixes: 274540670
Flag: none needed

Change-Id: Id359f53ac5f2bba19948d4ae3231092fb90cc7c5
2023-05-18 10:43:17 -07:00
Jagrut Desai
b9a88db27c Merge "Fixing spacing between folder icon and folder itself" into udc-dev 2023-05-18 17:21:33 +00:00
Sihua Ma
f8acb23e1f Fix widget clipping in widget back animation
Test: Manual
Fix: 280261814
Change-Id: I4db24ca624d50b1d860df428fdab9d591f35ac5e
2023-05-17 13:32:20 -07:00
Saumya Prakash
e212779ffd Merge "Display app icons in quick switch task view when there are no updates." into udc-dev 2023-05-17 17:11:49 +00:00
Winson Chung
2e1ce4c72f Merge "Only set drag shadow params if they are valid" into udc-dev 2023-05-17 03:44:42 +00:00
Saumya Prakash
033412a892 Display app icons in quick switch task view when there are no updates.
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fix: 275629107
Test: Launched keyboard quick switch view and changed focus back and forth

Change-Id: I6ce39e7842bb04c80d49d871002ef957708a8e59
2023-05-16 23:00:46 +00:00
Jagrut Desai
172266fb4e Fixing spacing between folder icon and folder itself
Test: Manual
Bug: 282990506
Flag: not needed
Change-Id: I4a873495ffdf6210b496a4d7d18546dc7483e66e
2023-05-16 14:04:14 -07:00
Charlie Anderson
afb447ee0d Merge "Adding a new Edit Mode LauncherState" into udc-dev 2023-05-16 18:42:34 +00:00
TreeHugger Robot
b9f04842b5 Merge "Add a no recent tasks message to the keyboard quick switch view" into udc-dev 2023-05-16 06:49:52 +00:00
Schneider Victor-tulias
4ee471fecf Merge "Update keyboard quick switch view ordering and add icons" into udc-dev 2023-05-16 05:12:47 +00:00
Treehugger Robot
56f539538f Merge "Don't treat Recents as transient for all apps from overview." into udc-dev 2023-05-16 01:28:49 +00:00
Schneider Victor-tulias
b29355c192 Add a no recent tasks message to the keyboard quick switch view
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 280652620
Test: launched the keyboard quick switch with 0, <=6 and >6 tasks launched
Change-Id: I560707645b83b79ba2203460e62e4c540f5da421
2023-05-15 16:49:45 -07:00
Schneider Victor-tulias
f0233c53d3 Merge "Code cleanup: recycle typed arrays when they are no longer needed" into udc-dev 2023-05-15 23:48:11 +00:00
TreeHugger Robot
f0c96721ba Merge "Add handling for toggling keyboard stashing from the keyboard" into udc-dev 2023-05-15 22:57:14 +00:00
TreeHugger Robot
15bc0d388a Merge "Adding support for listening to end callbacks when launching an intent from Launcher" into udc-dev 2023-05-15 22:20:32 +00:00
Winson Chung
583de1621d Only set drag shadow params if they are valid
- Invalid params trigger an exception to be thrown when starting a
  system drag

Bug: 269016702
Test: Presubmit
Change-Id: I4b1953afd72ab1c6d41f3b5b536f9578ef40d792
2023-05-15 22:10:16 +00:00
Tony Wickham
4f69ca52ef Merge "Remove unused/obsolete feature flags" into udc-dev 2023-05-15 21:46:15 +00:00
Tracy Zhou
3711aa64ac Merge "[Reland] Fix touch focus not updated correctly after launching overview with live tile." into udc-dev 2023-05-15 19:45:46 +00:00
Schneider Victor-tulias
b6407699ae Update keyboard quick switch view ordering and add icons
- Updated the keyboard quick switch view ordering to left-to-right (vice versa in RTL)
- Added app icons to keyboard quick switch taskviews

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 275629107
Test: launched keyboard quick switch view and changed focus back and forth
Change-Id: Ie2f0a1c08c7065c53075f6fa015000a2d6184491
2023-05-15 12:06:19 -07:00