Commit Graph

3473 Commits

Author SHA1 Message Date
Cyrus Boadway
1db10e2a3a Merge "Keep transparent drawable for clipping outline during launch animation" into sc-dev am: 66f1b57815 am: e08c377a72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15284080

Change-Id: If16f06c6aa4d615df865a64f9327dcae9c131eaa
2021-07-15 18:56:08 +00:00
Cyrus Boadway
66f1b57815 Merge "Keep transparent drawable for clipping outline during launch animation" into sc-dev 2021-07-15 18:28:29 +00:00
Pat Manning
d642b65137 Merge "Scale task rounded corners proportional to TaskView size." into sc-v2-dev 2021-07-15 17:39:31 +00:00
Pat Manning
8a6179bb7d Scale task rounded corners proportional to TaskView size.
Test: manual
Fix: 183936745
Change-Id: I2e2dd806826cba135d5a1e6ab9a5e80b8994d64d
2021-07-15 15:25:24 +00:00
Alex Chau
86ac825061 Move focused task to front when attaching RecentsView
- Only move focused task it's the first time attaching RecentsView
- Simpily remove and re-add focused task to move it to front

Bug: 192471181
Test: manual
Change-Id: I95b29c39328911beec7fd3d254f7a22be5e10cc1
2021-07-15 15:24:00 +01:00
Alex Chau
031373daa3 Reland "Snap to relative position to snappd task when dismissing"
This reland commit ba61b98fca accidentally reverted by http://ag/15162411

Bug: 188793333
Test: manual
Change-Id: Iae07a67d528aa80e8f87d37758244d0c46b61cf7
2021-07-15 15:12:34 +01:00
TreeHugger Robot
3df9de7cd0 Merge "Don't create gap between last task and clear all button" into sc-v2-dev 2021-07-15 10:54:47 +00:00
Hongwei Wang
a35d7ec90e Merge "Use display cutout info in auto-enter-pip transition" into sc-dev 2021-07-14 23:52:42 +00:00
Hongwei Wang
3c4f60900d Merge "Use display cutout info in auto-enter-pip transition" into sc-v2-dev 2021-07-14 21:00:47 +00:00
Cyrus Boadway
1cf5527ae8 Keep transparent drawable for clipping outline during launch animation
During the widget-activity transition, the widget foreground loses its
clipping radius, if the clipping is determined by a drawable. We remove
the drawable through the animation.

For widgets where there is content being clipped by the background's
corener radius, this results in the widget window appearing square
through the entire animation, then snapping in rounded corners on
animation-complete.

To solve this, we leave a transparent clone of the drawable in the
original drawable's place, for the balance of the animation, providing
the outline for clipping.

Manual testing against 20 Google widgets showed no regression in
behaviour in other cases.

Bug: 193665108
Test: manual

Change-Id: I3db31e4634c8dd6b22a513a976386d396445ebc2
2021-07-14 19:21:16 +00:00
TreeHugger Robot
6224eaea29 Merge "Notify System UI about taskbar state" into sc-v2-dev 2021-07-14 10:59:26 +00:00
Thales Lima
03f0c67420 Merge "launcher: check if task still exists before leaving it in focus" into sc-v2-dev 2021-07-14 09:54:10 +00:00
Schneider Victor-tulias
38a6d462a2 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev am: ae2e5d9231
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15099479

Change-Id: Icb5e7cdca02fab3c6c165ab3c612ee943d97d947
2021-07-13 23:41:14 +00:00
Schneider Victor-tulias
ae2e5d9231 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev 2021-07-13 23:27:45 +00:00
Hongwei Wang
854fbf8d23 Use display cutout info in auto-enter-pip transition
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/bpKcGg1eoOo5Jz5U6IwBYK
Bug: 191310680
Test: manual, auto-enter-pip from landscape with source rect hint being
      turned on, see the video
Change-Id: Ic191fc73597132a5119522dda477a4319e35d1c8
Merged-In: Ic191fc73597132a5119522dda477a4319e35d1c8
2021-07-13 13:24:57 -07:00
Hongwei Wang
70d4e3e2df Use display cutout info in auto-enter-pip transition
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/bpKcGg1eoOo5Jz5U6IwBYK
Bug: 191310680
Test: manual, auto-enter-pip from landscape with source rect hint being
      turned on, see the video
Change-Id: Ic191fc73597132a5119522dda477a4319e35d1c8
2021-07-13 13:22:42 -07:00
Thales Lima
9c1024759f launcher: check if task still exists before leaving it in focus
Fixes 191353942
Test: manually; check buganizer on how to reproduce

Change-Id: Ia75ff59b5a9ef5654747d445df4088a5b17f6a42
2021-07-13 17:35:44 +01:00
Thales Lima
c7c1ea8ac8 Merge "launcher: use correct preference key on SettingsChangeLogger" into sc-v2-dev 2021-07-13 14:57:14 +00:00
Thales Lima
1f06c5b457 launcher: use correct preference key on SettingsChangeLogger
The previous key was related to hotseat and not to the workspace size.

Fixes 184981523
Test: debugging and logcat logging

Change-Id: I445264ac0c4fb9ab99e31f96b7257271b730e2da
2021-07-13 13:46:20 +01:00
Alex Chau
4e3460b866 Remove debug logs for b/193125090
Bug: 193125090
Test: manual
Change-Id: I7758347d7b775e8d8b0926e8f0d8723c7af2c942
2021-07-12 18:48:34 +01:00
Alex Chau
8be6c7106c Don't create gap between last task and clear all button
- If a task is too close to ClearAllButton when being snapped to, change the snap position to barely not seeing ClearAllButton
- When snapping to the above tasks from quick switch, apply a horizontal grid translation to smoothly snap into  position
- Apply the above grid translation to TaskViewSimulator as well

Bug: 192254835
Test: manual
Change-Id: I32d562a1726f7c8b41ac10c7deece890df7e1304
2021-07-12 16:31:52 +01:00
Alex Chau
4818bc42cd Refresh Task overlay when thumbnail is refreshed
- TaplTestQuickStep.testOverviewActions is failing on cuttlefish large screens due to overview actions being disabled by NO_THUMBNAIL, which should be caused by thumbnail being loaded after overlay is enabled, a overlay refresh after thumbnails is loaded should fix the problem

Bug: 193125090
Test: manual
Change-Id: I3fa8093012c3d22adac49e5e0716576706a85dfa
2021-07-12 12:29:53 +01:00
Schneider Victor-tulias
bfe33b057a Update Gesture navigation tutorial to match new specs
- Updated strings
- Updated removed 'next' button when there are followign steps
- Added timeout to automatically continue the tutorial
- Combined back left and right into one step

Bug: 192009114
Bug: 177005427
Test: manual
Change-Id: I58b9017c4d69b5d097326c7d5be156a63951fb1a
2021-07-09 19:38:16 +00:00
Alex Chau
1e767a6ecc Refine logs for debugging TaplTestQuickStep.testOverviewActions on cf_foldables
- The failure is not reproducible locally, thus requires adding logs and check ATP result
- Removed some redundant logs
- Changed to log at VERBOSE
- Added extensive logging to all visibility/enable/alpha setter of ActionsView

Bug: 193125090
Test: Manual
Change-Id: I5b449a7f86ea4cef65e0e46de4b389deef9f53f3
2021-07-09 13:32:49 +01:00
Vinit Nayak
80aa4dbec0 Merge "Re-try binding to TouchInteractionService if service is killed" into sc-v2-dev 2021-07-08 22:09:51 +00:00
Evan Rosky
340471f9e6 Merge "Include shell+stage-split in legacy recents animations" into sc-v2-dev 2021-07-08 22:05:54 +00:00
Winson Chung
5f306f97f2 Merge "Fix crash when handling recents animation canceled" into sc-dev am: d489a4b6e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15236027

Change-Id: If65c9b5f4822bed2dbb63f0aa9f34ae7e2e3a922
2021-07-08 21:35:57 +00:00
Winson Chung
d489a4b6e9 Merge "Fix crash when handling recents animation canceled" into sc-dev 2021-07-08 21:21:37 +00:00
Vinit Nayak
297d2cdd44 Re-try binding to TouchInteractionService if service is killed
For problem explanation, see b/190339338#comment26.
When the binding dies, this attempts to retry
binding to the service with a backoff duration of
(1000 * 2^N)ms where N is # of attempts.

Bug: 190339338
Test: Taskbar seems interactable more consistently.
Manually failed the binding a couple times to see
retry mechanism and verified by logging locally.

Change-Id: Ia76207d0b2ef30b425ee1d7c66d7dee453bca7d8
2021-07-08 13:05:38 -07:00
Alex Chau
4b0ef07f7a Merge "Add logs for debugging TaplTestQuickStep.testOverviewActions on cf_foldables" into sc-v2-dev 2021-07-08 19:11:53 +00:00
Winson Chung
255fe1ea45 Fix crash when handling recents animation canceled
- If Launcher finishes the animation, that also cleans up the screenshot
    on the server side, so we can skip calling it

Fixes: 192684578
Test: N/a, adding a null check
Change-Id: I8bf1ad5089762469697d14842cc14c184055e925
2021-07-08 10:12:34 -07:00
Evan Rosky
ffa6652c25 Include shell+stage-split in legacy recents animations
This just builds the infrastructure and then, just as
an example/proof-of-concept, uses the infra to show/hide
the divider-bar when it makes sense.

Bug: 192292305
Test: enable SPLIT_SELECT, enter split, use recents and observe
      the divider bar appropriately showing/hiding
Change-Id: Iea0704b3f7821c3056a1675f11e671e81305831f
2021-07-08 09:03:18 -07:00
Evan Rosky
1abc73c587 Hook up split-launch to legacy transition system
Adds legacy versions of the animation logic.

Bug: 192279476
Test: use SPLIT_SELECT to launch 2 apps in split and observe
Change-Id: I5cbe7416819ba88d8c081fb413177fadac5b815d
2021-07-08 09:03:12 -07:00
Alex Chau
73202ec6b3 Add logs for debugging TaplTestQuickStep.testOverviewActions on cf_foldables
- The failure is not reproducible locally, thus requires adding logs and check ATP result

Bug: 193125090
Test: Manual
Change-Id: I3d2d37a43d4b89885214b72e48f45a9b6bc63f61
2021-07-08 15:29:28 +01:00
Ashish Gupta
277eb6fe59 Merge "NIU Actions: Add NIU Actions tooltip" into sc-dev am: 4e74ccb082
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15126744

Change-Id: I603a29767934ac22dc6200c3e63053d6278236d2
2021-07-08 07:42:16 +00:00
kumarashishg
88be649d21 NIU Actions: Add NIU Actions tooltip
These tooltips are added to educate the user about NIU buttons actions. We have added tooltips for Translate and Listen NIU actions buttons.

Bug: 186006700
Test: Manual
Change-Id: Ib076c2a44055b62f2daf06bddf45aca220a28756
2021-07-08 00:48:22 +00:00
Vinit Nayak
9241fe62d1 Merge "Set correct divider dimension for task menu options" into sc-dev am: 7d0826f3d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164589

Change-Id: Ia48a1e6b2ebab8f94f374d0c4369bf4b62d13bea
2021-07-07 20:13:15 +00:00
Vinit Nayak
7d0826f3d1 Merge "Set correct divider dimension for task menu options" into sc-dev 2021-07-07 19:56:56 +00:00
Winson Chung
da587fb7a6 Merge "Remove unused logs" into sc-dev 2021-07-07 18:02:53 +00:00
Vinit Nayak
a102bd896f Merge "Show back and IME switcher for gesture nav (1/2)" into sc-v2-dev 2021-07-07 18:02:17 +00:00
Alex Chau
41655c3d4a Merge "Allow dragging outside TaskView on fallback recents" into sc-v2-dev 2021-07-05 14:37:03 +00:00
Lucas Dupin
1f5a4c9522 Merge "Use launcher surface when removing launch target" into sc-dev am: e55878cedf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15193282

Change-Id: If0f2f60cae7d7d00ab5cf386b32f00247af887d6
2021-07-03 17:29:49 +00:00
Lucas Dupin
e55878cedf Merge "Use launcher surface when removing launch target" into sc-dev 2021-07-03 17:14:32 +00:00
Winson Chung
3ab305e759 Merge "Fix crash when handling recents animation canceled" into sc-dev am: a82403ab09
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15192339

Change-Id: Id8f402766124ecbb648d81527124e41495e182b5
2021-07-03 03:43:07 +00:00
Winson Chung
a82403ab09 Merge "Fix crash when handling recents animation canceled" into sc-dev 2021-07-03 03:26:26 +00:00
Winson Chung
553d978012 Fix crash when handling recents animation canceled
- If Launcher finishes the animation, that also cleans up the screenshot
  on the server side, so we can skip calling it

Fixes: 192684578
Test: N/a, adding a null check
Change-Id: Ia6b99b4262e72f925e7d622ea8833d3c88252633
2021-07-03 03:26:16 +00:00
Lucas Dupin
20a13047ae Use launcher surface when removing launch target
Otherwise events won't be dispatched properly and window opacity will be
wrong.

Test: manual
Fixes: 191149025
Change-Id: Ice7ea86252282c7dc1cb5925dd1bdb8cade89c08
2021-07-02 17:39:10 -07:00
Tracy Zhou
ee5dc1149e Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-dev 2021-07-02 21:41:28 +00:00
Tracy Zhou
26f47c711a [DO NOT MERGE] Make the cutout slightly smaller
Temporary fix for S. Leaving the bug open for a proper fix in T.

Bug: 189265196
Test: https://screenshot.googleplex.com/75fgCva736rqwg5
Change-Id: Ice3b189a41f759e090334e360e44543eabc4836d
2021-07-02 13:35:50 -07:00
Sunny Goyal
535c4957e6 Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 6348858734
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15137733

Change-Id: I298c261a148e909d1f68926b6d865fa6f2b44825
2021-07-02 18:37:41 +00:00