Commit Graph

5194 Commits

Author SHA1 Message Date
Merissa Tan
1b077203d6 Merge "Create new DesktopNavbarButtonsViewController class." 2022-01-19 19:22:49 +00:00
Iris Yang
36e0fd91a0 Merge "Set launch display id to an action performed on BaseQuickStepLauncher" 2022-01-19 06:09:30 +00:00
Jerry Chang
d941d02d95 Merge "Consolidate recent animation in split screen with shell-transition" 2022-01-19 01:45:55 +00:00
Merissa Tan
d41ce4980d Create new DesktopNavbarButtonsViewController class.
This CL creates a new DesktopNavbarButtonsViewController class to allow
for taskbar buttons and status icons customization on desktop
environment.

Recall: http://recall/clips/e008d2de-36d3-47f6-954a-5ce18bac69a5

Bug: 213964564
Bug: 196757951
Test: Switch between different system navigation modes and verify the
desktop taskbar buttons stay on screen.

Change-Id: Ie7a9a044fad3b60cd37d910b8eb78c8734aadfd5
2022-01-18 17:10:15 -08:00
TreeHugger Robot
f2172eba8c Merge "Make Taskbar focusable when a popup is open." 2022-01-15 00:00:55 +00:00
Schneider Victor-tulias
291d88460b Make Taskbar focusable when a popup is open.
- Added ArrowPopup#OnPopupClosedCallback to automatically remove Taskbar focus when the popup closes.

Fixes: 209917078
Test: opened popup in taskbar and closed it with switch access, touching anywhere on the screen and using the back gesture. went home to check if focus was removed.
Change-Id: Ie7aafc9cf0f03fadaa44e77818508e9e1d8db610
2022-01-14 12:52:53 -08:00
Tony Wickham
7b40594bc7 Merge changes I36f6cfb8,I7c784765
* changes:
  Create new window for Taskbar Nav Buttons when taskbar is focusable
  Make taskbar focusable when folder is open to get IME input
2022-01-14 17:12:08 +00:00
TreeHugger Robot
1b6d46f880 Merge "Remving SurfaceControlCompat" 2022-01-14 07:04:53 +00:00
Lucas Dupin
470c987e2e Merge "Directly assign mDepth" into sc-v2-dev am: c518932f74 am: 7b71c2ee59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16622831

Change-Id: I4686c845583d85ff58899869ac18a9d87762c537
2022-01-13 23:54:15 +00:00
Lucas Dupin
c518932f74 Merge "Directly assign mDepth" into sc-v2-dev 2022-01-13 23:19:20 +00:00
TreeHugger Robot
05de8c874f Merge "TalkBack doesn't announce when a task has being closed." into sc-v2-dev am: c0a6d3fc8f am: e81cab2fa4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16346766

Change-Id: I03d32f4df17adc36982ad03896583ede306934d3
2022-01-13 21:06:28 +00:00
TreeHugger Robot
c0a6d3fc8f Merge "TalkBack doesn't announce when a task has being closed." into sc-v2-dev 2022-01-13 20:36:44 +00:00
Lucas Dupin
03064a1e60 Directly assign mDepth
A request to set a new depth is ignored if the surface is currently
invalid. We should cache what was the requested value, so it will be
applied once the surface is valid again.

Test: manual
Fixes: 209028986
Change-Id: I812816da4b0139c7ea7b53a9fb00f11265ecdea8
2022-01-13 12:01:11 -08:00
Jerry Chang
85224ebd08 Consolidate recent animation in split screen with shell-transition
Also exclude corresponding parent task when wrapping up remote animation
target for recents animation.

Bug: 206487881
Test: manual check recent animation after split screen activated
Change-Id: I2e80eca1124d9a9e360513334211bde8a52575ea
2022-01-13 08:00:00 +00:00
TreeHugger Robot
b92b229a80 Merge "Launch activity if click on a TaskView which has the task running on different display wit root." 2022-01-13 06:07:15 +00:00
Winson Chung
30fc033b0c Merge "Revert "Add logs for null task list"" into sc-v2-dev am: b92c4e2319 am: daaebc8959
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16615289

Change-Id: Ic3c9e5aae3bd858a4471de6a3be5027fc844f5a8
2022-01-12 23:27:41 +00:00
Winson Chung
b92c4e2319 Merge "Revert "Add logs for null task list"" into sc-v2-dev 2022-01-12 23:00:00 +00:00
Tony Wickham
66971f87e1 Create new window for Taskbar Nav Buttons when taskbar is focusable
Test: Open folder from taskbar, edit name, ensure back button displays above IME and that IME sends input to the taskbar folder name
Bug: 205803170
Change-Id: I36f6cfb835aa7da280f15ea4b0aed8923ce8a012
2022-01-12 14:22:47 -08:00
Tony Wickham
c07fb08a1e Make taskbar focusable when folder is open to get IME input
- Remove ActivityContext#supportsIme(), as it's always true now
- Add OnFolderStateChangedListener, which we register when clicking on a taskbar folder icon to set the window focusable/not.
- Also remove Folder.STATE_NONE and instead default to STATE_CLOSED (renamed from STATE_SMALL).

TODO: make sure back button is visible above IME (followup CL)

Test: Open a folder from taskbar while in an app, no animation jump and can change folder name
Bug: 180051157
Change-Id: I7c7847657d462c16677d66b9ffa8b6fe5f164084
2022-01-12 14:22:31 -08:00
Jerry Chang
5360c00c85 Merge "Fix NPE when consuming snapshots for recent animation" into sc-v2-dev am: f6086e74e3 am: 0e22f9947b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16598402

Change-Id: I7cd1665d8bc22aecfa9feb39261087656be7facf
2022-01-12 01:58:10 +00:00
Jerry Chang
f6086e74e3 Merge "Fix NPE when consuming snapshots for recent animation" into sc-v2-dev 2022-01-12 01:21:14 +00:00
Winson Chung
08126d915c Revert "Add logs for null task list"
This reverts commit a46d36240b.

Reason for revert: Reverting logs for release

Change-Id: I65ae1ea691d5fb3d70a2db4beba08d7460b99e2b
2022-01-11 20:06:16 +00:00
Iris Yang
55f74d675c Set launch display id to an action performed on BaseQuickStepLauncher
Without this change, tapping all apps of work profile wouldn't bring
the work profile app back to phone.
Add ActivityOptions#setLaunchDisplayId to the display that the given
view is currently on. So the activity will be launched to the display
as the user is interacting with.

This change also modified BaseDraggingActivity which is the parent
class of BaseQuickstepLauncher. And the RecentsActivity is extending
BaseDraggingActivity.

Bug: 204164763
Test: Manually tested using Exo. Open work appliction(e.g.Calendar)
on Exo virtual display, and tapping on the phone's Calendar on work
profile to bring the application back to phone.
Demo video: https://drive.google.com/file/d/18LWMyDz5kYj8IwAwu5EOsBk3PsjEx1zf/view?usp=sharing&resourcekey=0-7eGtqiWZDciSCfFce29MtA

Change-Id: I31d822f6df7222939413f13da850230f46ba8001
2022-01-11 11:04:05 +00:00
Vinit Nayak
73d6b4c99e Remove code that assumes single GroupedTaskView am: 2c97c4ab19 am: b0786109bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16603208

Change-Id: I690c2f7740c94df5ae2b4ccf75e5a9c8ee8ffc37
2022-01-11 03:14:59 +00:00
Vinit Nayak
2c97c4ab19 Remove code that assumes single GroupedTaskView
* Old code assumes there will only be a single
GroupedTaskView, removing those code paths helps
consolidate single and grouped task code flows
* Correctly check when we need to add a stub
taskView for GroupedTaskViews by checking each
individual taskId

Test: Swiping with multiple split pairs doesn't
cause a cycle
Fixes: 213355942

Change-Id: Ibb98ae0dfcd4f52b762685aec9d2ee6445b9ef54
2022-01-10 15:59:33 -08:00
Sunny Goyal
26a1a46b4d Remving SurfaceControlCompat
Bug: 213421974
Test: Presubmit
Change-Id: I1279789b09364b35a454e32417f687c1e055f27a
2022-01-10 14:41:21 +00:00
Jerry Chang
7f8e57ed68 Fix NPE when consuming snapshots for recent animation
Fix: 207716265
Test: no exception throws after recent animation
Change-Id: Ic35aea2285fb120f7d0b5215137ad9450518702f
2022-01-10 18:48:16 +08:00
Pat Manning
9d5962e173 Merge "Create taskbar for kids mode." 2022-01-10 10:46:48 +00:00
Andy Chou
4ece098f3d Launch activity if click on a TaskView which has the task running on
different display wit root.

If click on the TaskView which has the task running on differnt display
with root, it means we are trying to pull the task to the root display.
So we should also launch the activity to the right display even it is in
live tile mode.
Also add null check for getRootViewDisplayId().

Bug: 207085426
Bug: 210075742
Test: manual test with app streaming wit phonehub notification
Change-Id: Icdaa6dfa26345d271f3505a0226cf434696f40da
2022-01-08 15:16:05 +00:00
TreeHugger Robot
1af0e4d22e Merge "Add null check when logging quick switch" into sc-v2-dev am: d873788275 am: 5bab8365b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16584901

Change-Id: I17f59874f884bf3b7c0e1d154d8d9ac8f9fa1b5c
2022-01-07 22:53:42 +00:00
TreeHugger Robot
d873788275 Merge "Add null check when logging quick switch" into sc-v2-dev 2022-01-07 22:13:12 +00:00
Tony Wickham
688148ac69 Add null check when logging quick switch
Test: none
Fixes: 209993127
Change-Id: I927f8969cf5ef3759b501fe1ada4d3b061b53d06
2022-01-07 18:32:14 +00:00
Pat Manning
2c4a1d8f7a Create taskbar for kids mode.
Test: manual
Bug: 203749295
Change-Id: I52c05cf8685e6e921bb717e9714d1cb2e5f4a351
2022-01-07 11:25:04 +00:00
TreeHugger Robot
d311cc753d Merge "Don't show split option if device in "Lock task mode"" into sc-v2-dev am: 19b3b93e5c am: bff00ec14f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16576986

Change-Id: I8089f588770a0bca6aaa28a9f7acd3c7354f8e1d
2022-01-06 23:54:25 +00:00
TreeHugger Robot
19b3b93e5c Merge "Don't show split option if device in "Lock task mode"" into sc-v2-dev 2022-01-06 23:20:54 +00:00
Vinit Nayak
c09012766b Don't show split option if device in "Lock task mode"
fixes: 199342537
Change-Id: Id212cce20b792fb8b16e9fa8eca4635773ae5ea7
2022-01-06 13:37:46 -08:00
Wei Sheng Shih
3b7ae6e723 Merge "Public API setSplashScreenStyle(3/N)" 2022-01-06 05:25:32 +00:00
TreeHugger Robot
ff5e679c70 Merge "Use list instead of array when filtering non-app leashes" into sc-v2-dev am: 5735251c33 am: a7d85caf4b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16571427

Change-Id: Ifc053aaafd1b063e0f1f8f5d046c24a0022fd8ca
2022-01-06 00:53:05 +00:00
TreeHugger Robot
5735251c33 Merge "Use list instead of array when filtering non-app leashes" into sc-v2-dev 2022-01-06 00:25:34 +00:00
TreeHugger Robot
491c680681 Merge "Handle split selection when animation is disabled" into sc-v2-dev am: 3a6a0f5a31 am: 0d07b6d0c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16512483

Change-Id: I3d2511065fe693a6d710d91d2f728914a05cda41
2022-01-05 23:30:56 +00:00
TreeHugger Robot
3a6a0f5a31 Merge "Handle split selection when animation is disabled" into sc-v2-dev 2022-01-05 22:56:01 +00:00
Vinit Nayak
d25fb5bd0b Use list instead of array when filtering non-app leashes
* Non-apps leashes can contain non-divider targets, which
was creating null elements in the array when an index didn't
get assigned.
* With a list we don't have to worry about empty index gaps
* Also remove the animation for the divider for certain
gestures because the surface isn't always valid for the
full duration of the animation. We probably would need to
synchronize with rest of recents animation

Fixes: 212218930
Test: No longer crashes when swipe up, hold, then swipe down
Change-Id: Ia1fc4d66e73f21b55fdbfe59342af025e2a525d9
2022-01-05 14:43:43 -08:00
Vinit Nayak
1465a5af7b Handle split selection when animation is disabled
* Consolidate setState() and setStateWithAnimation()
to be handled in the same manner
* If no animation, we run the created
PendingAnimation right away

Fixes: 209935590
Test: Tested w/ and w/o animation
Change-Id: I1d6fdba21761b6721e6bd52234016178547cd437
2022-01-05 12:19:11 -08:00
Hyunyoung Song
7b26540f64 Merge "Apply scrim protection to atomic state transition ALLAPPS -> NORMAL" into sc-v2-dev am: d96e07035c am: 1dc16ded78
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16567964

Change-Id: I4d42bb56d3018637eb62d86b0c996abe7c77fe06
2022-01-05 20:01:18 +00:00
Hyunyoung Song
d96e07035c Merge "Apply scrim protection to atomic state transition ALLAPPS -> NORMAL" into sc-v2-dev 2022-01-05 19:27:04 +00:00
TreeHugger Robot
58a8f3e508 Merge "Trace fold/unfold animation with atrace" 2022-01-05 18:13:41 +00:00
Hyunyoung Song
153cd69d14 Apply scrim protection to atomic state transition ALLAPPS -> NORMAL
Bug: 209480401

Test: manual, video attached on the bug

TL;DR;; minimized the delta for sc-v2

Change-Id: If8c9281bb4366540b9a4ea10a9b363ce82d78daf
2022-01-04 21:55:14 -08:00
Brian Isganitis
1ab5741b05 Merge "Avoid race condition with hotseat predictions." 2022-01-04 20:42:47 +00:00
Nicolo' Mazzucato
23a4275e1c Trace fold/unfold animation with atrace
This cl adds an always present listener to UnfoldTransitionProgressProvider to log a trace when the animation is running.

Bug: 203391751
Test: Traced with perfetto on top of this change and verified it is present as expected
Change-Id: I560c705795a37315bbdbdca0a1278bf7a2d99a64
2022-01-04 17:44:16 +01:00
TreeHugger Robot
59ebc0c3c9 Merge "Add ALLOW_SLIPPERY_TOUCHES to make StatusBarTouchController slippery" into sc-dev am: c0231f8d0f am: f58691ae42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16444734

Change-Id: Idd834fc5a587e2cdb3425612514efe54ece792cc
2021-12-23 07:15:54 +00:00