Commit Graph

7952 Commits

Author SHA1 Message Date
Vadim Tryshev
17839d5f62 Removing discovery bouncer from accessibility
It was obstructing views under it.

Solves both Talkback and Switch Access issues.

Bug: 80192025
Test: Manual
Change-Id: Ia7fad91e1fcb857afbf68f879550c670279cee68
2018-05-23 16:51:41 -07:00
TreeHugger Robot
39ac161095 Merge "Add mStartState to determine if user swipes up from Home." into ub-launcher3-edmonton 2018-05-23 17:57:58 +00:00
Jon Miranda
1d19e2f152 Start springs for All Apps when user flings up.
Bug: 77695481
Change-Id: Ifecfbbb89601947118f620f522662aee8a61946e
2018-05-23 09:13:07 -07:00
TreeHugger Robot
c0928c3ba0 Merge "Enable new open app transitions when in multiwindow mode." into ub-launcher3-edmonton 2018-05-23 00:35:22 +00:00
Jon Miranda
73c27ec176 Enable new open app transitions when in multiwindow mode.
Bug: 79118278
Change-Id: Iba79948256d70c913af0a9a584eb040f3a8b4151
2018-05-22 17:25:11 -07:00
Tracy Zhou
788c051493 Add mStartState to determine if user swipes up from Home.
Bug: 80146880
Test: Manual test
Change-Id: Ia0743bff3f2a5b3998a798743138b012ec461a94
2018-05-22 16:25:37 -07:00
TreeHugger Robot
5454fa1f6e Merge "Making caret visibility part of state definition" into ub-launcher3-edmonton 2018-05-22 23:08:42 +00:00
Sunny Goyal
56e1019e95 Making caret visibility part of state definition
> Hiding the caret in fast overview state
> Hiding caret in task swipe down interaction

Bug: 79700605
Change-Id: I984d535bc75802501e8aeb13c8f37387f331e5bc
2018-05-22 15:58:20 -07:00
Sunny Goyal
36b2fca3bd Merge "Reset the vertical progress when the discovery bounce is closed" into ub-launcher3-edmonton 2018-05-22 22:20:54 +00:00
TreeHugger Robot
085cebc741 Merge "Skip processing fallback icons as they are already badged and have shadow" into ub-launcher3-edmonton 2018-05-22 22:00:05 +00:00
TreeHugger Robot
d1134a0295 Merge "Making overview panel accessible via Tab" into ub-launcher3-edmonton 2018-05-22 22:00:02 +00:00
Vadim Tryshev
f1507a6a64 Making overview panel accessible via Tab
Keyboard navigation of AllAppsContainerView is broken in TOT; disabling
focusing there is necessary for Recents.

Bug: 72222505
Test: Manual
Change-Id: I85d544f7c8dbdaf12e49de51c6626bbc3dc32917
2018-05-22 14:47:44 -07:00
Sunny Goyal
0bd0244a73 Reset the vertical progress when the discovery bounce is closed
Since discovery bounce runs on absolute values, it can sometime leave the vertical progress
at an old value, if it is closed after the state change.
Also simplifying discovery bounce animation to use xml everytime.

Bug: 80099242
Change-Id: Iebc249dd02f474cbed85b695eeeb8c2bf60b935d
2018-05-22 11:40:58 -07:00
Tony Wickham
4e21c1b552 Cleanup how we set back button alpha
Add BackButtonAlphaHandler to set back button alpha, instead of setting
it from multiple places.

Also force back button alpha to be 1 if swipe up is disabled (b/80091187)

Change-Id: I49b63a0e6b033a3a947a847669a398f1b9ff0564
2018-05-22 11:05:01 -07:00
TreeHugger Robot
52cb0a73a4 Merge "Go back to previous state when hitting back from discovery bounce" into ub-launcher3-edmonton 2018-05-21 23:11:56 +00:00
Tony Wickham
52c1b66f46 Go back to previous state when hitting back from discovery bounce
Normally when you hit back, we just close the floating view if there
is one. This makes less sense for DiscoveryBounce, since it doesn't
feel like a different state even though it's technically a floating
view. So in that case, don't consume the back press; let launcher
handle it to go to the previous state.

Bug: 80075741
Change-Id: I7270b61be70509cb2101400a12929478a5d082aa
2018-05-21 16:01:49 -07:00
Hyunyoung Song
bd6fba9f58 onResume event should be logged (not twice but once)
Bug: 79541772

Change-Id: I5fe1271007e4579e1ec95d51c215ef48d0c6eedd
2018-05-21 12:27:46 -07:00
Tony Wickham
e542e91191 Merge "Cleanup UserManagerCompatVP to not use reflection" into ub-launcher3-edmonton 2018-05-21 18:18:47 +00:00
Tony Wickham
a9cc397673 Cleanup UserManagerCompatVP to not use reflection
Change-Id: I1e4afc9c36f9d8641799b70e83f6b9801aec2e3d
2018-05-21 10:54:09 -07:00
Tony Wickham
e2116daa88 Merge "Don't prevent animations in power save mode" into ub-launcher3-edmonton 2018-05-21 17:51:35 +00:00
Vadim Tryshev
98913d0c95 Remove code duplication
Bug: 72222505
Test: Manual
Change-Id: I6ae6ac7474b44c16bd765635e32d2e843bc02cac
2018-05-18 18:41:34 -07:00
Vadim Tryshev
4ae69dea49 Merge "Fixing reverted order of accessibility scrolling in Recents" into ub-launcher3-edmonton 2018-05-19 00:54:37 +00:00
Tony Wickham
8155fa2aa5 Don't prevent animations in power save mode
Now that batter saver mode doesn't get rid of animations in P, we
shouldn't use custom logic to prevent them either.

Also updated ATLEAST_P to use version code.

Bug: 79990054
Change-Id: If17cf369035c976f3d9d81f35432a045f1956ce5
2018-05-18 17:18:49 -07:00
Tony Wickham
f9d38098ca Merge "Fix a couple issues with swiping up from home" into ub-launcher3-edmonton 2018-05-18 16:50:47 +00:00
Matthew Ng
8b92fe336b Fade back button in and out tied with the overview/shelf (2/3)
Back button changes opacity when moving the shelf during swipe up
between home screen and overview. The alpha changes depending on the
progress of the swipe up animation. When going from app to home and vice
versa, the fade animation does not tie with the swipe up progress. The
fade animation also masks the back button drawable when ime visibility
changes.

Change-Id: I51e42930640ba711e81880b385bb722d7ee8ad33
Fixes: 74581837
Fixes: 76900236
Test: swipe up from home screen to overview
2018-05-18 00:48:51 +00:00
Tony Wickham
7de574175b Fix a couple issues with swiping up from home
- Don't update the animation to go from 0 to 1; instead, update the
  interpolator to clamp to the remaining progress (b/79773309)
- Fix NPE that can happen in a race between the atomic animation
  ending and the non-atomic animation canceling/ending

Change-Id: I313251dc5cbd7b931b043fc3e840bb4ab368a790
2018-05-17 16:30:46 -07:00
Sunny Goyal
fbf327f9ee Skip processing fallback icons as they are already badged and have shadow
Bug: 79496830
Change-Id: I3e601fda570eefdb277bfd50c846c5a2864f4b3a
2018-05-17 15:29:44 -07:00
TreeHugger Robot
48059dc706 Merge "Fixes a crash when turning off workprofile while the workprofile tab is active." into ub-launcher3-edmonton 2018-05-17 15:51:40 +00:00
Mario Bertschler
d460c084eb Fixes a crash when turning off workprofile while the workprofile tab is
active.

Bug: 79735930

Change-Id: Iafaddf827e648c9d39df78393a96f90dfc86fcca
2018-05-17 10:12:28 +02:00
Tony Wickham
b2ddf10041 Update interpolators and durations for state animations
When we enter overview (overview appears, workspace disappears):
- Workspace scales down from 1f to .8f with OvershootInterpolator(1.2f) at 200 ms
- Workspace fades from 1f to 0 with OvershootInterpolator(1.2f) at 200 ms
- Overview scales down from 1.33f to 1f with OvershootInterpolator(1.2f) at 200 ms
- Overview fades from 0 to 1f with OvershootInterpolator(1.2f) at 200 ms

When we exit overview (overview disappears, workspace appears):
- Workspace scales up from .92f to .1f with DecelerateInterpolator() at 200 ms
- Workspace fades from 0 to 1f with AccelerateInterpolator() at 200 ms
- Overview scales up from 1f to 1.1f with AccelerateInterpolator() at 180ms
- Overview fades from 1f to 0 with DecelerateInterpolator(1.7f) at 200 ms

Parallax while the finger moves: Workspace translates half the distance as the shelf

Bug: 79776746
Change-Id: I319d982cf202bcd6dbbcd68ffc5c0c7853629c7e
2018-05-16 15:59:31 -07:00
TreeHugger Robot
07b8b0b1f0 Merge "Fix bug where Workspace page alpha stays 0 in SpringLoaded mode." into ub-launcher3-edmonton 2018-05-16 22:51:44 +00:00
Jon Miranda
8d994cd6d5 Fix bug where Workspace page alpha stays 0 in SpringLoaded mode.
The page alpha gets set to 0 by updatePageAlphaValues sometime between
Workspace calling goToState(SPRING_LOADED) and onStartStateTransition.

By the time the transition is over, Workspace is no longer in a modal state
and so alpha never gets restored via updatePageAlphaValues.

Bug: 76449277
Change-Id: I95241395594dd9084763cc3bc51bc55319cadb73
2018-05-16 15:32:54 -07:00
Tony Wickham
2c27df5b5d Merge "Set status bar icons to dark at correct all apps progress" into ub-launcher3-edmonton 2018-05-16 22:23:50 +00:00
Vadim Tryshev
e628c474ea Fixing Recents sometimes restoring in Clear-all-reveal position.
This happened if a task was added between openings of Recents.

Bug: 72222505
Test: Manual
Change-Id: Id4cc8e7cbdb493973d329466369b62e4ac8ee0b3
2018-05-16 15:00:52 -07:00
Tony Wickham
77bf622c01 Merge "Make fling thresholds consistent" into ub-launcher3-edmonton 2018-05-16 21:55:41 +00:00
Tony Wickham
ec62522682 Set status bar icons to dark at correct all apps progress
Bug: 79866102
Change-Id: I8c97896319406c8360a2f60d213868ad59dafe19
2018-05-16 14:27:49 -07:00
Tony Wickham
0f640b6c1b Make fling thresholds consistent
There are 3 places we can block a fling:
- Swiping from home to all apps (through overview)
- Swiping from an app to all apps (through overview)
- Dismissing a task (in the same gesture that started by swiping down)

In all of these cases, we block the fling when crossing the threshold
to a new state (e.g. OVERVIEW), but unblock if the user pauses their
drag. With this change, the logic is consistent:
- Unblock the fling after pausing a short amount of time
- If a fling was blocked, increase the settling duration based on
  velocity

Bug: 78089840
Bug: 78658678
Change-Id: I5ef52b74229418b867b26c3c6d3db2cf6e48914b
2018-05-16 13:47:20 -07:00
Sunny Goyal
de75321542 Fixing wrong accessibility focus when opening a floating view
> Using common logic for announcing a floating view for widgets and folders

Bug: 79091095
Bug: 79748886
Change-Id: Ibb3fe48e68e724f50d69f51a03d3b35ad0baf625
2018-05-16 13:11:00 -07:00
Sunny Goyal
9638caf6e4 Merge "Dumping the excoded view hierarchy instead of the default activity dump" into ub-launcher3-edmonton 2018-05-16 19:57:05 +00:00
TreeHugger Robot
0b1174ddbe Merge "Adding Clear All to accessibility chevron on Recents" into ub-launcher3-edmonton 2018-05-16 19:12:00 +00:00
Vadim Tryshev
3f51631b80 Adding Clear All to accessibility chevron on Recents
For motivation, see email thread "Tweaks to for the reverted order of
accessibility swiping"

This doesn't add the action to the fallback Recents, so it will require
more work.

Bug: 79165501
Test: Manual
Change-Id: I99d608ccc13cc1742dc4d427e763125788e8edd2
2018-05-16 12:00:33 -07:00
Hyunyoung Song
1241e61a45 Improve Task user event logging
Bug: 79539824
Bug: 79541772

(1) Added page index of the TASK that is being launched
(2) Covers all three cases of task launch (tap, swipe down, quick scrub)
UserEvent: action:FLING direction=DOWN
UserEvent:  Source child:TASK, packageHash=-1598699687, componentHash=1952702153, pageIdx=0

UserEvent: action:DRAGDROP
UserEvent:  Source child:TASK, packageHash=-744307622, componentHash=-515832044, pageIdx=4

(3) Avoid double logging (When onStop is called, it is not logged if
the cause of onStop is APP or TASK launch)

Change-Id: Ic5db7d6a640d43bfb5cd667b49e37dd0ed127d5c
2018-05-16 11:26:35 -07:00
Sunny Goyal
55eb556a4b Dumping the excoded view hierarchy instead of the default activity dump
> Encoded hierarchy is smaller is size and has a lot more information about the views

Bug: 79861035
Change-Id: I84316b1b0031282b0579f3aaac22d8d8f00d8bcb
2018-05-16 10:55:21 -07:00
Hyunyoung Song
61745e17c7 Merge "Add logging for Onboarding Bug: 73784423" into ub-launcher3-edmonton 2018-05-15 21:48:06 +00:00
Tony Wickham
46afdf5194 Merge "Tune quick scrub" into ub-launcher3-edmonton 2018-05-15 21:34:34 +00:00
Hyunyoung Song
018eec6899 Add logging for Onboarding
Bug: 73784423

* Discovery bounce, homescreen, hotseat
UserEvent: action:TIP
UserEvent:  Source child:HOTSEAT id=0 BOUNCE

* Discovery bounce, overview, prediction
UserEvent: action:TIP
UserEvent:  Source child:PREDICTION BOUNCE

* Swipe up from navbar text (visibility, cancel target)
UserEvent: action:TIP
UserEvent:  Source child:TIP SWIPE_UP_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET SWIPE_UP_TEXT

* Quickscrub text (visibility, cancel target)
UserEvent: action:TIP
UserEvent:  Source child:TIP QUICK_SCRUB_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET QUICK_SCRUB_TEXT

* Prediction apps text (visibility, cancel target)
UserEvent: action:TAP
UserEvent:  Source child:TIP PREDICTION_TEXT

UserEvent: action:TAP
UserEvent:  Source child:CANCEL_TARGET PREDICTION_TEXT

Change-Id: I94710b5ed3d00e3599985b154eb660af4a958288
2018-05-15 14:31:07 -07:00
Tony Wickham
d58c2d5a48 Tune quick scrub
- Change durations/interpolators when starting from home vs an app
- Increase dim animation duration after quick scrub from an app
  - Also fixed contention between setting dim alpha for the animation
    and setting dim alpha for scrolling
Change-Id: I2c9ea52d4eafaad8954f3ff9d3c0c459a07953bc
2018-05-15 11:49:09 -07:00
Vadim Tryshev
3154cd16b0 Keep clear-all button revealed after dismiss
If it was visible before the dismiss, it will be visible after that.
As a nice side effect, it will preserve visibility on any layout, say,
after a rotation.

Bug: 79117932
Test: Manual
Change-Id: Ia8a544af1326458d4e2d7a07ae2b668f604bc0b3
2018-05-15 11:28:24 -07:00
TreeHugger Robot
c14adabe99 Merge "Scrolling on the most recent task upon Overview start" into ub-launcher3-edmonton 2018-05-15 17:47:50 +00:00
Sunny Goyal
ff102be52b Merge "Showing the caret/drag handle in transposed layout" into ub-launcher3-edmonton 2018-05-15 17:25:04 +00:00