Commit Graph

13487 Commits

Author SHA1 Message Date
Treehugger Robot
de35987f27 Merge "Stub impl new multi-desks IDesktopTaskListener APIs" into main 2025-02-05 17:18:46 -08:00
Treehugger Robot
8e5b44ad9c Merge "Introduce non-null itemInfo inside TaskView" into main 2025-02-05 15:09:39 -08:00
Treehugger Robot
19d46bede8 Merge "[CD Taskbar] New NavigationBarPanelContext per instance of taskbar" into main 2025-02-05 12:47:18 -08:00
minch
32321ddf56 Introduce non-null itemInfo inside TaskView
Let `TaskView` have a non-null `itemInfo` even it has no
tasks (no corresponding TaskContainer). Thus, we can still
go forward to log the necessary info of the `TaskView`
without any tasks.

Flag: EXEMPT refactor
Fix: 391918297
Test: TaskViewItemInfoTest
Change-Id: Idd08eb9846b1cd2043dd0087bc3e0078bb0b8247
2025-02-05 17:57:45 +00:00
Ahmed Fakhry
ea066cdc65 Stub impl new multi-desks IDesktopTaskListener APIs
This CL chain adds the new multi-desks APIs in `IDesktopTaskListener`
and a stub implementation in
`DesktopVisibilityController.DesktopTaskListenerImpl`.
Follow-up CLs will add the real impls.

Bug: 392978600
Test: m
Flag: EXEMPT new APIs without impl yet.
Change-Id: I360ef179769df16dbcf12a01d19d57a88bc82262
2025-02-05 17:48:12 +00:00
Jordan Silva
564d64c8cc Refactor: Update the way tintAmount is propagated to TTV
- Propagate the tintAmount using the Views instead of using a Flow.

This was done to minimize the usage of Flows to propagate animations
and progress through Views. It should improve the overall performance
of UI updates

Some stats about the number of collections:
- Entering Overview: ~4 collections
- Displaying Scrim: ~32 collections
- Hiding Scrim: ~35 collections
- With 4 apps on screen: ~140 collections

Bug: 390581380
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest
Test: TaskViewModelTest
Change-Id: Ice68edef12c7e3b2a26107b0fc6e62578de241b4
2025-02-05 15:25:59 +00:00
Jordan Silva
bc124b18b8 Remove fullscreenProgress that is not being used
This flow was previously collected by TTVM and later removed by ag/30431716.

Bug: 390581380
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest
Change-Id: Ie0add87740b00da7d1c5e61c048dace543c47a66
2025-02-05 14:55:08 +00:00
Sukesh Ram
5d8e6bcdee [CD Taskbar] New NavigationBarPanelContext per instance of taskbar
Create a new New NavigationBarPanelContext per instance of taskbar object for each new instance of taskbar.

Test: m
Bug: 394421505
Flag: EXEMPT not adding new behavior
Change-Id: I6c82140fac9e6a00f0462ea1a593c13f49c3deee
2025-02-04 18:08:25 -08:00
Lingyu Feng
c36a10604c Merge "Remove unused executeForTouchInteractionService() in TouchInteractionService" into main 2025-02-04 18:07:28 -08:00
Roy Chou
5c4bb0b8ce Merge "chore(magnification): remove the PRIVATE_FLAG_EXCLUDE_FROM_SCREEN_MAGNIFICATION window flag usage in Launcher app" into main 2025-02-04 17:11:34 -08:00
Treehugger Robot
3b11538381 Merge "Simplifying some ActivityContext and StateManager methods" into main 2025-02-04 12:16:44 -08:00
Brandon Dayauon
a0f2b0eeb0 Merge "Log work scheduler animation jank" into main 2025-02-04 10:52:19 -08:00
Sunny Goyal
1ada394e00 Simplifying some ActivityContext and StateManager methods
> Merging asContext and getContext meethod
> Simplifying some generic declaration in StateManager

Bug: 393703968
Flag: EXEMPT refactor
Test: Compilation
Change-Id: I679ac83e39b2a17f510698db15335aae8f735aad
2025-02-04 10:11:34 -08:00
Treehugger Robot
d3b31eb20d Merge "Removing BaseDraggingActivity > Merging come methods to BaseActivtiy > Separating wallpaper theme implementation to an independent class" into main 2025-02-04 09:29:46 -08:00
Artsiom Mitrokhin
49909b5167 Merge "Fix taskbar flickering when clicking its bottom part" into main 2025-02-04 07:02:48 -08:00
Pat Manning
8e7130d364 Merge "Refactor TaskViewTouchController to separately handle dismiss and launch." into main 2025-02-04 03:47:03 -08:00
Lingyu Feng
9a6a1fc4e0 Remove unused executeForTouchInteractionService() in TouchInteractionService
This CL replaces
executeForTouchInteractionService(tis -> executeForTaskbarManager()) with
executeForTaskbarManager() in TouchInteractionService, as `tis` is unused.

Bug: 391786915
Test: m
Flag: EXEMPT refactor
Change-Id: I573a1717aa237f5870157ed95fec4f864a669322
2025-02-04 12:03:40 +09:00
Sunny Goyal
edc1453cf1 Removing BaseDraggingActivity
> Merging come methods to BaseActivtiy
> Separating wallpaper theme implementation to an independent class

Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I8cdb6d1520beff3f8226b62c5b7eafd48b2c674f
2025-02-03 17:23:10 -08:00
Sunny Goyal
e5ab5669f7 Only accessing themeManager once the device is unlocked
Bug: 393248495
Test: atest RecentsModelTest
Flag: EXEMPT bugfix
Change-Id: I0f2868055de73c25b3eef9243ef0fccbf0383ad5
2025-02-03 16:10:52 -08:00
Brandon Dayauon
302f75ce69 Log work scheduler animation jank
bug: 392726070
Test: manual - see bug comment that shows capture perfetto
Flag: com.android.launcher3.work_scheduler_in_work_profile
Change-Id: Iebf873229a86b53062a91a58bec173c46c964ed5
2025-02-03 23:58:42 +00:00
Pat Manning
c824545d07 Refactor TaskViewTouchController to separately handle dismiss and launch.
Remove use of PendingAnimation for task dismiss.

Fix: 389080698
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ifdfd7d8ef78bba5d10ff6f157635430637805584
2025-02-03 19:46:52 +00:00
Shamali Patwa
a398bf4dc4 Merge "Support exclusion widget category filter in the widget picker" into main 2025-02-03 11:28:41 -08:00
Jeremy Sim
933c73ea0b Merge "Fix bug with app pair 10:90 launch" into main 2025-02-03 11:06:36 -08:00
Shamali P
2e1b51c54b Support exclusion widget category filter in the widget picker
The newly added NOT_KEYGUARD category enables hosts that shows all
widgets to let widgets opt out from being displayed in keyguard like
surfaces.

Bug: 394047125
Test: Unit tests and support app
Flag: EXEMPT bugfix

Change-Id: Ibaab0c8a052700b77289cd571bca33e3d96fa09f
2025-02-03 14:33:20 +00:00
Jordan Silva
d4ae2b1b8f Log TaskThumbnailView state changes with task ID and view hashcode
Fix: 392417881
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual.
Change-Id: I17c63afb106e66d87882618580eebd5105d1cb4d
2025-02-03 13:38:37 +00:00
Alex Chau
11c035cb2f Merge "Consider tasks with INVALID_DISPLAY as it's on DEFAULT_DISPLAY" into main 2025-02-03 02:06:51 -08:00
Alex Chau
5ab6c2e68a Consider tasks with INVALID_DISPLAY as it's on DEFAULT_DISPLAY
- In the test environment, some main display tasks can have INVALID_DISPLAY (-1) as their displayId, we should consider them as main display tasks or else they'll be sorted to an unexpected section in RecentsView

Bug: 391311008
Test: TaplTestsQuickstep#testQuickSwitchFromHome
Flag: com.android.launcher3.enable_separate_external_display_tasks
Change-Id: I5a89d91e342557e114eae6796e153a160d729301
2025-02-01 10:01:44 +00:00
Treehugger Robot
5c11f67ca3 Merge "[CD Taskbar] Refactor TaskbarManager - Make Window Contexts also follow map pattern" into main 2025-01-31 18:02:23 -08:00
Jeremy Sim
bc6df4af71 Fix bug with app pair 10:90 launch
Small fix for supporting the 10:90 split ratio. Previously, we detected the leftTop app by checking for left == 0 or top == 0; this led to a crash on app pair launch for 10:90 because, for example, the left pair's left bound was negative. Now we check for left <= 0 or top <= 0 instead.

Bug: 391866990
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: Visually correct when a 90:10 pair goes to recents and back
Change-Id: Ie22c12ea547b6d2dfeea4570ec32a79040cc45c2
2025-01-31 16:37:36 -08:00
Sukesh Ram
2f74082b3b [CD Taskbar] Refactor TaskbarManager - Make Window Contexts also follow map pattern
Make Window Contexts also follow map pattern.

Flag: EXEMPT not adding new behavior
Bug: 391706879
Test: Manual
Change-Id: Ib0672e653b9dbfcb3597210ca244f110515cd4dc
2025-01-31 21:53:46 +00:00
Treehugger Robot
634c3a0f8f Merge changes I8af39b58,I9a3e8ee2 into main
* changes:
  Finally remove `task1` and `task2` from `GroupTask`
  Remove `GroupTask.mSplitBounds`
2025-01-31 11:51:02 -08:00
Treehugger Robot
340720e8a7 Merge "Remove all external usages of GroupTask.task1/2 from Launcher3" into main 2025-01-31 11:42:55 -08:00
Ahmed Fakhry
129a3a0097 Finally remove task1 and task2 from GroupTask
See go/refactor-group-task for details. This is the final CL
in this refactor, where `task1` and `task2` are finally removed,
and `DesktopTask` is allowed to have empty tasks.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I8af39b58138f11030981311efc2e95a77cef125b
2025-01-31 17:14:46 +00:00
Ahmed Fakhry
c590a62c80 Remove GroupTask.mSplitBounds
See go/refactor-group-task for details. This CL removes `mSplitBounds`
from `GroupTask` and adds `splitBounds` to `SplitTask`. This makes its
usages more intentional.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I9a3e8ee2e96d46f9eb79a58ffcf5efc257615aac
2025-01-31 17:14:46 +00:00
Ahmed Fakhry
b6ecf5889e Remove all external usages of GroupTask.task1/2 from Launcher3
See go/refactor-group-task for details. This CL removes all the usages
of `task1` and `task2` from `GroupTask` in Launcher3. Follow-up CLs will
remove it from NexusLauncher and remove the fields altogether.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I902c8135b3a0aae95acf25267b3bcbf286bd4e7d
2025-01-31 17:14:44 +00:00
samcackett
5df5144b45 Add task menu shortcut for closing apps
Fix: 383977717
Test: OverviewMenuImageTest
Flag: EXEMPT bugfix

Change-Id: I24338a821e1ec9be21d22a5d1c4295dd6e28d13d
2025-01-31 08:37:18 -08:00
Treehugger Robot
dfa11eb35e Merge "Not calling updateCallback in constructor as it can cause initialization error" into main 2025-01-30 20:36:38 -08:00
Sunny Goyal
430fd3104f Not calling updateCallback in constructor as it can cause initialization error
Bug: 390930809
Flag: EXEMPT bugfix
Test: atest ActiveTrackpadListTest
Change-Id: Ifb14e2949f1f399fbb8b63f493f96d0dd54cc081
2025-01-30 13:25:04 -08:00
minch
353e0ed184 Introduce leftTop and rightBottom TaskContainer to GroupedTaskView
Flag: EXEMPT refactor
Bug: 391918297
Test: m
Change-Id: Id00dc0769e0a38311d203f14f90a7184e0f2f6e7
2025-01-30 18:25:45 +00:00
minch
dbdf49726f Refactor TaskView to allow no TaskContainers
Flag: EXEMPT refactor
Bug: 391918297
Test: m
Change-Id: I3343da2b6d73a0b0283334a37be5ae288d94f776
2025-01-30 18:23:57 +00:00
Artsiom Mitrokhin
371168b5e6 Fix taskbar flickering when clicking its bottom part
Using `MAIN_EXECUTOR.execute` caused the callback to sometimes
be postponed and executed out of order of other callbacks scheduled
using `Utilities.postAsyncCallback` (which uses asynchronous
messages instead [1]).

See detailed explanation in http://b/382015083#comment7.

[1] https://developer.android.com/reference/android/os/Message#setAsynchronous(boolean)

Bug: 382015083
Flag: EXEMPT bugfix
Test: manual
Change-Id: I409cf668764ffc8f7ba19b8c5e29426464ed6142
2025-01-30 06:58:53 -08:00
Treehugger Robot
4a17c7ab0d Merge "Move SimpleOrientationTouchTransformer to Dagger." into main 2025-01-29 19:42:42 -08:00
Lingyu Feng
b06120f793 Merge "Rename onDisplayReady to onDisplayAddSystemDecorations" into main 2025-01-29 17:24:01 -08:00
Anushree Ganjam
4597aae947 Move SimpleOrientationTouchTransformer to Dagger.
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I2c7adf5da76f0a60c167f4c650622ba8dfeac98d
2025-01-29 17:15:03 -08:00
Treehugger Robot
473bd5c0a0 Merge "Unifying various model update callbacks into one" into main 2025-01-29 16:05:25 -08:00
Treehugger Robot
a804d02912 Merge "Refactor: Extract Thumbnail and sysUiStatusNavFlags from TaskContainerVM" into main 2025-01-29 12:04:37 -08:00
Treehugger Robot
66e62820bc Merge "Add debugging logs to understand why addView gets IllegalArgumentException" into main 2025-01-29 10:58:19 -08:00
Sunny Goyal
e1e6f7a024 Merge "Using roundIconRes for loading appInfo icon if launcher's icon is round" into main 2025-01-29 10:51:09 -08:00
Sunny Goyal
8141a71281 Merge "Fixing icon shape not properly clipped" into main 2025-01-29 10:43:46 -08:00
Jordan Silva
39549a3843 Refactor: Extract Thumbnail and sysUiStatusNavFlags from TaskContainerVM
Moves the sysUiStatusNavFlags from TaskContainer to TaskView to align it
 with the new thumbnail architecture. This change allows for better
 management and access of this information within the TaskView.

Bug: 390581380
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: GetSysUiStatusNavFlagsUseCaseTest
Test: GetTaskUseCaseTest
Test: TaskUiStateMapperTest
Test: TaskViewModelTest
Change-Id: Ic285e41620350dbd3e975b6223e6b7d4cd62d3c0
2025-01-29 17:57:18 +00:00