Commit Graph

9491 Commits

Author SHA1 Message Date
Yogisha Dixit
f9acf1d5d4 Merge "Log widgets source." into sc-dev 2021-06-30 18:18:12 +00:00
Yogisha Dixit
658c5dafd4 Log widgets source.
Test: manual
(1) Upgrading to new DB version is successful (no errors thrown in logcat)
(2) Widgets that were added with the old DB version have CONTAINER_UNKNOWN as their source container
(3) Widgets that are added with the new DB version still log source container after reboot
Bug: 185778648
Change-Id: Iaa38f0be6bc4cb0d29842f9a2ea0d08de000c930
2021-06-30 17:48:14 +00:00
Cyrus Boadway
0d96baec13 Defer onColorsChanged updates during widget-to-home animation
Color change updates recreate the view, which can interfere with the
widget-to-home return animation, specifically the GhostView's use of the
AppWidgetHostView's render node.

Deferring the application of color changes until the end of the
animation allows the widget to settle and remove the GhostView before a
color change might recreate the widget's view.

Bug: 190818220
Test: manual
Change-Id: I6552e583ebb0e4810077d4e70fe9ecb07fd5d01a
2021-06-30 13:10:02 +00:00
Hyunyoung Song
77c532d799 Merge "Rebind recycler views if launcher activity restarted" into sc-dev 2021-06-30 04:00:23 +00:00
Jonathan Miranda
26a485bb2a Merge "Set elevation of popup and arrow to match. This ensures no shadow overlap." into sc-dev 2021-06-30 02:56:18 +00:00
Steven Ng
d35dcdec05 Merge "Use category icon for pending conversation widgets" into sc-dev 2021-06-29 23:15:04 +00:00
Jonathan Miranda
1b6a8b2255 Merge "Fix bug where status bar was not set properly." into sc-dev 2021-06-29 23:03:15 +00:00
Jon Miranda
fa73c02172 Set elevation of popup and arrow to match. This ensures no shadow overlap.
Bug: 191823198
Test: long press app where arrow is on top and bottom in:
      workspace, all apps, and search UI

Change-Id: Icc4ac259607175d5e12447a844ba166ba28b74af
2021-06-29 15:49:46 -07:00
Hyunyoung Song
0b9537e6fc Rebind recycler views if launcher activity restarted
Bug: 185038312
Test: manual
TL;DR;;
What was attempted but was too much refactoring of the code.

Failed attempt #1: try re triggering the search.
This was not trivial as SearchSession object is yet created.

Failed attempt #2: Restoring AdapterItems in AlphabeticalAppsList
This meant AdapterItems class and also it's children
had to extend Parceleable object.

Ultimate fix:
Original issue of dupe view id among slice and work recyclerview
should be fixed. And restoring should just work.

Change-Id: I1bddd6aa5bc736ade3b02f69aa947d64cfa467d6
2021-06-29 14:52:57 -07:00
Jon Miranda
401b921c19 Fix bug where status bar was not set properly.
- Need to check both alpha of the view, and alpha of the background color.

Bug: 187467559
Test: check status bar colors when using:
      - on white wallpaper,
      - on black wallpaper,
      - on wallpaper with white text
      - on wallpaper with dark text

Change-Id: Ie6f34d34dfa9dea716f95bd6a95125fbd650fc29
2021-06-29 14:23:55 -07:00
Yogisha Dixit
419ee4599e Merge "Show resize frame when widget is added." into sc-dev 2021-06-29 21:07:34 +00:00
Samuel Fufa
48ec126d8b Merge "Update snackbar color" into sc-dev 2021-06-29 18:48:38 +00:00
Alina Zaidi
7ed32025f1 Merge "Make sure search recycler view is bound to fast scroller if user is in search mode at the time of attachment of work/personal recycler view." into sc-dev 2021-06-29 18:13:23 +00:00
Yogisha Dixit
037a5362d8 Show resize frame when widget is added.
I referenced the code in Workspace.java that updates the widget view's
layout params before showing the resize frame.

Test: manual, AddWidgetTest and AddConfigWidgetTest tapl tests
Bug: 183437963
Change-Id: I6655917878fa22d6084b4bf39fc0661e7278d6f9
2021-06-29 18:25:38 +01:00
Steven Ng
12f7a59e5c Use category icon for pending conversation widgets
Fix: 192333050
Test: Manual
Change-Id: Ie3895cd4747f1bec1c8ca9af82347bb0eafa7415
2021-06-29 18:04:09 +01:00
Alina Zaidi
57973c328a Make sure search recycler view is bound to fast scroller if user is
in search mode at the time of attachment of work/personal recycler view.

Bug: 191980945
Test: Tested manually.
1) Open widget picker, scroll.
2) Enable dark mode, scroll.
3) Type search query, scroll.
4) Disable dark mode, scroll.
5) Have work profile in phone and repeat the above with work tab open
and search.

Change-Id: I106717091a88868c4bbe3fad0dd71c8344e9c8ed
2021-06-29 16:32:32 +01:00
Steven Ng
9bb83f65cb Merge "Set the widget preview title a11y text to "{widget name} widget"" into sc-dev 2021-06-29 14:25:13 +00:00
Steven Ng
85486d1c2c Set the widget preview title a11y text to "{widget name} widget"
Fix: 187376680
Test: Manual
Change-Id: I211d8e2b437091808d1f5a764075af4c3832ef48
2021-06-29 12:12:43 +01:00
Steven Ng
9f2674b6a9 Merge "Extract common measurement in widgets pickers to its base class" into sc-dev 2021-06-29 10:45:58 +00:00
Yogisha Dixit
9b8932f579 Merge "Don't show resize handle if widget cannot be resized." into sc-dev 2021-06-29 09:59:40 +00:00
Yogisha Dixit
ad68318048 Don't show resize handle if widget cannot be resized.
Test: manual
Bug: 190015493
Change-Id: Ibb0cc347103b8d01d30a19925f929617426e4889
2021-06-29 09:08:09 +01:00
Jonathan Miranda
fab44042cb Merge "Ensure iconScale never exceeds 1." into sc-dev 2021-06-29 02:12:56 +00:00
Hyunyoung Song
40c4d5fc4a Merge "RecyclerView Scrollbar is easier to target" into sc-dev 2021-06-29 00:08:52 +00:00
Sunny Goyal
2d6d8f890a Merge "Remove expensive logging." into sc-dev 2021-06-29 00:05:12 +00:00
Hyunyoung Song
c2e05c1df5 Merge "Don't use ProxyActivity when launching from SearchActionItemInfo intent" into sc-dev 2021-06-28 23:58:46 +00:00
Jon Miranda
ab3c681df8 Ensure iconScale never exceeds 1.
The rest of the scaled values should scale accordingly.

Bug: 190777089
Test: manual
Change-Id: I97f1724b7e96eea3ad81c295a98ccb71da756abb
2021-06-28 16:55:10 -07:00
Samuel Fufa
f6b7b17fa3 Update snackbar color
Bug: 184369338
Test: local
Change-Id: Id43b0957693d94236a3b6771b9ed881222c0e2b2
2021-06-28 15:28:52 -05:00
Steven Ng
c9d5391bf2 Merge "Refine all apps tabs alignment & remove ripple effect from tabs" into sc-dev 2021-06-28 16:38:50 +00:00
Steven Ng
fbe1836627 Extract common measurement in widgets pickers to its base class
Bug: 191644950
Test: 1. Open the full widget picker. Observe the clock widgets'
         previews are shown properly. Then, rotate the screen and
         observe the clock widgets' previews are shown properly.
      2. Open the bottom widgets picker for clock. Observe the
         clock widgets' previews are shown properly. Then, rotate
         the screen and observe the clock widgets' previews are shown
         properly.
      3. Repeat 1, 2 after changing the system navigation from button
         to gesture.
Change-Id: I564fc2ce0baf3103ae77499380ad69ec38ac6930
2021-06-28 14:55:27 +01:00
Hyunyoung Song
878dedfb84 Don't use ProxyActivity when launching from SearchActionItemInfo intent
Bug: 188490184
Test: Manual
Change-Id: I9b1b17dfb7e896025a01245414cdab11cf3125cb
2021-06-28 06:34:48 -07:00
Hyunyoung Song
58f49418ff RecyclerView Scrollbar is easier to target
Bug: 191666122
Test: manual

TL;DR;;
1) Allow some x offset when determining touch points are hitting the track
2) reduce the timeout to consider dragging state

Change-Id: Iebcbbbd1e50b602119795c57fc04c4c2a5ccdde5
2021-06-27 22:57:55 -07:00
Steven Ng
bf60673bbb Merge "Fix rounded corners for shortcut & generated preview shadow box" into sc-dev 2021-06-26 22:38:51 +00:00
Steven Ng
57072af106 Merge "Refine widgets removal logging" into sc-dev 2021-06-26 22:37:35 +00:00
Hyunyoung Song
24c8ebd88d Merge "When KEYCODE_BACK is received, hide keyboard" into sc-dev 2021-06-26 20:08:55 +00:00
Alina Zaidi
50401e31bd Merge "Compare maxSpanSize for WidgetsListContentEntries when updating visible entries in widget picker." into sc-dev 2021-06-26 18:04:19 +00:00
Alina Zaidi
57cdcceb07 Merge "Remove scrim from navigation bar from full widget picker." into sc-dev 2021-06-26 18:01:23 +00:00
Jonathan Miranda
7a582f2d7d Merge "Update colors for non-v31 devices." into sc-dev 2021-06-26 00:09:59 +00:00
Jonathan Miranda
48dbfcd1c8 Merge "Fix folder icon text alignment." into sc-dev 2021-06-25 22:31:46 +00:00
Schneider Victor-tulias
9617332f60 Remove expensive logging.
Removed expensive logs added for debugging. Removed unused code.

Fixes: 168788486
Test: none
Change-Id: I0579275633361d2d67399c773e6376af74c9f1b1
2021-06-25 11:48:15 -07:00
Jon Miranda
2be425b6b0 Fix folder icon text alignment.
- We set the parent view padding to be cellYPadding, so we no longer need to
  account for it when setting the text LayoutParams.

Bug: 191954558
Test: grid where scalableGrid=true and scalableGrid=false (4x5, and 5x5)
Change-Id: I8d7578b2589f801ceef229b663446d868d135ad0
2021-06-25 10:33:20 -07:00
Hilary Huo
7a5a96ea73 Merge "[settings-pixel-search] Flag guard slice logging." into sc-dev 2021-06-25 16:54:59 +00:00
TreeHugger Robot
1491ec31c5 Merge "Update widget manipulation colors." into sc-dev 2021-06-25 15:18:45 +00:00
Alina Zaidi
0b320545f8 Compare maxSpanSize for WidgetsListContentEntries when updating visible
entries in widget picker.

This is so that widgets are rearranged according to maxSpanSize in
widget table

Bug: 191336852
Test: Manually rotated widget picker with one of the headers expanded
and checked that widgets in widget table adjust according to screen's
horizontal size.

Change-Id: I2406ca9eccd18f4bb32b396acaa188c37f0059ee
2021-06-25 13:46:03 +01:00
Steven Ng
acd9d79932 Refine widgets removal logging
Test: N/A
Bug: 190565858
Change-Id: I7fb20eaf727db19787fa9b1fb36eeb5d1392e50c
2021-06-25 11:51:44 +01:00
Pinyao Ting
bbb9a9c033 Extra logging related to widget removal upon restore
As observed in b/187799223, widgets are removed after restore. We cannot
identify the root cause from the bugreport. This CL includes more
logging in the hope of identifying the root cause.

Bug: 18779922
Bug: 190565858
Test: manual
Change-Id: Ibdc9876716028592d17beac4542e1d8c498f9e4c
(cherry picked from commit 655ac082c2)
2021-06-25 09:22:33 +00:00
Yogisha Dixit
c0ac1dda74 Update widget manipulation colors.
Spec:
* Resize frame: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.OeO4S0j
* Drop target bar: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Test: manual
Bug: 187910396
Change-Id: I6fd433796970c428841ee96e45ee4fca1ded3665
Merged-In: I6fd433796970c428841ee96e45ee4fca1ded3665
2021-06-25 08:43:29 +00:00
Hyunyoung Song
011f438c97 When KEYCODE_BACK is received, hide keyboard
Bug: 191845409
Bug: 190351740

Test: manual
Change-Id: I9e3a55f7eb81b2c2a668532ebb991cefbf248163
2021-06-25 01:28:27 -07:00
Hilary Huo
b4538d1ef4 [settings-pixel-search] Flag guard slice logging.
Test: m
Bug: 191297465
Change-Id: I3f5f1ef5ad295e5d8ccedac00f290080653df5a3
2021-06-24 16:08:09 -07:00
Jonathan Miranda
a754e678a7 Merge "Move qsb according to spec." into sc-dev 2021-06-24 21:14:11 +00:00
Steven Ng
3ff0ee1a95 Fix rounded corners for shortcut & generated preview shadow box
Test: Open the widgets picker and locate shortcuts. Rounded corners are
      rendered on the rectangular box of a shortcut
Fix: 191948061
Change-Id: I24e4dc4c4a9c9c7e875444db5294f6c33f50db85
2021-06-24 21:17:13 +01:00