Commit Graph

458 Commits

Author SHA1 Message Date
Sunny Goyal
0d77cd7166 Merge "Removing unnecessary RemoteAnimationTargetCompat" 2022-10-24 17:16:49 +00:00
Riddle Hsu
7708b315e1 Merge "Attempt to reduce flakiness of testDisableRotationCheckForPhone" 2022-10-24 01:03:28 +00:00
Sunny Goyal
a18e285fe7 Removing unnecessary RemoteAnimationTargetCompat
Bug: 221961069
Test: Presubmit
Change-Id: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
2022-10-20 16:25:21 +00:00
Sunny Goyal
361da47493 Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev am: d79f84fffe am: cc6290d81f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20215466

Change-Id: Iee38fc975ce911b3a0fa3b43a97047dd094ce956
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 01:33:32 +00:00
Riddle Hsu
053f5910cb Attempt to reduce flakiness of testDisableRotationCheckForPhone
The request setOrientationLeft() is async that puts the target
rotation to setting. So the actual display rotation change may
happen when executing goHome(). Then the swipe gesture may be
interrupted that causes the test to fail.

Add a condition to wait for leaving natural orientation change
before calling goHome(). Also reorder and simplify the way to
start test activity to reduce execution time.

Bug: 253290379
Test: TaplTestsQuickstep#testDisableRotationCheckForPhone
Change-Id: I881d6f666c98fd3fe601b874adb0d14122bff2b7
2022-10-19 20:51:12 +08:00
Sunny Goyal
dd11f089cc Revert "Revert "Using Transaction directly instead of building s..."
Revert^2 "Removing unused surface transaction wrappers"

2460910c8c454bc2d3c9ae35bd32eeb590851788

Bug: 221961069
Test: Presubmit
Change-Id: I0028c9fe0de6fde6a77de84e4858fda14cd578dd
2022-10-18 16:30:26 +00:00
Vinit Nayak
d6c5147524 Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
Merged-In: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-17 13:59:18 -07:00
Vinit Nayak
391b79c084 Merge "Landscape 3 button nav on taskbar phone supported" 2022-10-17 20:14:36 +00:00
Vinit Nayak
831a4f0e1d Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-13 23:22:38 +00:00
Yein Jo
632468dc00 Merge "Revert "Enable Shell Transitions"" 2022-10-12 21:00:05 +00:00
Yein Jo
2be4e88eda Revert "Enable Shell Transitions"
Revert "Enable Shell Transitions"

Revert "Enable Shell Transitions"

Revert "Enable Shell Transitions"

Revert submission 19199517-enable_shell_transit

Reason for revert: DroidMonitor-triggered revert due to breakage, bug b/253049434 b/253109117 b/253181889 b/253271977
Reverted Changes:
I85f9565b3:Enable Shell Transitions
I75d0fe964:Enable Shell Transitions
I0565e423a:Enable Shell Transitions
I98bf8f0aa:Enable Shell Transitions

Change-Id: I6ad85a8f8168cdd40cb66eb58b9ea6a936bc2315
2022-10-12 20:57:48 +00:00
Evan Rosky
3ecceb8680 Merge "Enable Shell Transitions" 2022-10-12 16:08:27 +00:00
Nick Chameyev
09241680a7 Merge "Extract PreviewPositionHelper to shared library" into tm-qpr-dev am: 3e7c611358 am: 40497595fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20034765

Change-Id: Iae3e4e2373ef9918f541bfade1654808fa2a1864
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 17:21:11 +00:00
Nick Chameyev
cbfb35edc7 Extract PreviewPositionHelper to shared library
Moves Launcher's PreviewPositionHelper to shared
library between SystemUI and Launcher to reuse
it in the future in the partial screensharing
recents selector.

There should be no functional changes in the
code itself.

Bug: 240924926
Test: presubmit
Change-Id: Ib38b6f9db91e63a2598bf81229e3cd3e1a49ca60
2022-10-05 10:23:54 +01:00
Ming-Shin Lu
cb4f9b8dc5 Merge "TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation" into tm-qpr-dev am: 8ff85dc733 am: 6013ab3776
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20064292

Change-Id: I6aaeb6efe4af83a5c8621cceb3154be4d53be58c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 07:47:04 +00:00
Ming-Shin Lu
8ff85dc733 Merge "TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation" into tm-qpr-dev 2022-10-05 06:43:42 +00:00
Ming-Shin Lu
4d4f62ac77 TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation
As now FlickerTests is leveraging TAPL to interact devices CUJs,
we realized in LauncherInstrumentation will verify task bar visibility
automatically to expect it always visible when quick-switch, which is
not always reliable since the task bar may be hidden by manual or
when the activity requests to show IME.

Add setIgnoreTaskbarVisibility in LauncherInstrumentation for the caller
to ignore taskbar visibility if the test does not need to verify it.

Bug: 228012334
Bug: 240306344
Test: atest FlickerTests:SwitchImeWindowsFromGestureNavTest
      in tablet device
Test: atest NexusLauncherOutOfProcTests:com.android.quickstep.\
       TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet

Change-Id: Id0a35561523d733b8434acb702ec7dcaa466a1c2
2022-10-05 11:37:37 +08:00
Tracy Zhou
b2d7f05bad Merge "Remove ENABLE_QUICKSTEP_LIVE_TILE flag" into tm-qpr-dev am: d7a7bfc304 am: b2cd75e5df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20079254

Change-Id: Id23f4091da4d7216de27615c7e97f7139a37d392
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 21:07:54 +00:00
Tracy Zhou
c0095e81ae Remove ENABLE_QUICKSTEP_LIVE_TILE flag
Fixes: 249627137
Test: manual - (1) swipe up from app (2) swipe home (3) quick switch (4) split in overview
Change-Id: Ibe56ba3824b379b20fb3f0aa09be4d6bdb5abaa1
2022-09-29 04:58:52 +00:00
TreeHugger Robot
cee4a9b588 Merge "Revert "Using Transaction directly instead of building surface p..."" into tm-qpr-dev am: 3187928c51 am: c3f2fcea3e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19971330

Change-Id: I0d5f920d02125a61380c32007b01956a0baa9a54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 01:42:14 +00:00
Sunny Goyal
9925bbd147 Revert "Using Transaction directly instead of building surface p..."
Revert "Removing unused surface transaction wrappers"

Revert submission 19933596-tcompat

Reason for revert: b/246899728
Reverted Changes:
I31123dff7:Using Transaction directly instead of building sur...
I2e2526d21:Removing unused surface transaction wrappers

Change-Id: I63d1d8bb723b7bd05d345fb21a67f88e5fb36bc1
2022-09-15 14:07:51 -07:00
Sunny Goyal
e5f8f0ec23 [conflict] Using Transaction directly instead of building surface params am: fd2c9eb04e am: bb2c85a3eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19933596

Change-Id: Id10383b9dfd5319ba0570a65863fd0cf2156226b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-14 21:11:20 +00:00
Winson Chung
3f649ef892 Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
Merged-In: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-14 17:14:32 +00:00
Sunny Goyal
fd2c9eb04e Using Transaction directly instead of building surface params
Bug: 221961069
Test: Presubmit
Change-Id: I31123dff78de513addd0c851403af9097686c46e
2022-09-13 22:26:42 +00:00
Winson Chung
252ec11e4e Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-12 16:04:56 +00:00
Ats Jenk
c2475fa8ee Merge "Filter out active freeform tasks from recents" into tm-qpr-dev am: accde3a686 am: df6d7ffc46
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19817526

Change-Id: I3c7b1cc360d984be60d1fd41eaeb526e543c1a35
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 16:43:03 +00:00
Ats Jenk
accde3a686 Merge "Filter out active freeform tasks from recents" into tm-qpr-dev 2022-09-08 16:07:19 +00:00
Ats Jenk
461c3b3bd0 Filter out active freeform tasks from recents
Freeform tasks will show up as a separate, single tile in recents.
Filtering them out right now.

Bug: 244348395
Test: atest RecentTasksControllerTest RecentTasksListTest
Change-Id: Ifb197031076a8d8934cea78c6b68cb059477a81a
2022-09-07 15:32:02 -07:00
Alex Chau
17b18bbd8c Merge "Use real IDP in DeviceProfileTest" into tm-qpr-dev am: 0f1001c7b1 am: 2cda6fee53
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19717456

Change-Id: I640a82ccc8be13a2ff1779f915aa946c841bea6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-07 15:07:29 +00:00
Alex Chau
e818bcb997 Use real IDP in DeviceProfileTest
- Mock WindowManagerProxy instead of IDP in DeviceProfileTest
- Extracted NavigationMode to standalone class
- Moved parseNavigationMode to WindowManagerProxy so it can be mocked
- Moved DeviceProfileTest to internal repo

Bug: 242086027
Test: DeviceProfileTest
Change-Id: Ia5a43293b1380f04d786d2adf8503cfd10f7674a
2022-09-07 10:35:21 +01:00
Tony Wickham
2be2312543 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev am: d833fe4a12 am: 94894d8d88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19472817

Change-Id: Ib419b6f6fad396917f5b477e5c20ca5bd425a165
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 01:43:50 +00:00
Tony Wickham
d833fe4a12 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev
* changes:
  Fix taskbar stash state not persisting properly across recreate
  Add support to Tapl to recreateTaskbar
  Don't rely on QuickstepLauncher instance for tests
2022-09-01 00:52:54 +00:00
Tony Wickham
e74569e935 Fix taskbar stash state not persisting properly across recreate
Because we check supportsVisualStashing() in
TaskbarStashController#init(), we need to avoid using
TaskbarUIController to provide that value since TaskbarUIController
isn't initialized until a bit later than the other controllers. So I
moved the logic from supportsVisualStashing() back to
TaskbarStashController, but still allow TaskbarUIController to override
it (e.g. for DesktopTaskbarUIController).

After that fix, I noticed that force stopping launcher (to test the fix)
would briefly show the taskbar background before resetting the stashed
state. This is also due to LauncherTaskbarUIController not being ready
immediately, since that's what sets FLAG_IN_APP due to launcher being
paused. To work around this, I set FLAG_IN_APP to true by default in
TaskbarStashController#init(), since that is the most common case, and
taskbar background/stashed handle isn't shown on home anyway.

Test: Force stop launcher while taskbar is stashed, verify it recreates
as stashed without background flicker; same when changing wallpaper
color on home or in app; also tested when taskbar isn't stashed and in 3
button mode for good measure
Test: testHideTaskbarPersistsOnRecreate
Fixes: 235986838

Change-Id: Ie55bd70e8288d5ad7433dde970f18c176831d747
2022-08-30 13:42:04 -07:00
Pat Manning
5cf4d207f2 Merge "Launch tasks before testing switch to overview." into tm-qpr-dev am: 8463ab771e am: d6f5350f26
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19719106

Change-Id: I508373ba1b659b8cf108521e309568289d9be7f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 12:14:19 +00:00
Alex Chau
543857f496 Add screen recording to flaky test
- Also updated bug id for a ScreenRecord

Test: presubmit
Bug: 242163205
Bug: 241821721
Fix: 242163245
Change-Id: I43ff9fca285649933a100e4a02c660087308a7ac
2022-08-26 18:36:33 +01:00
Pat Manning
53d750e427 Launch tasks before testing switch to overview.
Bug: 238461210
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: I0033b8b33371a01165c595ae66826bef5699eddb
2022-08-24 12:25:00 +00:00
Nataniel Borges
8fe224c90a Fix testDisableRotationCheck
Move it to the NexusLauncherTests and launch app before rotation check

Bug: 241017339
Test: testDisableRotationCheck
Change-Id: Ia9b5d6738a8c725c68bb6422ab44cbed5ecbc0a6
2022-08-23 18:32:40 +00:00
Thales Lima
a08a443d63 Make folder sizes customizable
Introduce new attrs for folder sizes and update all grids to use the new attrs

Fix: 214582832
Fix: 236272949
Test: atest DeviceProfileTest
Test: manual comparison with mocks
Change-Id: I638052a7f01b4951df0dd26db577167468a3c46d
2022-08-12 12:24:18 +01:00
Tracy Zhou
6a4a229c27 Revert "Revert "Add testSplitFromOverview test (for phones)""
This reverts commit 24df4bffd8.

Reason for revert: resubmit

Change-Id: Iebc66cbce6885e06fe7691c548c1ffe950e936df
2022-08-11 17:59:34 -07:00
Thales Lima
9938c2f791 Calculate hotseat width based on available width
Navigation buttons take space on the hotseat, so hotseat width (qsb width and border space between icons) should be calculated instead of having a coded value.

Bug: 223724516
Bug: 228998463
Test: manual, changing display size
Test: manual, changing hotseatBarEndOffset value
Test: HotseatWidthCalculationTest
Change-Id: Ibd4f5ff2e06afda8e7420fb744db049d2e418e14
2022-08-04 15:21:06 +01:00
Alex Chau
206ede9c1f Adjust height of tablet AllApps base on row height
- Also used hotseatQsbHeight for AllApps QSB height as they have to match to transform between each other

Fix: 232907846
Test: manual on different tablets
Test: atest DeviceProfileTest
Change-Id: I001d0e129db2a5de6c8ace4c3302381110da03f1
2022-08-03 15:29:22 +00:00
Pat Manning
5f74bfd76d Refactor DeviceProfile tests based on dump() and use real device dimensions for tests.
- Added roundPxValueFromFloat when converting dp/sp to px to deterministically round up values around .5

Fix: 240133465
Bug: 237542518
Test: DeviceProfileTest.kt
Change-Id: If4239f714487fe5bf2ef44274e2ce415bd75c86d
2022-08-01 17:54:43 +00:00
Jeremy Sim
fe5bccbf6f Merge "Update calculation method for Overview UI placement on tablets" into tm-qpr-dev 2022-07-29 18:56:40 +00:00
TreeHugger Robot
0438ea2293 Merge "Revert "Add testSplitFromOverview test (for phones)"" into tm-qpr-dev 2022-07-29 07:05:34 +00:00
Winson Chung
24df4bffd8 Revert "Add testSplitFromOverview test (for phones)"
This reverts commit 1780cee0fe.

Reason for revert: b/240517487

Change-Id: Id0b690ebba880dd9c978ed42c0f965beb2678b8c
2022-07-29 00:01:17 +00:00
Jeremy Sim
1cfe6d490a Update calculation method for Overview UI placement on tablets
This update slightly changes the calculation method for Overview UI placement, in order to line up better with spec. (The previous calculation caused a small 30dp divergence on tablets.)

Bug: 236760307
Test: Manual by measuring pixels and comparing to spec
Change-Id: I94e9e7b5a6a24c37693425ac8ec71cd066003658
2022-07-28 14:05:24 -07:00
Tracy Zhou
f1a523a790 Merge "Add testSplitFromOverview test (for phones)" into tm-qpr-dev 2022-07-28 05:06:40 +00:00
Vadim Tryshev
45633e5aa1 Merge "Moving all sources that are shared between Launcher and TAPL in one directory" into tm-qpr-dev 2022-07-27 20:24:35 +00:00
vadimt
f6ef879cf4 Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877, 234414088
Test: presubmit
Change-Id: I3d923ea4b54d1a4c3d2b345be09692727d30433e
2022-07-27 20:18:46 +00:00
Evan Rosky
d87f3ff8ea Enable Shell Transitions
Bug: 161711458
Test: existing tests  pass
Change-Id: I85f9565b331c8353c2222e7c8e8803c4d8fce88f
2022-07-27 18:35:36 +00:00