Commit Graph

10269 Commits

Author SHA1 Message Date
TreeHugger Robot
0c689ef773 Merge "Clean up IllegalStateException for page pairing" into sc-v2-dev 2021-10-27 11:21:46 +00:00
Pinyao Ting
35c5755b71 Fix the fallback logic for shortcut icons when icons are missing
The icons of shortcuts in general are not persisted in backup payload
and thus are not available on the new device, apps are reposponsible for
republishing those shortcuts on the new device, with the only exception
being pinned shortcuts, whose icons are stored in launcher.db as a
fallback when icons are not avaialble in the shortcut themselves.

A previous CL unexpected excluded deep shortcuts from loading their
fallback icons in launcher.db, causes pinned shortcut to fallback
further to default droid icons, this CL restores the original behavior.

Bug: 202346722
Test: manual
Change-Id: Ie09becd3a0dc1ca1e7c2573fe1b68b61a58c2091
2021-10-26 18:02:08 +00:00
TreeHugger Robot
8935b22cd7 Merge "Fix the remove button icon not centered when the home screen is in landscape." into sc-v2-dev 2021-10-26 00:06:37 +00:00
Sebastian Franco
63d1a181e5 Fix the remove button icon not centered when the home screen is in landscape.
To fix it I put the bounds of the Icon/drawable when the text is not visible.

Fix: 202811811
Test: Manually Tested.
Change-Id: Ieff54a73e819c4b3a61e28fd76faf93a84b67666
2021-10-25 17:34:11 -05:00
Alex Chau
53c7ed5084 Avoid calling getIconResult if recycle is called after request is queued
Fix: 203582251
Test: atest -c NexusLauncherTests:com.android.launcher3.memory.MemoryTests
Change-Id: Ice1e981e1813df516008be578aa89ee17fb79fab
2021-10-25 21:06:27 +01:00
Alex Chau
920be89b26 Clean up IllegalStateException for page pairing
Fix: 198820019
Test: manual
Change-Id: Ic691f781b20d664c57a26370aae479ab68508303
2021-10-25 15:20:16 +01:00
TreeHugger Robot
d4df41b78f Merge "Bugfix where the widget handles appear even when you can't resize it." into sc-v2-dev 2021-10-21 20:46:37 +00:00
Sunny Goyal
486adb03a0 Fixing wrong text spacing bounds
Bug: 203740844
Test: Manual
Change-Id: I68fcab489643acf80759f90736f806ae2852e648
2021-10-21 11:30:18 -07:00
Sebastian Franco
4067f5d4ae Bugfix where the widget handles appear even when you can't resize it.
To fix it I added the following logic condition: if the minimum size of
the widget (`mMinVSpan` vertically) is equal to the maximum size of the
widget (`mMaxVSpan` vertically), then you can't change the size and the
handles shouldn't appear, I did this for both the horizontal handles as
well as the vertical handles.

Fix: 202004006
Change-Id: Ide05231f5712a736129ac6cb2fee358f7c70e371
Test: Manully veryfied.
2021-10-21 17:32:31 +00:00
TreeHugger Robot
ea38519fa4 Merge "Fix bug with resize frame in Launcher3." into sc-v2-dev 2021-10-20 20:50:17 +00:00
Schneider Victor-tulias
e9bd364390 Merge "Generalize the icon popup menu types." into sc-v2-dev 2021-10-20 18:32:56 +00:00
Yogisha Dixit
7b1d25b251 Fix bug with resize frame in Launcher3.
Also updated the tests to check that the resize frame is shown.

Bug: 192655785
Test: AddWidgetTest, AddConfigWidgetTest, manual
Change-Id: Id348f39cec1bebc8ec9ea9f3068f4bda2159eac4
2021-10-20 19:03:14 +01:00
Pat Manning
3c647ff30a Merge "Add new quickstep test for many tasks open at once." into sc-v2-dev 2021-10-20 15:20:26 +00:00
Pat Manning
ccec1de6ae Add new quickstep test for many tasks open at once.
This test is needed for testing overview-grid-related functionality.
- Opening non-focused tasks
- Dismissing a non-focused task from the grid
- Grid rows rebalancing after dismissal, which only happens when enough
apps are open to be off-screen.
- Grid tasks do not scroll after dismissal.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: Ic907db4643cdc2eb9e4610dab917347e234e470c
2021-10-20 14:40:32 +01:00
Samuel Fufa
f0f2b75ada Merge "[Search] [Race condition] Fix wrong titles showing on BubbleTextHolder" into sc-v2-dev 2021-10-20 03:15:25 +00:00
sfufa@google.com
d7bdd97ac6 [Search] [Race condition] Fix wrong titles showing on BubbleTextHolder
No need to remove the listener on BubbleTextView#reset as BubbleTextView's parent should never change and always listen for ItemInfo updates.

Bug: 203506475
Test: Manual
Change-Id: Ie00b293495c79d36c9eb08408754389ab4b80839
2021-10-19 17:15:06 -07:00
Schneider Victor-tulias
16e04e29d2 Generalize the icon popup menu types.
Generalized popup menu types and logic to allow wider uses outside of launcher.

Bug: 198438631
Test: long pressed launcher icons and pressed menu options
Change-Id: Iadcbb1796496c0061dcee362784e426ff55dc94a
2021-10-19 16:06:16 -07:00
Sunny Goyal
37a237b2cd Merge "Adding support for dynamic letter spacing for icon labels" into sc-v2-dev 2021-10-19 22:56:16 +00:00
Samuel Fufa
c46c83c8c8 Merge "[Work Profile] Fix NPE on WorkModeSwitch" into sc-v2-dev 2021-10-19 22:01:25 +00:00
Sunny Goyal
0d69cb6ef7 Adding support for dynamic letter spacing for icon labels
Bug: 201697936
Test: Manual
Change-Id: I0ab81291c40afcac30c5caf7b5638889908775f8
2021-10-19 13:09:58 -07:00
TreeHugger Robot
06146a1944 Merge "Revert "Clear only workspace shortcut / widget related tests"" into sc-v2-dev 2021-10-19 19:56:29 +00:00
sfufa@google.com
dda4f2c602 [Work Profile] Fix NPE on WorkModeSwitch
Bug: 202868251
Test: manual
Change-Id: I16e149e0aab1b53f7a0e753f353ccace08cf6b71
2021-10-19 11:22:55 -07:00
Alex Chau
abf9850dea Merge "Don't apply left/right inset on gesture nav landscape" into sc-v2-dev 2021-10-19 10:24:57 +00:00
Alex Chau
bbe6cf30a2 Don't apply left/right inset on gesture nav landscape
Fix: 201775630
Test: Go to landscape with gesture nav, widgets not cropped and cellSize matches HSV
Change-Id: I68e62897b31dbb8509c95a20e8d3a3528a40fe9b
2021-10-18 20:52:05 +01:00
Alex Chau
9b3dd6c0b9 Revert "Clear only workspace shortcut / widget related tests"
This reverts commit 22be1a47f4.

Reason for revert: Breaks another test
Bug: 202546679

Change-Id: I796c508a6d7c00ec8c1d48e3517453f9eca0616c
2021-10-18 17:52:12 +00:00
Tracy Zhou
ae88197e5f Track LauncherState for task bar stashing better
- Animate in onStateTransitionStart
- Commit in onStateTransitionComplete

Fixes: 193938970
Fixes: 200765631
Fixes: 201644899
Test: Go home from overview; Go to all apps from home; Go to overview from home
Change-Id: I393022c86f09806fea29fb5bc7191304b473f231
2021-10-18 10:51:51 -07:00
Hyunyoung Song
32f3616f0c Merge "Enable widget picker aiai search" into sc-v2-dev 2021-10-18 17:24:53 +00:00
Samuel Fufa
4ff90a435e Merge "[Search] Hide A-Z list when search is entered from QSB" into sc-v2-dev 2021-10-16 04:28:23 +00:00
sfufa@google.com
7a620d3673 [Search] Hide A-Z list when search is entered from QSB
preview attached to bug report

Bug: 201781284
Test: manual
Change-Id: I572360d2d49b38577a7d77115aede4c3269d42e9
2021-10-15 15:49:43 -07:00
TreeHugger Robot
6a4f5427ea Merge "Clear only workspace shortcut / widget related tests" into sc-v2-dev 2021-10-15 19:38:46 +00:00
TreeHugger Robot
27e294a973 Merge "Removing overscroll pluging support" into sc-v2-dev 2021-10-15 19:27:25 +00:00
Hyunyoung Song
0d794e65aa Enable widget picker aiai search
Bug: 183108439
Test: manual
Change-Id: I93f00131817622ad441d3374f22f26df8b28114d
2021-10-15 11:10:50 -07:00
Alex Chau
22be1a47f4 Clear only workspace shortcut / widget related tests
- This ensure hotseat to be populated with default items, so it won't result in an empty taskbar which get stashed in apps
- Workspace needs to be cleared because shortcut / widget dragging won't always work if there are items in workspace. It only happens in test due to the way we drag items.

Fix: 202546679
Test: NexusLauncherTests:com.android.launcher3.ui.widget.RequestPinItemTest
Change-Id: Ib3ded6a685eaa1b169b75fd179c9e29ca4be1e72
2021-10-15 16:01:44 +01:00
Thales Lima
4d6f3d67d2 Merge "launcher: create a device profile for foldables" into sc-v2-dev 2021-10-15 10:10:36 +00:00
Samuel Fufa
f53278c908 Merge "[Search] Fix ItemInfo assignment conflict" into sc-v2-dev 2021-10-14 23:22:16 +00:00
TreeHugger Robot
cd9f57042c Merge "Update logging to help debug b/200572078" into sc-v2-dev 2021-10-14 22:33:59 +00:00
Thales Lima
1de4d55d55 launcher: create a device profile for foldables
This creates a device_profiles_split.xml that will be used when the
device is a foldable. This makes the changes contained for specific
devices and make it possible to use different padding files in the
future if needed.

Bug: 191879424
Test: tested with NexusLauncher and Launcher3, in foldables and
handhelds
Test: check that 4x4 is not scalable anymore on handhelds by using HSV

Change-Id: If6ef14e3611c5252634c080643433545ce186f0d
2021-10-14 22:42:25 +01:00
sfufa@google.com
0fe464ddb9 [Search] Fix ItemInfo assignment conflict
When a BubbleTextHolder has more than one bubble text view, BubbleTextView#getParent().onItemInfoChanged is problematic as the ItemInfo associated with the last BubbleTextView will be the final ItemInfo set on parent. This is fixed by setting ItemInfo change receiver more explicitly.

Bug: 203020679
Test: Manual
Change-Id: Ia8aeead1a6151c2aa47148ba4846ae3d3ee39b73
2021-10-14 14:35:08 -07:00
Samuel Fufa
d942287299 Merge "[Search] Introduce feature flag ENABLE_ONE_SEARCH" into sc-v2-dev 2021-10-14 00:26:20 +00:00
Schneider Victor-tulias
8d8412f5b0 Update logging to help debug b/200572078
The class name logged in a repro of b/200572078 was insufficient after updated logs. Added more logging to get a pointer and stack trace when callbacks are added.

Test: ran launcher and checked logs
Bug: 200572078
Change-Id: I01bf98f488204311415a3946d66d99f656387cc4
2021-10-13 15:02:12 -07:00
sfufa@google.com
3b6b03b756 [Search] Introduce feature flag ENABLE_ONE_SEARCH
Bug: 201781284
Test: Manual
Change-Id: I31f8b6fe5664c874e4c9605a1d174807b6170df0
2021-10-13 11:28:09 -07:00
Alex Chau
238aaee059 Allow 2x2 and 3x3 to be migrated after restore
- Allow disabled grid to be used during restore
- Remove all inactive grid dbFiles to allow grid migration to happen
- Set the proper grid after restore to trigger migration

Bug: 202125760
Test: Restore a 2x2,3x3 grid, icons and widgets are migrated to 4x4 grid
Test: Restore a 4x4 grid, icons and widgetse stays in original position
Change-Id: Ie59e1ca0ca56ed2de52d88cd5f51b980788afa52
2021-10-12 17:36:04 +01:00
TreeHugger Robot
fa8860a1b5 Merge "Revert "More logging for drop bar not appearing for dragged widget"" into sc-v2-dev 2021-10-12 09:18:08 +00:00
Vadim Tryshev
a666b8f5da Revert "More logging for drop bar not appearing for dragged widget"
This reverts commit 876c15aa1f.

Reason for revert: After this CL, the flake disappeared. Revert to see if this was because of this CL.

Bug: 195031154
Test: presubmit

Change-Id: Ic3c54900927615338d9510ad179e87ee43133e4e
2021-10-11 22:10:50 +00:00
TreeHugger Robot
198030c1e0 Merge "[Search] Scale up small search icons on drag start" into sc-v2-dev 2021-10-09 05:01:30 +00:00
Samuel Fufa
8469dc98c6 Merge changes I097134c4,Icfe39c30 into sc-v2-dev
* changes:
  [Work profile][Test] Remove tracing logs for testWorkeduFlow
  [Work Profile] Enable work profile tests
2021-10-08 22:37:09 +00:00
Jonathan Miranda
273aa1c7af Merge "Update folder preview and folder background colors." into sc-v2-dev 2021-10-08 18:22:06 +00:00
Thales Lima
292a993c4a Merge "launcher: refactoring variables into arrays" into sc-v2-dev 2021-10-08 16:15:18 +00:00
Thales Lima
83bedbfe97 launcher: refactoring variables into arrays
There are a lot of variables that can be merged together into arrays
following some optimizations done in other places.

Bug: 191879424
Test: checking cell size and extra space in dumpsys
Change-Id: I1d73fbb5da2df2345ced7f46df5bae5d75d9d6b1
2021-10-08 13:36:56 +01:00
TreeHugger Robot
96ddd1cfd8 Merge "Enable QUICK_WALLPAPER_PICKER for droidfood." into sc-v2-dev 2021-10-08 02:50:59 +00:00