Commit Graph

5620 Commits

Author SHA1 Message Date
TreeHugger Robot
8a50f93f91 Merge "Fade overview actions on transition to Home." into sc-dev 2021-04-30 01:05:13 +00:00
Zak Cohen
cf38c65dc4 Fade overview actions on transition to Home.
Bug: 184696445
Fixes: 184696445
Test: Local build and flash
Change-Id: I950a08b1528ba983157615f99c21f06de220d414
2021-04-29 16:17:10 -07:00
TreeHugger Robot
2aec5f2643 Merge "Fix a couple issues with tracking launch cookies" into sc-dev 2021-04-29 21:04:25 +00:00
TreeHugger Robot
ae95cd1cc1 Merge "Logging ItemInfo.attribute field for LauncherUiChanged atom." into sc-dev 2021-04-29 20:33:22 +00:00
Bill Yi
fdcf8103e0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ide1f0bfcb4a3a28bcdbc2d0ec830f77de864546f
2021-04-29 19:00:17 +00:00
Winson Chung
3c192b3f72 Fix a couple issues with tracking launch cookies
- Fix NPE when there is no running task
- Fix issue where we were defaulting to a prediction icon when
  there was no launch cookie
- Don't use a launch cookie when we are launching from a non-workspace
  item, just fallback to the package name matching in that case

Fixes: 186653036
Fixes: 186593373
Test: Swipe up from various apps launched from predictions, also
      launch an app from all apps and swipe up and ensure it
      doesn't match a prediction
Change-Id: Ie8f5da010c140a5056045ac268d082c80271ab68
2021-04-29 04:23:40 +00:00
thiruram
7350b0f47e Logging ItemInfo.attribute field for LauncherUiChanged atom.
Unlike LaucherStaticLayout, LauncherUiChanged atom does not have origin field to write into statsd. This workaround solution will pack attribute value into target_id field and provides backward compatibility too.

Bug: 186169419
Test: Manual
Change-Id: Ib5344fad08accdd0aac827700c3842b7f102b7dc
2021-04-28 17:35:20 -07:00
TreeHugger Robot
127714094a Merge "Change TaskIconMenu to lay out vertically" into sc-dev 2021-04-28 20:16:43 +00:00
Vinit Nayak
4cc0dbb552 Change TaskIconMenu to lay out vertically
Still lays out horizontally when in phone
landscape.
TODO(b/186583656), need to center view.
Also have all layout be dynamic instead of having
some cases be in XML and some in code.

Bug: 181704764
Test: Task menu visible with all options in
portrait/landscape tablet
portrait phone
fake/real landscape phone

Change-Id: I3632eeb174f3e4baf2c9d69d51c1815c3c512e59
2021-04-28 11:47:08 -07:00
Winson Chung
4dd75b334f Merge "Prevent multiple calls to finish on the recents controller" into sc-dev 2021-04-28 17:22:19 +00:00
Winson Chung
bfb6274920 Merge "Invalidate when switching to new consumer" into sc-dev 2021-04-28 17:01:02 +00:00
Winson Chung
fb45e57ac1 Prevent multiple calls to finish on the recents controller
Bug: 186246362
Test: Verify from logs that we don't finish the controller
      multiple times
Change-Id: I8d40a756216133b8a278a28b822cf75c6e2a3046
2021-04-27 21:20:24 -07:00
Tony Wickham
9137946fd6 Merge "Don't setEnableDrawingLiveTile(true) unless end target is RECENTS" into sc-dev 2021-04-28 04:15:35 +00:00
TreeHugger Robot
69cb35a85a Merge "Some overview scrim and status bar color adjustments" into sc-dev 2021-04-28 03:23:13 +00:00
Bill Lin
0bcfe825fc Merge "Revert "Revert "2/ Resolve gesture one handed conflicts swipe up..."" into sc-dev 2021-04-28 03:14:30 +00:00
TreeHugger Robot
45167d6030 Merge "Removing dependency on wallpaper colors and using theme resources" into sc-dev 2021-04-28 03:00:17 +00:00
Winson Chung
4df3b23225 Invalidate when switching to new consumer
- When switching to a new consumer, also invalidate the handler to
  clean up references held by that handler
- Also make sure that we calculate the task index used for logging
  prior to starting the task view since the handler can be invalidated
  between starting the activity and the callback happening

Bug: 185909226
Test: Presubmit
Change-Id: I20e06b5a6b31a5e242c6fc840bf4f215797eb12c
2021-04-27 19:13:04 -07:00
Tony Wickham
b482188775 Some overview scrim and status bar color adjustments
- Replace UI_STATE_OVERVIEW with UI_STATE_FULLSCREEN_TASK. Overview no
  longer needs it's own status bar treatment as it's handled by
  ScrimView already. So remove instances of UI_STATE_OVERVIEW and
  replace some with UI_STATE_FULLSCREEN_TASK if a TaskView is behind
  the status bar.
- Add ScrimView to fallback recents activity.
- Remove scrim from Background state, don't fade it in until the
  gesture ends to RECENTS.

Test: watch scrim and status bar colors during the following
- Swipe up to home (no scrim, status bar matches task at first but
  then wallpaper once task isn't overlapping status bar)
- Swipe up to overview (no scrim until let go to overview, status
  bar matches task at first, then wallpaper after not overlapping,
  then scrim once it's 90% opacity)
- Quick switch from home (scrim fades in, status bar matches once
  it reaches 90% opacity)
- Quick switch from app (no scrim, status bar matches center task)
- Repeat above for 3P launcher and 2 button mode

Fixes: 185681676
Fixes: 185286870
Change-Id: I9e5c292cc734e714169b9cc8268e8dad4e868aca
2021-04-27 17:44:30 -07:00
Tony Wickham
e953739fd0 Don't setEnableDrawingLiveTile(true) unless end target is RECENTS
This addresses the case where the gesture ends before an end
target is calculated. Also technically live tile is only
supported in RECENTS anyway.

Test: Open calculator, tap the nav region, ensure we don't go home
(Same for 2 button mode, but tap outside of deferred region)

Fixes: 186197537
Change-Id: I05e288ae952f8c8ea0fa72d8c6e6aa2b6dbb0b1e
2021-04-27 17:34:04 -07:00
TreeHugger Robot
222b4757f5 Merge "Allow Workspace Scrim to be colored per state" into sc-dev 2021-04-28 00:10:26 +00:00
Sunny Goyal
4ed0fb5074 Removing dependency on wallpaper colors and using theme resources
Bug: 184676715
Test: Manual
Change-Id: Ie9a9a784c4a8a8cd484bfd8ea463deedcd4deed6
2021-04-27 16:29:08 -07:00
Winson Chung
df84326662 Add some logging for the app icon in overview
Bug: 186444448
Test: Presubmit
Change-Id: Iaa5aef39a461b8e37ec9f4e85d7a0d21233bf40f
2021-04-27 22:46:54 +00:00
Zak Cohen
4d35ac3020 Allow Workspace Scrim to be colored per state
Make it possible to set the color of workspace scrim to a different color
per state. Motivated by making Overview Scrim and All Apps scrims different
colors.

Bug: 186253733
Test: Local build and flash
Change-Id: Id7c38ce3c9173308eedfcb7592ececa7bd6bf220
2021-04-27 14:04:46 -07:00
TreeHugger Robot
8a38f39354 Merge "Initialize RotationTouchHelper with RecentsAnimationDeviceState ctor" into sc-dev 2021-04-27 20:49:37 +00:00
Alex Chau
8ac1a576f2 Apply TaskView's (non)fullscreenTranslation correctly in emulated landscape
PS4: Change approach to return a FloatProperty instead, as getPagedOrientationHandler() can throw NPE when called without a parent, as applyTranslationX/Y is called in onRecycle

Fixes: 186432016
Test: In small screen without home screen rotation, TaskView stay in position when rotating and icon is in displayed correct position after rotation. In quick switch, Task window also fill the screen.
Test: In large screen when dragging up from last task in quick switch, TaskView stays on screen when being dragged up
Change-Id: I54247e81066913e5cc072cf72543d780ff55ccaf
2021-04-27 19:18:48 +01:00
Alex Chau
129b001f29 Merge "Only show ActionsView when GestureEndTarget is RECENTS" into sc-dev 2021-04-27 13:36:49 +00:00
András Klöczl
d376b27d21 Merge "Add animation for all visible pages on home screen." into sc-dev 2021-04-27 12:07:29 +00:00
Alex Chau
9e6b8d6715 Only show ActionsView when GestureEndTarget is RECENTS
- Also, only animate ActionsView out if it's visible

Fixes: 186507807
Test: Restart launcher, swipe up from home, ActionsView is not shown
Change-Id: I7a83b39cea5176efd40552e3a2dd2257d9e2db4c
2021-04-27 12:44:16 +01:00
Cyrus Boadway
5f35ff021d Merge changes I65d2b1bc,I35bf9cb4 into sc-dev
* changes:
  Animate App Widget activity launch from Quickstep launchers
  Add a mechanism to temporarily defer App Widget updates
2021-04-27 10:17:00 +00:00
Bill Lin
bb1e047dd8 Revert "Revert "2/ Resolve gesture one handed conflicts swipe up..."
Revert "Revert "1/ Add onStartTransition() callback for SYSUI_ST..."

Revert submission 14315426-revert_fix_ohm_exit_flicker

Reason for revert: The root cause of b/186197537 is ag/14296935
I should safe to re-landing the 2 CLs

Reverted Changes: 
Ifd17094f0:Revert "1/ Add onStartTransition() callback for SY...
Ia921d073c:Revert "2/ Resolve gesture one handed conflicts sw...

Change-Id: If2164819e96919ca8c0c184639b3cbff0f91caf5
2021-04-27 10:13:29 +00:00
Andras Kloczl
da0e0e3c1c Add animation for all visible pages on home screen.
When an app is opened from the home screen there's a
slight animation that was only playing on the current
page and not on all the visible pages.

Test: manual
Bug: 174464691
Change-Id: Ia32cbf6d6277882a0c33063e78acdf1ccc4a5acc
2021-04-27 11:19:26 +02:00
Cyrus Boadway
61110601f6 Animate App Widget activity launch from Quickstep launchers
Following the general pattern on icon launch animations, define a
'floating widget view' to represent the appearance of the app widget
through the launch animation.

The floating widget view separates the foreground and background
components of the LauncherAppWidgetHostView, which can be positioned
and animated separately.

The background (or placeholder if no background can be identified)
moves and grows from its original position and size to the launched
app's position and size.

The widget's foreground scales and moves to match, fading out to be
replaced with the app window.

Bug: 169042867
Test: manual
Change-Id: I65d2b1bc80275f9df460790720e13d1650093347
2021-04-27 08:31:49 +00:00
Bill Lin
3b1df8d735 Merge "Revert "2/ Resolve gesture one handed conflicts swipe up recents"" into sc-dev 2021-04-27 03:37:31 +00:00
Jonathan Miranda
e19a8e53a1 Merge "Remove reliance on surface to update depth" into sc-dev 2021-04-27 00:35:57 +00:00
Vinit Nayak
3f6c3e134f Initialize RotationTouchHelper with RecentsAnimationDeviceState ctor
Added logs to debug why multiple instances of RotationTouchHelper
are being created to begin with.
Ran labtest on CF, passes.

Fixes: 177316094
Change-Id: Ibb980980c61965f456a84a9d85a72ec4ec6e0b19
2021-04-26 15:17:07 -07:00
Jon Miranda
d8cc458867 Remove reliance on surface to update depth
- Also no longer resets depth on surface change, as depth is independent
  from blur.

This fixes the bug where depth is not accurately reflected.

Bug: 185680609
Bug: 185189176
Test: launch app and swipe home multiple times
      launch app and back gesture to home

Change-Id: I5e2f4ce08b8bf84b7356fbd080ae732875c5e04e
2021-04-26 14:42:44 -04:00
Sunny Goyal
7fb983d5e3 Merge "Removing some dependency on icon shape" into sc-dev 2021-04-26 17:27:12 +00:00
Alex Chau
cc98cebc95 Merge "Pass WindowContext to DisplayInfoChangeListener" into sc-dev 2021-04-26 16:50:32 +00:00
Winson Chung
2f8158f259 Merge "Revert "Revert "Default shell_starting_surface to true to match platform behavior.""" into sc-dev 2021-04-26 16:29:37 +00:00
Bill Lin
d7b6a429cd Revert "2/ Resolve gesture one handed conflicts swipe up recents"
This reverts commit 789aa86617.

Reason for revert: for clarify b/186197537 

Change-Id: Ia921d073c2ad4e427c5436370313c2095f2adea8
2021-04-26 13:00:00 +00:00
Tracy Zhou
60a4a0b33d Merge "Revert "Finish recents animation upon home rotation"" into sc-dev 2021-04-24 19:29:51 +00:00
Tracy Zhou
0f8787db80 Revert "Finish recents animation upon home rotation"
This reverts commit 9d5ee19952.

Reason for revert: Broke a tapl test

Change-Id: Iafc513ca64f751d09c8606c072b29c589f030ad6
2021-04-24 19:28:20 +00:00
Evan Rosky
3e7b61b094 Merge "Fix surface release race when using Shell Transitions" into sc-dev 2021-04-24 01:29:42 +00:00
Winson Chung
0fdd43ab0d Revert "Revert "Default shell_starting_surface to true to match platform behavior.""
This reverts commit 250f568cb2.

Reason for revert: b/186121207 should be fixed

Change-Id: Ia374d9ad251134979999d794331e3b375d183996
2021-04-23 23:53:16 +00:00
Tony Wickham
5caf5e66ec Merge "Redraw live tile in updatePageOffsets()" into sc-dev 2021-04-23 23:45:17 +00:00
Jonathan Miranda
5018eff3a2 Merge "Have one app open animation properties for both cold/start app launch." into sc-dev 2021-04-23 22:43:35 +00:00
TreeHugger Robot
d15a58d528 Merge "Switch RecentsView to use regular animator update listener." into sc-dev 2021-04-23 22:39:23 +00:00
Jon Miranda
ebffb3cacf Switch RecentsView to use regular animator update listener.
- No dependency on MultiValueUpdateListener.
Bug: 186253351
Test: manual, verify animation looks normal

Change-Id: Ia83da412ef802eaaf1b3b61b2d6be78799b08b0d
2021-04-23 21:18:18 +00:00
TreeHugger Robot
024dd4ba47 Merge "Add null check to NavigationModeFeatureFlag" into sc-dev 2021-04-23 20:41:35 +00:00
Tony Wickham
d4dd48acc9 Add null check to NavigationModeFeatureFlag
Test: none
Fixes: 185790043
Change-Id: I591c18df0394e7ab4286687fffe8713a4507373e
2021-04-23 11:56:42 -07:00