Commit Graph

13653 Commits

Author SHA1 Message Date
Shikha Malhotra
2e255ed0ac Merge "Refactor code to be used in LauncherLily features" into tm-dev 2022-04-21 07:50:32 +00:00
Pat Manning
de5d9718ed Merge "Prevent edit state workspace scale from hiding next pages." into tm-dev 2022-04-20 17:21:31 +00:00
Brian Isganitis
6d780af405 Merge "Log taskbar all apps entrypoint, launches, and drags" into tm-dev 2022-04-20 17:13:52 +00:00
Pat Manning
ea5c1d29fe Prevent edit state workspace scale from hiding next pages.
Fix: 228969651
Test: manual
Change-Id: I0cceb3bfab19e0721b21fb8c55fe1218b1f25af8
2022-04-20 14:41:46 +01:00
Shikha Malhotra
e957b600d3 Refactor code to be used in LauncherLily features
Refactor add to workspace code to be used in Lily Launcher.
Also utilising code swap feature to swap out functionality of sorting
items on workspaces and finding next vacant space.

Bug: b/218186705
Test: Manually tested Launcher3 works.
Change-Id: I42a44eabeb307e1d23ef333e0a169437f9062bb6
2022-04-20 07:22:20 +00:00
Sihua Ma
34ba5a9534 Merge "Attach work badge to Weather and Battery widgets" into tm-dev 2022-04-20 02:01:11 +00:00
Sihua Ma
4c5bd537bb Attach work badge to Weather and Battery widgets
Moving the part where widget icon is generated from WidgetsListHeader (UI thread) to IconCache (backend)

Test: Open widget picker -> switch to work widget picker -> verify that Battery and Weather are badged
Fix: 226132413, 209995894
Change-Id: I3d649f2b26d7d8e7b756129b5bae4433ea344d43
2022-04-19 15:41:56 -07:00
Brian Isganitis
65df4506bf Merge "Prevent arrow popup from going off screen bottom when below icon." into tm-dev 2022-04-19 21:56:48 +00:00
TreeHugger Robot
1a93004398 Merge "Putting back generics for Workspace" into tm-dev 2022-04-19 20:25:37 +00:00
Brian Isganitis
79c938e8be Prevent arrow popup from going off screen bottom when below icon.
The current approach sometimes causes popups to go off the bottom of the screen, because we are not account for top insets and we are double counting extraVerticalSpace.

Test: Manual
Fix: 228326181
Change-Id: I148f9ff579e4406a0834195977e1cb7abf3707e5
2022-04-19 18:08:04 +00:00
Thales Lima
ee80d6919e Merge "Make hotseat RTL aware" into tm-dev 2022-04-19 16:47:52 +00:00
Sunny Goyal
cd2ac0f3e9 Updating target SDK for Launcher
Bug: 229173942
Bug: 226461147
Test: Presubmit
Change-Id: Id9e303f113cba87adf26442f1417ed2814555c54
2022-04-18 13:55:01 -07:00
Brandon Dayauon
32f1e89193 Merge "Fixed overlap issue where toggle button gets overlapped by 3 button nav bar..now button shifts up so it's not totally obscured" into tm-dev 2022-04-16 19:36:27 +00:00
Brandon Dayauon
241293aaee Fixed overlap issue where toggle button gets overlapped by 3 button nav bar..now button shifts up so it's not totally obscured
Test: Manual - On Raven
Before: https://screenshot.googleplex.com/sYq2i7YGjqmMjXe
After: https://screenshot.googleplex.com/9WRtgisGChisbFj
Bug: 223996104
Change-Id: Ic302e26b2fb6db9a9e06b335c753266e92b6c671
2022-04-15 16:29:35 -07:00
Sunny Goyal
bee13b6305 Catch SecurityException from NoMan to workaround possible race condition
Bug: 63636581
Bug: 227445069
Test: n/a issue not reproducible
Change-Id: Ib3dcf013ba9220d3d2d59032163191f0aef5d062
2022-04-15 10:20:19 -07:00
TreeHugger Robot
cdcbebb752 Merge "Revert "fix broken build on erorrprone"" into tm-dev 2022-04-15 04:09:57 +00:00
Sunny Goyal
645af0a6b3 Revert "fix broken build on erorrprone"
Revert submission 17730702-fixErrorProneBuild

Reason for revert: Breaks Launcher3 unbundled build by using hidden library in main Launcher code
Reverted Changes:
Id0ce4d308:Change version checks to use SdkLevel.isAtLeast*
I8fc801b00:fix broken build on erorrprone

Change-Id: Ib1cd50a746bad3b6fb9fbd455a7cdce30f341d8b
2022-04-14 16:54:07 -07:00
Sunny Goyal
2248d74666 Merge "Improving folder icon drawable" into tm-dev 2022-04-14 23:35:05 +00:00
Sihua Ma
af91920955 Merge "Showing alert dialog when shortcut version higher than the App" into tm-dev 2022-04-14 18:26:10 +00:00
Jonathan Scott
ad90ded7bc Merge "fix broken build on erorrprone" into tm-dev 2022-04-14 18:00:10 +00:00
Shikha Malhotra
fefafe5aa9 Putting back generics for Workspace
This got over-written in merging files

Bug: b/218186705
Test: Manually tested Launcher3 works.
Change-Id: I55287e110d067a338204924337091ead044b34ec
2022-04-14 15:35:33 +00:00
kholoud mohamed
9db305478e fix broken build on erorrprone
Bug: 229190745
Test: m -j out/soong/.intermediates/packages/apps/Launcher3/Launcher3/android_common/lint/lint-baseline.xml
Change-Id: I8fc801b0051a7e14578fa331b22653f109c1dcc6
2022-04-14 14:18:30 +01:00
Alex Chau
a74a8595fb Creaet separate pull back animation for AllApps
- In tablet, only animate recyclerView on pullback to be consistent with widget bottom sheet, and avoid showing a gap below mAppsView

Fix: 220345008
Test: manual on small and large screen
Change-Id: I1f7d03b6bd16af7a91a51a0985ef163d9e365261
2022-04-14 11:01:25 +01:00
Sihua Ma
da8759ae29 Showing alert dialog when shortcut version higher than the App
Creating an AlertDialog when the disabled reason of the shortcut is DISABLED_REASON_VERSION_LOWER, which happens when the backed-up shortcut was created from an application that has a version higher than the one installed on the device. The AlertDialog will direct the user to the play store and update the application.

Test: Manual
Fix: 224796975
Change-Id: I0125fada60b48176775de6782ba03ee6790904aa
2022-04-14 01:34:44 -07:00
Alex Chau
59120581e4 Dismiss keyboard when leaving AllApps state
Fix: 221024791
Test: Launcher3 dismiss keyboard when leaving AllApps
Test: NexusLauncher can still open keyboard automatically in AllApps
Change-Id: I61b50e3fc4c6ed83bd5234c5daef3b2cb428b520
2022-04-13 18:48:23 +01:00
András Klöczl
fed1182660 Merge "Change page snapping logic for large screen devices" into tm-dev 2022-04-13 11:18:39 +00:00
Shikha Malhotra
80a315e50f Merge "Review comments followup" into tm-dev 2022-04-13 08:00:31 +00:00
Andras Kloczl
07111f25f4 Change page snapping logic for large screen devices
Use 15% of the screen width instead of 40% of the page
width currently used for phones.

Test: try page snapping on Launcher home
Bug: 213305066
Change-Id: I6a525100bf942c5089f580a27250c425ca95cf00
2022-04-12 20:23:23 +01:00
Shikha Malhotra
f78da1bae3 Review comments followup
These are review comments followup from ag/17399997

Bug: b/218187058
Test: manually test thet Launcher3 features work correctly
Change-Id: I9865a37c1ed663370dc28e7678994f3d961e3cd1
2022-04-12 14:33:07 +00:00
Pat Manning
7013ee716d Add drop target button overlap correction to second button only.
Bug: 228311837
Bug: 228311837
Test: manual.
Change-Id: Ib9256deadd58c7350143221bf98c79415aaf9bc4
2022-04-12 12:54:15 +01:00
Pat Manning
4349d21246 Merge "Adjust grid cell visualizations." into tm-dev 2022-04-12 11:50:38 +00:00
TreeHugger Robot
2b80d6f813 Merge "Fixing potential ANR when fetching for wallpaper info" into tm-dev 2022-04-11 22:43:43 +00:00
TreeHugger Robot
2c9195b988 Merge "Don't use double padding in DeferredAppWidgetHostView if that would result in negative width" into tm-dev 2022-04-11 20:33:30 +00:00
Sunny Goyal
ba7cf0dc7d Fixing potential ANR when fetching for wallpaper info
Bug: 214581894
Test: Manual
Change-Id: I616b34b0ce6c96ed360073b2e8ff4eed81190add
2022-04-11 13:21:35 -07:00
Brian Isganitis
5b89b31b12 Log taskbar all apps entrypoint, launches, and drags
Test: wwdebug, wwlogcat, ensure container is formatted as follows:
    container_info {
      all_apps_container {
        taskbar {
        }
      }
    }
Bug: 204696617
Change-Id: I2492b133f95fccb059010bc9e5ed6cce73c211f9
2022-04-11 12:14:14 -07:00
Alex Chau
e8a60abc83 Don't use double padding in DeferredAppWidgetHostView if that would result in negative width
Fix: 203530620
Test: manual
Change-Id: I4aeff08e4fafec74e6a1bb031dfa14ae9d59e87e
2022-04-11 18:39:40 +01:00
Josh Tsuji
538581639e Merge "Add the staggered ring appear animation!" into tm-dev 2022-04-11 14:32:44 +00:00
Jeremy Sim
5d2a1f47c0 Merge "Fix placement bug with split staging icon in RtL" into tm-dev 2022-04-10 01:48:53 +00:00
Jeremy Sim
e15927eec7 Merge "Implement splitting from Taskbar long-press" into tm-dev 2022-04-09 01:21:14 +00:00
Jeremy Sim
43c79704ed Fix placement bug with split staging icon in RtL
Fixes a bug where switching the phone to RtL caused Overview's split staging icon to be placed incorrectly.

The bug was caused by the fact that FrameLayout margins were not working consistently in RtL. This may be another bug; more investigation required (b/201920967).

This fix makes it so that the icon is positioned using setX and setY rather than margins.

Fixes: 227372971
Test: Manual
Change-Id: I6e5371d20e8e2e4e6f41ba93d0dfa36ed085c103
2022-04-08 18:05:05 -07:00
Sunny Goyal
c317d925f7 Improving folder icon drawable
> Only clearing bitmap for foreground layer.
  Background and dot have only one draw command and is waster without rasterizing
> Moving bitmap creation to background thread
> Removing folder clipping since the folder draws outside bounds anyway
> Fixing the size of the foreground layer to what is actually needed

Bug: 224945025
Test: Manual
Change-Id: I72a8149ce4c44c266d5bdf45368d3dda5a960ac2
2022-04-08 14:41:40 -07:00
Shikha Malhotra
6d6f62c462 Merge "Added provision to switch the PageIndicator in specific Launchers" into tm-dev 2022-04-08 20:17:44 +00:00
Jeremy Sim
abdf25d226 Implement splitting from Taskbar long-press
Implements the ability to split the screen by long-pressing a Taskbar icon.

Bug: 217964720
Test: Manual
Change-Id: I5d324d8ca912c10cc3c3de21cae98fad546b85ac
2022-04-08 12:15:16 -07:00
Brian Isganitis
d3d6f0d6db Merge "Add separate AFV type for options popup dialog." into tm-dev 2022-04-08 17:46:07 +00:00
Luca Zuccarini
45c43c7058 Merge "[Toast] Polish the layout of the QSB, tabs and header protection." into tm-dev 2022-04-08 17:21:32 +00:00
Stefan Andonian
24125503c1 Merge "Simplify AbstractFloatingView.closeOpenViews usage." into tm-dev 2022-04-08 16:06:26 +00:00
Shikha Malhotra
0f2e1b6714 Added provision to switch the PageIndicator in specific Launchers
Please see the related CL in LauncherLilyGoogle where pagination is
implemented as persistent dots.

Bug: b/218187058
Test: manually test thet Launcher3 features work correctly
Change-Id: Ic20aa92249b1bbe3c4ab7810683b54648a181722
2022-04-08 11:47:46 +00:00
Brian Isganitis
7ef4fe42cb Add separate AFV type for options popup dialog.
Now that we close all non rebind safe AFVs onResume, the options popup dialog is getting closed. This dialog is rebind safe, but currently using TYPE_OPTIONS_POPUP which isn't.

Test: Dialog stays open on activity recreate. Also ran affected tests.
Bug: 227142635
Change-Id: Ibbac925ce5dd2de5c7770cb8f5bd8c5e438449cf
2022-04-07 16:29:44 -07:00
Stefan Andonian
d123fbd15d Simplify AbstractFloatingView.closeOpenViews usage.
This is a follow-up code review to ag/1754638 to address a comment that was missed before the CR was pushed.

Bug: 227142635
Test: Folders still close when launcher is paused.
Change-Id: Ib6724dc3a6ba49e259ba7de655f6810d6a692d16
2022-04-07 22:19:26 +00:00
Sebastián Franco
608b5cd5d8 Merge "Make the text for the drop target buttons fit if it's too long." into tm-dev 2022-04-07 22:14:07 +00:00