Commit Graph

14838 Commits

Author SHA1 Message Date
Brian Isganitis
0aa30e2292 Fix how task stack listener closes overlays on task changes.
Originally gated onTaskMovedToFront behind prototype because looked like
it was causing overlay to close when it shouldn't. However, it turns out
it was actually onTaskStackChanged that was doing this.

Additionally, changing onTaskMovedToFront to close with animation, because this will fire if swiping up from all apps (going to overview so Launcher is considered as the task moving to front). Also, registered onTaskCreated to be a bit more thorough.

Test: Manual (EDU, All Apps, and EDU + All Apps)
Fix: 283373523
Flag: none
Change-Id: I4cd3969f91a93bab190b764a656d9cfc03d1ce09
(cherry picked from commit 34c6b871af)
2023-06-02 15:34:35 +00:00
Treehugger Robot
55f38fb397 Merge "Create separate fullscreen launch type for shortcuts" into udc-dev 2023-06-02 05:22:23 +00:00
Anushree Ganjam
9b4f62e681 Merge "Add UID in AppInfo." into udc-dev 2023-06-02 01:17:29 +00:00
Jon Miranda
68135ebfd3 Merge "Update taskbar icon size to match spec." into udc-dev 2023-06-02 00:31:25 +00:00
Vinit Nayak
e65bf2a620 Merge "Skip drawing taskbar background in setup" into udc-dev 2023-06-01 23:13:19 +00:00
Anushree Ganjam
97434eea53 Add UID in AppInfo.
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.

Log Uid in Impression Logging.

Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA

Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
2023-06-01 22:45:19 +00:00
Jon Miranda
2c515c8076 Update taskbar icon size to match spec.
Bug: 282798528
Test: measured views manually

Change-Id: Iba173ae3e3682b62703ece81dd18eb91370b4627
2023-06-01 12:31:57 -07:00
Vinit Nayak
5364b0dac9 Skip drawing taskbar background in setup
Test: Manually went into SUW and observed
Fixes: 272674390
Change-Id: I102d1433692793f51d930e710d68134d4536c397
2023-06-01 10:52:39 -07:00
Jagrut Desai
ce8dd7884a Fixing TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet()
Currently, test asssumes that we are in persistent taskbar mode and assumes that taskbar is visible after switching to non ime activity.

We need overall strategy to how we migrate currentl TaplTestQuickstep to test for transient taskbar mode also. But, this will fix the current flakiness.

Test: Pre-submit
Flag: not needed
Bug: 281772186
Change-Id: Ie7e3364febd38ce489c3d3c881b94b8b308d3cb5
2023-05-31 15:05:35 -07:00
Jagrut Desai
e208e02aba Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev 2023-05-31 20:45:37 +00:00
Schneider Victor-tulias
8f95307087 Merge "Fix launcher activity leak in TouchInteractionService" into udc-dev 2023-05-31 17:49:35 +00:00
Jagrut Desai
84e959a72a Fixing Toast Hiding behind Taskbar - Part 2
Test: Visual, Manual
Bug: 282964229
Flag: not needed
Change-Id: If2373d8f0bc44a555844c78d20877e9636a7e176
2023-05-31 10:41:16 -07:00
TreeHugger Robot
6136566902 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-31 16:52:27 +00:00
Vinit Nayak
52ac882e9b Merge "Resize mRemoteTargetHandles when RecentsAnimationStarts" into udc-dev 2023-05-30 22:10:28 +00:00
Vinit Nayak
8852010eb8 Create separate fullscreen launch type for shortcuts
Bug: 283045822
Test: Verified via debugger the right API is called,
still have issues on split side
Flag: none

Change-Id: Ic2fcbf4ffe05503b0c2e1fade3e3e990498cf6cf
2023-05-30 13:43:24 -07:00
Stefan Andonian
57eaf86f8d Merge "Revert "Keep ViewCaptureRule logic self-contained."" into udc-dev 2023-05-30 17:49:54 +00:00
Bill Yi
1f1006a32b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Icaab575a19af3fc98557b9bf65388a66aebbee71
2023-05-28 22:51:02 -07:00
Achim Thesmann
2bcfbd3739 Merge "Allow BAL in Launcher" into udc-dev 2023-05-27 17:48:16 +00:00
Randy Pfohl
d2905028fb Merge "update padding to allow long text to not be truncated" into udc-dev 2023-05-27 02:02:34 +00:00
Schneider Victor-tulias
f304ab8e2b Fix launcher activity leak in TouchInteractionService
TouchInteractionService cannot be garbage collected until it has been cleared from the sysui process. Switching to use a WeakReference to help with garbage collection.

Flag: not needed
Bug: 283490010
Test: ran launcher and performed gestures
Change-Id: I37aa5f858f2ae0ac78b46478ab4c5f24770bd64f
2023-05-26 14:39:14 -07:00
Stefan Andonian
0a8fab01da Revert "Keep ViewCaptureRule logic self-contained."
This reverts commit eec7a9d90f.

Reason for revert: Failing tests.

Change-Id: Idf16453bbd7f0ace17d8e80d3303fae26b50333b
2023-05-26 21:11:41 +00:00
randypfohl
4613be550b update padding to allow long text to not be truncated
Test: built and run locally, screenshots in bug
Flag: none

Bug:279624252
Change-Id: I932782757e1087cc7a321bab2e4d682419ec4a28
2023-05-26 13:35:53 -07:00
Vinit Nayak
ed7b50efee Merge "Handle fullscreen app launchs in split init flow for SplitSelectDataHolder" into udc-dev 2023-05-26 20:19:19 +00:00
Schneider Victor-tulias
b4e91b14bd Merge "Update gesture nav edu motion and colors" into udc-dev 2023-05-26 16:12:06 +00:00
Schneider Victor-tulias
010a55d377 Merge "Fix keyboard quick switch d-pad left/right traversal direction" into udc-dev 2023-05-26 16:11:51 +00:00
Winson Chung
a5fb95df57 Merge "Try to handle side-task launches even if not fully transitioned to overview" into udc-dev 2023-05-26 04:25:21 +00:00
Stefan Andonian
9678d9470c Merge "Keep ViewCaptureRule logic self-contained." into udc-dev 2023-05-25 22:53:28 +00:00
Ikram Gabiyev
749a2d2a6a Merge "Remove contentDescription attribute in filter icon" into udc-dev 2023-05-25 18:40:00 +00:00
Stefan Andonian
eec7a9d90f Keep ViewCaptureRule logic self-contained.
This will make it easier for other apps / processes to integrate the
ViewCapture logic into their integrated testing frameworks.

Bug: 270158224
Test: Verified that a zip file was generated properly and was able to be
loaded into go/web-hv properly.

Change-Id: Ib3e4a0b60497937b750126590071884882b22917
2023-05-25 17:59:46 +00:00
Saumya Prakash
4ccfbf38bb Merge "Update Lottie files in gesture nav education" into udc-dev 2023-05-25 17:10:23 +00:00
Hui Kang
879d746de7 Merge changes from topic "Annotate Platinum Test" into udc-dev
* changes:
  [3/7]Add PlatinumTest annotation to tests
  [4/7]Add PlatinumTest annotation to tests
2023-05-25 16:04:10 +00:00
Luca Zuccarini
07c3491ec2 Merge "Add a view type check to ensure the right animation is used." into udc-dev 2023-05-25 15:42:51 +00:00
Winson Chung
98fbe25da9 Try to handle side-task launches even if not fully transitioned to overview
- The launcher state does not transition from Background -> Overview
  until the overview animation finishes, and if a side task is launched
  before that happens, then we receive onTaskAppeared() but
  isInLiveTileMode() is false, which results in a state where no
  animation of the side task surface is run, and the recents animation
  is not finished.  In these cases, if we've already calculated the
  end target is RECENTS, then we can still animate the side task
- Adding some more gesture logs to indicate side task launched (or didn't)

Bug: 279114961
Test: Go to overview and launch next task

Change-Id: I23eac8721da801f14cc95fc6781a0ef9f0355cc0
2023-05-25 06:14:53 +00:00
Brandon Dayauon
fe3d513650 Merge "Update work tab colors and fab background color" into udc-dev 2023-05-25 03:07:59 +00:00
Vinit Nayak
57de6565a0 Resize mRemoteTargetHandles when RecentsAnimationStarts
* TopTaskTracker gets updated too late after we've exited
split screen so we can't use that to determine how many
RemoteTargetHandles to use
* We default to 2, and then scale it down to 1. Because we
modify the array holding the handles directly, it should
also get updated in AbsSwipeUpHandler
* Temporary solution to stop setting up RecentsView if we detect that
TopTaskTracker has incorrect data and re-setup when we get
onRecentsAnimationStart()

Test: Tested quickswitch in gestural and recents button
double tap in button nav.
Bug: 236226779
Flag: none

Change-Id: I1bae7aed1f8712ddd1bf496acfcb851c0e32a115
2023-05-24 16:26:33 -07:00
Ikram Gabiyev
45b33a1a55 Remove contentDescription attribute in filter icon
Remove contentDescription attribute for multi-instance
filter icon ImageView since importantForAccessibility="no"
to avoid talkback noting it instead of the task name itself.

Bug: 280908761
Test: manually reproduce the steps in the bug
Change-Id: Ifdc884537222565fc2e52d5a17272f19a4446f62
2023-05-24 14:01:04 -07:00
Schneider Victor-tulias
9a7de100f4 Update gesture nav edu motion and colors
- Updated gesture nav edu overview step post-success motion and colors
- Updated gesture nav edu menu done button color and legacy action button color
- Switching light/dark mode when a step is complete started the demonstration animation. fixed this jank

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281764891
Fixes: 283964958
Bug: 279823249
Test: ran full tutorial with ENABLE_NEW_GESTURE_NAV_TUTORIAL enabled and disabled
Change-Id: I9adc05947267ec038b6f374b2a29a5499468883b
2023-05-24 18:36:39 +00:00
Jagrut Desai
990aef6c00 Merge "Android U: GM3 Color Tokens for Taskbar and quickstep" into udc-dev 2023-05-24 17:28:33 +00:00
Schneider Victor-tulias
8f26e47736 Fix keyboard quick switch d-pad left/right traversal direction
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 284156698
Test: tried keyboard quick switching with d-pad left/right in rtl/ltr
Change-Id: Idb7466b316cb7cbd9f592c5949d2c95c3278d85f
2023-05-24 10:04:05 -07:00
Brandon Dayauon
adcc16cf56 Update work tab colors and fab background color
Spec: https://screenshot.googleplex.com/6mKVuFNNNQfXpbD

bug: 283120562
test:
manually Launcher3 build var:
worktab lt: https://screenshot.googleplex.com/B8v44jm77o5Jyc7
widgetpicker tab lt: https://screenshot.googleplex.com/48WjAB8fKpZSEQ7
sharesheet tab lt: https://screenshot.googleplex.com/9rfSBeNALXbG7NL
worktab dt: https://screenshot.googleplex.com/332jCxde9vDW7hd
widgetpicker tab dt: https://screenshot.googleplex.com/3PGtrvQ2jLhQD4k
sharesheet tab dt: https://screenshot.googleplex.com/3jr4GPzRc3rzMA6

NexusLauncher:
worktab lt: https://screenshot.googleplex.com/BH2SFMXfQ4dtBeh
sharesheet lt: https://screenshot.googleplex.com/5axg34QgTt87iSL
widget picker tab lt: https://screenshot.googleplex.com/928kWFJ5mTun9py
worktab dt: https://screenshot.googleplex.com/7KWKLH4kt6nJpXT
sharesheet dt: https://screenshot.googleplex.com/778UoyhYrhimSAz
widgetpicker tab dt: https://screenshot.googleplex.com/FFFxBLqsATNXj8v

Change-Id: I78f20b2863a04d23e8a8880fc1d6a3ac0cfeb82a
2023-05-24 09:10:03 -07:00
Luca Zuccarini
f898ee474c Merge "Remove redundant instances of depth controller." into udc-dev 2023-05-24 11:35:21 +00:00
Hui Kang
5bde3f8573 [4/7]Add PlatinumTest annotation to tests
These tests are in the audited platinum suite (go/platinum-audit-flake)

Test: make
Bug: 283409062
Change-Id: Id438fde00b2a6e31694bef125d20637af514b9da
2023-05-24 01:17:18 +00:00
Bill Yi
754bb05feb Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-23 22:58:05 +00:00
Saumya Prakash
de9f592268 Update Lottie files in gesture nav education
The existing home gesture animation had a flicker due to an incorrect
frame in the Lottie jsons. This change updates the json files for all
form factors to the corrected version.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 283760250
Test: Went through the home gesture tutorial on tablet, foldable, and
mobile and verified the new animation played correctly

Change-Id: I55276ba9258e2b9908f05e0397f7c084fedf3926
2023-05-23 21:59:32 +00:00
Jagrut Desai
5b3161ef3e Android U: GM3 Color Tokens for Taskbar and quickstep
Test: Manual, Design Review
Bug: 268505871
Flag: not needed
Change-Id: I68e5092ccc69cf8a0d40aa4cc49fe9e8d82a68f4
2023-05-23 11:44:15 -07:00
Thales Lima
ac206e1daf Merge "Create TAPL test for taskbar in overview" into udc-dev 2023-05-23 18:32:34 +00:00
Luca Zuccarini
a96dcb0cc7 Remove redundant instances of depth controller.
During each app launch, a new `MyDepthController` is instantiated, which
registers two of its methods as listeners for cross window blur and
opaqueness. This controller's usefulness spans that specific animation
only, but the listeners are never unregistered. This creates conflicts
when an opaqueness signal happens, which cause the background to flicker
(see videos).

Bug: 283335820
Test: manual, see videos in the bug
Flag: not needed, bug fix
Change-Id: I3dcb0b8ff0aa77bf3183a926889d0131b17bcaa4
2023-05-23 15:33:17 +00:00
Thales Lima
1f10e53ba2 Create TAPL test for taskbar in overview
Fix: 269985301
Test: TaplTestsQuickstep
Flag: none
Change-Id: Iea0311bcba54882f7f2cf5d35cd98a538ae85855
2023-05-23 13:22:10 +00:00
Tony Huang
2d586455dc Merge "Hide divider immediately if going to launcher" into udc-dev 2023-05-23 03:04:18 +00:00
Bill Yi
358954a957 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2ba41c3831b537e4564e3e4ddf48ec4125a1260a
2023-05-22 17:36:20 -07:00