Commit Graph

18285 Commits

Author SHA1 Message Date
Fengjiang Li
dd2b47350e Merge "[Launcher Jank] Avoid lock contention on AssetManager in all apps preinflate thread" into main 2024-04-29 17:05:36 +00:00
Gustav Sennton
56f9df0620 Merge "[Desktop Mode] Show indicators under Taskbar app icons for running apps" into main 2024-04-29 08:28:28 +00:00
Fengjiang Li
b2d0845a29 [Launcher Jank] Avoid lock contention on AssetManager in all apps preinflate thread
Create a separate context with a separate AssetManager obj.

Bug: 337056120
Flag: NONE
Test: presubmit
Change-Id: Ic6765f7f19b649605aec6a889f8382ee10f929b0
2024-04-29 04:43:25 +00:00
Willie Koomson
21379bfbbc Merge "Remove widget education tip dialog" into main 2024-04-26 20:23:21 +00:00
Holly Jiuyu Sun
782d506330 Merge "[a11y] Change all apps screen name to All Apps instead of reusing Home." into main 2024-04-26 18:28:29 +00:00
Willie Koomson
5fb9b1595e Merge "Fix Add button animations" into main 2024-04-26 18:24:13 +00:00
Treehugger Robot
d62a3aefc0 Merge "Converting IconShape to mainThreadInitializedObject instead of keeping it a process static" into main 2024-04-26 16:17:52 +00:00
Gustav Sennton
52a8b7e24b [Desktop Mode] Show indicators under Taskbar app icons for running apps
In Desktop Mode we show running Desktop apps in the Taskbar. With this
change we also show an indicator under the app icon for each such
running app.

Bug: 332504528
Test: manual
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT
Change-Id: If0906dab8ad0bd8a78d93a4e99db47550e763bed
2024-04-26 15:29:00 +00:00
Willie Koomson
d731ba2ff1 Remove widget education tip dialog
This change removes the widget education tip dialog, and the arrow
tip view. These are no longer needed now that taps are handled by
showing an add button.

Bug: 335318980
Test: `pm clear com.google.android.apps.nexuslauncher` and open widget
 picker
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: I9b24a41604880f5f94939c02b94f1a9f6a6c83d5
2024-04-25 22:56:36 +00:00
Sunny Goyal
638a687fc8 Converting IconShape to mainThreadInitializedObject instead of
keeping it a process static

Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: Id66100e0cb300659c6017c287eb38ab04290477b
2024-04-25 15:56:30 -07:00
Holly Sun
47b9cb8436 [a11y] Change all apps screen name to All Apps instead of reusing Home.
Now even when we enter the All Apps page, talkback still reads the page name as Home (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=586;drc=120838b04dcaf072704c6fb382ea9115672cfcaa).

Bug: 330470894
Bug: 333833220
Test: manual
Flag: NA
Change-Id: I32a1ce8844cd111c7d1c492ee0a39fec47858a47
2024-04-25 15:13:41 -07:00
Willie Koomson
ff1a1a9e46 Fix Add button animations
Use AnimatorSet to make the fade animations sequential instead of
simultaneous. Also reduce the total duration to 200ms (100ms fade out,
100ms fade).

Before: http://screencast/cast/NjQ4NTcwMjcyNzQzNDI0MHxjNDY5NDJiNy03Mg
After: http://screencast/cast/NTg5NDA0NDI5ODI0ODE5MnxmMjczMTlmYi05Mw

Bug: 333734220
Test: manual, see screencast
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD

Change-Id: I2ee87f33c46e5dd07974152fa32393c39a18ecf1
2024-04-25 20:51:15 +00:00
Shamali P
01a297942a Fix issue that expanded widgets appear before next item moved down
Issue - http://screen/AYyCKCWZH4uYeBp

* Before - http:/screencast/cast/NTc1NzE0MTg1NDk3ODA0OHwyNjA4ZmU5OC02ZQ
* After - http://screencast/cast/NDcyNTkzNzcyMjYyMTk1MnwxNmU1MTRmNy1jMw

Additionally, also fixes problem that fade in for some expanded sections
didn't always happen.

Bug: 332457155
Flag: N/A
Test: Manual (see video)
Change-Id: Iad3a341d9b992c72b61492d57db4faa96a06ecfa
2024-04-25 20:31:54 +00:00
Helen Cheuk
b9ed7c152a Merge "Disable launcher focus outline animation" into main 2024-04-25 18:43:05 +00:00
Himanshu Gupta
578f1a474e Merge "Fix Accessbility bugs for PS." into main 2024-04-25 17:03:54 +00:00
Himanshu Gupta
42e3196011 Fix Accessbility bugs for PS.
This Cl contains:
1. Alt text for Lock/Unlock button as per state.
2. Alt text for Header when Locked.
3. Removing Header from accessibility target when unlocked.

Bug: 328024119
Test: Manual
Flag: NA
Change-Id: I791176afdae4fc6eb9387080aa036c1aed2a03a9
2024-04-25 11:57:53 +01:00
Treehugger Robot
b1037fb3ca Merge "Put Receiver unregistration on Background thread." into main 2024-04-25 00:24:59 +00:00
Shamali Patwa
587c3ce049 Merge changes from topic "bottomsheet-with-insets" into main
* changes:
  Align the margins between handle, text, and container with main picker.
  Update the app-specific picker to have a container like the main picker
2024-04-24 21:16:28 +00:00
Stefan Andonian
1f9bb1372c Put Receiver unregistration on Background thread.
Bug: 336722585
Test: Verified manually this doesn't break the build.
Flag: NA
Change-Id: If083d5c4ca7749946b50f5d4b64a5ea87f5651ce
2024-04-24 20:25:17 +00:00
Shamali P
9478a40898 Update the app-specific picker to have a container like the main picker
This is to ensure widgets are displayed with same container across the
two pickers.

* http://screencast/cast/NDYxNjMzNDExNjY1MTAwOHwwMTBlYzkwZC0wNg
* http://screencast/cast/NjY1NzAyNzY5NzgwMzI2NHwyYTg3ZWIzNS0wNw
* http://screencast/cast/NTYyMzcwMTc4NDQ5NDA4MHw3Y2JlZDEwZS04Mw

Bug: 328812171
Flag: N/A
Test: Manual - need to build a SS test for this opened - 336284716
Change-Id: I42b743b99cf6f47b7bade57de01b130df78ac1e9
2024-04-24 19:14:50 +00:00
Shamali P
3132947812 Limit number of items grouped on a row to 3.
With shortcuts this allows for more space to display two word title
below without ellipsizing it. (screen/4pJvcFFKJhooqZU)

Also let widget description show upto 3 lines to more of it to show
when stacked (screen/7xv8ng4H7iRLU79)

Bug: N/A
Flag: N/A
Test: Screenshot
Change-Id: Ia4e30f943f602b811e607d9cb52152f78cdc20e5
2024-04-24 19:14:23 +00:00
Saumya Prakash
8245ac04e3 Merge "Only run search edu when enabled, also make code more generic." into main 2024-04-24 16:13:43 +00:00
helencheuk
ce0f8595b7 Disable launcher focus outline animation
Bug: 335424188
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Teamfood
Change-Id: I31c63607c914da956d7c6139cc5089fe419f40e1
2024-04-24 11:37:30 +01:00
Sunny Goyal
ee6f471f3f Merge "Using settings cache for listening to haptic feedback setting" into main 2024-04-24 01:25:50 +00:00
Saumya Prakash
17cd6ca62a Only run search edu when enabled, also make code more generic.
We only need to run the Search edu if it is enabled on devices. The code
itself is also made more generic in terms of method and variable names.

Fix: 330401405
Test: Enable and disable the search function and check whether the edu tooltip shows
up for each specific use case.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
2024-04-23 22:02:15 +00:00
Willie Koomson
f88bf7e23f Merge "Fix issue with tap-to-add on recycled WidgetCells" into main 2024-04-23 18:53:33 +00:00
Sunny Goyal
99d9c7efbd Using settings cache for listening to haptic feedback setting
Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I5732875c1e3ce6468078b4bfdc2fa0eb7a29f0de
2024-04-23 11:30:00 -07:00
Treehugger Robot
62a1a8a336 Merge "Move PreInstalled App List to UserCache." into main 2024-04-23 18:24:01 +00:00
Winson Chung
a9ccb34d1c Merge "Migrate PackageManagerHelper to MainThreadInitializedObject" into main 2024-04-23 18:10:56 +00:00
Sunny Goyal
edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Himanshu Gupta
ae4631e6a3 Move PreInstalled App List to UserCache.
Bug: 333543006
Test: atest PrivateSpaceHeaderViewTest, AlphabeticalAppsListTest
Flag: NA
Change-Id: I84233c5a6406325d9e641b72ea8455911b46f65f
2024-04-23 15:28:01 +01:00
Fengjiang Li
fa0a4c1c11 Merge "[Predictive Back] Swipe back within workspace all apps should only scale down content view, rather than whole all apps sheet" into main 2024-04-23 03:45:32 +00:00
Sebastián Franco
a67a53eeed Merge "Make getWidgetProviderInfoByProviderName return the correct WidgetItem for Pixel own widgets." into main 2024-04-23 02:11:50 +00:00
Sunny Goyal
10fa016352 Fixing MainThreadInitializedObject
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
2024-04-22 17:04:33 -07:00
Treehugger Robot
e5bffd4c48 Merge "Show add button when WidgetCell text is tapped" into main 2024-04-22 22:27:38 +00:00
Sebastian Franco
b41d4b4e7a Make getWidgetProviderInfoByProviderName return the correct WidgetItem
for Pixel own widgets.

The pixel own widgets can have categories and getWidgetProviderInfoByProviderName
might not find the right widget if the widget has a category.

Flag: NA
Test: Manaul testing =(
Test: Make sure the placement in the widget picker is correct.
Test: All widgets in widget_section.xml with alsoKeepInApp set to false will previously dissapear on the preview.
Fix: 331628371
Change-Id: I1e4c8ae3dd21f8aef3e4aac99ce6ce6701e94760
2024-04-22 10:47:50 -07:00
Treehugger Robot
774d05e970 Merge "Remove debug tracing for b/321775748" into main 2024-04-22 16:35:32 +00:00
Mykola Podolian
1f40fa0e7f Merge "Updated pointer to match visual specification." into main 2024-04-22 16:06:39 +00:00
Schneider Victor-tulias
3f8eea99e3 Remove debug tracing for b/321775748
Flag: N/A
Fixes: 321775748
Test: FallbackRecentsTest
Change-Id: I1f746bf43025e093e94e60f8a1561f4f6a0f9b22
2024-04-22 09:55:49 -04:00
Winson Chung
bb32b7e0de Migrate PackageManagerHelper to MainThreadInitializedObject
- This is in preparation for other things that can be loaded with
  PMH initialization and prevents duplicate temporary helpers from
  loading this many times.
- Most calls in PMH can use the app context, but one call requires
  starting activities/showing toasts so that one needs to take the
  context and can be made static instead.

Bug: 323112914
Test: atest NexusLauncherTests
Change-Id: Id11c780955880cf49c022cbf2744c41e1b696355
2024-04-22 12:35:03 +00:00
Shamali Patwa
a80e199798 Merge "Keep rounded corners while scrolling in right pane & fix scrollbar size." into main 2024-04-19 22:43:39 +00:00
Stefan Andonian
f22011a51c Merge "Use ItemInfo with correct position when adding to Workspace via Accessibility." into main 2024-04-19 21:13:11 +00:00
Shamali Patwa
4ee10f33ee Merge "Use same margins for widgets bottom sheet as all apps." into main 2024-04-19 21:08:24 +00:00
Anushree Ganjam
093ef5fa30 Merge "When AllAppsSearchBarController's mInput edit text focus is false, we should hidekeyboard." into main 2024-04-19 19:59:44 +00:00
Stefan Andonian
86d3c8814b Use ItemInfo with correct position when adding to Workspace via Accessibility.
Bug: 332651703
Flag: NA
Test: Verified that the issue isn't reproducible with the fix. The issue
was 100% reproducible before.
Change-Id: I01207396e19b4f7d14d6a147e5e5fb98bae9ea99

Change-Id: I81aad9758ee33b8acc2d6a1242e54f2a47124374
2024-04-19 16:22:39 +00:00
Fengjiang Li
7d80f801b1 Merge "[Predictive Back] AbstractSlideInView#mViewToAnimateInSwipeToDismiss can be private" into main 2024-04-19 16:22:30 +00:00
Charlie Anderson
299e42cf8d Merge "Fix NPE for where intent.package is null but targetpkg is not." into main 2024-04-19 15:10:20 +00:00
mpodolian
73b07e2024 Updated pointer to match visual specification.
Updated bubble bar view pointer to have rounded tip.

Test: BubbleBarViewAnimatorTest
Fixes: 333546362
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: I7875426b06a330bc355a833c51849335f831317e
2024-04-19 15:32:26 +01:00
Brandon Dayauon
715059a1e3 Merge "Make settings cog animate back to original button" into main 2024-04-19 10:07:36 +00:00
Brandon Dayauon
24db282ed4 Merge changes Ied2efcf6,I07579635 into main
* changes:
  Polish workFAB with updated spec.
  Fix workFAB alignment.
2024-04-19 00:59:19 +00:00