Commit Graph

14818 Commits

Author SHA1 Message Date
Achim Thesmann
2bcfbd3739 Merge "Allow BAL in Launcher" into udc-dev 2023-05-27 17:48:16 +00:00
Randy Pfohl
d2905028fb Merge "update padding to allow long text to not be truncated" into udc-dev 2023-05-27 02:02:34 +00:00
randypfohl
4613be550b update padding to allow long text to not be truncated
Test: built and run locally, screenshots in bug
Flag: none

Bug:279624252
Change-Id: I932782757e1087cc7a321bab2e4d682419ec4a28
2023-05-26 13:35:53 -07:00
Vinit Nayak
ed7b50efee Merge "Handle fullscreen app launchs in split init flow for SplitSelectDataHolder" into udc-dev 2023-05-26 20:19:19 +00:00
Schneider Victor-tulias
b4e91b14bd Merge "Update gesture nav edu motion and colors" into udc-dev 2023-05-26 16:12:06 +00:00
Schneider Victor-tulias
010a55d377 Merge "Fix keyboard quick switch d-pad left/right traversal direction" into udc-dev 2023-05-26 16:11:51 +00:00
Winson Chung
a5fb95df57 Merge "Try to handle side-task launches even if not fully transitioned to overview" into udc-dev 2023-05-26 04:25:21 +00:00
Stefan Andonian
9678d9470c Merge "Keep ViewCaptureRule logic self-contained." into udc-dev 2023-05-25 22:53:28 +00:00
Ikram Gabiyev
749a2d2a6a Merge "Remove contentDescription attribute in filter icon" into udc-dev 2023-05-25 18:40:00 +00:00
Stefan Andonian
eec7a9d90f Keep ViewCaptureRule logic self-contained.
This will make it easier for other apps / processes to integrate the
ViewCapture logic into their integrated testing frameworks.

Bug: 270158224
Test: Verified that a zip file was generated properly and was able to be
loaded into go/web-hv properly.

Change-Id: Ib3e4a0b60497937b750126590071884882b22917
2023-05-25 17:59:46 +00:00
Saumya Prakash
4ccfbf38bb Merge "Update Lottie files in gesture nav education" into udc-dev 2023-05-25 17:10:23 +00:00
Hui Kang
879d746de7 Merge changes from topic "Annotate Platinum Test" into udc-dev
* changes:
  [3/7]Add PlatinumTest annotation to tests
  [4/7]Add PlatinumTest annotation to tests
2023-05-25 16:04:10 +00:00
Luca Zuccarini
07c3491ec2 Merge "Add a view type check to ensure the right animation is used." into udc-dev 2023-05-25 15:42:51 +00:00
Winson Chung
98fbe25da9 Try to handle side-task launches even if not fully transitioned to overview
- The launcher state does not transition from Background -> Overview
  until the overview animation finishes, and if a side task is launched
  before that happens, then we receive onTaskAppeared() but
  isInLiveTileMode() is false, which results in a state where no
  animation of the side task surface is run, and the recents animation
  is not finished.  In these cases, if we've already calculated the
  end target is RECENTS, then we can still animate the side task
- Adding some more gesture logs to indicate side task launched (or didn't)

Bug: 279114961
Test: Go to overview and launch next task

Change-Id: I23eac8721da801f14cc95fc6781a0ef9f0355cc0
2023-05-25 06:14:53 +00:00
Brandon Dayauon
fe3d513650 Merge "Update work tab colors and fab background color" into udc-dev 2023-05-25 03:07:59 +00:00
Ikram Gabiyev
45b33a1a55 Remove contentDescription attribute in filter icon
Remove contentDescription attribute for multi-instance
filter icon ImageView since importantForAccessibility="no"
to avoid talkback noting it instead of the task name itself.

Bug: 280908761
Test: manually reproduce the steps in the bug
Change-Id: Ifdc884537222565fc2e52d5a17272f19a4446f62
2023-05-24 14:01:04 -07:00
Schneider Victor-tulias
9a7de100f4 Update gesture nav edu motion and colors
- Updated gesture nav edu overview step post-success motion and colors
- Updated gesture nav edu menu done button color and legacy action button color
- Switching light/dark mode when a step is complete started the demonstration animation. fixed this jank

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281764891
Fixes: 283964958
Bug: 279823249
Test: ran full tutorial with ENABLE_NEW_GESTURE_NAV_TUTORIAL enabled and disabled
Change-Id: I9adc05947267ec038b6f374b2a29a5499468883b
2023-05-24 18:36:39 +00:00
Jagrut Desai
990aef6c00 Merge "Android U: GM3 Color Tokens for Taskbar and quickstep" into udc-dev 2023-05-24 17:28:33 +00:00
Schneider Victor-tulias
8f26e47736 Fix keyboard quick switch d-pad left/right traversal direction
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 284156698
Test: tried keyboard quick switching with d-pad left/right in rtl/ltr
Change-Id: Idb7466b316cb7cbd9f592c5949d2c95c3278d85f
2023-05-24 10:04:05 -07:00
Brandon Dayauon
adcc16cf56 Update work tab colors and fab background color
Spec: https://screenshot.googleplex.com/6mKVuFNNNQfXpbD

bug: 283120562
test:
manually Launcher3 build var:
worktab lt: https://screenshot.googleplex.com/B8v44jm77o5Jyc7
widgetpicker tab lt: https://screenshot.googleplex.com/48WjAB8fKpZSEQ7
sharesheet tab lt: https://screenshot.googleplex.com/9rfSBeNALXbG7NL
worktab dt: https://screenshot.googleplex.com/332jCxde9vDW7hd
widgetpicker tab dt: https://screenshot.googleplex.com/3PGtrvQ2jLhQD4k
sharesheet tab dt: https://screenshot.googleplex.com/3jr4GPzRc3rzMA6

NexusLauncher:
worktab lt: https://screenshot.googleplex.com/BH2SFMXfQ4dtBeh
sharesheet lt: https://screenshot.googleplex.com/5axg34QgTt87iSL
widget picker tab lt: https://screenshot.googleplex.com/928kWFJ5mTun9py
worktab dt: https://screenshot.googleplex.com/7KWKLH4kt6nJpXT
sharesheet dt: https://screenshot.googleplex.com/778UoyhYrhimSAz
widgetpicker tab dt: https://screenshot.googleplex.com/FFFxBLqsATNXj8v

Change-Id: I78f20b2863a04d23e8a8880fc1d6a3ac0cfeb82a
2023-05-24 09:10:03 -07:00
Luca Zuccarini
f898ee474c Merge "Remove redundant instances of depth controller." into udc-dev 2023-05-24 11:35:21 +00:00
Hui Kang
5bde3f8573 [4/7]Add PlatinumTest annotation to tests
These tests are in the audited platinum suite (go/platinum-audit-flake)

Test: make
Bug: 283409062
Change-Id: Id438fde00b2a6e31694bef125d20637af514b9da
2023-05-24 01:17:18 +00:00
Bill Yi
754bb05feb Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-05-23 22:58:05 +00:00
Saumya Prakash
de9f592268 Update Lottie files in gesture nav education
The existing home gesture animation had a flicker due to an incorrect
frame in the Lottie jsons. This change updates the json files for all
form factors to the corrected version.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 283760250
Test: Went through the home gesture tutorial on tablet, foldable, and
mobile and verified the new animation played correctly

Change-Id: I55276ba9258e2b9908f05e0397f7c084fedf3926
2023-05-23 21:59:32 +00:00
Jagrut Desai
5b3161ef3e Android U: GM3 Color Tokens for Taskbar and quickstep
Test: Manual, Design Review
Bug: 268505871
Flag: not needed
Change-Id: I68e5092ccc69cf8a0d40aa4cc49fe9e8d82a68f4
2023-05-23 11:44:15 -07:00
Thales Lima
ac206e1daf Merge "Create TAPL test for taskbar in overview" into udc-dev 2023-05-23 18:32:34 +00:00
Luca Zuccarini
a96dcb0cc7 Remove redundant instances of depth controller.
During each app launch, a new `MyDepthController` is instantiated, which
registers two of its methods as listeners for cross window blur and
opaqueness. This controller's usefulness spans that specific animation
only, but the listeners are never unregistered. This creates conflicts
when an opaqueness signal happens, which cause the background to flicker
(see videos).

Bug: 283335820
Test: manual, see videos in the bug
Flag: not needed, bug fix
Change-Id: I3dcb0b8ff0aa77bf3183a926889d0131b17bcaa4
2023-05-23 15:33:17 +00:00
Thales Lima
1f10e53ba2 Create TAPL test for taskbar in overview
Fix: 269985301
Test: TaplTestsQuickstep
Flag: none
Change-Id: Iea0311bcba54882f7f2cf5d35cd98a538ae85855
2023-05-23 13:22:10 +00:00
Tony Huang
2d586455dc Merge "Hide divider immediately if going to launcher" into udc-dev 2023-05-23 03:04:18 +00:00
Bill Yi
358954a957 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2ba41c3831b537e4564e3e4ddf48ec4125a1260a
2023-05-22 17:36:20 -07:00
Vinit Nayak
69ee1b9caf Handle fullscreen app launchs in split init flow for SplitSelectDataHolder
* SystemUi split APIs are overloaded to launch fullscreen tasks
as well, break that out into a separate method for clarity
* Have SplitSelectDataHolder also special case fullscreen launches

Bug: 283045822
Test: Launched various combinations of split tasks,
also tapped on initial view to see fullscreen launch with tasks
and intents
Flag: none

Change-Id: If3de9784b72e0f5f27f1b6d97cbf835b8f5391de
2023-05-22 16:30:04 -07:00
Treehugger Robot
25e94ccb1b Merge "Adding debug tracing for b/262282528" into udc-dev 2023-05-22 22:48:47 +00:00
Vadim Tryshev
807d9c2c30 Merge "Revert "Re-enabling a couple of tests"" into udc-dev 2023-05-22 20:28:07 +00:00
Schneider Victor-tulias
b323851e01 Merge "Update BorderAnimator to work with layout updates" into udc-dev 2023-05-22 20:17:35 +00:00
Schneider Victor-tulias
bd0188abd1 Merge "Fix redesigned gesture nav jank" into udc-dev 2023-05-22 19:01:35 +00:00
Schneider Victor-tulias
7dee27f470 Update BorderAnimator to work with layout updates
1. if a 'ViewScaleTargetProvider' is being used, this can cause a crash
2. otherwise, the old border bounds are reapplied, which is likely no longer correct

Updated BorderAnimator to use 'BorderAnimationParams' rather than 'ViewScaleTargetProvider'. This removes some unnecessary null checks while making the util class simpler to use. It also allows us to listen for specific view events for the border animation.

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 283272516
Test: opened the keyboard quick switch view and highlighted a view in recents view, then rotated the screen several times
Change-Id: I7959d6cd892ebcdd2c68163dd56c358815494af6
2023-05-22 11:33:57 -07:00
Jagrut Desai
6acf350107 Merge "Fix Taskbar Education Tooltip Bottom Margin" into udc-dev 2023-05-22 17:04:25 +00:00
Tony Huang
2083c5450d Hide divider immediately if going to launcher
Divider should hide immediately when going to launcher, this fix
the divider hidden delay in 3-btn-nav mode.

Fix: 283058496
Test: manual
Test: pass existing tests
Change-Id: Ia4eaba8020c564cc95b8652fe0f7066b653b9df4
2023-05-22 16:38:14 +08:00
Jon Miranda
9e0eee3729 Merge "Fix SUW unstash animation." into udc-dev 2023-05-20 20:16:17 +00:00
Jon Miranda
0aef6981ac Fix SUW unstash animation.
- Defer any UI updates to taskbar after the SUW unstash animation is created.
- Predicted app icons take longer to load, so it's possible that they are
  added after the animation is created.
- This avoids the case where icons are seemingly in the taskbar but
  do not get animated like the rest of the icons.

- We also need to call onAnimationStart for the reveal animation immediately,
  otherwise the clipToOutline params never get set.

Bug: 277712185
Test: flash device, very quickly go through SUW
Change-Id: I4c3089da0d20bf91672e2305655c4c37b1f367aa
2023-05-19 17:24:50 -07:00
vadimt
144a9508be Adding debug tracing for b/262282528
We see two long-clicks on the taskbar instead of expected one.

Bug: 262282528
Test: presubmit
Change-Id: I231d54ac08cf53ac7b0b6177da6b671314998021
2023-05-19 17:04:04 -07:00
Jagrut Desai
709242e89e Fix Taskbar Education Tooltip Bottom Margin
Test: Manual
Bug: 282990924
Flag: Not needed
Change-Id: I977e7fc84382b1c43612516c8d6f27610ad25a3f
2023-05-19 15:45:41 -07:00
Vadim Tryshev
8d1de90744 Revert "Re-enabling a couple of tests"
This reverts commit 81b228a5fb.

Reason for revert: b/283523638

Change-Id: I2787b34e369ed2c879d80806bc30cab3dbb10c69
2023-05-19 21:17:55 +00:00
Achim Thesmann
ab66d1461d Allow BAL in Launcher
Widgets like Google News were blocked when they tried to start
background activities on non-Pixel devices that use Launcher3.

Bug: 281617254
Test: manual test
Change-Id: I2b68aeafd0d1dce7b37428dcada58d2648e57681
2023-05-19 21:05:56 +00:00
Vinit Nayak
258019fe8e Merge "Separate code paths to launch split from existing pair vs new pair" into udc-dev 2023-05-19 17:51:23 +00:00
Vadim Tryshev
bc4813afb2 Merge "Re-enabling a couple of tests" into udc-dev 2023-05-19 17:37:16 +00:00
Luca Zuccarini
2449a01b22 Add a view type check to ensure the right animation is used.
Bug: 265134143
Test: recorded perfetto trace, see bug
Change-Id: If6abc36f0f43c6bb632fc824c19717c1231b32dc
2023-05-19 09:51:15 +00:00
Hongwei Wang
0c66b151e3 Merge "Notify WMShell on aborting auto-enter-pip" into udc-dev 2023-05-18 23:00:03 +00:00
Randy Pfohl
f6b74f1521 Merge "Updating overview colors to utilize new tokens" into udc-dev 2023-05-18 22:43:30 +00:00
Saumya Prakash
66e7ec721b Merge changes If2c82082,I03532b80 into udc-dev
* changes:
  Update Lottie animations for gesture navigation tutorial to enable custom colors
  Update gesture tutorial colors
2023-05-18 22:01:49 +00:00