Commit Graph

447 Commits

Author SHA1 Message Date
Stefan Andonian
df57fd822c Merge "Allow Binding the First Workspace Page before the Rest." into tm-qpr-dev 2023-03-13 20:54:03 +00:00
Brandon Dayauon
cf88ea1e62 Support two line text in AllApps/OnDeviceSearch w/ feature flag
Made separate feature flag for on device search
Add unit test to test twoLine string
- Unit tests for testing newStringThatShouldSupportTwoLineText() in BubbleTextView.java. This class tests a couple of strings
and uses the getLineCount() to determine if the test passes. Verifying with getLineCount() is sufficient since BubbleTextView can only be in one line or two lines,
and this is enough to ensure whether the string should be specifically wrapped onto the second line and to ensure truncation.

bug: 201388851
test: presubmit, ran locally on big and small device, before: https://screenshot.googleplex.com/3Q6pwveFDZqxDXL (ORIGINAL TWO LINE TEXT)
after:  https://screenshot.googleplex.com/7pkwUto6HGzMYoT

Change-Id: I93e6ed179e1081d5cdffc6db9c7ae34de8021c24
2023-03-09 15:13:04 -08:00
Brandon Dayauon
dee687c33a Play original haptic when feature flag is off. Rename feature flag
- Remove the Utilities.atLeast check since it's no longer relevant as there is no new haptics being played
in the original haptic..

When FeatureFlag is off, the haptic for all apps and qsb is played in one place. So when
FeatureFlag is on, we need to isolate where the haptic call gets played so we disable calling it from two places
and play the haptics at the respective areas.
flag: ENABLE_PREMIUM_HAPTICS_ALL_APPS=false


bug: 270634265
test: Manual
Change-Id: I7b92c427e880b196130270ed9709cf1ea0e19e0a
2023-03-09 00:14:14 +00:00
Stefan Andonian
9abd8cbf14 Allow Binding the First Workspace Page before the Rest.
The way WorkspaceBinder is currently setup, any calls to
bindWorkspace will result in the entire workspace being bound
all at the same time. These edits change that. Now callers
like LoaderTask can bind the first workspace pages before the
rest by splitting the WorkspaceBinding into 3 methods that
need to be called in order, but can happen at a staggered cadence.

Bug: 251502424
Test: Loaded and bound the workspace properly.
Change-Id: I28fa721ea95dae2df03e27f600653ba5bebe3ef1
2023-03-08 04:23:43 +00:00
Sunny Goyal
b138ec9fc6 Adding support for overriding flag values in test
Bug: 270386012
Test: Verified on device
Change-Id: Ic1af9ca369c0cd2ec49d98875f7b97e90a0050ca
2023-03-03 09:29:42 -08:00
Sunny Goyal
f4bead71ea Merge "Restarting launcher if a flag changes" into tm-qpr-dev 2023-03-02 16:23:45 +00:00
Sunny Goyal
0788fd792e Removing some usused features
Bug: 270386012
Test: Presubmit
Change-Id: Ica71109d43c42d9d0d5269520f7b7e72921f42a6
2023-03-01 09:51:24 -08:00
Alex Chau
6a10a003d6 Merge "Land ENABLE_TASKBAR_IN_OVERVIEW" into tm-qpr-dev 2023-03-01 17:13:35 +00:00
Liam, Lee Pong Lam
237d663b70 Add feature flag for remove smartspace default date
Bug: 269761613
Test: Manual

Change-Id: I9d315a5889bb35efa4b3db91e3af6c981c6b9665
2023-03-01 03:46:37 +00:00
Alex Chau
8aa3f00238 Land ENABLE_TASKBAR_IN_OVERVIEW
Fix: 270393449
Test: manual
Change-Id: I731bfa8ee86154fd034781e27272abc81a6fe6c6
2023-02-28 20:18:32 +00:00
Sunny Goyal
2003c1c73f Restarting launcher if a flag changes
> Only restart when the screen is off.
> This allows better propogation of flags similar to systemUI
> Adding support for integer flags

Bug: 266854800
Test: Verified on device using device_config shell command
Change-Id: I4ea9c564f2d973f11f9570b5a21365183afefab7
2023-02-28 12:01:22 -08:00
Sunny Goyal
1297f400bc Merge "Moving flag creation to a separate file" into tm-qpr-dev 2023-02-28 19:18:25 +00:00
Sunny Goyal
98204add71 Moving flag creation to a separate file
> This provides better control over proguarding descriptions
> Enforcing bug number in flag creation

Bug: 270386012
Test: Presubmit and verified on device
Change-Id: I31014e397690379024d2e42c0e913ce806b9569c
Merged-In: I31014e397690379024d2e42c0e913ce806b9569c
2023-02-28 18:05:42 +00:00
Sunny Goyal
ae030217db Merge "Moving IS_DEBUG_DEVICE to a compile time flag for better proguard support" into tm-qpr-dev 2023-02-25 00:53:56 +00:00
Sunny Goyal
c2e3a8afec Adding bug number for each feature flag
Bug: 270386012
Test: N/A
Change-Id: Ibe2d5b252c8c71dd0e6b77090b04e1a427a8c23c
Merged-In: Ibe2d5b252c8c71dd0e6b77090b04e1a427a8c23c
2023-02-23 22:05:10 +00:00
TreeHugger Robot
01c1dff441 Merge "ENABLE_WIDGET_PICKER_DEPTH" into tm-qpr-dev 2023-02-23 13:22:15 +00:00
Alex Chau
8da1cac660 Merge "Revert "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile""" into tm-qpr-dev 2023-02-23 10:51:55 +00:00
Sunny Goyal
29fa0f3b66 Moving IS_DEBUG_DEVICE to a compile time flag for better proguard support
Bug: 270386012
Test: Presubmit
Change-Id: Ic4a81567f5b9752ab17c725566ce728c3d767bd6
2023-02-22 17:02:45 -08:00
Sunny Goyal
171bb04407 Removing some obsolete features
Bug: 270386012
Test: Presubmit
Change-Id: I9d68b3d17e02d6e79ab726eb7c8da1e5a4d337ef
2023-02-22 23:17:15 +00:00
Alex Chau
eabf2c39f7 Revert "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile""
This reverts commit 5dfd939d41.

Reason for revert: b/270395565
Bug: 253338238

Change-Id: I6b2e44c92a67f6675d6947f34167a5f0c1cc6a45
2023-02-22 20:31:10 +00:00
Alex Chau
ce9766da2d ENABLE_WIDGET_PICKER_DEPTH
Fix: 270393895
Test: manual
Change-Id: I167354425e5469663c283919f84c8bdf664cceec
2023-02-22 20:18:39 +00:00
Kevin Lim
d8c97f669f [DenserUI] Add feature flag for app icon in inline shortcuts.
Bug: 268667774
Test: Tested in functional change: ag/21409510
Change-Id: Ifbd0bf1ed244e09b85236c02be289bfc026599e3
2023-02-21 21:39:38 +00:00
Jagrut Desai
202c68c8a2 Merge "Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY Test: Visual(pics in buganizer) Bug: 265462138 Bug: 267382941" into tm-qpr-dev 2023-02-16 17:39:35 +00:00
Schneider Victor-tulias
673e6437b8 Merge "Add the KeyboardQuickSwitchView (1/2)" into tm-qpr-dev 2023-02-14 17:46:23 +00:00
Schneider Victor-tulias
f908729fa8 Add the KeyboardQuickSwitchView (1/2)
Preparatory change for adding the KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: I468481a023e82d3ef7c7d4d44c5b9435173b49ae
2023-02-13 15:34:39 -08:00
Jagrut Desai
ec0b4e1693 Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY
Test: Visual(pics in buganizer)
Bug: 265462138
Bug: 267382941

Change-Id: I223cd5ea7e5b553619dfc81c36f1be93e399639d
2023-02-13 13:34:23 -08:00
Brandon Dayauon
0abe8af6a6 Merge "Add featureFlag for icon in textheader" into tm-qpr-dev 2023-02-13 17:52:58 +00:00
Nicolò Mazzucato
5147b1d509 Merge "Drive Launcher unfold animation from System UI" into tm-qpr-dev 2023-02-11 09:24:42 +00:00
Brandon Dayauon
b648c9eda3 Merge "Zero state feature flag" into tm-qpr-dev 2023-02-11 05:50:46 +00:00
Nicolo' Mazzucato
8d9edd292b Drive Launcher unfold animation from System UI
Before this cl, both Launcher and System UI processes were registering for hinge angle and device state (e.g. folded/unfolded) change events to calculate the current unfold animation progress. In some cases, launcher ui thread was busy, delaying the progress calculation from the hinge angle value (that was received ~at the same time by both processes). This resulted in launcher and sysui unfold animation not being synchronized in some cases.

With this cl, System UI process uses OverviewProxyService to send the unfold events to Launcher. In this way, both process always have the exact same progress (+- 1 frame)

This is currently guarded by a launcher flag, by default with the new behaviour, to allow devs to compare the experience and easily debug potential regressions.

Bug: 268490854
Test: Analysed perfetto trace + RemoteUnfoldTransitionProgressProviderTest + manual
Change-Id: If15fd6fe39abb3d922c5fdb327100206dfa3665d
2023-02-10 22:04:19 +00:00
Lucas Silva
bc333343ec Merge "Allow QuickstepTransitionManager to be overridden" into tm-qpr-dev 2023-02-10 20:47:27 +00:00
Lucas Silva
099341fa97 Allow QuickstepTransitionManager to be overridden
This allows for custom animations in classes inheriting from
QuickstepLauncher

Bug: 260637266
Test: flashed device and verified animation
Change-Id: I21fa112851e9ce43037151fc4c2fd21e90056712
2023-02-10 10:41:39 -05:00
Charlie Anderson
5b3d4806f9 Updating flag for U Popup in separate CL
Bug: b/247880037
Test: manually
Change-Id: I40bbddc801872dcb0c144f77f1c94feed5afaa40
2023-02-09 10:42:12 -05:00
Brandon Dayauon
f4437f742e Merge "Implement diff haptics going into all apps" into tm-qpr-dev 2023-02-09 00:45:24 +00:00
TreeHugger Robot
96328e98d1 Merge "Remove ENABLE_TASKBAR_REVISED_THRESHOLDS feature flag." into tm-qpr-dev 2023-02-07 21:03:18 +00:00
Brandon Dayauon
12c193e6c5 Implement diff haptics going into all apps
Notes:
* the reason why 0.6 -> 1 never happened was because of AllAppsSwipeController where
it had a clampToProgress. By changing lowerbound to 0 the progress actually shows fully 0->1

- composed the haptics in the constructor
- added new listener class in AATransitionController

Added featureflag

bug: 233751149
test: Manually - presubmit, ran “make -j7 Launcher3” from master branch  photo: https://screenshot.googleplex.com/8r5FZh6buzkQMjk
Change-Id: I5e1a24170fdbfdd35b8d8f24af0ec5e8586641a2
2023-02-07 11:36:42 -08:00
Jon Miranda
24bd17f23d Remove ENABLE_TASKBAR_REVISED_THRESHOLDS feature flag.
Test: manual
Fixes: 268056334
Change-Id: Iab0eb1ca76b49f0acb96f50274cb2c81d9f213a5
2023-02-07 09:09:52 -08:00
Holly Jiuyu Sun
2560660062 Merge "[play] Add feature flag for play." into tm-qpr-dev 2023-02-07 02:15:14 +00:00
Holly Sun
76bb3bef8e [play] Add feature flag for play.
Bug: 260712395
Test: manual
Change-Id: Ib96ab0789e0648fdc311f31f52b9867fe0253a69
2023-02-06 15:30:34 -08:00
TreeHugger Robot
fd9f322bdb Merge "[QL-v3] Move quick launch v3 flag to AllAppsDeviceConfigFlag" into tm-qpr-dev 2023-02-04 06:53:54 +00:00
Holly Sun
7030729e72 [QL-v3] Move quick launch v3 flag to AllAppsDeviceConfigFlag
Bug: 261629630
Test: manual
Change-Id: I5d553e727748591070e0015f6fec13d1765ff2c0
2023-02-02 13:50:58 -08:00
Pat Manning
7b8f766b85 Move overview actions to task menu when no focused task.
Bug: 265641913
Test: manual
Change-Id: I03a88275b399940468246a69365f76f7deda724e
2023-02-02 11:37:15 +00:00
Brian Isganitis
7eb187b197 Enable taskbar EDU tooltip flag.
Test: Manual
Fix: 263157739
Change-Id: Iaf02a42a2ff02b25b5068c7241f894e586c42e1b
2023-01-31 14:07:56 -08:00
TreeHugger Robot
71e2763b6e Merge "[QL-v3] Add feature flag." into tm-qpr-dev 2023-01-31 20:41:02 +00:00
TreeHugger Robot
fd02dce88f Merge "Add flag for new download app UI color and contrast update." into tm-qpr-dev 2023-01-31 19:16:06 +00:00
Federico Baron
9984d810ea Add flag for new download app UI color and contrast update.
There have been new developments in the design of download apps to have better colors with better contrast. We will guard this progress under this flag.

Bug: 267272201
Test: N/A
Change-Id: I905436f32daeb62bed26b483773283ce38f66923
2023-01-31 01:05:10 -08:00
Brandon Dayauon
be533df003 Zero state feature flag
bug: 262773731
test: Manual - turned feature flag on/off
Change-Id: Ie3ea451473c5f8e3feb13c002f3b505e98e7da85
2023-01-30 13:49:31 -08:00
Luca Zuccarini
2098381808 [Toast] Introduce SysUI's animation library to the transition manager.
Bug: 250588519
Test: manual, see videos in bug
Change-Id: Iccc440c95ecc14d39e35d911798e239b698b950a
2023-01-27 13:49:40 +00:00
Holly Sun
6a62176621 Move ENABLE_HIDE_GBOARD_HEADER_STATIC from feature flag to server side flag.
Bug: 266708932
Test: manual with adb command
Change-Id: Id064367ee970120cf0aa668b9c81613f7262bad8
2023-01-25 10:12:38 -08:00
Brandon Dayauon
847e7e678e Add featureFlag for icon in textheader
bug: 265337277
test: manual- presubmit
Change-Id: Icbf96d29d0ab7c96dcbd300a5df9152cf4552eb5
2023-01-24 12:30:54 -08:00