Commit Graph

14852 Commits

Author SHA1 Message Date
Stefan Andonian
05ca3a8089 Refactor Workspace Loading / Processing code.
There are no behavioral changes (other than we no longer are recycling
objects while processing workspace items), but this refactor will setup
the next change to load the first workspace page before other workspace
pages.

Bug: 251502424
Test: Workspace, app widgets, and containers loaded properly.
Change-Id: I437aab40000d841d7fcc4380d05ab4a8f5d5c2ad
2023-02-15 17:36:27 +00:00
Charlie Anderson
9af03389d6 Merge "adding the new Material U App Shortcut Popup design" into tm-qpr-dev 2023-02-15 15:11:49 +00:00
Luca Zuccarini
190992e6fb Merge "[Toast] Disable decorator updates if background drawables are used." into tm-qpr-dev 2023-02-15 11:37:11 +00:00
Sebastián Franco
aa6f00af01 Merge "Fix issue where bottom scrim appears in homescreen when it shouldn't" into tm-qpr-dev 2023-02-15 01:57:03 +00:00
Federico Baron
e958fb2e7f Merge "Remove unused file WidgetsListSearchHeaderHolder" into tm-qpr-dev 2023-02-15 00:46:18 +00:00
Sebastian Franco
40f94c84f8 Fix issue where bottom scrim appears in homescreen when it shouldn't
The bottom scrim should be shown for the Pixel Launcher, other third
party launchers show it when the 3 bottom navigation is activated.

The existing condition for 3 bottom navigation is no longer valid
because the insets at the bottom can be greather than 0 in other
situations other than 3 bottom navigation.

Test: the scrom should not show at all
Test: It appears in some situations where the taskbar is showing
and the scrim gets updates which not always happens so it's hard to
manually recreate, but there is a test that is flaky because of it
HomeScreenImageTabletTest#comparePixelTablet2023HomeScreen.
Fix: 267614579

Change-Id: Iacaf93011aa3f2f643186560fe34b4b26ce52314
2023-02-14 13:46:44 -08:00
Charlie Anderson
8ad9144ca2 adding the new Material U App Shortcut Popup design
Bug: 247880037
Test: tested manually
Change-Id: I66c291df54dfc2a76fc974082a19091deb167f73
2023-02-14 16:03:15 -05:00
Federico Baron
521e3748d8 Merge "Fix wrong widget appearing in widget picker for tablet" into tm-qpr-dev 2023-02-14 19:28:19 +00:00
Schneider Victor-tulias
673e6437b8 Merge "Add the KeyboardQuickSwitchView (1/2)" into tm-qpr-dev 2023-02-14 17:46:23 +00:00
Federico Baron
b215c5416e Remove unused file WidgetsListSearchHeaderHolder
WidgetsListSearchHeaderHolder was the only file that remained after all the redundant widget search header logic got removed. It is dead code now so this CL deletes it.

Bug: 268646258
Test: Verified on device
Change-Id: I670364bd7c2d5ce46d2c8837ef483e5ac2315547
2023-02-14 01:49:55 -08:00
Schneider Victor-tulias
f908729fa8 Add the KeyboardQuickSwitchView (1/2)
Preparatory change for adding the KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: I468481a023e82d3ef7c7d4d44c5b9435173b49ae
2023-02-13 15:34:39 -08:00
Federico Baron
ecb0532597 Fix wrong widget appearing in widget picker for tablet
The wrong widget would appear in tablets because we were finding the widgets by PackageUserKey title instead of comparing the PackageUserKey objects themselves.

Fix: 269160189
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and verify that in landscape mode in tablet clicking the battery header shows the correct widget
Change-Id: I4f17ba057d9287fc83e3b1e0072cacf0eee3deef
2023-02-13 13:53:55 -08:00
Sunny Goyal
a75105ef03 Merge "Moving widget background to xml, so that the same constantstate is used for all entries" into tm-qpr-dev 2023-02-13 18:12:43 +00:00
Brandon Dayauon
0abe8af6a6 Merge "Add featureFlag for icon in textheader" into tm-qpr-dev 2023-02-13 17:52:58 +00:00
Sunny Goyal
77e732a1c4 Moving widget background to xml, so that the same constantstate is
used for all entries

This helps reduce launcher memory by avoiding multuple duplicate
drawable generation

Bug: 268646258
Test: Verified on device
Change-Id: I829750f081cfce65063b35a614b903066d9a4bed
2023-02-13 05:49:31 +00:00
Nicolò Mazzucato
5147b1d509 Merge "Drive Launcher unfold animation from System UI" into tm-qpr-dev 2023-02-11 09:24:42 +00:00
Brandon Dayauon
b648c9eda3 Merge "Zero state feature flag" into tm-qpr-dev 2023-02-11 05:50:46 +00:00
Sunny Goyal
290998522c Merge "Removing unnecessary search header duplication" into tm-qpr-dev 2023-02-10 23:10:49 +00:00
Nicolo' Mazzucato
8d9edd292b Drive Launcher unfold animation from System UI
Before this cl, both Launcher and System UI processes were registering for hinge angle and device state (e.g. folded/unfolded) change events to calculate the current unfold animation progress. In some cases, launcher ui thread was busy, delaying the progress calculation from the hinge angle value (that was received ~at the same time by both processes). This resulted in launcher and sysui unfold animation not being synchronized in some cases.

With this cl, System UI process uses OverviewProxyService to send the unfold events to Launcher. In this way, both process always have the exact same progress (+- 1 frame)

This is currently guarded by a launcher flag, by default with the new behaviour, to allow devs to compare the experience and easily debug potential regressions.

Bug: 268490854
Test: Analysed perfetto trace + RemoteUnfoldTransitionProgressProviderTest + manual
Change-Id: If15fd6fe39abb3d922c5fdb327100206dfa3665d
2023-02-10 22:04:19 +00:00
Lucas Silva
bc333343ec Merge "Allow QuickstepTransitionManager to be overridden" into tm-qpr-dev 2023-02-10 20:47:27 +00:00
Sunny Goyal
62a4932310 Removing unnecessary search header duplication
Bug: 268646258
Test: Verified on device
Change-Id: I33a7df6a523e5600dc6251c3d8feff1236362705
2023-02-10 11:26:05 -08:00
Federico Baron
740541e0a0 Merge "Implement two pane widget picker" into tm-qpr-dev 2023-02-10 17:20:55 +00:00
Sunny Goyal
c424941565 Merge "Updating Drawables as per GraphicsUtils changes" into tm-qpr-dev 2023-02-10 16:46:19 +00:00
Lucas Silva
099341fa97 Allow QuickstepTransitionManager to be overridden
This allows for custom animations in classes inheriting from
QuickstepLauncher

Bug: 260637266
Test: flashed device and verified animation
Change-Id: I21fa112851e9ce43037151fc4c2fd21e90056712
2023-02-10 10:41:39 -05:00
Fengjiang Li
ab04ffb491 [Predictive Back] All apps to home on tablet
Scale down bottom sheet background during predictive back on tablet

Test: manual
Bug: b/267226579, b/267226556
Change-Id: Ie67689a05d631a480bcc2ae602b5caf4feaf8182
2023-02-10 00:53:12 +00:00
Federico Baron
4b1a38bb7d Implement two pane widget picker
The widget picker design is currently not optimized for large screen form factor devices.
We resolve that by adding a two pane widget picker like that of the design in go/widget-picker-2023.

Bug: 256684299
Test: Make sure to be on a tablet in landscape mode.
        1.Turn on flag LARGE_SCREEN_WIDGET_PICKER.
        2. Press and hold on an empty spot in workspace until the popup menu appears.
        3. Click widgets.
        4. Notice the new two pane layout
Change-Id: Ia3ea17dc320f72f9bc5dea52399ff51d9161602b
2023-02-09 16:36:45 -08:00
Sunny Goyal
799e12077b Updating Drawables as per GraphicsUtils changes
Bug: 266661614
Test: Presubmit
Change-Id: Ia3d0e0bc7a2b019d234e3bca71e893d5c4c54ca8
2023-02-09 16:14:04 -08:00
TreeHugger Robot
b9f2727171 Merge "Log sizes being sent to widgets" into tm-qpr-dev 2023-02-09 23:32:57 +00:00
Charlie Anderson
5b3d4806f9 Updating flag for U Popup in separate CL
Bug: b/247880037
Test: manually
Change-Id: I40bbddc801872dcb0c144f77f1c94feed5afaa40
2023-02-09 10:42:12 -05:00
Luca Zuccarini
9395830195 [Toast] Disable decorator updates if background drawables are used.
These lines cause an NPE when using Toast after toggling the flag.

Bug: 268470113
Test: manual
Change-Id: I3b2b162cde37fe780580872e015672c0c9339e4f
2023-02-09 13:18:00 +00:00
Thales Lima
5d5aad3024 Merge "Create an XML parser for WorkspaceSpecs" into tm-qpr-dev 2023-02-09 11:19:59 +00:00
Brandon Dayauon
f4437f742e Merge "Implement diff haptics going into all apps" into tm-qpr-dev 2023-02-09 00:45:24 +00:00
Sebastián Franco
00cbb5e63c Merge "Fix foldable single page bug" into tm-qpr-dev 2023-02-08 22:31:39 +00:00
Sebastian Franco
1c017d5d58 Fix foldable single page bug
I did a last minute change and uploaded the wrong branch.

Bug: 268356439
Change-Id: Ia11ce681d57b7a637c01b2155b16486cf5fd648f
2023-02-08 18:29:36 +00:00
Thales Lima
1a2d4bd6f4 Create an XML parser for WorkspaceSpecs
Extract DeviceProfileTest to Launcher3 so it can be used in other tests as well, and change name of previous base test to be more descriptive.

Bug: 241386436
Test: WorkspaceSpecsTest
Change-Id: I64613bb5a23c374ed15fb6d936192236a541ab9b
2023-02-08 11:20:14 +00:00
Thales Lima
fcb6a5fc06 Merge "Improvements for All Apps on different display sizes" into tm-qpr-dev 2023-02-08 10:02:17 +00:00
Sebastián Franco
726e9acea4 Merge "Simulating a split screen CellLayout using one CellLayout" into tm-qpr-dev 2023-02-08 01:04:20 +00:00
Sebastian Franco
09589326db Simulating a split screen CellLayout using one CellLayout
Test: atest ReorderWidget
Fix: 188081026
Change-Id: I8eda5f77c11dc2625ae1f028d07539c28018fb55
2023-02-07 17:03:22 -08:00
TreeHugger Robot
3c86d903a6 Merge "[Predictive Back] Revert all apps scale when exiting from search" into tm-qpr-dev 2023-02-08 00:38:11 +00:00
TreeHugger Robot
96328e98d1 Merge "Remove ENABLE_TASKBAR_REVISED_THRESHOLDS feature flag." into tm-qpr-dev 2023-02-07 21:03:18 +00:00
TreeHugger Robot
71a7a13f06 Merge "Rotate back button drawable when IME present." into tm-qpr-dev 2023-02-07 20:32:31 +00:00
Brandon Dayauon
12c193e6c5 Implement diff haptics going into all apps
Notes:
* the reason why 0.6 -> 1 never happened was because of AllAppsSwipeController where
it had a clampToProgress. By changing lowerbound to 0 the progress actually shows fully 0->1

- composed the haptics in the constructor
- added new listener class in AATransitionController

Added featureflag

bug: 233751149
test: Manually - presubmit, ran “make -j7 Launcher3” from master branch  photo: https://screenshot.googleplex.com/8r5FZh6buzkQMjk
Change-Id: I5e1a24170fdbfdd35b8d8f24af0ec5e8586641a2
2023-02-07 11:36:42 -08:00
Pat Manning
e68ae41196 Rotate back button drawable when IME present.
Currently rotation for IME rotates the whole view, including the background.

Fix: 266874111
Test: manual.
Change-Id: Iea310c99d0714d98ce534a0170316a0fb351f57d
2023-02-07 17:55:59 +00:00
Jon Miranda
24bd17f23d Remove ENABLE_TASKBAR_REVISED_THRESHOLDS feature flag.
Test: manual
Fixes: 268056334
Change-Id: Iab0eb1ca76b49f0acb96f50274cb2c81d9f213a5
2023-02-07 09:09:52 -08:00
Nicolo' Mazzucato
e8ee34ad8a Move Launcher classes shared between tests and prod in a separate lib
This is necessary because otherwise those are included in several gradle projects. Gradle doesn't support the same files imported in different projects, and it removes them from a random one if it happens, resulting in missing symbols.

This extracts the shared files in a new target, and adds it as dep of the original target.

Test: Build launcher + execute a few tests manually with gradle + verify that Launcher.java can resolve all symbols with gradle config
Bug: 262267728
Change-Id: Ida5b25c45320d517603834112f4699e4d3344c03
2023-02-07 12:03:10 +00:00
Holly Jiuyu Sun
2560660062 Merge "[play] Add feature flag for play." into tm-qpr-dev 2023-02-07 02:15:14 +00:00
TreeHugger Robot
becfd2ac75 Merge "Marking that we process REQUEST_ENABLE_ROTATION" into tm-qpr-dev 2023-02-07 01:39:02 +00:00
TreeHugger Robot
4a2bf3b131 Merge "Update tests to support floating search." into tm-qpr-dev 2023-02-06 23:50:49 +00:00
Holly Sun
76bb3bef8e [play] Add feature flag for play.
Bug: 260712395
Test: manual
Change-Id: Ib96ab0789e0648fdc311f31f52b9867fe0253a69
2023-02-06 15:30:34 -08:00
vadimt
3c2ab8b1e1 Marking that we process REQUEST_ENABLE_ROTATION
Bug: 187761685
Test: presubmit
Change-Id: I8239cd59dada685618fb273ef5840d30756ec84a
2023-02-06 15:00:49 -08:00