Commit Graph

6601 Commits

Author SHA1 Message Date
Tracy Zhou
c91ef50257 Animate split confirmation after second app selection from workspace
Fixes: 239824922
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/099acb31-1e05-4d00-a670-590c177a846e
Change-Id: Ifb769afcaf694a1157444f273da69331db15ab1a
2022-11-30 03:39:02 +00:00
Vinit Nayak
792a827309 Merge "Send corrent SUW insets for taskbar portrait vs landscape" into tm-qpr-dev 2022-11-30 00:50:51 +00:00
Jon Miranda
912e6dd64d Merge "Allow touches on transient taskbar if ime is present." into tm-qpr-dev 2022-11-29 22:42:03 +00:00
Jon Miranda
106cc895e9 Allow touches on transient taskbar if ime is present.
Bug: 260101467
Test: open chrome, enter url to pull up ime, swipe up to show taskbar,
      tap on taskbar icon

Change-Id: Ic8be6c2bb82fc9b8ab83572cb8622ac157078ea9
2022-11-29 11:30:39 -08:00
TreeHugger Robot
1330244f0a Merge "Fixing shortcuts not getting theme icons" into tm-qpr-dev 2022-11-29 01:10:38 +00:00
Brian Isganitis
39768edb67 Merge changes Idae0c3d8,I8c599912 into tm-qpr-dev
* changes:
  Stash taskbar while EDU is open.
  Remove Taskbar EDU icon wave animation.
2022-11-28 22:14:42 +00:00
TreeHugger Robot
c04120e61e Merge "Disallow transient taskbar to un/stash in certain sys ui states" into tm-qpr-dev 2022-11-28 18:54:40 +00:00
Alex Chau
735c016bef Merge "Allow 3p launchers to use swipe proxy in AllSetActivity" into tm-qpr-dev 2022-11-28 18:53:59 +00:00
Sunny Goyal
ce4896cff5 Fixing shortcuts not getting theme icons
Bug: 238650110
Test: Updated ThemeIconsTest
Change-Id: I803cd6eefa4e393bf19901a44712622adac7f4b1
2022-11-28 09:48:50 -08:00
Brian Isganitis
84633c1a9d Stash taskbar while EDU is open.
The stashing behavior is consistent with the All Apps overlay.

Test: Manual
Bug: 217261955
Change-Id: Idae0c3d829e806be6c18f00455f7ddd0d60f0efb
2022-11-28 16:02:40 +00:00
Brian Isganitis
92400681a9 Remove Taskbar EDU icon wave animation.
As per the latest mocks, the taskbar will be stashed during EDU to
prevent taskbar interactions that inadvertently close the EDU sheet.
Thus, this animation is no longer needed.

Test: Manual
Bug: 217261955
Change-Id: I8c5999121b7bb927b748d6163575dc4555ece84c
2022-11-28 15:46:17 +00:00
Vinit Nayak
209dd03b69 Send corrent SUW insets for taskbar portrait vs landscape
* There were two separate blocks of code for sending insets
for Taskbar during SUW, consolidate those
* We also weren't changing Taskbar window height corresponding
to the added insets/change of height for different
orientations in SUW

Fixes: 253538830
Test: Went through SUW and switched orientations,
no back button overlap

Change-Id: Ifb3bc1c20a793ef062bf338a3bdf933b8ae98c28
2022-11-24 10:29:16 -08:00
Pat Manning
bc75ac55fd Allow 3p launchers to use swipe proxy in AllSetActivity
Bug: 257926371
Test: manual
Change-Id: If70412ecaa81481d8147abb3c52859ae4ea54a11
2022-11-24 14:57:08 +00:00
Jon Miranda
3535426bea Merge "Check for isTaskbarPresent in addition to isTransientTaskbar when the method is called outside of taskbar." into tm-qpr-dev 2022-11-24 01:28:18 +00:00
Jon Miranda
81bc0b78ce Disallow transient taskbar to un/stash in certain sys ui states
Bug: 258604928
Test: cant un/stash with keyguard, notifications, or qs open
      can un/stash in app as expected

Change-Id: Ib422a35fb31fc818123eae39ac3a7e6deb79f187
2022-11-23 15:26:06 -08:00
Vinit Nayak
dba5a396b0 Merge "Prevent empty recents going home when splitting with taskbar present" into tm-qpr-dev 2022-11-23 22:20:44 +00:00
Jon Miranda
807823155d Check for isTaskbarPresent in addition to isTransientTaskbar
when the method is called outside of taskbar.

This prevents the case where phone runs transient taskbar logic.

Bug: 260006210
Test: added local logs, tested in phone mode
Change-Id: I600c06d6c797bd68461ac033dcc2c6158f221024
2022-11-23 12:05:43 -08:00
Pat Manning
82f05a857d Merge "Set grid progress even when task count is 0." into tm-qpr-dev 2022-11-23 11:31:35 +00:00
Vinit Nayak
182eb9dc15 Prevent empty recents going home when splitting with taskbar present
* Recents is empty, so it thinks we need to go home
* Split selection state prevents that, since second app can be
choosen from taskbar

Fixes: 260024461
Test: Recents still goes home when taskbar not present and
has no recent tasks. Doesn't go home when split with a single task;
second task launches correctly from taskbar

Change-Id: Ib5fc7989c66c5efccde53ea48319f9669cd664e2
2022-11-22 13:20:49 -08:00
Ikram Gabiyev
bb1e2a526a Merge "Remove on drag listener after drag ended" into tm-qpr-dev 2022-11-22 19:24:37 +00:00
Tony Wickham
da858aab44 Merge "Override displacement for transient taskbar instead of mCurrentShift" into tm-qpr-dev 2022-11-22 18:37:22 +00:00
Jon Miranda
e57cab1da8 Merge "Add revised thresholds for transient taskbar behind flag ENABLE_TASKBAR_REVISED_THRESHOLDS." into tm-qpr-dev 2022-11-22 17:20:21 +00:00
Ikram Gabiyev
7d633ecb07 Remove on drag listener after drag ended
Remove the on drag listener for the drag layer
in the taskbar after ACTION_DRAG_ENDED is received

This is an additional refactoring discussed
in ag/20490352

Bug: 258850827

Test: manually reproduced the steps in the bug
Change-Id: Ibe207001f41d3ba97a8acaf17d633cbd6682fafd
2022-11-22 06:07:09 +00:00
TreeHugger Robot
654ba7f6a8 Merge "Cleanup overview threshold which was only needed for 2-button mode" into tm-qpr-dev 2022-11-22 01:16:26 +00:00
Jon Miranda
3d72ac1a78 Add revised thresholds for transient taskbar behind flag ENABLE_TASKBAR_REVISED_THRESHOLDS.
Bug: 260002412
Test: enable flag
Change-Id: I4d82a853061b1540b6c6aea5e58b05a3ea6638e0
2022-11-21 23:46:34 +00:00
Tony Wickham
7a19cccafe Override displacement for transient taskbar instead of mCurrentShift
mCurrentShift is based on displacement, but is used and set in different
places. To keep consistency throughout, we should override the
displacement at the source instead.

Test: manually swiped up between home/overview threshold and catch up
threshold; let go to go to overview and ensure no jump occurs.
Flag: teamfood (ENABLE_TRANSIENT_TASKBAR)
Fixes: 259981285

Change-Id: Id9f5b2bcdc2e56e15ddb6d93c4ee5d5ececc094d
2022-11-21 20:14:56 +00:00
Ats Jenk
1a8b95a9d4 Merge "Add onTaskMovedToFront to close floating views" into tm-qpr-dev 2022-11-21 19:04:15 +00:00
Brian Isganitis
0ccbd7334c Merge "Do not start drag from pre-drag if cancelled during animation." into tm-qpr-dev 2022-11-21 19:04:04 +00:00
Brian Isganitis
455eca41be Merge "Still launch disabled item if we can't handle its click." into tm-qpr-dev 2022-11-21 19:02:44 +00:00
Schneider Victor-tulias
b9e03da563 Merge "Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."" into tm-qpr-dev 2022-11-21 19:01:04 +00:00
TreeHugger Robot
104517cefb Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev 2022-11-21 18:30:19 +00:00
TreeHugger Robot
8700307b23 Merge "Fix NPE from using DeviceLockedInputConsumer after the surface has been released" into tm-qpr-dev 2022-11-21 18:18:49 +00:00
Tony Wickham
9cddf4133b Cleanup overview threshold which was only needed for 2-button mode
- Removed hasReachedOverviewThreshold() and mPassedOverviewThreshold
- Changed calculateEndTargetForNonFling() to check velocity.y to
  determine whether to go HOME or LAST_TASK when no other conditions are
  met (e.g. mIsMotionPaused still goes to RECENTS). To allow transient
  taskbar to override this so that user stays in LAST_TASK when invoking
  the taskbar, kept setHasReachedHomeOverviewThreshold() but renamed it
  to setCanSlowSwipeGoHome(),

Test: TaplTestsQuickstep, manually tested on tablet and phone to ensure
the correct end target was chosen when hitting this code path in
calculateEndTargetForNonFling
Flag: teamfood (ENABLE_TRANSIENT_TASKBAR)
Fixes: 259715295

Change-Id: I925be3433d7d2792cdc2a75a18dc575019f2cc95
2022-11-21 17:57:20 +00:00
Schneider Victor-tulias
1ba39205bc Fix NPE from using DeviceLockedInputConsumer after the surface has been released
Fixes: 243154747
Test: swipe up from camera app while device is locked
Change-Id: Ia92e3e3cccb37e0d14592b0f3094f5aba1073300
2022-11-19 12:26:34 -08:00
Brian Isganitis
4ff301eb9d Do not start drag from pre-drag if cancelled during animation.
This change affects the preDragCondition for icons that do not have a
popup menu. The condition assumes we are still in pre-drag after
DragView is finished animating, but the user can cancel the drag in this
time (e.g. by releasing their finger early).

Test: Manual. Holding and releasing on suspended icon does not crash,
while holding and dragging still works as expected.
Fix: 258233476

Change-Id: Ic76f785cffcbfe0fe51eb1473022f2dc34563070
2022-11-19 02:32:08 +00:00
Ikram Gabiyev
793c37153a Merge "Stash transient taskbar upon icon drag" into tm-qpr-dev 2022-11-19 02:19:25 +00:00
Jon Miranda
e912742234 Merge "Prevent x-axis window movement during the initial swipe up to show transient taskbar" into tm-qpr-dev 2022-11-19 01:58:37 +00:00
Sihua Ma
7b516983bc Merge "Clear drag views during swipe up animation progress" into tm-qpr-dev 2022-11-18 22:59:10 +00:00
Brian Isganitis
543528594a Merge "Only allow one TaskbarRecentsAnimationsListener at a time." into tm-qpr-dev 2022-11-18 21:38:58 +00:00
Hawkwood Glazier
d5ab17164d Merge "Update PluginManager Import" into tm-qpr-dev 2022-11-18 21:17:18 +00:00
Jon Miranda
08be3775f6 Prevent x-axis window movement during the initial swipe up to show transient taskbar
- If gesture starts and isLikelyToStartANewTask=true, we do not clamp
- If gesture starts and isLikelyToStartANewTask=false AND transient taskbar is not
  already showing, we clamp the scrolling

Bug: 258851206
Test: swipe up to show taskbar, no x-axis movement
      swipe left/right still works as expected

Change-Id: Iac194df63e03b4a28b49008983c88c165847aa31
2022-11-18 13:10:34 -08:00
Jon Miranda
e3bcc7bf40 Merge "Fix home/overview threshold." into tm-qpr-dev 2022-11-18 21:02:01 +00:00
Schneider Victor-tulias
e04a878709 Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."
This reverts commit a0be92c830.

Reason for revert: Bug fixed and logs are too verbose

Test: ran launcher and checked logs
Fixes: 244593270
Change-Id: Ia67ba96b0b2146308f9cad1df884144edf2ab186
2022-11-18 11:00:33 -08:00
TreeHugger Robot
9b3aaf2b7d Merge "End live tile when quick settings expands, not just notification shade." into tm-qpr-dev 2022-11-18 16:45:30 +00:00
Jon Miranda
4b26e8f081 Merge "Use mContext instead of TaskbarActivityContex to enable transient taskbar." into tm-qpr-dev 2022-11-18 03:12:00 +00:00
Jon Miranda
21d4253c01 Fix home/overview threshold.
Fixes: 258836670
Test: Enable I06e16d78c179b7c3281f423ed8c7dd6cfc42229a to visually show
      thresholds on screen
      Swipe up to overview where taskbar not showing
      and also with taskbar already showing

Change-Id: Ie7487a5f869c0718d9ee08209dee8331a01d5989
2022-11-17 18:09:31 -08:00
Brian Isganitis
50b3b62eba Merge "Add a11y titles for taskbar windows." into tm-qpr-dev 2022-11-18 01:56:22 +00:00
TreeHugger Robot
3a801de233 Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev 2022-11-18 01:44:01 +00:00
Brian Isganitis
424c7f4393 Still launch disabled item if we can't handle its click.
See where ItemClickHandler#handleDisabledItemClick returns false for
context. If we do not honor this return value, the framework will not
show a dialog in response to attempting launch the item.

Fix: 258232619
Test: Manual
Change-Id: Ie3b112eea17caf0a84defb331133bda9f3add5b6
2022-11-18 01:09:18 +00:00
Brian Isganitis
9390b500a9 Only allow one TaskbarRecentsAnimationsListener at a time.
If another animation is created while one is occurring, we should clean
up the previous one.

Test: Manual
Fix: 233868461
Change-Id: Idf0e33ae95cbf19741ee943e450d478b1e18716b
2022-11-18 00:02:53 +00:00