Commit Graph

760 Commits

Author SHA1 Message Date
Sebastián Franco
015eda683f Merge "Make sure to not call DragOver when the drag is still under PreDrag" into main 2023-09-28 16:13:32 +00:00
Sebastian Franco
1be772df1d Make sure to not call DragOver when the drag is still under PreDrag
Adding a flag so we can turn off this behavior if it break a drag functionallity

Fix: 299748096
Test: most of dragging test will test this
Change-Id: I4f45faea4f19bd99a946a28372546e18ca5f6a2f
2023-09-27 15:05:47 -07:00
Schneider Victor-tulias
f055c25ec1 Merge "Clean up FeatureFlags.java" into main 2023-09-27 17:28:16 +00:00
Brandon Dayauon
cd460094ba Merge "Do a vertical check for two line text, if it clips dont show two line." into main 2023-09-26 22:16:37 +00:00
Schneider Victor-tulias
8d3d623bc7 Clean up FeatureFlags.java
Flag: not needed
Bug: 291651514
Test: not needed
Change-Id: I37d7ac39f5feddab303ccb3c3305e2e2b3b6bd3e
2023-09-26 17:25:33 -04:00
Brandon Dayauon
3cdb32cc1f Do a vertical check for two line text, if it clips dont show two line.
Added extra 16dp to the cell height in DeviceProfile as per spec: https://docs.google.com/presentation/d/1dSt-zY_wRrOmd9a9nsQG458CIK0RUqVJsHJxLHP_0Nc/edit#slide=id.g237e909075a_2_6
Updated tests andincluded vertical check to see if two line can be fully rendered without being clipped. Otherwise just show one line.
Since existing cell height is 104dp, we add 16dp to be up to spec (120dp)
- Clean up FeatureFlag ENABLE_TWOLINE_ALLAPPS and now use aconfig flag

bug: 270390937
Test: manually - photos
Regular font: https://screenshot.googleplex.com/ArUcgZgHqR4ZWBQ
Bigger font than regular that makes text to one line because it wouldve truncate: https://screenshot.googleplex.com/6s8EdMAbBLsYhLi
Bigger font than regular with predicted app row (twoline):
https://screenshot.googleplex.com/38TEQei5GvPiCc7
Super big font: https://screenshot.googleplex.com/3JUYYprJRQ32Hsq
big display and regular font: https://screenshot.googleplex.com/55rBKVQ8htSe9Vc
big display and bigger than regular font: https://screenshot.googleplex.com/3atzKzJUbfM7YQW
flag: is off

Change-Id: I6998ea5da35d3e00ac75327d16b5ca676fb11c1a
2023-09-26 02:38:16 +00:00
Thales Lima
8f58b0a63d Enable TEAMFOOD for ENABLE_RESPONSIVE_WORKSPACE flag
Bug: 299935275
Test: manual
Change-Id: If341730c3eb43ffb243b960ad76bc223058e426d
2023-09-25 16:27:21 -07:00
Thales Lima
ca31b6105e Migrate ENABLE_RESPONSIVE_WORKSPACE to aconfig
- Keeping FeatureFlags.ENABLE_RESPONSIVE_WORKSPACE for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_RESPONSIVE_WORKSPACE in tests as aconfig still can't be mocked

Bug: 299935275
Test: manual
Change-Id: I092df894a3624dca6b9d381d56ada71d807547b5
2023-09-25 16:25:15 -07:00
Andrew Cole
e81a3cef0c Merge "Unfolded Two Pane Widget Picker Prototype" into main 2023-09-25 19:59:30 +00:00
Andrew Cole
c19a618706 Unfolded Two Pane Widget Picker Prototype
As described, this is a small prototype to show what the current state of the two pane widget picker would look like in an unfolded foldable.

Bug: 301918659
Test: N/A
Flag: UNFOLDED_WIDGET_PICKER
Change-Id: Ia495de39a470f1dccf70ce53e59c7929525c4a00
2023-09-25 11:00:24 -07:00
Stefan Andonian
84230b2ea0 Merge "Move "Enable Boot Aware Startup data" to behind a FeatureFlag." into main 2023-09-25 17:06:12 +00:00
Stefan Andonian
dbc8ec530c Move "Enable Boot Aware Startup data" to behind a FeatureFlag.
Previously this was hard-coded to disabled, but that was before
FeatureFlags were made to be boot aware.

Bug: 251502424
Test: Verified that doing this doesn't break my device. Also tested the
Pre-loading feature itself and didn't see any errors in the logs.

Change-Id: I031e1756b985664a2e8d8ad26e16803ead874727
2023-09-21 19:10:22 +00:00
Pat Manning
349f101411 Merge "Migrate ENABLE_CURSOR_HOVER_STATES to aconfig" into main 2023-09-19 16:56:45 +00:00
Sebastián Franco
c468af4139 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev am: 216a765894 am: 07ce8fa893
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681787

Change-Id: I74496b2ce863dadce1fbe3889de242c133a75121
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 19:02:27 +00:00
Sebastián Franco
216a765894 Merge "Disable FOLDABLE_SINGLE_PAGE" into udc-qpr-dev 2023-09-14 17:50:54 +00:00
Pat Manning
c49d60b946 Migrate ENABLE_CURSOR_HOVER_STATES to aconfig
- Keeping FeatureFlags.ENABLE_CURSOR_HOVER_STATES for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_CURSOR_HOVER_STATES in tests as aconfig still can't be mocked

Bug: 300054410
Test: manual
Change-Id: Id385e8ee32ccf8b920b9b7f9cc620af32def589f
2023-09-14 11:08:02 +01:00
Alex Chau
2ddd019a4c Merge "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig" into main 2023-09-13 20:57:51 +00:00
Alex Chau
e1955fe4b9 Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig
- Keeping FeatureFlags.ENABLE_GRID_ONLY_OVERVIEW for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_GRID_ONLY_OVERVIEW in tests as aconfig still can't be mocked

Bug: 270397206
Test: manual
Change-Id: I799e05311adc21184a6ad7ce92a3abdab3f25c25
2023-09-13 15:59:01 +01:00
Jagrut Desai
ff077335d1 Merge "Revert "ENABLE_TASKBAR_PINNING for TEAMFOOD"" into main 2023-09-12 23:37:59 +00:00
Jagrut Desai
62bbdcaa15 Revert "ENABLE_TASKBAR_PINNING for TEAMFOOD"
This reverts commit 1b9f4cc9e8.

Reason for revert: waiting to turn on until feature is complete. 

Change-Id: I362f2e86e0ff512934bf12360fbffbce43c0cdaa
2023-09-12 20:20:05 +00:00
Federico Baron
95090ebcc5 Merge "Add flag for smartspace as a widget implementation" into main 2023-09-12 18:43:58 +00:00
Sebastian Franco
f376613a5b Disable FOLDABLE_SINGLE_PAGE
ENABLE_TWO_PANEL_HOME is no longer used so I will also
remove it.

TwoPanelWorkspaceTest was expecting an icon on the hotseat
which no longer exist.

We will use the new flag system in main for this
feature.

Test: atest ReorderWidgets
Test: atest FoldableIntegrity
Bug: 270395274
Change-Id: I122a924a81ae989ff5636d8e276d6d31bbe0877d
2023-09-12 18:19:53 +00:00
Brian Isganitis
0d157469ae Merge "Promote ENABLE_ALL_APPS_SEARCH_IN_TASKBAR to TEAMFOOD." into main 2023-09-12 16:49:52 +00:00
Jagrut Desai
8f754a92c7 Merge "ENABLE_TASKBAR_PINNING for TEAMFOOD" into main 2023-09-12 16:15:55 +00:00
Jagrut Desai
1b9f4cc9e8 ENABLE_TASKBAR_PINNING for TEAMFOOD
enable taskbar pinning feature for teamfood.

Bug: 270396583
Bug: 265437087
Test: Presubmit
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ib4c5900bc64b091f3666d06d018d234f3e77f963
2023-09-11 16:07:42 -07:00
Tracy Zhou
01cc856157 Always recreate TaskbarActivityContext
- Add ENABLE_TASKBAR_NO_RECREATION flag
  When the flag is turned on,
  * Always destroy and recreate
  * Move task bar drag layer lifecycle from TaskbarActivityContext to TaskbarManager
  * Wrap the drag layer into a fullscreen root view

Note that in order to preserve the window across multiple TaskbarActivityContext creations, the inset types and ids must stay the same, so it's extracted out.

Bug: 274517647
Test: Fold and unfold a few times. Use a few applications. Make sure the task bar is visible and in the right place (tested with ENABLE_TASKBAR_NO_RECREATION and FLAG_HIDE_NAVBAR_WINDOW both on, both off, and one on and one off)
Change-Id: Ic3f0aa3d056fe178a53b76b2ad6cc6b9bffd5898
2023-09-10 22:43:47 -07:00
fbaron
c29072540c Add flag for smartspace as a widget implementation
Bug: 200721106
Flag: no flag
Test: no test
Change-Id: I6140c3471599f627106c8d039409c3d295d2b699
2023-09-05 15:54:39 -07:00
Anushree Ganjam
20bbe42cad Merge "Remove the test aconfig lib." into main 2023-08-31 19:24:23 +00:00
Anushree Ganjam
2a14b978c6 Remove the test aconfig lib.
zhidou@ from ACE team is working on AConfigFakelib which will be useful
to set fake flag values in both unit tests and UI automator tests.
Meanwhile, we will mock the flag values for unit tests and UI automator
tests will have all flags values defaulted to false.

testAConfigLib with "test:true" doesn't generate fake flags values and
forces us to set the flag values using "SetFlagsRule". "SetFlagsRule"
doesn't work with Out Of Proc tests and hence doesn't serve the purpose
for us. AConfigFakelib and FakeFlagTargetPreparer should use for Out Of
Proc tests.

testAConfigLib with "test:true" is suitable for java host tests where
there is no device involved. Launcher tests are instrumentation tests and tests run on actual
devices. So we can use the production version of the AConfig lib and device
config flag values will be fetched for UI Automator tests.

Also migrating "enable_twoline_allapps" to trunk stable. Unit tests is
using mockito to mock the flag value as false. The owner of
"enable_twoline_allapps" can mock the value to true in unit tests as
next step.

Bug: 294913042
Test: Local studio build and soong build
Flag: enable_twoline_allapps

Change-Id: Iea42bf18197832a9ecbddc1c3aaa8c9e36169131
2023-08-30 15:20:51 -07:00
Charlie Anderson
69524513db Remove ENABLE_MATERIAL_U_POPUP flag and cleanup dead code
- removes a lot of dead code for the old popup design and especially around adding notifications to popups
- renames several resource files to remove the material_u specification, as it is now the only design

Test: manually run through launcher popups
Bug: 270395516
Flag: ENABLE_MATERIAL_U_POPUP
Change-Id: I462063482206578b4b896a6d405dc2383f2da510
2023-08-30 20:40:25 +00:00
Brian Isganitis
dcc887884d Promote ENABLE_ALL_APPS_SEARCH_IN_TASKBAR to TEAMFOOD.
Test: Manual
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: Ib52f4b34857be9583ca3268a9a941e7beca801b7
2023-08-24 22:34:57 +00:00
Anushree Ganjam
29e1e61e07 Merge "Add Launcher aconfig." into main 2023-08-24 22:03:18 +00:00
Anushree Ganjam
d1a28fe08d Add Launcher aconfig.
Use `enable_expanding_pause_work_button` as an example.

See go/trunk-stable-launcher for implementation details

Bug: 294913042

Test: adb shell device_config put launcher com.google.android.platform.launcher.aconfig.flags.enable_expanding_pause_work_button true

Flag: enable_expanding_pause_work_button
Change-Id: I732722c8b219c023adf5bf31f132ce9da72fc4d5
2023-08-24 11:11:02 -07:00
Fengjiang Li
d18fcad565 Re-enable ALL_APPS_GONE_VISIBILITY and ENABLE_ALL_APPS_RV_PREINFLATION
Re-submit ag/24499161 with ag/24517009 to ensure tests are still passing

Flags: ENABLE_ALL_APPS_RV_PREINFLATION ALL_APPS_GONE_VISIBILITY
Test: Tested in bug bash
Bug: 288161355 291651514
Change-Id: I562d39f5edef46240700669b26d6e8fb27cbb77a
2023-08-22 18:20:52 -07:00
Fengjiang Li
053c11a344 Merge "Revert "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch"" into udc-qpr-dev 2023-08-22 18:49:10 +00:00
Fengjiang Li
df7cb761aa Revert "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch"
This reverts commit e302fb8cd9.

Reason for revert: WellbeingTests#testPauseAppFromAllApps is failing b/297040371

Change-Id: I92f885abff4bb1e3058eebcd23bf23875e5f84cf
2023-08-22 18:42:38 +00:00
Fengjiang Li
2474a8c1fb Merge "Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch" into udc-qpr-dev 2023-08-22 15:09:20 +00:00
Treehugger Robot
a5f24d709e Merge "Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag" into udc-qpr-dev 2023-08-22 09:09:51 +00:00
Sunny Goyal
5442cbc300 Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag
Bug: b/270397209
Test: Presubmit
Flag: RECEIVE_UNFOLD_EVENTS_FROM_SYSUI
Change-Id: I4f87777fd27b5489557742b58e25dc5488b7d32b
2023-08-22 04:31:09 +00:00
Fengjiang Li
e302fb8cd9 Turn on ENABLE_ALL_APPS_RV_PREINFLATION and ALL_APPS_GONE_VISIBILITY for udc-qpr branch
Flags: ENABLE_ALL_APPS_RV_PREINFLATION ALL_APPS_GONE_VISIBILITY
Test: Tested in bug bash
Bug: 288161355 291651514
Change-Id: Iea486fcbe7099e823cac17d05d1b5a18d5258b2c
2023-08-21 10:55:54 -07:00
Treehugger Robot
37385af4b5 Merge "Turn off TWOLINE_TEXT_ALLAPPS" into udc-qpr-dev 2023-08-19 00:52:39 +00:00
Brandon Dayauon
cbcbcd82b3 Turn off TWOLINE_TEXT_ALLAPPS
Turning off twoline text for all_apps since we will revisit with UX to minimize grid size changes.
The ENABLE_TWOLINE_DEVICESEARCH is fine to be kept on.

bug: 270390937
test: manual-presubmit
Flag: flipping on -> off
Change-Id: I262f809d43b0781c1942bf7176869d6b74e77f1e
2023-08-18 16:22:50 -07:00
Treehugger Robot
7af0db7e94 Merge "Enable ENABLE_DYNAMIC_TASKBAR_THRESHOLDS." into udc-qpr-dev 2023-08-17 18:49:51 +00:00
Jon Miranda
0605413a30 Enable ENABLE_DYNAMIC_TASKBAR_THRESHOLDS.
Bug: 274467454
Test: manual, has been soaking in teamfood

Change-Id: I2729ed3c4f93ef5a4e8e1769802931e1c6b80708
2023-08-17 07:48:03 -07:00
Vinit Nayak
d07d83dd75 Merge "Revert "Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD"" into udc-qpr-dev 2023-08-17 05:04:53 +00:00
Vinit Nayak
e09f34628e Merge "Revert "Teamfood ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS"" into udc-qpr-dev 2023-08-17 05:04:53 +00:00
Vinit Nayak
e606ad44c0 Revert "Enable ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE for TEAMFOOD"
This reverts commit d49239be89.

Reason for revert: delaying to QPR2

Change-Id: I0b5cb044395c311470ad1fcd9b901ef2e787eb05
2023-08-16 17:28:10 +00:00
Tracy Zhou
c73f6f1a9e Revert "Teamfood ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS"
This reverts commit 0615a80f8b.

Reason for revert: Delaying the feature to QPR2

Bug: 270394122
Change-Id: Iefb3550959926ba3430062f8515b265ee8b29bc0
2023-08-16 17:20:27 +00:00
Andy Wickham
c928369894 Merge "Enable Toast launch animations flags by default" into udc-qpr-dev 2023-08-11 23:21:31 +00:00
Luca Zuccarini
c3c75c28b0 Enable Toast launch animations flags by default
Bug: 270394041
Bug: 270394392
Bug: 262778448
Bug: 293863913
Flag: ENABLE_SEARCH_RESULT_BACKGROUND_DRAWABLES
Flag: ENABLE_SEARCH_RESULT_LAUNCH_TRANSITION
Test: manual
Change-Id: I9019d76045e3f6d931c99c0fc14435b52d8671bf
2023-08-11 18:36:40 +00:00