Commit Graph

451 Commits

Author SHA1 Message Date
Brandon Dayauon
1d3ddb877d Add floatingMaskView when animating to mimic bottom container.
- On expand, we add the floating mask view and translate it out at the end.
- On collapse, we translate off the mask view in the beginning once the floating mask view is added
so that we can translate it in before the actual collapsing part of the animation

bug:339850589
Test manually:
https://drive.google.com/file/d/1YNc3vq9Cb5BcbcPOHp8H3lhe6KmYBdLI/view?usp=sharing
Flag:ACONFIG com.android.launcher3.private_space_floating_mask_view STAGING

Change-Id: I7c303e6629d83408bd314886fe10113246e44dcb
2024-05-13 11:08:05 -07:00
Willie Koomson
1156e8419a Hide add button text if cell is too narrow
If the WidgetCell is not wide enough, hide the add button text and show
an icon-only plus button.

Bug: 333735974
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ieb0b2e679bd4a5785a0f7f01e177ad412a355ce7
2024-05-02 19:55:41 +00:00
Brandon Dayauon
782af232e3 Merge "Update badge color to textColorPrimaryInverse" into main 2024-04-23 20:42:56 +00:00
Brandon Dayauon
4f781aeac0 Update badge color to textColorPrimaryInverse
Just got updated textColorPrimaryInverse color to use on badge to support the themedness. This color
is consistent with the popup icon colors that is already being used.

bug:324574278
Test after:
dark theme: https://drive.google.com/file/d/1Q9BKlbw0bi5yz-wzPa160JMBEqK7QKcJ/view?usp=sharing
light theme: https://drive.google.com/file/d/1QH_FSOo8H63K_8WKfiDuV1ypGqctYMqt/view?usp=sharing
Flag: None

Change-Id: If59e20356d80b234ad405cfe6995d474dbfe5c57
2024-04-23 11:13:22 -07:00
Shamali Patwa
a80e199798 Merge "Keep rounded corners while scrolling in right pane & fix scrollbar size." into main 2024-04-19 22:43:39 +00:00
Brandon Dayauon
24db282ed4 Merge changes Ied2efcf6,I07579635 into main
* changes:
  Polish workFAB with updated spec.
  Fix workFAB alignment.
2024-04-19 00:59:19 +00:00
Shamali P
5f7eb1f2ee Keep rounded corners while scrolling in right pane & fix scrollbar size.
[demo](http://screencast/api/gif/NDU4MTQ5ODE3Mzc4NDA2NHxhYmUzMDcxNy04MA/image)

Bug: 333734241
Test: screencast
Flag: N/A
Change-Id: Ifb522ca2c0a1092bf41c630e336b19c81d504c26
2024-04-18 22:32:30 +00:00
Brandon Dayauon
baf5f6ec3d Polish workFAB with updated spec.
Updating the workFAB to the new spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2c8f3ae8e02_0_0
Have the background endPadding to be 4 and icon have an endMargin of 12 and the text endMargin of 16.
So that when the text is disappeared, the space between the icon and the right bound is 16dp to spec.

bug:332761814
Test manually:
after LTR expanded:https://drive.google.com/file/d/1NZQW0CF9VFZBoM3673LFiUknqW2nf4r8/view?usp=sharing
after LTR collapsed: https://drive.google.com/file/d/1NRpdTuYQntSs5-yeRL1fJIJy2ETDOYLM/view?usp=sharing
after RTL collapsed: https://drive.google.com/file/d/1NE51MIsS5Fk0DwAuzCehEQzTa42OGj_o/view?usp=sharing
after RTL expanded: https://drive.google.com/file/d/1NPgiPfzw3DOa_xbB_TtlwK-G1Y5WCi53/view?usp=sharing
Flag:None

Change-Id: Ied2efcf6b1bd19c191d80e47bae4f8f6e3794803
2024-04-18 14:40:42 -07:00
Brandon Dayauon
a1af2cee1c Instead of popup to show letters, show private space icon on fast scrolling
Use spannableString to show the icon instead of regular letters for the private space icons.

bug:304752744
Test manual: https://drive.google.com/file/d/1LFy4-bu69Kuo8eV4erjJOsbkiQJs09kC/view?usp=sharing
Flag: None

Change-Id: I149d7aba6b0a4fdafacd2684e56827c7e1b9d724
2024-04-17 12:37:38 -07:00
Holly Jiuyu Sun
eff58ad8e2 Merge "[PS] Update PS tile icon." into main 2024-04-15 17:19:48 +00:00
Treehugger Robot
8fc5e593c3 Merge "Update icon for install to private shortcut[final]" into main 2024-04-13 16:00:19 +00:00
Holly Sun
0b6dafbd3e [PS] Update PS tile icon.
Screenshot:
https://screenshot.googleplex.com/9XM6jYqhvz8etp3
https://screenshot.googleplex.com/3qUGXvqmvrWhWHr

Test: manual
Bug: 333929173
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile trunkfood
Change-Id: Ibeb2a55cd80c8ae9a5446c40061f7e014f81ed4c
2024-04-12 11:14:57 -07:00
Himanshu Gupta
0faeff7f76 Update icon for install to private shortcut[final]
Bug: 333553036
Test: https://photos.app.goo.gl/KmQXWYWKQsWwg3fW6
Flag: NA
Change-Id: I50c2e6e0294097d3ce81ac590aaa8c753c6d23ad
2024-04-12 11:39:24 +01:00
Sunny Goyal
8049369af8 Freezing legacy feature flags
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags

Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
2024-04-09 15:26:07 -07:00
Brandon Dayauon
c3281ee18a Ripple to header and button when click happens
bug:320701510
Test: manual video: https://drive.google.com/file/d/11X7vUetuMN1J34Now4zlQZ0WaOnryLpA/view?usp=sharing
Flag: None

Change-Id: Ibe22d02b59da5b1133f02ebd936520b97a63e44a
2024-04-04 14:08:41 -07:00
Holly Sun
44d2299ee7 [PS] Use onSurface for tint.
Screenshot:
https://screenshot.googleplex.com/6WSZJGdT9hY2Ww5
https://screenshot.googleplex.com/AiTX4JJjfRyfvPc

Bug: 325068252
Test: manual
Flag: aconfig enable_private_space trunkfood
Change-Id: I36bcf1156149630450ca3dfc063984e3deb6851f
2024-03-21 11:52:26 -07:00
Willie Koomson
078737f22b Merge "Add tap-to-add button to widget picker" into main 2024-03-15 23:26:05 +00:00
Willie Koomson
cdc26951ff Add tap-to-add button to widget picker
This change introduces an "Add" button that appears when a widget
preview is clicked in the widget picker. This button disappears when the
preview is clicked again, or another preview is clicked. When the button
is pressed, it adds that widget to the picker. The add button is
available in the app-specific widget sheet as well.

Bug: 323886237
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT

Change-Id: I86a8a4c22119960c54a885fd2efeb91916b4f9a0
2024-03-15 20:10:45 +00:00
Shamali P
34d1db731b Rename the color attr for paging dot indicator used in launcher.
Additionally, make the widgetPickerActivity theme support dark mode.

http://screencast/cast/NDY5OTUzNTA0ODcwNDAwMHxmZWU3ZDBjZS04ZQ

Bug: 326092660
Test: Manual
Flag: N/A
Change-Id: Ic2816853bd25bd04e07d661682d720d1940c268c
2024-03-14 19:38:37 +00:00
Brandon Dayauon
40ea056886 Update icon background color of the private space widget tile
This icon background should be the same as the web icon backgrounds in Toast which is: materialColorSurfaceContainerLowest

bug: 320562455
Test: Manual - photos:
after private space qstile quicklaunchable dark theme: https://drive.google.com/file/d/1UZUxOdyEMEyLmPhnuPWJ085gQHrGgUdC/view?usp=sharing
after private space qstile nonquicklaunchable dark theme: https://drive.google.com/file/d/1UOoR0VHxdIIvMFfvhc_5MwHsg40wURA3/view?usp=sharing
after private space qstile quicklaunchable light theme: https://drive.google.com/file/d/1Ub1Nra_5rMlWuciI_a6yJM48EL6IdEsp/view?usp=sharing
after private space qstile nonquicklaunchable light theme: https://drive.google.com/file/d/1UidMqcHI2rXTtwmwIRXkGiKJkaeP8ubi/view?usp=sharing
Flag: com.google.android.apps.nexuslauncher.enable_inject_private_space_tile

Change-Id: Id118a6cc69d091b216c49b7fe778d8b6c84966b2
2024-03-05 12:00:12 -08:00
Jagrut Desai
4ff2e24704 Adjusting weight of taskbar all apps icon or action key
Test: Presubmit
Bug: 320478286
Bug: 325529964
Flag: NONE
Change-Id: I0f9a8d340638464cf3a79279b3cbb27d60fcf93d
2024-02-21 13:37:10 -08:00
Brandon Dayauon
08b06523a5 Collapse private space container and animate header.
- Just opposite of how it will expand.
- RecyclerView.SmoothScroller is needed to scroll the container.

- Need to separate the lock button because this way I can use animateLayout changes and it itself was its own drawable. Separated into icon and textView in a viewGroup.
- Give the background the 10padding on the left and right so that when in animation, the icon can adjust the padding/margins there.
- Using propertySetter to set animation
- Animates the alpha of the settings alpha

- updated test to account for the nested child views the test needs to inspect

bug: 299294792
test: manual:
Expand + Collapse Video: https://drive.google.com/file/d/1Og66eqmXv3THn0wO4_x6Tfp2AbwFWUwZ/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TEAMFOOD

Change-Id: I96f1d172a481522d23b4cee996ddec65961fce78
2024-02-16 21:23:51 -08:00
Anna Zhuravleva
f843af4084 Merge "Update icon for install to private shortcut" into main 2024-02-13 18:00:29 +00:00
Uwais Ashraf
99fdf7a75e App chip refactor
- Adds background outline replacing 2 circles + rect approach. This
enables easier shadow drawing code.
- Simplify structure of AppChipView.
- Adds an anchor View to simplify laying out of menu around app chip

Bug: 313644427
Bug: 317007147
Fix: 322760765
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest
Change-Id: I56c2644779863c083ae475a740a84321b1d0c396
2024-02-09 12:09:42 +00:00
Anna Zhuravleva
a42e9d4410 Update icon for install to private shortcut
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT
Test: https://b.corp.google.com/issues/316118005#comment5
Change-Id: I4f5316be5117be09510cac6922c43abe946e9938
2024-02-05 17:10:44 +00:00
Holly Sun
ac84289439 [PS] Update PS icon.
Now we have a specific icon for Private Space in material icon lib (https://fonts.corp.google.com/icons?icon.query=private+space&icon.platform=android).
Figma: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=20135-133573&mode=design&t=hXFY1ODhROG362hc-0

Screenshot: https://screenshot.googleplex.com/4YwYyeupJWt2Lq5

Bug: 323434770
Test: unit + manual
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile teamfood
Change-Id: I175c16d61ad9d263684c345622f17301eba4472d
2024-02-01 16:47:25 -08:00
Holly Jiuyu Sun
dd8de0a6d0 Merge "[PS] Update icon background for PS, Widget and web." into main 2024-01-30 23:34:05 +00:00
Himanshu Gupta
eaeb666e43 Merge "Separating system and user-installed apps in PS container." into main 2024-01-26 14:22:19 +00:00
Himanshu Gupta
0cc11dbcac Separating system and user-installed apps in PS container.
We add a horizontal line separator in PS container which demarcates
user-installed vs system installed apps in private space.
User-installed are shown above the separator, system ones below.

UX Mock: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?node-id=11546%3A310574&mode=dev
Mock Image: https://photos.app.goo.gl/Wj8sJkS7P7bRbovg8
Demo video: https://photos.app.goo.gl/MBw6HpDnf6PJqUfs8

Bug: 308054233
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Test: AlphabeticalAppsListTest
Change-Id: Iad8e289c49a05ac7ef1978bd8e4ebe7aa0add0ca
2024-01-26 11:04:13 +05:30
Holly Sun
997d385778 [PS] Update icon background for PS, Widget and web.
PS:
https://screenshot.googleplex.com/3xVtx5bPD296pUd
https://screenshot.googleplex.com/B3MkSoyfkBJPRsA
https://screenshot.googleplex.com/8pqs2ZsNatEvcBF
https://screenshot.googleplex.com/9CK9hqHSGfc6jin

Widget:
https://screenshot.googleplex.com/AdcmB7ScDnxK2Hv
https://screenshot.googleplex.com/9XkaghiVrx3YBLq
https://screenshot.googleplex.com/7hh3xU4JTUXG4X5
https://screenshot.googleplex.com/Ao2wWAAGVF4kHpe

Bug: 320562455
Test: manual
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile teamfood
Change-Id: I46d9ae92cc21a4ba6e66be2271c584ee0e3514cd
2024-01-25 16:04:08 -08:00
Holly Jiuyu Sun
e5d943e848 Merge "[PS] Update resource files to include round background." into main 2024-01-24 03:53:28 +00:00
Sunny Goyal
e0c1649d87 Cleaning up some unused notifications functionality
Bug: 321154530
Test: Presubmit
Flag: N/A
Change-Id: I1ff2a4f19595659d89e7d72ee1b29036bbd54d8f
2024-01-19 00:21:02 -08:00
Holly Sun
22dd6a5435 [PS] Update resource files to include round background.
Bug: 19531436
Test: manual
Flag: aconfig enable_inject_private_space_tile teamfood
Change-Id: I287d5cb1c613419035b5b2e4da7c64f897de7c23
2024-01-16 16:37:41 -08:00
Anna Zhuravleva
eb1966c278 Merge "Add shortcut to install an app to Private space" into main 2024-01-12 15:51:05 +00:00
Anna Zhuravleva
29a3139815 Add shortcut to install an app to Private space
Introduce long-press shortcut to install a copy
of the main user app to private space.

Test: manual, installed apps in different stores
and tried shortcut
https://screenshot.googleplex.com/6oAVamTytiYmvPC.png
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT

Change-Id: I702cd2a27388e3cc6e9e126308d5479836ba6655
2024-01-11 12:40:28 +00:00
Holly Sun
97b1bba413 Implement Install Apps button in Private Space.
UX mock: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?node-id=7246%3A83750&mode=dev
UX icon spec: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=19979-224329&mode=design&t=50SDFdomAtonNU4V-0

Video: https://drive.google.com/file/d/1VtTzxR46dLiaozOo6sOHADv1qTcBOwDP/view?usp=sharing
Screenshot:
https://screenshot.googleplex.com/3ShcUozVrkGMHbc
https://screenshot.googleplex.com/3F4c3yzJ7RUpma7

Reason to use PrivateSpaceInstallAppButtonInfo: reuse `VIEW_TYPE_ICON`, which needs an AppInfo.

Bug: 308064949
Test: manual
Flag: ACONFIG com.android.launcher3.private_space_app_installer_button development
Change-Id: I3fb27fae8324d4b276816b17f9b0a2d9b6f33ed2
2024-01-10 14:28:33 -08:00
Sunny Goyal
4df719a1e6 Removing ENABLE_CACHED_WIDGET since we now have always listenign widget
> Also using PendingWidgetView for deferred widget view

Bug: 270395008
Flag: LEGACY ENABLE_CACHED_WIDGET enabled
Test: Exising widgets tests pass.
      Verified UI by forcefully rendering deferred widget

Change-Id: Id34f89d778f9f993c1b7ad13f66e57fda9843417
2024-01-04 09:26:10 -08:00
Brandon Dayauon
c800c97697 Change all apps handle color to outLineVariant.
Before the change the color was colorSurfaceVariant but should be updated to outlineVariant.

bug:275087095
Test: Manual -
Before darkTheme:https://screenshot.googleplex.com/94KykP7mjhBsKUc
After darkTheme:https://screenshot.googleplex.com/3N5XaSRonQkFuis
Before lightTheme:https://screenshot.googleplex.com/BNigdK4GWgSe2fm
After lightTheme: https://screenshot.googleplex.com/3Li5DUCDxXeACac
Flag: None

Change-Id: Ie7b077e05108d53dab869fcc1225ddae993207f2
2023-12-21 18:52:29 +00:00
helencheuk
1b3b67d004 Add radius to widget internal focus to fit new focus outline design
Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I9b11e8bf21dbb5045586907f0fc13577e236c8e7
2023-12-19 11:27:04 +00:00
Sunny Goyal
464509b375 Merging widget item click listener to default click listener
> Also removing check for dragHandle, since dragHandle is already removed

Bug: 307306823
Test: atest Launcher3Tests
Flag: N/A
Change-Id: I0b452dd1fbccf15ed686370471e8866b179fd77e
2023-11-28 12:07:16 -08:00
Pat Manning
c5b7cf9e4e Add background to app chip menu so elevation shadow renders.
Fix: 312146447
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest.
Change-Id: I43113acd0eaafac2955cd4bbebafc103bdba6d98
2023-11-20 15:15:54 +00:00
Jagrut Desai
a2825e011c Merge "New Meta Action Icon for Taskbar" into main 2023-11-17 17:59:45 +00:00
Pat Manning
d3f3308d12 Merge "Update Icon App Chip Menu to new specs." into main 2023-11-17 15:06:42 +00:00
Pat Manning
43c4b50c17 Update Icon App Chip Menu to new specs.
Fix: 304228083
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT

Change-Id: Ib018c7f59e1141b6f21618b28d411facc937ac7c
2023-11-16 18:18:48 +00:00
Jagrut Desai
deb22d9e78 New Meta Action Icon for Taskbar
Test: Presubmit, Manual
Bug: 310942087
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Change-Id: Ia1783a1afa92181efded4cfdbd5e7ae3d4e081e8
2023-11-16 08:33:03 -08:00
Himanshu Gupta
08badb3f6f Adding Private Space views to Launcher.
This CL adds the following:
* Static View Elements to be added to AllApps recycler View
* View Controller to load the above elements dynamically
* Private Space Section Decorator
* PrivateProfile Manager containing the logic related to Private Space
* Abstract UserProfileManager as the super class of Work/Private
ProfileManager

Private Space Views Figma
[link](https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=14535-111985&mode=design&t=JLz9W0O551TpzQYH-0)

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I8aa4247c78064a551e5e0d0b46d3fc033873f99d
2023-11-14 11:58:16 +00:00
Holly Sun
6ec3d23a4b [PS] Add private space icon and strings.
Bug: 298227797
Test: manual and unit
Flag: inject_private_space_tile
Change-Id: Ic7ec649ac69f02a82a6ee0b4e63262d8ad3e0916
2023-10-13 12:29:19 -07:00
Pat Manning
1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Brian Isganitis
45441c7a3c Optimize paths for all apps search drawables.
The search icon has been split into two much shorter paths than the
previous single path. Additionally, the xml file size has decreased.

Test: Manual
Bug: 265170176
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I3dcd0f5c978e2c3d249ec01f34b7346657da6bb6
2023-09-13 22:59:09 +00:00
Brian Isganitis
0b9c0589b7 Add All Apps search icon variant behind flag.
Bug: 265170176
Test: https://b.corp.google.com/issues/265170176#comment15
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I0f5fa4fbbab687d92435d299656b9c27d93525b4
2023-09-07 18:29:46 +00:00