Commit Graph

17204 Commits

Author SHA1 Message Date
Schneider Victor-tulias
8f795844e9 Merge "Refactor the BorderAnimator for simplicity" into main 2023-10-01 17:27:16 +00:00
Jagrut Desai
9c80d72947 Merge "Fixing testQuickSwitchToPreviousAppForTablet" into main 2023-09-29 19:38:48 +00:00
Schneider Victor-tulias
7335bcf7f5 Refactor the BorderAnimator for simplicity
The internal implementation of BorderAnimator does not need to be as exposed. refactored the class to be simpler to implement

Flag: ENABLE_KEYBOARD_QUICK_SWITCH, ENABLE_CURSOR_HOVER_STATES
Bug: 302334949
Test: check border animation in keyboard quick switch and recents view
Change-Id: I8a2e4fa0abc5af743352cd6409aee9f2912b41a2
2023-09-29 15:08:05 -04:00
Schneider Victor-tulias
0606b1f296 Merge "Add TAPL tests for the keyboard quick switch view" into main 2023-09-29 18:42:11 +00:00
Luca Zuccarini
850a282446 [Toast] Fix ANR when tapping on rich card chip. am: ba44979d79 am: f876cb4bf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24894969

Change-Id: Iac57076c82c798876d7d94c9f03d3fc1d34bc09f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 18:41:51 +00:00
Schneider Victor-tulias
41b42bf7d5 Add TAPL tests for the keyboard quick switch view
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 267520665
Test: TaplTestsKeyboardQuickSwitch
Design doc: go/kqs-tapl-tests

Change-Id: I1c3c5c758011a36ed405426f543ce450910f774e
2023-09-29 14:39:35 -04:00
Luca Zuccarini
f876cb4bf4 [Toast] Fix ANR when tapping on rich card chip. am: ba44979d79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24894969

Change-Id: Ic9371183df1de229eb96a867c01eab21fd0f8b02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 17:36:12 +00:00
Sunny Goyal
72a7407695 Merge "Passing activityClassName when setting unlock controller" into main 2023-09-29 16:48:03 +00:00
Fengjiang Li
576c7ff4d7 Merge "Don't preinflate all apps for taskbar in AllAppsStore#setApps" into main 2023-09-29 16:16:58 +00:00
Luca Zuccarini
ba44979d79 [Toast] Fix ANR when tapping on rich card chip.
This method recursively looks up the view hierarchy for a suitable view
to animate. The wrong variable was causing an infinite loop by never
updating the object being checked for the end condition.

With the fix, the animation behaves as expected.

Fix: 302568434
Flag: ENABLE_SEARCH_RESULT_LAUNCH_ANIMATION
Test: see video in the bug.
Change-Id: I123e50f1618a1e48256c0c976eeb46c93e8391b2
Merged-In: I123e50f1618a1e48256c0c976eeb46c93e8391b2
2023-09-29 11:41:55 +00:00
Jagrut Desai
f9ad6ab8bb Merge "Add more debugs logs to TaskbarManager" into udc-qpr-dev am: f2412770e2 am: 7a150d07d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24829188

Change-Id: Ia5fae16bbb40ac5553b92380f8b1f7f592cb201e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 05:04:26 +00:00
Jagrut Desai
7a150d07d7 Merge "Add more debugs logs to TaskbarManager" into udc-qpr-dev am: f2412770e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24829188

Change-Id: I4abe9d51d2fb4e0b740484dcb5e08c3198848b39
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 03:57:48 +00:00
Sunny Goyal
613254e657 Passing activityClassName when setting unlock controller
Bug: 302621267
Test: Presubmit
Flag: N/A
Change-Id: I84f9e404dc2e0654d38dd24c08e82fa5d103a067
2023-09-28 20:29:53 -07:00
Jagrut Desai
f2412770e2 Merge "Add more debugs logs to TaskbarManager" into udc-qpr-dev 2023-09-29 02:39:18 +00:00
Vinit Nayak
5b759afe90 Merge "Revert "Unignore splitscreen tapl tests"" into main 2023-09-28 23:14:29 +00:00
Jagrut Desai
c1bd53c3f0 Add more debugs logs to TaskbarManager
- adding more logs to TaskbarManager to investigate taskbar being present in folded state of the device.

Test: Presubmit
Bug: 254119092
Flag: not needed
Change-Id: I81c475f1c6bbc8d5b7874ddc45e8778861b61cd0
2023-09-28 15:46:22 -07:00
Fengjiang Li
e92556819b Don't preinflate all apps for taskbar in AllAppsStore#setApps
Triggering all apps pre-infation at AllAppsStore#setApps is too late for taskbar, because it is in same frame when user opens all apps from taskbar. We should find an earlier entry point to pre-inflate all apps for taskbar.

Test: Verify taskbar is rendered correctly. Also verify we no longer pre-inflate all apps for taskbar in perfetto trace
Change-Id: If1f8c616b6be7f64ea16807f4b7a8b75da55d038
2023-09-28 14:29:07 -07:00
Brian Isganitis
a5cdbe5d4e Merge "Fix Taskbar AllApps touch interception when above EDU." into main 2023-09-28 21:17:55 +00:00
Jagrut Desai
e34b94f5b9 Merge "Gesture Error Detection - Improvements Part 3" into main 2023-09-28 18:55:38 +00:00
Vinit Nayak
8d0442372b Revert "Unignore splitscreen tapl tests"
This reverts commit 80d274e041.

Reason for revert: b/302542596

Change-Id: Iac1274dd844ff1baea1e8c7b22a54bf353c69974
2023-09-28 18:45:37 +00:00
Jagrut Desai
dbbeac7747 Fixing testQuickSwitchToPreviousAppForTablet
Bug: 286084688
Test: Presubmit
Flag: not needed
Change-Id: Ibd2a98096df5dc15fa3ae5833b8cab0fe77850e5
2023-09-28 10:57:26 -07:00
Vinit Nayak
6120e525d8 Merge "Unignore splitscreen tapl tests" into main 2023-09-28 05:12:36 +00:00
Jagrut Desai
f39c5099a8 Gesture Error Detection - Improvements Part 3
- Adding Gesture Event to log when detected invalid velocity in AbsSwipeUpHandler.

Bug: 288462574
Test: Presubmit
Flag: not needed
Change-Id: I5656e2eaaba3b2ae6c2143cb2a5752c106f5fd6f
2023-09-27 18:55:57 -07:00
Jagrut Desai
257b5cade6 Merge "Gesture Error Detection - Improvements Part 2" into main 2023-09-28 01:52:06 +00:00
Vinit Nayak
80d274e041 Unignore splitscreen tapl tests
* Previous they were failling locally, now they've magically
started working, let's see if the same happen in TH.

Bug: 297135374
Test: Passes/gets ignored correctly locally
Change-Id: I580afa43011237ca167bb763c65ef1974586a0fa
2023-09-27 14:45:13 -07:00
Helen Cheuk
5ab9a57ec0 Merge "Fixed delay of thumbnail loading when going to overview from home" into main 2023-09-27 20:29:00 +00:00
Jagrut Desai
883ea7c72b Gesture Error Detection - Improvements Part 2
- Adding gesture error detection for ON_START_RECENTS_ANIMATION for to be getting callabck within time limit.

Bug: 293379641
Bug: 290266108
Test: Presubmit
Flag: not needed
Change-Id: I7d0f70c55dc44749218ff8d8427e71cd512d083c
2023-09-27 13:24:09 -07:00
Holly Jiuyu Sun
01088a4001 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev am: 6c3cd3c092 am: 564a0acda7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24856663

Change-Id: I0ec7ee12bf09f7b7902915c28e22b5e923f5ac55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 19:44:28 +00:00
Vinit Nayak
909fe37472 Merge "Revert "Verifying that workspace looks correct at the end of the test."" into main 2023-09-27 18:42:25 +00:00
Holly Jiuyu Sun
564a0acda7 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev am: 6c3cd3c092
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24856663

Change-Id: If4a73bc64242feec4786705603c5c128fc2cecba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 17:49:29 +00:00
Holly Jiuyu Sun
6c3cd3c092 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev 2023-09-27 16:05:41 +00:00
helencheuk
9e142d3998 Fixed delay of thumbnail loading when going to overview from home
Some thumbnail snapshots show up slowly when GRID_ONLY_OVERVIEW is enabled because more thumbnails are displayed than before and some cache related code needs to be changed. This issue should be fixed for smooth user experience so all thumbnails could be shown quickly and at the same time.
Root causes and corresponding solution are as below:
1. No high resolution thumbnails are in cache when entering overview. It is either no cache at all or just low resolution cache
Solution: Preload when high resolution is enabled
2. The cache size is 3 which is not enough for tablet
Solution: Update cache size to 8 when it is tablet, and preload more if cache size increases. Remove least recent ones when cache size decreases

Fix: 271570416
Test: RecentsModelTest
Test: TaskKeyByLastActiveTimeCache
Test: TaskThumbnailCacheTest
Change-Id: I60003ca20942c256a0a1047678ea4368cd2520eb
2023-09-27 16:57:27 +01:00
Liran Binyamin
44bd688301 Merge "Let the bubble bar handle gestures over the bubble bar." into main 2023-09-27 15:39:16 +00:00
Tracy Zhou
aa366d03cd Merge "Fix wrong 3 button order in landscape mode sometimes" into main 2023-09-26 23:58:47 +00:00
Ats Jenk
a54772832b Merge "Animate launching desktop from overview" into main 2023-09-26 23:20:46 +00:00
Vinit Nayak
df751430bc Revert "Verifying that workspace looks correct at the end of the test."
This reverts commit 62e3b162ba.

Reason for revert: Possible culprit for b/301966780

Change-Id: Ice6babe404feeddf9f8b13ce2a6288005402c9cd
2023-09-26 15:19:20 -07:00
Brandon Dayauon
cd460094ba Merge "Do a vertical check for two line text, if it clips dont show two line." into main 2023-09-26 22:16:37 +00:00
Ats Jenk
a24b63d644 Animate launching desktop from overview
Create a new controller that handles launching desktop from recents. It
creates a remote transition runner. Then notifies wmshell to show
desktop apps and use this remote runner to run the animation.

TODO:
- there are flickers in the animation

Bug: 297590571
Test: open an app on desktop, swipe up to overview, click on desktop
      tile
      open multiple apps on desktop, swipe up to overview, click on
      desktop tile

Change-Id: Ie8c9189bace77ba80e6be90222b3f786dfe5bb15
2023-09-26 10:39:49 -07:00
Schneider Victor-tulias
eaa495a864 Remove string concatenation uses with ActiveGestureLog
Flag: ENABLE_LONG_PRESS_NAV_HANDLE
Bug: 301953713
Test: checked logs
Change-Id: Id5c3bdf170fdb56305c585f1c34ec9a5310256b8
2023-09-26 16:12:32 +00:00
Liran Binyamin
d7f1942d4a Let the bubble bar handle gestures over the bubble bar.
This change introduces a motion event flag to signal that the gesture
is being originated over the bubble bar (similar to the nav bar gesture flag). Downstream consumers use this flag to ignore the event in order
to allow the bubble bar to handle it.

The black screen in b/293348900 seemed to be related to the recents
shell transition closing the app that was in the foreground before
swiping on the bubble bar handle. Not sure why it ended up with a black
screen, but this change avoids starting the recents transition entirely.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/BSxLROoflr1i2yy0v6Y4G

Fixes: 294421126
Bug: 293348900
Test: Manual:
      - Add bubble to the bubble bar
      - Swipe up over the bubble bar
      - Observe that the bubble bar expands

      - Launch application
      - Swipe up on the bubble bar handle
      - Observe that the bubble bar expands

Change-Id: Iea15829de97edb6bfbfb7007388865230faaf736
2023-09-26 12:02:27 -04:00
Brandon Dayauon
3cdb32cc1f Do a vertical check for two line text, if it clips dont show two line.
Added extra 16dp to the cell height in DeviceProfile as per spec: https://docs.google.com/presentation/d/1dSt-zY_wRrOmd9a9nsQG458CIK0RUqVJsHJxLHP_0Nc/edit#slide=id.g237e909075a_2_6
Updated tests andincluded vertical check to see if two line can be fully rendered without being clipped. Otherwise just show one line.
Since existing cell height is 104dp, we add 16dp to be up to spec (120dp)
- Clean up FeatureFlag ENABLE_TWOLINE_ALLAPPS and now use aconfig flag

bug: 270390937
Test: manually - photos
Regular font: https://screenshot.googleplex.com/ArUcgZgHqR4ZWBQ
Bigger font than regular that makes text to one line because it wouldve truncate: https://screenshot.googleplex.com/6s8EdMAbBLsYhLi
Bigger font than regular with predicted app row (twoline):
https://screenshot.googleplex.com/38TEQei5GvPiCc7
Super big font: https://screenshot.googleplex.com/3JUYYprJRQ32Hsq
big display and regular font: https://screenshot.googleplex.com/55rBKVQ8htSe9Vc
big display and bigger than regular font: https://screenshot.googleplex.com/3atzKzJUbfM7YQW
flag: is off

Change-Id: I6998ea5da35d3e00ac75327d16b5ca676fb11c1a
2023-09-26 02:38:16 +00:00
Andy Wickham
136bdf80b3 Merge "Add some gesture logs" into udc-qpr-dev am: 66072ca559 am: c18764fce1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755061

Change-Id: I02949308dda86a905029fdcc21dcfb80dd91e3b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 01:27:39 +00:00
Holly Sun
e292642489 Log toggle status for LPNH and LPH in Settings.
Bug: 295039461
Test: manual
Flag: PRESS_HOLD_NAV_HANDLE_TO_SEARCH. LONG_PRESS_HOME_BUTTON_TO_SEARCH
Change-Id: I380dd6f62378098edf063f29d10305b8c404f38d
2023-09-26 00:36:44 +00:00
Andy Wickham
c18764fce1 Merge "Add some gesture logs" into udc-qpr-dev am: 66072ca559
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755061

Change-Id: Iabb40a2aaf81ac23121ec356b55c012da92348a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 00:31:56 +00:00
Andy Wickham
66072ca559 Merge "Add some gesture logs" into udc-qpr-dev 2023-09-25 23:54:20 +00:00
Bill Yi
bef73824d4 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-09-25 20:17:46 +00:00
Treehugger Robot
34cea0d3b7 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-09-25 19:00:16 +00:00
Jagrut Desai
adf9c428db Merge "Adding gesture error detection to RecentsAnimationCallback" into main 2023-09-25 17:03:34 +00:00
Becky Qiu
42a06b0476 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP. am: 86b6a887d1 am: f545328f56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24828699

Change-Id: Ic62100a1f4ca6aa2a0a0c1a1962cedff070f7e70
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-23 07:45:25 +00:00
Becky Qiu
f545328f56 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP. am: 86b6a887d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24828699

Change-Id: Ifd35410d27765efc7896dac8e002ce3f1690a8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-23 06:48:19 +00:00