From 04b355a2d9166bd5ff23445c1d7fe7e2b38ae6a7 Mon Sep 17 00:00:00 2001 From: Alex Chau Date: Wed, 22 May 2024 16:04:58 +0100 Subject: [PATCH] Don't call onModalnessUpdated if modalness stays the same - Repeatedly calling onModalnessUpdated results in repeated calls of View.setAlpha, which caused regression in Overview loading time Fix: 341266234 Test: android.platform.test.scenario.messenger.OpenAppFromQuickStepAndOpenQuickStepMicrobenchmark#testOpenQuickStepAndOpenApp Flag: EXEMPT bugfix Change-Id: Id756e80f20afafee2bb45e6a3ab861d83ab0b674 --- quickstep/src/com/android/quickstep/views/TaskView.kt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/quickstep/src/com/android/quickstep/views/TaskView.kt b/quickstep/src/com/android/quickstep/views/TaskView.kt index 1490fd03bb..05b9d40a7e 100644 --- a/quickstep/src/com/android/quickstep/views/TaskView.kt +++ b/quickstep/src/com/android/quickstep/views/TaskView.kt @@ -257,6 +257,9 @@ constructor( */ protected var modalness = 0f set(value) { + if (field == value) { + return + } field = value onModalnessUpdated(field) }