From d2e930bbb77348dbc642b76df2d62daf39c8b157 Mon Sep 17 00:00:00 2001 From: Jordan Silva Date: Tue, 18 Mar 2025 11:18:55 -0700 Subject: [PATCH] Fix Chip menu expanding outside the screen This CL removes isLandscape condition from menu translation that prevents Comet to translate the menu with split app. The menu needs to be translated when in split screen mode, regardless of orientation. Fix: 404549940 Flag: com.android.launcher3.enable_overview_icon_menu Test: OverviewImageTest Test: OverviewSplitTaskImageTest Test: OverviewMenuImageTest Test: Manual. Instructions in the bug. Change-Id: I5e4d07a9f1d2e36b847808aec9ae348a7ef78f59 --- quickstep/src/com/android/quickstep/views/TaskMenuView.kt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/quickstep/src/com/android/quickstep/views/TaskMenuView.kt b/quickstep/src/com/android/quickstep/views/TaskMenuView.kt index 696f934701..4d4ce4e583 100644 --- a/quickstep/src/com/android/quickstep/views/TaskMenuView.kt +++ b/quickstep/src/com/android/quickstep/views/TaskMenuView.kt @@ -428,9 +428,7 @@ constructor(context: Context?, attrs: AttributeSet?, defStyleAttr: Int = 0) : var additionalTranslationX = 0f if ( - recentsViewContainer.deviceProfile.isLandscape && - taskContainer.stagePosition == - SplitConfigurationOptions.STAGE_POSITION_BOTTOM_OR_RIGHT + taskContainer.stagePosition == SplitConfigurationOptions.STAGE_POSITION_BOTTOM_OR_RIGHT ) { // Animate menu and icon when split task would display off the side of the screen. additionalTranslationX =