aixan/lawnchair
1
0
Fork 0
mirror of https://github.com/LawnchairLauncher/lawnchair.git synced 2026-03-04 01:46:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Memory Leak] Attempt to fix leak caused by onEndCallback created for open app animation not running

Browse Source 
Fix: 397690719
Flag: NONE - release code
Test: presubmit
Change-Id: Icf36b744f21f50b7182c81437ef29b5886c2d43d
This commit is contained in:
Fengjiang Li
2025-02-19 10:24:04 -08:00
parent e0221f0c8b
commit c926dd5be2
2 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
quickstep/src/com/android/launcher3/QuickstepTransitionManager.java
View File

@@ -226,7 +226,6 @@ public class QuickstepTransitionManager implements OnDeviceProfileChangeListener
private static final int TASKBAR_TO_HOME_DURATION_FAST = 300;
private static final int TASKBAR_TO_HOME_DURATION_SLOW = 1000;
protected static final int CONTENT_SCALE_DURATION = 350;
protected static final int CONTENT_SCRIM_DURATION = 350;
private static final int MAX_NUM_TASKS = 5;
@@ -244,7 +243,13 @@ public class QuickstepTransitionManager implements OnDeviceProfileChangeListener
private final StartingWindowListener mStartingWindowListener =
new StartingWindowListener(this);
private ContentObserver mAnimationRemovalObserver = new ContentObserver(
// TODO(b/397690719): Investigate the memory leak from TaskStackChangeListeners#mImpl
// This is a temporary fix of memory leak b/397690719. We track registered
// {@link TaskRestartedDuringLaunchListener}, and remove them on activity destroy.
private final List<TaskRestartedDuringLaunchListener> mRegisteredTaskStackChangeListener =
new ArrayList<>();
private final ContentObserver mAnimationRemovalObserver = new ContentObserver(
ORDERED_BG_EXECUTOR.getHandler()) {
@Override
public void onChange(boolean selfChange) {
@@ -338,7 +343,14 @@ public class QuickstepTransitionManager implements OnDeviceProfileChangeListener
TaskRestartedDuringLaunchListener restartedListener =
new TaskRestartedDuringLaunchListener();
restartedListener.register(onEndCallback::executeAllAndDestroy);
onEndCallback.add(restartedListener::unregister);
mRegisteredTaskStackChangeListener.add(restartedListener);
onEndCallback.add(new Runnable() {
@Override
public void run() {
restartedListener.unregister();
mRegisteredTaskStackChangeListener.remove(restartedListener);
}
});
RemoteAnimationRunnerCompat runner = createAppLaunchRunner(v, onEndCallback);
@@ -1210,6 +1222,12 @@ public class QuickstepTransitionManager implements OnDeviceProfileChangeListener
SystemUiProxy.INSTANCE.get(mLauncher).setStartingWindowListener(null);
ORDERED_BG_EXECUTOR.execute(() -> mLauncher.getContentResolver()
.unregisterContentObserver(mAnimationRemovalObserver));
if (BuildConfig.IS_STUDIO_BUILD && !mRegisteredTaskStackChangeListener.isEmpty()) {
throw new IllegalStateException("Failed to run onEndCallback created from"
+ " getActivityLaunchOptions()");
}
mRegisteredTaskStackChangeListener.forEach(TaskRestartedDuringLaunchListener::unregister);
mRegisteredTaskStackChangeListener.clear();
}
/**