From c778a67f8beb60f6ff556d9839a9e718aa54c9ba Mon Sep 17 00:00:00 2001 From: Cole Faust Date: Wed, 10 Jan 2024 12:30:39 -0800 Subject: [PATCH] Baseline NewApi issues NewApi is a lint check that you don't call framework methods that were introduced in versions later than your min_sdk_version. We want to make this an error, so we're baselineing all existing issues. This cl was generated automatically, by taking all the NewApi issues from the reference baselines, and all the non-NewApi issues from the existing checked in baselines. Bug: 268261262 Test: Presubmits Change-Id: Ibfbf5af12819d43dabd4b6c0eb12a4d0e8258f30 --- Android.bp | 36 +- lint-baseline-go-res-lib.xml | 576 ----------------- lint-baseline-launcher3.xml | 609 ------------------ lint-baseline-res-lib.xml | 48 -- lint-baseline.xml | 233 ++++--- ...-common-deps-lib.xml => lint-baseline2.xml | 21 +- 6 files changed, 135 insertions(+), 1388 deletions(-) delete mode 100644 lint-baseline-go-res-lib.xml delete mode 100644 lint-baseline-launcher3.xml delete mode 100644 lint-baseline-res-lib.xml rename lint-baseline-common-deps-lib.xml => lint-baseline2.xml (54%) diff --git a/Android.bp b/Android.bp index 19d2a5893b..e2dd48dc57 100644 --- a/Android.bp +++ b/Android.bp @@ -112,9 +112,6 @@ android_library { resource_dirs: [], manifest: "tests/tapl/AndroidManifest.xml", platform_apis: true, - lint: { - baseline_filename: "lint-baseline.xml", - }, } java_library_static { @@ -132,9 +129,6 @@ java_library_static { ], }, static_libs: ["libprotobuf-java-lite"], - lint: { - baseline_filename: "lint-baseline.xml", - }, } java_library_static { @@ -153,9 +147,6 @@ java_library_static { "libprotobuf-java-lite", "launcher_log_protos_lite", ], - lint: { - baseline_filename: "lint-baseline.xml", - }, } java_library { @@ -167,9 +158,6 @@ java_library { sdk_version: "current", min_sdk_version: min_launcher3_sdk_version, - lint: { - baseline_filename: "lint-baseline.xml", - }, } // Library with all the dependencies for building Launcher3 @@ -196,7 +184,7 @@ android_library { sdk_version: "current", min_sdk_version: min_launcher3_sdk_version, lint: { - baseline_filename: "lint-baseline-res-lib.xml", + baseline_filename: "lint-baseline2.xml", }, } @@ -218,7 +206,7 @@ android_library { min_sdk_version: min_launcher3_sdk_version, manifest: "AndroidManifest-common.xml", lint: { - baseline_filename: "lint-baseline-common-deps-lib.xml", + baseline_filename: "lint-baseline2.xml", }, } @@ -265,7 +253,7 @@ android_app { "AndroidManifest-common.xml", ], lint: { - baseline_filename: "lint-baseline-launcher3.xml", + baseline_filename: "lint-baseline.xml", }, } @@ -289,9 +277,6 @@ android_library { ], manifest: "quickstep/AndroidManifest.xml", min_sdk_version: "current", - lint: { - baseline_filename: "lint-baseline.xml", - }, } // Library with all the dependencies for building Launcher Go @@ -323,9 +308,6 @@ android_library { "AndroidManifest-common.xml", ], min_sdk_version: "current", - lint: { - baseline_filename: "lint-baseline-go-res-lib.xml", - }, } // Build rule for Quickstep library @@ -354,9 +336,6 @@ android_library { manifest: "quickstep/AndroidManifest.xml", platform_apis: true, min_sdk_version: "current", - lint: { - baseline_filename: "lint-baseline-launcher3.xml", - }, } // Build rule for Launcher3 Go app for Android Go devices. @@ -399,9 +378,6 @@ android_app { jacoco: { include_filter: ["com.android.launcher3.*"], }, - lint: { - baseline_filename: "lint-baseline.xml", - }, } @@ -438,9 +414,6 @@ android_app { jacoco: { include_filter: ["com.android.launcher3.*"], }, - lint: { - baseline_filename: "lint-baseline.xml", - }, } @@ -491,8 +464,5 @@ android_app { jacoco: { include_filter: ["com.android.launcher3.*"], }, - lint: { - baseline_filename: "lint-baseline.xml", - }, } diff --git a/lint-baseline-go-res-lib.xml b/lint-baseline-go-res-lib.xml deleted file mode 100644 index c5669f2a61..0000000000 --- a/lint-baseline-go-res-lib.xml +++ /dev/null @@ -1,576 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/lint-baseline-launcher3.xml b/lint-baseline-launcher3.xml deleted file mode 100644 index 107a34694b..0000000000 --- a/lint-baseline-launcher3.xml +++ /dev/null @@ -1,609 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/lint-baseline-res-lib.xml b/lint-baseline-res-lib.xml deleted file mode 100644 index e52f8fbc70..0000000000 --- a/lint-baseline-res-lib.xml +++ /dev/null @@ -1,48 +0,0 @@ - - - - - - - - - - - - - - - - - - - - diff --git a/lint-baseline.xml b/lint-baseline.xml index 23a22be31b..fe005cadf0 100644 --- a/lint-baseline.xml +++ b/lint-baseline.xml @@ -1,148 +1,169 @@ - + - - - - + message="Call requires API level 29 (current min is 26): `android.content.res.Resources#getFloat`" + errorLine1=" return mContext.getResources().getFloat(resId);" + errorLine2=" ~~~~~~~~"> + line="73" + column="40"/> - - - - - - - - - - - - - - - - + message="Call requires API level 31 (current min is 26): `android.appwidget.AppWidgetHostView#resetColorResources`" + errorLine1=" resetColorResources();" + errorLine2=" ~~~~~~~~~~~~~~~~~~~"> + line="117" + column="13"/> + message="Call requires API level 31 (current min is 30): `android.appwidget.AppWidgetHostView#setColorResources`" + errorLine1=" view.setColorResources(mWallpaperColorResources);" + errorLine2=" ~~~~~~~~~~~~~~~~~"> + line="433" + column="18"/> - - - - - - - - - - - - - - - - - - - - - - - - + message="Call requires API level 28 (current min is 26): `android.app.Person#getKey`" + errorLine1=" return people.stream().filter(person -> person.getKey() != null)" + errorLine2=" ~~~~~~"> + line="72" + column="56"/> + message="Method reference requires API level 28 (current min is 26): `Person::getKey`" + errorLine1=" .map(Person::getKey).sorted().toArray(String[]::new);" + errorLine2=" ~~~~~~~~~~~~~~"> + file="packages/apps/Launcher3/src/com/android/launcher3/notification/NotificationKeyData.java" + line="73" + column="22"/> + message="Field requires API level 29 (current min is 26): `android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction#ACTION_PAGE_LEFT`" + errorLine1=" AccessibilityNodeInfo.AccessibilityAction.ACTION_PAGE_LEFT" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + file="packages/apps/Launcher3/src/com/android/launcher3/PagedView.java" + line="1814" + column="17"/> + message="Field requires API level 29 (current min is 26): `android.view.accessibility.AccessibilityNodeInfo.AccessibilityAction#ACTION_PAGE_RIGHT`" + errorLine1=" : AccessibilityNodeInfo.AccessibilityAction.ACTION_PAGE_RIGHT);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + file="packages/apps/Launcher3/src/com/android/launcher3/PagedView.java" + line="1815" + column="19"/> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/lint-baseline-common-deps-lib.xml b/lint-baseline2.xml similarity index 54% rename from lint-baseline-common-deps-lib.xml rename to lint-baseline2.xml index e52f8fbc70..84f1b15d54 100644 --- a/lint-baseline-common-deps-lib.xml +++ b/lint-baseline2.xml @@ -1,10 +1,10 @@ - + - - - - - + \ No newline at end of file