From c7295ee37a442b5ee386fd877dbd6d2b5f884736 Mon Sep 17 00:00:00 2001 From: Vinit Nayak Date: Tue, 20 Sep 2022 16:21:37 -0700 Subject: [PATCH] Add margin to SUW back button * navButtonsLayoutParams marginEnd was removed, and SUW was relying on that value to add margins to SUW back button, but was returning 0. Fixes: 242999939 Test: Visually observed in SUW test activity adb shell am start -n com.google.android.setupwizard/.SetupWizardTestActivity Change-Id: I5ffc421e9b731b0d9c7b7c48eab807d4419721b1 --- quickstep/res/values/dimens.xml | 2 +- .../android/launcher3/taskbar/NavbarButtonsViewController.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/quickstep/res/values/dimens.xml b/quickstep/res/values/dimens.xml index c85e71cebc..fb78ef76f5 100644 --- a/quickstep/res/values/dimens.xml +++ b/quickstep/res/values/dimens.xml @@ -258,7 +258,7 @@ 16dp 8dp 44dp - 47dp + 48dp 24dp 35dp 24dp diff --git a/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java b/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java index 1c345a6aa4..c27caf1dfe 100644 --- a/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java +++ b/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java @@ -270,7 +270,8 @@ public class NavbarButtonsViewController implements TaskbarControllers.LoggableT // end-aligned, so start-align instead. FrameLayout.LayoutParams navButtonsLayoutParams = (FrameLayout.LayoutParams) mNavButtonContainer.getLayoutParams(); - navButtonsLayoutParams.setMarginStart(navButtonsLayoutParams.getMarginEnd()); + navButtonsLayoutParams.setMarginStart( + resources.getDimensionPixelSize(R.dimen.taskbar_contextual_button_margin)); navButtonsLayoutParams.setMarginEnd(0); navButtonsLayoutParams.gravity = Gravity.START; mNavButtonContainer.requestLayout();