From c2bb120a8752fd1c826b1e4e2a88a2eb40cc03c1 Mon Sep 17 00:00:00 2001 From: Brian Isganitis Date: Wed, 26 Jun 2024 14:50:54 -0400 Subject: [PATCH] Have recreateTaskbar perform recreate on UiThread. Test: Taskbar{AllApps,Overlay}ControllerTest Bug: 230027385 Flag: TEST_ONLY Change-Id: I663e5ad7bb37e73381e2ef9d787c80177cfdf7a7 --- .../taskbar/allapps/TaskbarAllAppsControllerTest.kt | 3 +-- .../taskbar/overlay/TaskbarOverlayControllerTest.kt | 5 +++-- .../android/launcher3/taskbar/rules/TaskbarUnitTestRule.kt | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/allapps/TaskbarAllAppsControllerTest.kt b/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/allapps/TaskbarAllAppsControllerTest.kt index 2d7e751677..adda51c31d 100644 --- a/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/allapps/TaskbarAllAppsControllerTest.kt +++ b/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/allapps/TaskbarAllAppsControllerTest.kt @@ -65,9 +65,8 @@ class TaskbarAllAppsControllerTest { } @Test - @UiThreadTest fun testToggle_taskbarRecreated_allAppsReopened() { - allAppsController.toggle() + getInstrumentation().runOnMainSync { allAppsController.toggle() } taskbarUnitTestRule.recreateTaskbar() assertThat(allAppsController.isOpen).isTrue() } diff --git a/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/overlay/TaskbarOverlayControllerTest.kt b/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/overlay/TaskbarOverlayControllerTest.kt index 494499aecd..4f83ac02e0 100644 --- a/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/overlay/TaskbarOverlayControllerTest.kt +++ b/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/overlay/TaskbarOverlayControllerTest.kt @@ -150,9 +150,10 @@ class TaskbarOverlayControllerTest { } @Test - @UiThreadTest fun testRecreateTaskbar_closesWindow() { - TestOverlayView.show(overlayController.requestWindow()) + getInstrumentation().runOnMainSync { + TestOverlayView.show(overlayController.requestWindow()) + } taskbarUnitTestRule.recreateTaskbar() assertThat(hasOpenView(taskbarContext, TYPE_TASKBAR_OVERLAY_PROXY)).isFalse() } diff --git a/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/rules/TaskbarUnitTestRule.kt b/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/rules/TaskbarUnitTestRule.kt index 9f9a37b8eb..88df0293cb 100644 --- a/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/rules/TaskbarUnitTestRule.kt +++ b/quickstep/tests/multivalentTests/src/com/android/launcher3/taskbar/rules/TaskbarUnitTestRule.kt @@ -135,7 +135,7 @@ class TaskbarUnitTestRule(private val testInstance: Any, private val context: Co /** Simulates Taskbar recreation lifecycle. */ fun recreateTaskbar() { - taskbarManager.recreateTaskbar() + instrumentation.runOnMainSync { taskbarManager.recreateTaskbar() } injectControllers() }