From b759de4769a02811e2fffd977aefd160ee3341f4 Mon Sep 17 00:00:00 2001 From: Stefan Andonian Date: Wed, 28 Sep 2022 20:48:24 +0000 Subject: [PATCH] Fix ViewCapture NPE. The ViewPropertyRefs, when copied from 1 frame to another, where also transferring the same "next" reference. Sometimes, the recycled ViewPropertyRef would be the same ViewPropertyRef instance as one of the copied ViewPropertyRefs, which would caused an NPE, since the recycled VPR would have it's next value set to null. Bug: 249125402 Test: Repro steps are dragging and dropping around an item on the workspace to different locations. This consistently repro's the crash in about 10 seconds of doing this. Afte the fix, the crash stopped. Change-Id: Ia43d8f788eb4889c0890fea0bb839cb9fed78ada --- quickstep/src/com/android/quickstep/util/ViewCapture.java | 1 - 1 file changed, 1 deletion(-) diff --git a/quickstep/src/com/android/quickstep/util/ViewCapture.java b/quickstep/src/com/android/quickstep/util/ViewCapture.java index cfcfce0b6a..6171c5dbea 100644 --- a/quickstep/src/com/android/quickstep/util/ViewCapture.java +++ b/quickstep/src/com/android/quickstep/util/ViewCapture.java @@ -421,7 +421,6 @@ public class ViewCapture { out.visibility = this.visibility; out.willNotDraw = this.willNotDraw; out.clipChildren = this.clipChildren; - out.next = this.next; out.elevation = this.elevation; }