From b140ccec4932e4f4f33bb3be59f2f8a903f212e4 Mon Sep 17 00:00:00 2001 From: Liran Binyamin Date: Fri, 27 Sep 2024 13:00:18 +0000 Subject: [PATCH] Increase frame limit for bubble bar screen test This test is flaky because the animation sometimes doesn't finish before the screenshot is taken. Increasing the frame limit should help to ensure that the animation has time to finish. ABTD 100x runs (passed): https://android-build.corp.google.com/abtd/run/L84400030006722716 Change-Id: I410fb74a947d805551ce1b2303f0dc4c8d616de9 Flag: com.android.wm.shell.enable_bubble_bar Fixes: 366544536 Test: ABTD above --- .../launcher3/taskbar/bubbles/BubbleBarViewScreenshotTest.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quickstep/tests/multivalentScreenshotTests/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewScreenshotTest.kt b/quickstep/tests/multivalentScreenshotTests/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewScreenshotTest.kt index 82a76250c2..b5a418b04d 100644 --- a/quickstep/tests/multivalentScreenshotTests/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewScreenshotTest.kt +++ b/quickstep/tests/multivalentScreenshotTests/src/com/android/launcher3/taskbar/bubbles/BubbleBarViewScreenshotTest.kt @@ -98,7 +98,7 @@ class BubbleBarViewScreenshotTest(emulationSpec: DeviceEmulationSpec) { // if we're still expanding, wait with taking a screenshot val shouldWait: (ComponentActivity, View) -> Boolean = { _, _ -> bubbleBarView.isExpanding } // increase the frame limit to allow the animation to end before taking the screenshot - screenshotRule.frameLimit = 50 + screenshotRule.frameLimit = 500 screenshotRule.screenshotTest( "bubbleBarView_expanded_threeBubbles", checkView = shouldWait,