diff --git a/quickstep/res/values-sw600dp-land/dimens.xml b/quickstep/res/values-sw600dp-land/dimens.xml index 4e3c02cd77..2cd48d5e97 100644 --- a/quickstep/res/values-sw600dp-land/dimens.xml +++ b/quickstep/res/values-sw600dp-land/dimens.xml @@ -15,8 +15,7 @@ */ --> - 19.1dp - 10dp + 12dp 52dp 38dp diff --git a/quickstep/res/values-sw600dp/dimens.xml b/quickstep/res/values-sw600dp/dimens.xml index 223a5e994d..5153afae5c 100644 --- a/quickstep/res/values-sw600dp/dimens.xml +++ b/quickstep/res/values-sw600dp/dimens.xml @@ -20,8 +20,6 @@ 12dp 4dp 36dp - 19.37dp - 22dp 60dp 36dp 36dp diff --git a/quickstep/res/values/dimens.xml b/quickstep/res/values/dimens.xml index 3f08cf3c3a..4210052f98 100644 --- a/quickstep/res/values/dimens.xml +++ b/quickstep/res/values/dimens.xml @@ -35,13 +35,12 @@ 16dp 0dp 0.7 + 1.1 48dp 32dp - 28dp - 28dp - 8dp + 24dp 16dp 16dp diff --git a/quickstep/src/com/android/launcher3/BaseQuickstepLauncher.java b/quickstep/src/com/android/launcher3/BaseQuickstepLauncher.java index fe24c4bb85..6abcbd5504 100644 --- a/quickstep/src/com/android/launcher3/BaseQuickstepLauncher.java +++ b/quickstep/src/com/android/launcher3/BaseQuickstepLauncher.java @@ -296,7 +296,7 @@ public abstract class BaseQuickstepLauncher extends Launcher { new SplitSelectStateController(this, mHandler, getStateManager(), getDepthController()); overviewPanel.init(mActionsView, controller); - mActionsView.setDp(getDeviceProfile()); + mActionsView.updateDimension(getDeviceProfile(), overviewPanel.getLastComputedTaskSize()); mActionsView.updateVerticalMargin(DisplayController.getNavigationMode(this)); mAppTransitionManager = new QuickstepTransitionManager(this); diff --git a/quickstep/src/com/android/quickstep/BaseActivityInterface.java b/quickstep/src/com/android/quickstep/BaseActivityInterface.java index 9686510638..48127c04e2 100644 --- a/quickstep/src/com/android/quickstep/BaseActivityInterface.java +++ b/quickstep/src/com/android/quickstep/BaseActivityInterface.java @@ -19,7 +19,6 @@ import static com.android.launcher3.LauncherAnimUtils.VIEW_BACKGROUND_COLOR; import static com.android.launcher3.anim.Interpolators.ACCEL_2; import static com.android.launcher3.anim.Interpolators.INSTANT; import static com.android.launcher3.anim.Interpolators.LINEAR; -import static com.android.launcher3.util.DisplayController.getNavigationMode; import static com.android.quickstep.AbsSwipeUpHandler.RECENTS_ATTACH_DURATION; import static com.android.quickstep.GestureState.GestureEndTarget.RECENTS; import static com.android.quickstep.util.RecentsAtomicAnimationFactory.INDEX_RECENTS_FADE_ANIM; @@ -62,7 +61,6 @@ import com.android.launcher3.views.ScrimView; import com.android.quickstep.util.ActivityInitListener; import com.android.quickstep.util.AnimatorControllerWithResistance; import com.android.quickstep.util.SplitScreenBounds; -import com.android.quickstep.views.OverviewActionsView; import com.android.quickstep.views.RecentsView; import com.android.quickstep.views.TaskView; import com.android.systemui.shared.recents.model.ThumbnailData; @@ -224,7 +222,7 @@ public abstract class BaseActivityInterface0dp 0dp 0dp - 0dp - 0dp - 0dp + 0dp 0dp 0dp 0dp diff --git a/src/com/android/launcher3/DeviceProfile.java b/src/com/android/launcher3/DeviceProfile.java index 33bb0a5eb9..734f8dd744 100644 --- a/src/com/android/launcher3/DeviceProfile.java +++ b/src/com/android/launcher3/DeviceProfile.java @@ -195,9 +195,7 @@ public class DeviceProfile { public int overviewTaskIconDrawableSizeGridPx; public int overviewTaskThumbnailTopMarginPx; public final int overviewActionsHeight; - public final int overviewActionsMarginThreeButtonPx; - public final int overviewActionsTopMarginGesturePx; - public final int overviewActionsBottomMarginGesturePx; + public final int overviewActionsTopMarginPx; public final int overviewActionsButtonSpacing; public int overviewPageSpacing; public int overviewRowSpacing; @@ -408,16 +406,14 @@ public class DeviceProfile { overviewTaskIconDrawableSizeGridPx = res.getDimensionPixelSize(R.dimen.task_thumbnail_icon_drawable_size_grid); overviewTaskThumbnailTopMarginPx = overviewTaskIconSizePx + overviewTaskMarginPx * 2; - overviewActionsTopMarginGesturePx = res.getDimensionPixelSize( - R.dimen.overview_actions_top_margin_gesture); - overviewActionsBottomMarginGesturePx = res.getDimensionPixelSize( - R.dimen.overview_actions_bottom_margin_gesture); + // In vertical bar, use the smaller task margin for the top regardless of mode. + overviewActionsTopMarginPx = isVerticalBarLayout() + ? overviewTaskMarginPx + : res.getDimensionPixelSize(R.dimen.overview_actions_top_margin); overviewPageSpacing = res.getDimensionPixelSize(R.dimen.overview_page_spacing); overviewActionsButtonSpacing = res.getDimensionPixelSize( R.dimen.overview_actions_button_spacing); overviewActionsHeight = res.getDimensionPixelSize(R.dimen.overview_actions_height); - overviewActionsMarginThreeButtonPx = res.getDimensionPixelSize( - R.dimen.overview_actions_margin_three_button); // Grid task's top margin is only overviewTaskIconSizePx + overviewTaskMarginGridPx, but // overviewTaskThumbnailTopMarginPx is applied to all TaskThumbnailView, so exclude the // extra margin when calculating row spacing. @@ -1103,6 +1099,24 @@ public class DeviceProfile { } } + /** + * Returns the number of pixels required below OverviewActions excluding insets. + */ + public int getOverviewActionsClaimedSpaceBelow() { + if (isTaskbarPresent && !isGestureMode) { + // Align vertically to where nav buttons are. + return ((taskbarSize - overviewActionsHeight) / 2) + getTaskbarOffsetY(); + } + + return 0; + } + + /** Gets the space that the overview actions will take, including bottom margin. */ + public int getOverviewActionsClaimedSpace() { + return overviewActionsTopMarginPx + overviewActionsHeight + + getOverviewActionsClaimedSpaceBelow(); + } + /** * @return the bounds for which the open folders should be contained within */ @@ -1323,12 +1337,10 @@ public class DeviceProfile { overviewTaskIconDrawableSizeGridPx)); writer.println(prefix + pxToDpStr("overviewTaskThumbnailTopMarginPx", overviewTaskThumbnailTopMarginPx)); - writer.println(prefix + pxToDpStr("overviewActionsMarginThreeButtonPx", - overviewActionsMarginThreeButtonPx)); - writer.println(prefix + pxToDpStr("overviewActionsTopMarginGesturePx", - overviewActionsTopMarginGesturePx)); - writer.println(prefix + pxToDpStr("overviewActionsBottomMarginGesturePx", - overviewActionsBottomMarginGesturePx)); + writer.println(prefix + pxToDpStr("overviewActionsTopMarginPx", + overviewActionsTopMarginPx)); + writer.println(prefix + pxToDpStr("overviewActionsHeight", + overviewActionsHeight)); writer.println(prefix + pxToDpStr("overviewActionsButtonSpacing", overviewActionsButtonSpacing)); writer.println(prefix + pxToDpStr("overviewPageSpacing", overviewPageSpacing));