From 73c6288038c05d8e1c692e4027927e4fd6452fd7 Mon Sep 17 00:00:00 2001 From: Vinit Nayak Date: Wed, 9 Feb 2022 15:59:13 -0800 Subject: [PATCH] Add null check for null task in getItemInfo() * Pass back an empty WorkspaceItemInfo with correct itemType set on it so at least it can be identified if remaining fields are missing. Fixes: 218625473 Test: Wasn't able to repro crash Change-Id: If20d8fa648edf6c210ad5398905bf78e173b23a1 --- quickstep/src/com/android/quickstep/views/TaskView.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/quickstep/src/com/android/quickstep/views/TaskView.java b/quickstep/src/com/android/quickstep/views/TaskView.java index 6a2c997e05..d046fefda8 100644 --- a/quickstep/src/com/android/quickstep/views/TaskView.java +++ b/quickstep/src/com/android/quickstep/views/TaskView.java @@ -462,11 +462,15 @@ public class TaskView extends FrameLayout implements Reusable { return getItemInfo(mTask); } - protected WorkspaceItemInfo getItemInfo(Task task) { - ComponentKey componentKey = TaskUtils.getLaunchComponentKeyForTask(task.key); + protected WorkspaceItemInfo getItemInfo(@Nullable Task task) { WorkspaceItemInfo stubInfo = new WorkspaceItemInfo(); stubInfo.itemType = LauncherSettings.Favorites.ITEM_TYPE_TASK; stubInfo.container = LauncherSettings.Favorites.CONTAINER_TASKSWITCHER; + if (task == null) { + return stubInfo; + } + + ComponentKey componentKey = TaskUtils.getLaunchComponentKeyForTask(task.key); stubInfo.user = componentKey.user; stubInfo.intent = new Intent().setComponent(componentKey.componentName); stubInfo.title = task.title;