From 9aa005b657bebe60867b2c2961c2f5deac8cf359 Mon Sep 17 00:00:00 2001 From: Jagrut Desai Date: Thu, 24 Oct 2024 15:29:34 -0700 Subject: [PATCH] Fix Taskbar Touchable Region when overview is in split select mode The problem: when Overview is in split slect mode second split app pick from taskbar take you back home. Why, because upon touch the taskbar touch region get set to empty and then we later don't meet any conditions to set default touch region to something. The solution: change the condition of checking overview in onTaskbarOrBubblebarWindowHeightOrInsetsChanged so that we check that taskbar is in any overview s tate and we don't rely on the stash controller flag alone. we follow similar logic in updateInsetsTouchability, but we gate that only behind transient taskba r hence this was not an issue for transient taskbar. Test: Manual Bug: 373559050 Flag: EXEMPT bugfix Change-Id: Ia507354f42959ce9d320114a313bfc533186b524 --- .../com/android/launcher3/taskbar/TaskbarInsetsController.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarInsetsController.kt b/quickstep/src/com/android/launcher3/taskbar/TaskbarInsetsController.kt index 4a6b6d46b0..325a0d3e91 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarInsetsController.kt +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarInsetsController.kt @@ -150,7 +150,7 @@ class TaskbarInsetsController(val context: TaskbarActivityContext) : LoggableTas } if ( taskbarStashController.isInApp || - taskbarStashController.isInOverview || + controllers.uiController.isInOverviewUi || DisplayController.showLockedTaskbarOnHome(context) ) { // only add the taskbar touch region if not on home