From 972d121edbd9cab8616779c18fb7de2136be92f3 Mon Sep 17 00:00:00 2001 From: Sunny Goyal Date: Fri, 9 Mar 2018 13:09:49 -0800 Subject: [PATCH] Fixing folder icons not handling clicks Change-Id: I52c21086d5734783ffc26e75b301ecce1a8bb956 --- src/com/android/launcher3/folder/Folder.java | 10 +--------- src/com/android/launcher3/folder/FolderPagedView.java | 3 ++- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/src/com/android/launcher3/folder/Folder.java b/src/com/android/launcher3/folder/Folder.java index b3310c7b6f..2b4242959d 100644 --- a/src/com/android/launcher3/folder/Folder.java +++ b/src/com/android/launcher3/folder/Folder.java @@ -18,7 +18,6 @@ package com.android.launcher3.folder; import static com.android.launcher3.LauncherAnimUtils.SPRING_LOADED_EXIT_DELAY; import static com.android.launcher3.LauncherState.NORMAL; -import static com.android.launcher3.LauncherState.OVERVIEW; import static com.android.launcher3.compat.AccessibilityManagerCompat.sendCustomAccessibilityEvent; import android.animation.Animator; @@ -86,7 +85,7 @@ import java.util.List; /** * Represents a set of icons chosen by the user or generated by the system. */ -public class Folder extends AbstractFloatingView implements DragSource, View.OnClickListener, +public class Folder extends AbstractFloatingView implements DragSource, View.OnLongClickListener, DropTarget, FolderListener, TextView.OnEditorActionListener, View.OnFocusChangeListener, DragListener, ExtendedEditText.OnBackKeyListener { private static final String TAG = "Launcher.Folder"; @@ -253,13 +252,6 @@ public class Folder extends AbstractFloatingView implements DragSource, View.OnC mFooterHeight = mFooter.getMeasuredHeight(); } - public void onClick(View v) { - Object tag = v.getTag(); - if (tag instanceof ShortcutInfo) { - mLauncher.onClick(v); - } - } - public boolean onLongClick(View v) { // Return if global dragging is not enabled if (!mLauncher.isDraggingEnabled()) return true; diff --git a/src/com/android/launcher3/folder/FolderPagedView.java b/src/com/android/launcher3/folder/FolderPagedView.java index a468cb54ef..fa7565adb0 100644 --- a/src/com/android/launcher3/folder/FolderPagedView.java +++ b/src/com/android/launcher3/folder/FolderPagedView.java @@ -45,6 +45,7 @@ import com.android.launcher3.Workspace.ItemOperator; import com.android.launcher3.anim.Interpolators; import com.android.launcher3.keyboard.ViewGroupFocusHelper; import com.android.launcher3.pageindicators.PageIndicatorDots; +import com.android.launcher3.touch.ItemClickHandler; import com.android.launcher3.util.Thunk; import java.util.ArrayList; @@ -237,7 +238,7 @@ public class FolderPagedView extends PagedView { R.layout.folder_application, null, false); textView.applyFromShortcutInfo(item); textView.setHapticFeedbackEnabled(false); - textView.setOnClickListener(mFolder); + textView.setOnClickListener(ItemClickHandler.INSTANCE); textView.setOnLongClickListener(mFolder); textView.setOnFocusChangeListener(mFocusIndicatorHelper); textView.setOnKeyListener(mKeyListener);