From 908e9bb1cca50c76285676004a4c2f2cd6fae38f Mon Sep 17 00:00:00 2001 From: vadimt Date: Fri, 28 Feb 2020 18:02:30 -0800 Subject: [PATCH] Fix remaining cause of a leak in SecondaryDropTarget Bug: 139137636 Change-Id: Ib94c5804616910ee562d63c022579042bb1727f5 --- src/com/android/launcher3/SecondaryDropTarget.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/com/android/launcher3/SecondaryDropTarget.java b/src/com/android/launcher3/SecondaryDropTarget.java index 114c49118f..184113413b 100644 --- a/src/com/android/launcher3/SecondaryDropTarget.java +++ b/src/com/android/launcher3/SecondaryDropTarget.java @@ -67,7 +67,6 @@ public class SecondaryDropTarget extends ButtonDropTarget implements OnAlarmList super(context, attrs, defStyle); mCacheExpireAlarm = new Alarm(); - mCacheExpireAlarm.setOnAlarmListener(this); } @Override @@ -75,6 +74,7 @@ public class SecondaryDropTarget extends ButtonDropTarget implements OnAlarmList super.onAttachedToWindow(); if (mHadPendingAlarm) { mCacheExpireAlarm.setAlarm(CACHE_EXPIRE_TIMEOUT); + mCacheExpireAlarm.setOnAlarmListener(this); mHadPendingAlarm = false; } } @@ -84,6 +84,7 @@ public class SecondaryDropTarget extends ButtonDropTarget implements OnAlarmList super.onDetachedFromWindow(); if (mCacheExpireAlarm.alarmPending()) { mCacheExpireAlarm.cancelAlarm(); + mCacheExpireAlarm.setOnAlarmListener(null); mHadPendingAlarm = true; } } @@ -168,6 +169,7 @@ public class SecondaryDropTarget extends ButtonDropTarget implements OnAlarmList } // Cancel any pending alarm and set cache expiry after some time mCacheExpireAlarm.setAlarm(CACHE_EXPIRE_TIMEOUT); + mCacheExpireAlarm.setOnAlarmListener(this); if (uninstallDisabled) { return false; }