From 825ede3e92a7517bf8a6553ffca3a03c71bb0668 Mon Sep 17 00:00:00 2001 From: Vinit Nayak Date: Fri, 11 Nov 2022 18:43:56 -0800 Subject: [PATCH] Update test for vertical split * Takes into account taskbar insets, not sure what expected val should be so copied the same logic from code Bug: 219411750 Test: Ran test, passes Change-Id: I6230a3d043e41446c35c9b393abf4a2e0ea891af --- .../src/com/android/quickstep/FullscreenDrawParamsTest.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/quickstep/tests/src/com/android/quickstep/FullscreenDrawParamsTest.kt b/quickstep/tests/src/com/android/quickstep/FullscreenDrawParamsTest.kt index 6d47281f6c..0c96539762 100644 --- a/quickstep/tests/src/com/android/quickstep/FullscreenDrawParamsTest.kt +++ b/quickstep/tests/src/com/android/quickstep/FullscreenDrawParamsTest.kt @@ -94,8 +94,13 @@ class FullscreenDrawParamsTest : DeviceProfileBaseTest() { params.setProgress(/* fullscreenProgress= */ 1.0f, /* parentScale= */ 1.0f, /* taskViewScale= */ 1.0f, /* previewWidth= */ 0, dp, mPreviewPositionHelper) + // Probably unhelpful, but also unclear how to test otherwise ¯\_(ツ)_/¯ + val fullscreenTaskHeight = (dp.heightPx - dp.taskbarSize) * + (1 - (splitBounds.topTaskPercent + splitBounds.dividerHeightPercent)) + val canvasScreenRatio = canvasHeight / fullscreenTaskHeight + val expectedBottomHint = dp.taskbarSize * canvasScreenRatio assertThat(params.mCurrentDrawnInsets.bottom) - .isWithin(1f).of((dp.taskbarSize * TASK_SCALE)) + .isWithin(1f).of(expectedBottomHint) } @Test