From 27d3c595cfd3c462b93364c357253c2f4b686f37 Mon Sep 17 00:00:00 2001 From: Andy Wickham Date: Thu, 20 Feb 2020 20:32:07 +0000 Subject: [PATCH] Makes all ArrowPopups AccessibilityTargets. This currently includes the menu that pops up when long pressing an app icon in Launcher or Search, or long pressing Smartspace. Previously, only the menu for Launcher apps grabbed accessibility focus after the open animation completed, and now all three do. Fixes: 145253300 Change-Id: I147b45d38a04ab9a55eee9b5bd5551b4c7185fcf --- src/com/android/launcher3/popup/ArrowPopup.java | 6 ++++++ .../android/launcher3/popup/PopupContainerWithArrow.java | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/com/android/launcher3/popup/ArrowPopup.java b/src/com/android/launcher3/popup/ArrowPopup.java index d9bd7144c5..065eb37470 100644 --- a/src/com/android/launcher3/popup/ArrowPopup.java +++ b/src/com/android/launcher3/popup/ArrowPopup.java @@ -32,6 +32,7 @@ import android.graphics.Paint; import android.graphics.Rect; import android.graphics.drawable.ShapeDrawable; import android.util.AttributeSet; +import android.util.Pair; import android.view.Gravity; import android.view.LayoutInflater; import android.view.View; @@ -358,6 +359,11 @@ public abstract class ArrowPopup extends Abstrac } } + @Override + protected Pair getAccessibilityTarget() { + return Pair.create(this, ""); + } + private void animateOpen() { setVisibility(View.VISIBLE); diff --git a/src/com/android/launcher3/popup/PopupContainerWithArrow.java b/src/com/android/launcher3/popup/PopupContainerWithArrow.java index 05ea694d6f..445acca5c9 100644 --- a/src/com/android/launcher3/popup/PopupContainerWithArrow.java +++ b/src/com/android/launcher3/popup/PopupContainerWithArrow.java @@ -37,7 +37,6 @@ import android.os.Build; import android.os.Handler; import android.os.Looper; import android.util.AttributeSet; -import android.util.Pair; import android.view.MotionEvent; import android.view.View; import android.view.ViewGroup; @@ -329,11 +328,6 @@ public class PopupContainerWithArrow extends Arr R.string.shortcuts_menu_with_notifications_description); } - @Override - protected Pair getAccessibilityTarget() { - return Pair.create(this, ""); - } - @Override protected void getTargetObjectLocation(Rect outPos) { getPopupContainer().getDescendantRectRelativeToSelf(mOriginalIcon, outPos);