From 664457dbfd1b82abdcc30c574e4cda586aa6a323 Mon Sep 17 00:00:00 2001 From: Joe Onorato Date: Wed, 28 Oct 2009 16:30:34 -0400 Subject: [PATCH] Fix 2200739 - Crash when you click on an empty icon slot in 3d all apps --- src/com/android/launcher2/AllAppsView.java | 34 +++++++++++++--------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/src/com/android/launcher2/AllAppsView.java b/src/com/android/launcher2/AllAppsView.java index 783be9315a..795f490675 100644 --- a/src/com/android/launcher2/AllAppsView.java +++ b/src/com/android/launcher2/AllAppsView.java @@ -1028,6 +1028,20 @@ public class AllAppsView extends RSSurfaceView mTouchXBorders[4] = width; } + void fling() { + mInvokeFling.execute(); + } + + void move() { + mInvokeMove.execute(); + } + + void moveTo(float row) { + mState.targetPos = row; + mState.save(); + mInvokeMoveTo.execute(); + } + int chooseTappedIcon(int x, int y, float pos) { // Adjust for scroll position if not zero. y += (pos - ((int)pos)) * (mTouchYBorders[1] - mTouchYBorders[0]); @@ -1051,22 +1065,14 @@ public class AllAppsView extends RSSurfaceView return -1; } - return (((int)pos) * Defines.COLUMNS_PER_PAGE) + int index = (((int)pos) * Defines.COLUMNS_PER_PAGE) + (row * Defines.ROWS_PER_PAGE) + col; - } - void fling() { - mInvokeFling.execute(); - } - - void move() { - mInvokeMove.execute(); - } - - void moveTo(float row) { - mState.targetPos = row; - mState.save(); - mInvokeMoveTo.execute(); + if (index >= mState.iconCount) { + return -1; + } else { + return index; + } } /**