aixan/lawnchair
1
0
Fork 0
mirror of https://github.com/LawnchairLauncher/lawnchair.git synced 2026-03-06 02:46:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor DeviceProfile tests based on dump() and use real device dimensions for tests.

Browse Source 
- Added roundPxValueFromFloat when converting dp/sp to px to deterministically round up values around .5

Fix: 240133465
Bug: 237542518
Test: DeviceProfileTest.kt
Change-Id: If4239f714487fe5bf2ef44274e2ce415bd75c86d
This commit is contained in:
Pat Manning
2022-07-20 12:08:54 +01:00
committed by Alex Chau
parent 8157be497d
commit 5f74bfd76d
23 changed files with 1802 additions and 5914 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/com/android/launcher3/testing/shared/ResourceUtils.java
View File

@@ -21,6 +21,7 @@ import android.util.DisplayMetrics;
import android.util.TypedValue;
public class ResourceUtils {
private static final float EPSILON = 0.0001f;
public static final int DEFAULT_NAVBAR_VALUE = 48;
public static final int INVALID_RESOURCE_HANDLE = -1;
public static final String NAVBAR_LANDSCAPE_LEFT_RIGHT_SIZE = "navigation_bar_width";
@@ -71,7 +72,25 @@ public class ResourceUtils {
}
public static int pxFromDp(float size, DisplayMetrics metrics, float scale) {
return size < 0 ? INVALID_RESOURCE_HANDLE : Math.round(scale
* TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP, size, metrics));
float value = scale * TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP, size, metrics);
return size < 0 ? INVALID_RESOURCE_HANDLE : roundPxValueFromFloat(value);
}
/**
* Rounds a pixel value, taking into account floating point errors.
*
* <p>If a dp (or sp) value typically returns a half pixel, such as 20dp at a 2.625 density
* returning 52.5px, there is a small chance that due to floating-point errors, the value will
* be stored as 52.499999. As we round to the nearest pixel, this could cause a 1px difference
* in final values, which we correct for in this method.
*/
public static int roundPxValueFromFloat(float value) {
float fraction = (float) (value - Math.floor(value));
if (Math.abs(0.5f - fraction) < EPSILON) {
// Note: we add for negative values as well, as Math.round brings -.5 to the next
// "highest" value, e.g. Math.round(-2.5) == -2 [i.e. (int)Math.floor(a + 0.5d)]
value += EPSILON;
}
return Math.round(value);
}
}