From 4b2403bbdf41399ab6319a7f9626ff7f7d23c986 Mon Sep 17 00:00:00 2001 From: Hyunyoung Song Date: Wed, 9 Dec 2020 11:11:14 -0800 Subject: [PATCH] Fix NPE inside SEarchResultThumbnailView on cropping Bug: 175161949 Test: builds. Created screenshot of landscape portion and verified Change-Id: Ib80147bcb40cf73364e8bed91f38019716aa71c8 --- .../launcher3/views/ThumbnailSearchResultView.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/com/android/launcher3/views/ThumbnailSearchResultView.java b/src/com/android/launcher3/views/ThumbnailSearchResultView.java index f213f229a8..573d48f799 100644 --- a/src/com/android/launcher3/views/ThumbnailSearchResultView.java +++ b/src/com/android/launcher3/views/ThumbnailSearchResultView.java @@ -88,9 +88,15 @@ public class ThumbnailSearchResultView extends androidx.appcompat.widget.AppComp bitmap = ((BitmapDrawable) target.getRemoteAction().getIcon() .loadDrawable(getContext())).getBitmap(); // crop - bitmap = Bitmap.createBitmap(bitmap, 0, - bitmap.getHeight() / 2 - bitmap.getWidth() / 2, - bitmap.getWidth(), bitmap.getWidth()); + if (bitmap.getWidth() < bitmap.getHeight()) { + bitmap = Bitmap.createBitmap(bitmap, 0, + bitmap.getHeight() / 2 - bitmap.getWidth() / 2, + bitmap.getWidth(), bitmap.getWidth()); + } else { + bitmap = Bitmap.createBitmap(bitmap, bitmap.getWidth() / 2 - bitmap.getHeight() / 2, + 0, + bitmap.getHeight(), bitmap.getHeight()); + } setTag(itemInfo); } else { bitmap = (Bitmap) target.getExtras().getParcelable("bitmap");