From 368dc79f55153229b4d7defcc36e90c8f5ffe65a Mon Sep 17 00:00:00 2001 From: vadimt Date: Wed, 10 Mar 2021 12:19:12 -0800 Subject: [PATCH] Increase wait times in TAPL This helps to avoid misleading errors when the system has performance problems. Test: presubmit Bug: 179392551 Change-Id: I4de3c543f32f41af64bd6107885df82b03973d35 --- tests/src/com/android/launcher3/ui/WorkTabTest.java | 4 ++-- .../com/android/launcher3/tapl/LauncherInstrumentation.java | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/src/com/android/launcher3/ui/WorkTabTest.java b/tests/src/com/android/launcher3/ui/WorkTabTest.java index a6c7c03da4..8f4381b0fe 100644 --- a/tests/src/com/android/launcher3/ui/WorkTabTest.java +++ b/tests/src/com/android/launcher3/ui/WorkTabTest.java @@ -18,7 +18,6 @@ package com.android.launcher3.ui; import static com.android.launcher3.LauncherState.ALL_APPS; import static com.android.launcher3.LauncherState.NORMAL; import static com.android.launcher3.allapps.AllAppsStore.DEFER_UPDATES_TEST; -import static com.android.launcher3.tapl.LauncherInstrumentation.LONG_WAIT_TIME_MS; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; @@ -37,6 +36,7 @@ import com.android.launcher3.allapps.AllAppsContainerView; import com.android.launcher3.allapps.AllAppsPagedView; import com.android.launcher3.allapps.WorkModeSwitch; import com.android.launcher3.dragndrop.DragLayer; +import com.android.launcher3.tapl.LauncherInstrumentation; import com.android.launcher3.testing.TestProtocol; import com.android.launcher3.views.WorkEduView; @@ -147,7 +147,7 @@ public class WorkTabTest extends AbstractLauncherUiTest { return true; } return false; - }, LONG_WAIT_TIME_MS); + }, LauncherInstrumentation.WAIT_TIME_MS); executeOnLauncher(launcher -> launcher.getStateManager().goToState(ALL_APPS)); WorkEduView workEduView = getEduView(); diff --git a/tests/tapl/com/android/launcher3/tapl/LauncherInstrumentation.java b/tests/tapl/com/android/launcher3/tapl/LauncherInstrumentation.java index f279a82475..a3f37d2fe6 100644 --- a/tests/tapl/com/android/launcher3/tapl/LauncherInstrumentation.java +++ b/tests/tapl/com/android/launcher3/tapl/LauncherInstrumentation.java @@ -155,8 +155,7 @@ public final class LauncherInstrumentation { private static final String OVERVIEW_RES_ID = "overview_panel"; private static final String WIDGETS_RES_ID = "primary_widgets_list_view"; private static final String CONTEXT_MENU_RES_ID = "deep_shortcuts_container"; - public static final int WAIT_TIME_MS = 10000; - public static final int LONG_WAIT_TIME_MS = 60000; + public static final int WAIT_TIME_MS = 60000; private static final String SYSTEMUI_PACKAGE = "com.android.systemui"; private static final String ANDROID_PACKAGE = "android"; @@ -656,7 +655,7 @@ public final class LauncherInstrumentation { try { final AccessibilityEvent event = mInstrumentation.getUiAutomation().executeAndWaitForEvent( - command, eventFilter, LONG_WAIT_TIME_MS); + command, eventFilter, WAIT_TIME_MS); assertNotNull("executeAndWaitForEvent returned null (this can't happen)", event); final Parcelable parcelableData = event.getParcelableData(); event.recycle();