From 84261f9d9b6d8d2baa41a1877998b53479cd2388 Mon Sep 17 00:00:00 2001 From: Brian Isganitis Date: Sat, 25 Feb 2023 02:00:09 +0000 Subject: [PATCH] Ensure taskbar background always transparent in notification tray. Persistent, taskbar can be in light or dark modes. Since notification tray has its own background color, we should hide ours to avoid clashing with it. Test: Manual Fix: 270758899 Change-Id: Iedc6aae42aac30987af3259ccee11c5998e10517 --- .../launcher3/taskbar/NavbarButtonsViewController.java | 7 +------ .../android/launcher3/taskbar/TaskbarActivityContext.java | 6 ++---- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java b/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java index bafd5b4532..84bf02ec28 100644 --- a/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java +++ b/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java @@ -288,14 +288,9 @@ public class NavbarButtonsViewController implements TaskbarControllers.LoggableT updateButtonLayoutSpacing(); updateStateForFlag(FLAG_SMALL_SCREEN, isPhoneButtonNavMode(mContext)); - // Animate taskbar background when either.. - // notification shade expanded AND not on keyguard - // back is visible for bouncer mPropertyHolders.add(new StatePropertyHolder( mControllers.taskbarDragLayerController.getNavbarBackgroundAlpha(), - flags -> ((flags & FLAG_NOTIFICATION_SHADE_EXPANDED) != 0 - && (flags & FLAG_KEYGUARD_VISIBLE) == 0) - || (flags & FLAG_ONLY_BACK_FOR_BOUNCER_VISIBLE) != 0)); + flags -> (flags & FLAG_ONLY_BACK_FOR_BOUNCER_VISIBLE) != 0)); // Rotation button RotationButton rotationButton = new RotationButtonImpl( diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java index 81389abf01..57e11de26f 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java @@ -589,10 +589,8 @@ public class TaskbarActivityContext extends BaseTaskbarContext { AnimatorSet anim = new AnimatorSet(); anim.play(mControllers.taskbarViewController.getTaskbarIconAlpha().get( TaskbarViewController.ALPHA_INDEX_NOTIFICATION_EXPANDED).animateToValue(alpha)); - if (!isThreeButtonNav()) { - anim.play(mControllers.taskbarDragLayerController.getNotificationShadeBgTaskbar() - .animateToValue(alpha)); - } + anim.play(mControllers.taskbarDragLayerController.getNotificationShadeBgTaskbar() + .animateToValue(alpha)); anim.start(); if (skipAnim) { anim.end();