From 26a1b452f47f9fe4f1cfc700d98df8a3a569eac2 Mon Sep 17 00:00:00 2001 From: Derek Sollenberger Date: Fri, 23 Feb 2018 13:37:25 -0500 Subject: [PATCH] Stop using deprecated Canvas APIs. Bug: 73777445 Test: compile Change-Id: Ic0a1f4ebc10ba46229fd97408c052c0b450b4945 --- src/com/android/launcher3/badge/BadgeRenderer.java | 2 +- src/com/android/launcher3/dragndrop/DragView.java | 2 +- src/com/android/launcher3/folder/FolderIcon.java | 7 +++---- src/com/android/launcher3/folder/PreviewBackground.java | 5 ++--- src/com/android/launcher3/folder/PreviewItemManager.java | 2 +- .../android/launcher3/graphics/DragPreviewProvider.java | 2 +- src/com/android/launcher3/graphics/FixedScaleDrawable.java | 2 +- src/com/android/launcher3/graphics/LauncherIcons.java | 2 +- .../android/launcher3/graphics/PreloadIconDrawable.java | 2 +- .../launcher3/shortcuts/ShortcutDragPreviewProvider.java | 2 -- .../launcher3/views/DoubleShadowBubbleTextView.java | 4 ++-- .../android/launcher3/views/RecyclerViewFastScroller.java | 2 +- 12 files changed, 15 insertions(+), 19 deletions(-) diff --git a/src/com/android/launcher3/badge/BadgeRenderer.java b/src/com/android/launcher3/badge/BadgeRenderer.java index 72d49f02ff..948742727c 100644 --- a/src/com/android/launcher3/badge/BadgeRenderer.java +++ b/src/com/android/launcher3/badge/BadgeRenderer.java @@ -80,7 +80,7 @@ public class BadgeRenderer { Log.e(TAG, "Invalid null argument(s) passed in call to draw."); return; } - canvas.save(Canvas.MATRIX_SAVE_FLAG); + canvas.save(); // We draw the badge relative to its center. float badgeCenterX = iconBounds.right - mDotCenterOffset / 2; float badgeCenterY = iconBounds.top + mDotCenterOffset / 2; diff --git a/src/com/android/launcher3/dragndrop/DragView.java b/src/com/android/launcher3/dragndrop/DragView.java index a59b8996b5..8d4f2ef0a3 100644 --- a/src/com/android/launcher3/dragndrop/DragView.java +++ b/src/com/android/launcher3/dragndrop/DragView.java @@ -448,7 +448,7 @@ public class DragView extends View { canvas.drawBitmap(mBitmap, 0.0f, 0.0f, mPaint); if (crossFade) { mPaint.setAlpha((int) (255 * mCrossFadeProgress)); - final int saveCount = canvas.save(Canvas.MATRIX_SAVE_FLAG); + final int saveCount = canvas.save(); float sX = (mBitmap.getWidth() * 1.0f) / mCrossFadeBitmap.getWidth(); float sY = (mBitmap.getHeight() * 1.0f) / mCrossFadeBitmap.getHeight(); canvas.scale(sX, sY); diff --git a/src/com/android/launcher3/folder/FolderIcon.java b/src/com/android/launcher3/folder/FolderIcon.java index 2de09b8f28..13926db691 100644 --- a/src/com/android/launcher3/folder/FolderIcon.java +++ b/src/com/android/launcher3/folder/FolderIcon.java @@ -467,11 +467,10 @@ public class FolderIcon extends FrameLayout implements FolderListener { final int saveCount; if (canvas.isHardwareAccelerated()) { - saveCount = canvas.saveLayer(0, 0, getWidth(), getHeight(), null, - Canvas.HAS_ALPHA_LAYER_SAVE_FLAG | Canvas.CLIP_TO_LAYER_SAVE_FLAG); + saveCount = canvas.saveLayer(0, 0, getWidth(), getHeight(), null); } else { - saveCount = canvas.save(Canvas.CLIP_SAVE_FLAG); - canvas.clipPath(mBackground.getClipPath(), Region.Op.INTERSECT); + saveCount = canvas.save(); + canvas.clipPath(mBackground.getClipPath()); } mPreviewItemManager.draw(canvas); diff --git a/src/com/android/launcher3/folder/PreviewBackground.java b/src/com/android/launcher3/folder/PreviewBackground.java index 285aef8c85..a0912a4a06 100644 --- a/src/com/android/launcher3/folder/PreviewBackground.java +++ b/src/com/android/launcher3/folder/PreviewBackground.java @@ -227,11 +227,10 @@ public class PreviewBackground { final int saveCount; if (canvas.isHardwareAccelerated()) { saveCount = canvas.saveLayer(offsetX - mStrokeWidth, offsetY, - offsetX + radius + shadowRadius, offsetY + shadowRadius + shadowRadius, - null, Canvas.CLIP_TO_LAYER_SAVE_FLAG | Canvas.HAS_ALPHA_LAYER_SAVE_FLAG); + offsetX + radius + shadowRadius, offsetY + shadowRadius + shadowRadius, null); } else { - saveCount = canvas.save(Canvas.CLIP_SAVE_FLAG); + saveCount = canvas.save(); canvas.clipPath(getClipPath(), Region.Op.DIFFERENCE); } diff --git a/src/com/android/launcher3/folder/PreviewItemManager.java b/src/com/android/launcher3/folder/PreviewItemManager.java index 06d3eb166b..1f69f6e768 100644 --- a/src/com/android/launcher3/folder/PreviewItemManager.java +++ b/src/com/android/launcher3/folder/PreviewItemManager.java @@ -168,7 +168,7 @@ public class PreviewItemManager { } private void drawPreviewItem(Canvas canvas, PreviewItemDrawingParams params) { - canvas.save(Canvas.MATRIX_SAVE_FLAG); + canvas.save(); canvas.translate(params.transX, params.transY); canvas.scale(params.scale, params.scale); Drawable d = params.drawable; diff --git a/src/com/android/launcher3/graphics/DragPreviewProvider.java b/src/com/android/launcher3/graphics/DragPreviewProvider.java index 6a328e9230..b770785828 100644 --- a/src/com/android/launcher3/graphics/DragPreviewProvider.java +++ b/src/com/android/launcher3/graphics/DragPreviewProvider.java @@ -103,7 +103,7 @@ public class DragPreviewProvider { } destCanvas.translate(-mView.getScrollX() + blurSizeOutline / 2, -mView.getScrollY() + blurSizeOutline / 2); - destCanvas.clipRect(clipRect, Op.REPLACE); + destCanvas.clipRect(clipRect); mView.draw(destCanvas); // Restore text visibility of FolderIcon if necessary diff --git a/src/com/android/launcher3/graphics/FixedScaleDrawable.java b/src/com/android/launcher3/graphics/FixedScaleDrawable.java index 262a95e2b0..0f0e42428d 100644 --- a/src/com/android/launcher3/graphics/FixedScaleDrawable.java +++ b/src/com/android/launcher3/graphics/FixedScaleDrawable.java @@ -29,7 +29,7 @@ public class FixedScaleDrawable extends DrawableWrapper { @Override public void draw(Canvas canvas) { - int saveCount = canvas.save(Canvas.MATRIX_SAVE_FLAG); + int saveCount = canvas.save(); canvas.scale(mScaleX, mScaleY, getBounds().exactCenterX(), getBounds().exactCenterY()); super.draw(canvas); diff --git a/src/com/android/launcher3/graphics/LauncherIcons.java b/src/com/android/launcher3/graphics/LauncherIcons.java index 34fc921a64..8abfdeae8e 100644 --- a/src/com/android/launcher3/graphics/LauncherIcons.java +++ b/src/com/android/launcher3/graphics/LauncherIcons.java @@ -302,7 +302,7 @@ public class LauncherIcons implements AutoCloseable { } else { icon.setBounds(left, top, left+width, top+height); } - mCanvas.save(Canvas.MATRIX_SAVE_FLAG); + mCanvas.save(); mCanvas.scale(scale, scale, textureWidth / 2, textureHeight / 2); icon.draw(mCanvas); mCanvas.restore(); diff --git a/src/com/android/launcher3/graphics/PreloadIconDrawable.java b/src/com/android/launcher3/graphics/PreloadIconDrawable.java index a40b6df93b..ea55ba441f 100644 --- a/src/com/android/launcher3/graphics/PreloadIconDrawable.java +++ b/src/com/android/launcher3/graphics/PreloadIconDrawable.java @@ -176,7 +176,7 @@ public class PreloadIconDrawable extends FastBitmapDrawable { } canvas.drawPath(mScaledProgressPath, mProgressPaint); - int saveCount = canvas.save(Canvas.MATRIX_SAVE_FLAG); + int saveCount = canvas.save(); Rect bounds = getBounds(); canvas.scale(mIconScale, mIconScale, bounds.exactCenterX(), bounds.exactCenterY()); diff --git a/src/com/android/launcher3/shortcuts/ShortcutDragPreviewProvider.java b/src/com/android/launcher3/shortcuts/ShortcutDragPreviewProvider.java index cfb9258dd9..ee97641109 100644 --- a/src/com/android/launcher3/shortcuts/ShortcutDragPreviewProvider.java +++ b/src/com/android/launcher3/shortcuts/ShortcutDragPreviewProvider.java @@ -50,12 +50,10 @@ public class ShortcutDragPreviewProvider extends DragPreviewProvider { Bitmap.Config.ARGB_8888); Canvas canvas = new Canvas(b); - canvas.save(Canvas.MATRIX_SAVE_FLAG); canvas.translate(blurSizeOutline / 2, blurSizeOutline / 2); canvas.scale(((float) size) / bounds.width(), ((float) size) / bounds.height(), 0, 0); canvas.translate(bounds.left, bounds.top); d.draw(canvas); - canvas.restore(); return b; } diff --git a/src/com/android/launcher3/views/DoubleShadowBubbleTextView.java b/src/com/android/launcher3/views/DoubleShadowBubbleTextView.java index c8203f7f23..01b63bec47 100644 --- a/src/com/android/launcher3/views/DoubleShadowBubbleTextView.java +++ b/src/com/android/launcher3/views/DoubleShadowBubbleTextView.java @@ -63,10 +63,10 @@ public class DoubleShadowBubbleTextView extends BubbleTextView { ColorUtils.setAlphaComponent(mShadowInfo.ambientShadowColor, alpha)); drawWithoutBadge(canvas); - canvas.save(Canvas.CLIP_SAVE_FLAG); + canvas.save(); canvas.clipRect(getScrollX(), getScrollY() + getExtendedPaddingTop(), getScrollX() + getWidth(), - getScrollY() + getHeight(), Region.Op.INTERSECT); + getScrollY() + getHeight()); getPaint().setShadowLayer(mShadowInfo.keyShadowBlur, 0.0f, mShadowInfo.keyShadowOffset, ColorUtils.setAlphaComponent(mShadowInfo.keyShadowColor, alpha)); diff --git a/src/com/android/launcher3/views/RecyclerViewFastScroller.java b/src/com/android/launcher3/views/RecyclerViewFastScroller.java index fc121d3618..58c9148030 100644 --- a/src/com/android/launcher3/views/RecyclerViewFastScroller.java +++ b/src/com/android/launcher3/views/RecyclerViewFastScroller.java @@ -289,7 +289,7 @@ public class RecyclerViewFastScroller extends View { if (mThumbOffsetY < 0) { return; } - int saveCount = canvas.save(Canvas.MATRIX_SAVE_FLAG); + int saveCount = canvas.save(); canvas.translate(getWidth() / 2, mRv.getScrollBarTop()); // Draw the track float halfW = mWidth / 2;