From 9538d9bf996b3f99129c702d02d9c47f7620c4f8 Mon Sep 17 00:00:00 2001 From: Jon Miranda Date: Thu, 1 Apr 2021 13:14:23 -0400 Subject: [PATCH 1/9] Set FLAG_IMMUTABLE flag on FirstScreenBroadcast PendingIntent. Bug: 183927137 Test: restore phone and ensure broadcast is sent Change-Id: I8d8e38a1aa6bdf13879d460cfa84cabe6c6bb1f2 (cherry picked from commit b62fba0d0199d719ac63761846e09b4b28e1dc2c) --- src/com/android/launcher3/model/FirstScreenBroadcast.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/com/android/launcher3/model/FirstScreenBroadcast.java b/src/com/android/launcher3/model/FirstScreenBroadcast.java index 5112304fb8..f9ed2c78b6 100644 --- a/src/com/android/launcher3/model/FirstScreenBroadcast.java +++ b/src/com/android/launcher3/model/FirstScreenBroadcast.java @@ -15,6 +15,8 @@ */ package com.android.launcher3.model; +import static android.app.PendingIntent.FLAG_IMMUTABLE; +import static android.app.PendingIntent.FLAG_ONE_SHOT; import static android.os.Process.myUserHandle; import android.app.PendingIntent; @@ -145,7 +147,7 @@ public class FirstScreenBroadcast { .putStringArrayListExtra(HOTSEAT_ITEM_EXTRA, new ArrayList<>(hotseatItems)) .putStringArrayListExtra(WIDGET_ITEM_EXTRA, new ArrayList<>(widgetItems)) .putExtra(VERIFICATION_TOKEN_EXTRA, PendingIntent.getActivity(context, 0, - new Intent(), PendingIntent.FLAG_ONE_SHOT))); + new Intent(), FLAG_ONE_SHOT | FLAG_IMMUTABLE))); } private static String getPackageName(ItemInfo info) { From d9389278cc9cc56fe2e66d771674008893c99135 Mon Sep 17 00:00:00 2001 From: Bob Badour Date: Mon, 12 Jul 2021 16:07:39 -0700 Subject: [PATCH 2/9] [LSC] Add LOCAL_LICENSE_KINDS to packages/apps/Launcher3 Added SPDX-license-identifier-Apache-2.0 to: Android.mk Bug: 68860345 Bug: 151177513 Bug: 151953481 Test: m all Exempt-From-Owner-Approval: janitorial work Change-Id: I7114a8abc76d6aff0357e15e65b5a6d909f7cd35 Merged-in: I069f0fcd0652dcfd3e9c539e1f9bcb4c9225a10b --- Android.mk | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Android.mk b/Android.mk index 2c595505ff..aff12c5e5f 100644 --- a/Android.mk +++ b/Android.mk @@ -91,6 +91,9 @@ LOCAL_FULL_LIBS_MANIFEST_FILES := $(LOCAL_PATH)/AndroidManifest-common.xml LOCAL_JACK_COVERAGE_INCLUDE_FILTER := com.android.launcher3.* +LOCAL_LICENSE_KINDS := SPDX-license-identifier-Apache-2.0 +LOCAL_LICENSE_CONDITIONS := notice +LOCAL_NOTICE_FILE := $(LOCAL_PATH)/NOTICE include $(BUILD_PACKAGE) # @@ -124,6 +127,9 @@ LOCAL_FULL_LIBS_MANIFEST_FILES := \ LOCAL_MANIFEST_FILE := go/AndroidManifest.xml LOCAL_JACK_COVERAGE_INCLUDE_FILTER := com.android.launcher3.* +LOCAL_LICENSE_KINDS := SPDX-license-identifier-Apache-2.0 +LOCAL_LICENSE_CONDITIONS := notice +LOCAL_NOTICE_FILE := $(LOCAL_PATH)/NOTICE include $(BUILD_PACKAGE) # @@ -200,6 +206,9 @@ LOCAL_FULL_LIBS_MANIFEST_FILES := \ LOCAL_MANIFEST_FILE := quickstep/AndroidManifest.xml LOCAL_JACK_COVERAGE_INCLUDE_FILTER := com.android.launcher3.* +LOCAL_LICENSE_KINDS := SPDX-license-identifier-Apache-2.0 +LOCAL_LICENSE_CONDITIONS := notice +LOCAL_NOTICE_FILE := $(LOCAL_PATH)/NOTICE include $(BUILD_PACKAGE) @@ -250,6 +259,9 @@ LOCAL_FULL_LIBS_MANIFEST_FILES := \ LOCAL_MANIFEST_FILE := quickstep/AndroidManifest.xml LOCAL_JACK_COVERAGE_INCLUDE_FILTER := com.android.launcher3.* +LOCAL_LICENSE_KINDS := SPDX-license-identifier-Apache-2.0 +LOCAL_LICENSE_CONDITIONS := notice +LOCAL_NOTICE_FILE := $(LOCAL_PATH)/NOTICE include $(BUILD_PACKAGE) From 1c016851862141218ed2e9feb795a150e60ebe1c Mon Sep 17 00:00:00 2001 From: Damian Patel Date: Wed, 28 Jul 2021 14:38:39 +0000 Subject: [PATCH 3/9] API level 30 upgrade: AOSP/Launcher3 The AndroidManifest.xml and build.gradle file of the AOSP Launcher app has been upgraded so that its targetSdkVersion is 30. This change has been made on git_master so that we can avoid presubmit conflicts when making this change on the aosp-master branch. Change-Id: Ie476f8cbe56bf51218b15b8361a22fec2dc845e6 (cherry picked from commit 499ffce2e704aa82b4d10468f99afd3dc4e727f8) --- AndroidManifest.xml | 2 +- build.gradle | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 8066816e89..f793131fd3 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -20,7 +20,7 @@ - + + diff --git a/tests/AndroidManifest-common.xml b/tests/AndroidManifest-common.xml index 918ec4af1a..4d980c47e0 100644 --- a/tests/AndroidManifest-common.xml +++ b/tests/AndroidManifest-common.xml @@ -16,6 +16,7 @@ @@ -235,5 +236,11 @@ + + + From 183bca2dcce50780f8d434e99558fac1bcf2af28 Mon Sep 17 00:00:00 2001 From: Alan Viverette Date: Thu, 26 Aug 2021 03:27:13 +0000 Subject: [PATCH 9/9] Temporarily disable Launcher3 tests affected by fling changes Bug: 197802324 Test: TaplTestsLauncher3 Change-Id: I3958bd9fb5521d09fa7cae642128b9f5e11b8e2e Merged-In: I3958bd9fb5521d09fa7cae642128b9f5e11b8e2e (cherry picked from commit bc4dc49c6c48bc716df63def3b25c476a414a757) --- .../tests/src/com/android/quickstep/TaplTestsQuickstep.java | 2 ++ tests/src/com/android/launcher3/ui/TaplTestsLauncher3.java | 1 + 2 files changed, 3 insertions(+) diff --git a/quickstep/tests/src/com/android/quickstep/TaplTestsQuickstep.java b/quickstep/tests/src/com/android/quickstep/TaplTestsQuickstep.java index a5038a1fb0..b856e0b560 100644 --- a/quickstep/tests/src/com/android/quickstep/TaplTestsQuickstep.java +++ b/quickstep/tests/src/com/android/quickstep/TaplTestsQuickstep.java @@ -44,6 +44,7 @@ import com.android.quickstep.views.RecentsView; import org.junit.After; import org.junit.Before; +import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; @@ -218,6 +219,7 @@ public class TaplTestsQuickstep extends AbstractQuickStepTest { } @Test + @Ignore("b/197802324") @PortraitLandscape public void testAllAppsFromHome() throws Exception { // Test opening all apps diff --git a/tests/src/com/android/launcher3/ui/TaplTestsLauncher3.java b/tests/src/com/android/launcher3/ui/TaplTestsLauncher3.java index 4dd44f4193..d8576df947 100644 --- a/tests/src/com/android/launcher3/ui/TaplTestsLauncher3.java +++ b/tests/src/com/android/launcher3/ui/TaplTestsLauncher3.java @@ -247,6 +247,7 @@ public class TaplTestsLauncher3 extends AbstractLauncherUiTest { } @Test + @Ignore("b/197802324") @PortraitLandscape public void testWidgets() throws Exception { // Test opening widgets.